)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"51d6c7b7d4e5f8f22329f726ff11e6c8d2ff59c2","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A regression was introduced by"},{"line_number":10,"context_line":"https://review.opendev.org/c/openstack/nova/+/811521"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch aims to resolve the logic issues, and allow virtual"},{"line_number":13,"context_line":"servers to build when multiple security groups are present."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"57f54252_c7cf7a94","line":11,"updated":"2025-04-03 15:07:00.000000000","message":"so general comment this pretty closely maps to the approach i suggested in https://review.opendev.org/c/openstack/nova/+/811521/13/nova/network/neutron.py\n\nso +1 for that \n\nThanks for filing the bug as well.\n\nI have triaged it as high because the sooner we fix this the less impact it will have, and it would be nice to get this fixed before 2025.1 starts making it into production.\n\nThe main blocks to that are creating a reproduction test and showing that it fixes it.\n\n\nOur neutron fixture has some support for security groups but not a lot\n\nSo likely what we would have to do is mock list_security_groups \n\nhttps://github.com/openstack/nova/blob/master/nova/tests/fixtures/neutron.py#L874-L879\n\nso that we can emulate returnign the two groups with diffent ids but the same name.\n\nAnd in the server create request we can use the uuid.\n\nthat should result in expect api error we see today\n\nyou coudl \nstart by copying a simple test case like \n\nhttps://github.com/openstack/nova/blob/9d910ec4bf2a12baf3b5f0ec3bc41686413538fb/nova/tests/functional/regressions/test_bug_1522536.py\n\nand tweaking it to fake the server goup response and we can show it passes after.\n\nAlternatively we can additionally add some unit tests to do this more directly.\n\n\nIf you do not have time to do this, I may try and hack on this next week during the ptg.\n\nthis is a slightly more expansive example using neutron ports as part of the test.\n\nhttps://github.com/openstack/nova/blob/9d910ec4bf2a12baf3b5f0ec3bc41686413538fb/nova/tests/functional/regressions/test_bug_2025480.py#L43\n\n\nthe minium test coverage we will need is just a unit test coverign the chagned fucntion showign an examle wehre if you have 2 secuirty groups with a sane name and you request it by uuid it nolonger raises.\n\nthe relevent test for this shoudl have been\n \nhttps://github.com/openstack/nova/blob/master/nova/tests/unit/network/test_neutron.py#L9371-L9403\n\nthat is continuing to faise an expection with your change as it should\n\nwhat we need to do is copy it and change the requested security groups to request by uuid and it shoudl nolonger raise\n\nlike this\n\nhttps://github.com/openstack/nova/blob/master/nova/tests/unit/network/test_neutron.py#L9303-L9335\n\nyou could also narrow the scope of testing by calling _get_security_group_ids but non of the current test do that si its proably simpler to follw the existing pattern.","commit_id":"9f8690734cd2b74a8a85664863e05b229a36beb5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"de53b8bd9cd56b9a9645f25aa6bbdec700682955","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16a88da1_9f734e69","updated":"2026-04-10 10:58:25.000000000","message":"this is now literally identical to https://review.opendev.org/c/openstack/nova/+/970337/5 but that one has release note and is not in merge conflict (according to gerrit)\nI suggest we abandon this patch here and focus on the linked one.","commit_id":"24c055c0f585a9b95437a2ee761c4ee5de8cf41a"}]}