)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"8c8ff128d6dcd669599bfe9718b1bbfe357bbc98","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add check_instance_state validation to lock API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The lock API makes instance action event record in the beginning."},{"line_number":10,"context_line":"The instance action table has foriegn key to the instance uuid in"},{"line_number":11,"context_line":"the instances table. If the lock API is called before instance record"},{"line_number":12,"context_line":"is not registered in the main DB, the lock API returns 500 Internal"},{"line_number":13,"context_line":"Error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fbe7dfab_3f23177c","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":37},"updated":"2025-04-03 07:07:24.000000000","message":"typo foreign","commit_id":"1505f098e24d91722e14b31b2aa66c64140725e6"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"2f2bb2dc7e83563fac52a001e543768b0eb9398b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add check_instance_state validation to lock API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The lock API makes instance action event record in the beginning."},{"line_number":10,"context_line":"The instance action table has foriegn key to the instance uuid in"},{"line_number":11,"context_line":"the instances table. If the lock API is called before instance record"},{"line_number":12,"context_line":"is not registered in the main DB, the lock API returns 500 Internal"},{"line_number":13,"context_line":"Error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2b5aff08_ca609285","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":37},"in_reply_to":"fbe7dfab_3f23177c","updated":"2025-04-03 08:46:18.000000000","message":"Done","commit_id":"1505f098e24d91722e14b31b2aa66c64140725e6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"8c8ff128d6dcd669599bfe9718b1bbfe357bbc98","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f84fb24_efb2a9ad","updated":"2025-04-03 07:07:24.000000000","message":"Hi Masahito, thanks for fixing this bug.\nA soft -1 just to notify you about a minor typo.\nOtherwise lgtm. 👍️","commit_id":"1505f098e24d91722e14b31b2aa66c64140725e6"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"2f2bb2dc7e83563fac52a001e543768b0eb9398b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"789e9525_93c85f87","in_reply_to":"7f84fb24_efb2a9ad","updated":"2025-04-03 08:46:18.000000000","message":"Thank for the quick reviewing 😊","commit_id":"1505f098e24d91722e14b31b2aa66c64140725e6"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"ff16b476b3a3e9f5f4e0cf804fe9b75df065a1ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76edc7b8_c8a60899","updated":"2025-04-03 14:21:43.000000000","message":"recheck nova-ceph-multistore","commit_id":"5f5ec41f4746263e2bef81efb01cff3c75d6719b"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"e8787f9761ba935569f78488ea51a9800ee793cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fd4f6e20_c5de93f8","updated":"2025-11-27 14:44:36.000000000","message":"Do shelved servers have a launched at? I\u0027m wondering because https://docs.openstack.org/api-guide/compute/server_concepts.html#server-actions states that `unshelve` is one of the actions that\u0027s prevented, so I\u0027d assume I should be able to lock a shelved server.","commit_id":"3042858006ee033fdff202c0cac8f216113454ad"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a44db78b9ba21e67460fc88edb3f00325035d75b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ed9e907e_b64cfdbc","updated":"2025-11-27 15:25:44.000000000","message":"could you please create a functional reproducer that shows the original issues in a separate commit then add this patch top of that?","commit_id":"3042858006ee033fdff202c0cac8f216113454ad"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"1c76bd11fa7cae898e8bc583eb2c4a534e54d5a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cadec42a_d11f5733","in_reply_to":"96e27a7c_6e0e27f5","updated":"2025-12-16 04:13:52.000000000","message":"@gibizer@gmail.com @kajinamit@oss.nttdata.com Thanks. Submitted the bug reproducer commit and rebased this patch on top of it.","commit_id":"3042858006ee033fdff202c0cac8f216113454ad"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"75c7d86341da7fd037845f1f957170cae4380887","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96e27a7c_6e0e27f5","in_reply_to":"ed9e907e_b64cfdbc","updated":"2025-11-27 18:20:12.000000000","message":"+1 (adding this to mark this comment unresolved)\nAdding a reproducer test to nova/tests/functional/regressions to demonstrate the problem and validate the issue is resolved in this change would be useful, especially seeing that the current code does not really simulate the instance being absent from cell dbs.","commit_id":"3042858006ee033fdff202c0cac8f216113454ad"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"748aa27b1b605bba7304fe54ce20161112eb2003","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96babff9_871a15cf","in_reply_to":"fd4f6e20_c5de93f8","updated":"2025-11-27 15:31:26.000000000","message":"I tested\n 1. Creating an instance\n 2. Shelve the instance\nand see launched_at is kept after shelve completes. (Grepping the code shows that launched_at is only set when an instance is launched and has no chance of reset)","commit_id":"3042858006ee033fdff202c0cac8f216113454ad"}]}