)]}'
{"id":"openstack%2Fnova~947185","triplet_id":"openstack%2Fnova~stable%2F2023.2~I8e0613436f379fda70ce1ec9ccc63690997cc372","project":"openstack/nova","branch":"stable/2023.2","topic":"bug/2054446-stable/2023.2","hashtags":[],"change_id":"I8e0613436f379fda70ce1ec9ccc63690997cc372","subject":"Fix deepcopy usage for BlockDeviceMapping in get_root_info","status":"ABANDONED","created":"2025-04-15 05:54:12.000000000","updated":"2025-04-15 06:36:39.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":926696,"cherry_pick_of_patch_set":3,"meta_rev_id":"7cbc7a3ad73c0efdee92c6a67f4d5d186952a030","_number":947185,"virtual_id_number":947185,"owner":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"actions":{},"labels":{"Verified":{"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-15 05:54:12.000000000","updated_by":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"reviewer":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"state":"CC"},{"updated":"2025-04-15 06:36:39.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"12048b5bdb36f72f77aa065312442cc18df7f200","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"date":"2025-04-15 05:54:12.000000000","message":"Patch Set 1: Cherry Picked from branch stable/2024.1.","accounts_in_message":[],"_revision_number":1},{"id":"3399c92a2de872953dd1e6cfbeb7f4673056e4e8","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"date":"2025-04-15 05:56:14.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"7cbc7a3ad73c0efdee92c6a67f4d5d186952a030","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-04-15 06:36:39.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-947185-5mkcj/index.html\u003e","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"98247aecd02ed8e017108bd1f1209dce2b78482a","revisions":{"98247aecd02ed8e017108bd1f1209dce2b78482a":{"kind":"REWORK","_number":1,"created":"2025-04-15 05:54:12.000000000","uploader":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"ref":"refs/changes/85/947185/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/85/947185/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/947185/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/947185/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/947185/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/85/947185/1"}}},"commit":{"parents":[{"commit":"c4467364647387a3b2bae06d61c1e8c7b363ea5f","subject":"libvirt: Fix regression of listDevices() return type","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c4467364647387a3b2bae06d61c1e8c7b363ea5f"}]}],"author":{"name":"Zhang Hua","email":"joshua.zhang@canonical.com","date":"2024-05-24 07:49:12.000000000","tz":480},"committer":{"name":"Yaguang Tang","email":"heut2008@gmail.com","date":"2025-04-15 05:54:12.000000000","tz":0},"subject":"Fix deepcopy usage for BlockDeviceMapping in get_root_info","message":"Fix deepcopy usage for BlockDeviceMapping in get_root_info\n\nThe method get_root_info sometimes receives a BlockDeviceMapping object,\nwhich lacks a copy method. The previous code assumed root_bdm was always\nan instance of DriverBlockDevice, a subclass of dict that supports the copy()\nmethod. However, during testing, it was discovered that root_bdm could also\nbe a BlockDeviceMapping object, which does not have a copy method.\n\nTo address this, the change replaces the copy() call with copy.deepcopy()\naccording to the suggestion in the comment [1], which works for both\nBlockDeviceMapping and DriverBlockDevice instances. The deepcopy method is\nsupported because oslo.versionedobjects implements the __deepcopy__ method.\n\nThis change ensures the function handles both object types correctly,\npreventing the AttributeError observed during testing.\n\n[1] https://review.opendev.org/c/openstack/nova/+/909611/4/nova/virt/libvirt/blockinfo.py\n\n\n\nChange-Id: I9432718586855ff57e8e6a5cae064e0685dd01e8\n\n(cherry picked from commit 065bf99fc79a3d086e1859f9542afaafa8c3bf00)\n(cherry picked from commit 9ff4953954dddf9985698869cbe9ff5d00857210)\n\nChange-Id: I8e0613436f379fda70ce1ec9ccc63690997cc372\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/98247aecd02ed8e017108bd1f1209dce2b78482a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/98247aecd02ed8e017108bd1f1209dce2b78482a"}]},"branch":"refs/heads/stable/2023.2"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
