)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c33bfe8ba248d3da1fc4e9fd784b0250485c9f2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d19ef54_6591ee02","updated":"2025-04-15 13:40:29.000000000","message":"The functional test expected to fail. I will reimplement the fixture without WSGIService","commit_id":"4c9b6be87a9bfe50d6a212f604b6def41264bc57"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c2faa7f50f2f5bf710cab0686a4b73024888d2bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"56699232_74d912b5","updated":"2025-04-15 14:39:53.000000000","message":"@melwittt@gmail.com could you please check the CELL_CACHE reset test coverage reduction if this make sense from you perspective as you battle with the issue according to https://review.opendev.org/c/openstack/nova/+/717662","commit_id":"b1d32e5e53f1cc6ee26bf7dd6f4f9ef3b84843ff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"13a25776_a794576a","updated":"2025-04-17 13:30:51.000000000","message":"Thanks for the reviews","commit_id":"b1d32e5e53f1cc6ee26bf7dd6f4f9ef3b84843ff"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"068fbafcc17548d7a9e2bfc3f9e40242ff2df01f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3805c751_bafe9519","updated":"2025-04-17 18:21:57.000000000","message":"Looks good to me, thanks!","commit_id":"51eb60063fa09e742508af18da3513c5fabb7de8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd9e5cf9359a87329dd216c5dac9d5ef502c3996","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb7da070_32c76e0d","updated":"2025-04-17 15:51:15.000000000","message":"this all largely looks good to me.\ni think mels comments have been adressed to but let see what she thinks","commit_id":"51eb60063fa09e742508af18da3513c5fabb7de8"}],"nova/service.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b205891dc141af1b76f53a103d6fce952fc2a46","unresolved":true,"context_lines":[{"line_number":327,"context_line":"        context.CELL_CACHE \u003d {}"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"class WSGIServer(service.ServiceBase):"},{"line_number":331,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    default_pool_size \u003d CONF.wsgi.default_pool_size"}],"source_content_type":"text/x-python","patch_set":3,"id":"26b7f947_6fbd8dc5","side":"PARENT","line":330,"updated":"2025-04-17 10:28:37.000000000","message":"for what its worth i never quite new why this was in this file instead of closer to wsgi application or console script.","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        context.CELL_CACHE \u003d {}"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"class WSGIServer(service.ServiceBase):"},{"line_number":331,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    default_pool_size \u003d CONF.wsgi.default_pool_size"}],"source_content_type":"text/x-python","patch_set":3,"id":"36e44c75_361c8f5b","side":"PARENT","line":330,"in_reply_to":"26b7f947_6fbd8dc5","updated":"2025-04-17 13:30:51.000000000","message":"I think it grown organically. Once it was copied over oslo.service to be shared with the other projects but nova never moved to use the oslo.service copy. \n\nThese are clearly only used for outside of the mod_wsgi path, so can be deleted now (the same way as oslo.service also not port this to the threading backend)","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":true,"context_lines":[{"line_number":330,"context_line":"class WSGIServer(service.ServiceBase):"},{"line_number":331,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    default_pool_size \u003d CONF.wsgi.default_pool_size"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def __init__(self, name, app, host\u003d\u00270.0.0.0\u0027, port\u003d0, pool_size\u003dNone,"},{"line_number":336,"context_line":"                       protocol\u003deventlet.wsgi.HttpProtocol, backlog\u003d128,"}],"source_content_type":"text/x-python","patch_set":3,"id":"01780167_7501e2b2","side":"PARENT","line":333,"updated":"2025-04-17 13:30:51.000000000","message":"I just noticed that we probably have config options to be deleted as well. I will check deeper and propose follow up.","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac0d994e29bed4b1a94ec280f4a6e291f4adda14","unresolved":false,"context_lines":[{"line_number":330,"context_line":"class WSGIServer(service.ServiceBase):"},{"line_number":331,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    default_pool_size \u003d CONF.wsgi.default_pool_size"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def __init__(self, name, app, host\u003d\u00270.0.0.0\u0027, port\u003d0, pool_size\u003dNone,"},{"line_number":336,"context_line":"                       protocol\u003deventlet.wsgi.HttpProtocol, backlog\u003d128,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a61ee1b1_282d5e01","side":"PARENT","line":333,"in_reply_to":"01780167_7501e2b2","updated":"2025-04-17 14:49:54.000000000","message":"https://review.opendev.org/c/openstack/nova/+/947595","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":true,"context_lines":[{"line_number":348,"context_line":"        :raises: nova.exception.InvalidInput"},{"line_number":349,"context_line":"        \"\"\""},{"line_number":350,"context_line":"        # Allow operators to customize http requests max header line size."},{"line_number":351,"context_line":"        eventlet.wsgi.MAX_HEADER_LINE \u003d CONF.wsgi.max_header_line"},{"line_number":352,"context_line":"        self.name \u003d name"},{"line_number":353,"context_line":"        self.app \u003d app"},{"line_number":354,"context_line":"        self._server \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"156249ff_5a3cbabf","side":"PARENT","line":351,"updated":"2025-04-17 13:30:51.000000000","message":"ditto","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac0d994e29bed4b1a94ec280f4a6e291f4adda14","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        :raises: nova.exception.InvalidInput"},{"line_number":349,"context_line":"        \"\"\""},{"line_number":350,"context_line":"        # Allow operators to customize http requests max header line size."},{"line_number":351,"context_line":"        eventlet.wsgi.MAX_HEADER_LINE \u003d CONF.wsgi.max_header_line"},{"line_number":352,"context_line":"        self.name \u003d name"},{"line_number":353,"context_line":"        self.app \u003d app"},{"line_number":354,"context_line":"        self._server \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"090aa19f_b34158f0","side":"PARENT","line":351,"in_reply_to":"156249ff_5a3cbabf","updated":"2025-04-17 14:49:54.000000000","message":"https://review.opendev.org/c/openstack/nova/+/947595","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":true,"context_lines":[{"line_number":358,"context_line":"        self._logger \u003d logging.getLogger(\"nova.%s.wsgi.server\" % self.name)"},{"line_number":359,"context_line":"        self._use_ssl \u003d use_ssl"},{"line_number":360,"context_line":"        self._max_url_len \u003d max_url_len"},{"line_number":361,"context_line":"        self.client_socket_timeout \u003d CONF.wsgi.client_socket_timeout or None"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        if backlog \u003c 1:"},{"line_number":364,"context_line":"            raise exception.InvalidInput("}],"source_content_type":"text/x-python","patch_set":3,"id":"491173e1_12d87897","side":"PARENT","line":361,"updated":"2025-04-17 13:30:51.000000000","message":"ditto","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac0d994e29bed4b1a94ec280f4a6e291f4adda14","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        self._logger \u003d logging.getLogger(\"nova.%s.wsgi.server\" % self.name)"},{"line_number":359,"context_line":"        self._use_ssl \u003d use_ssl"},{"line_number":360,"context_line":"        self._max_url_len \u003d max_url_len"},{"line_number":361,"context_line":"        self.client_socket_timeout \u003d CONF.wsgi.client_socket_timeout or None"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        if backlog \u003c 1:"},{"line_number":364,"context_line":"            raise exception.InvalidInput("}],"source_content_type":"text/x-python","patch_set":3,"id":"653904d8_3f37d341","side":"PARENT","line":361,"in_reply_to":"491173e1_12d87897","updated":"2025-04-17 14:49:54.000000000","message":"https://review.opendev.org/c/openstack/nova/+/947595","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":true,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        if self._use_ssl:"},{"line_number":416,"context_line":"            try:"},{"line_number":417,"context_line":"                ca_file \u003d CONF.wsgi.ssl_ca_file"},{"line_number":418,"context_line":"                cert_file \u003d CONF.wsgi.ssl_cert_file"},{"line_number":419,"context_line":"                key_file \u003d CONF.wsgi.ssl_key_file"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"                if cert_file and not os.path.exists(cert_file):"},{"line_number":422,"context_line":"                    raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":3,"id":"c7d63936_860697a9","side":"PARENT","line":419,"range":{"start_line":417,"start_character":0,"end_line":419,"end_character":49},"updated":"2025-04-17 13:30:51.000000000","message":"ditto","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac0d994e29bed4b1a94ec280f4a6e291f4adda14","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        if self._use_ssl:"},{"line_number":416,"context_line":"            try:"},{"line_number":417,"context_line":"                ca_file \u003d CONF.wsgi.ssl_ca_file"},{"line_number":418,"context_line":"                cert_file \u003d CONF.wsgi.ssl_cert_file"},{"line_number":419,"context_line":"                key_file \u003d CONF.wsgi.ssl_key_file"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"                if cert_file and not os.path.exists(cert_file):"},{"line_number":422,"context_line":"                    raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":3,"id":"d330643d_94d40f84","side":"PARENT","line":419,"range":{"start_line":417,"start_character":0,"end_line":419,"end_character":49},"in_reply_to":"c7d63936_860697a9","updated":"2025-04-17 14:49:54.000000000","message":"https://review.opendev.org/c/openstack/nova/+/947595","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":true,"context_lines":[{"line_number":442,"context_line":"                    \u0027cert_reqs\u0027: ssl.CERT_NONE,"},{"line_number":443,"context_line":"                }"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"                if CONF.wsgi.ssl_ca_file:"},{"line_number":446,"context_line":"                    ssl_kwargs[\u0027ca_certs\u0027] \u003d ca_file"},{"line_number":447,"context_line":"                    ssl_kwargs[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"10d61edd_45180c16","side":"PARENT","line":445,"updated":"2025-04-17 13:30:51.000000000","message":"ditto","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac0d994e29bed4b1a94ec280f4a6e291f4adda14","unresolved":false,"context_lines":[{"line_number":442,"context_line":"                    \u0027cert_reqs\u0027: ssl.CERT_NONE,"},{"line_number":443,"context_line":"                }"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"                if CONF.wsgi.ssl_ca_file:"},{"line_number":446,"context_line":"                    ssl_kwargs[\u0027ca_certs\u0027] \u003d ca_file"},{"line_number":447,"context_line":"                    ssl_kwargs[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"55a27ab2_6e7706c0","side":"PARENT","line":445,"in_reply_to":"10d61edd_45180c16","updated":"2025-04-17 14:49:54.000000000","message":"https://review.opendev.org/c/openstack/nova/+/947595","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":true,"context_lines":[{"line_number":463,"context_line":"            \u0027protocol\u0027: self._protocol,"},{"line_number":464,"context_line":"            \u0027custom_pool\u0027: self._pool,"},{"line_number":465,"context_line":"            \u0027log\u0027: self._logger,"},{"line_number":466,"context_line":"            \u0027log_format\u0027: CONF.wsgi.wsgi_log_format,"},{"line_number":467,"context_line":"            \u0027debug\u0027: False,"},{"line_number":468,"context_line":"            \u0027keepalive\u0027: CONF.wsgi.keep_alive,"},{"line_number":469,"context_line":"            \u0027socket_timeout\u0027: self.client_socket_timeout"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b0c90ef_e546a753","side":"PARENT","line":466,"updated":"2025-04-17 13:30:51.000000000","message":"ditto","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac0d994e29bed4b1a94ec280f4a6e291f4adda14","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            \u0027protocol\u0027: self._protocol,"},{"line_number":464,"context_line":"            \u0027custom_pool\u0027: self._pool,"},{"line_number":465,"context_line":"            \u0027log\u0027: self._logger,"},{"line_number":466,"context_line":"            \u0027log_format\u0027: CONF.wsgi.wsgi_log_format,"},{"line_number":467,"context_line":"            \u0027debug\u0027: False,"},{"line_number":468,"context_line":"            \u0027keepalive\u0027: CONF.wsgi.keep_alive,"},{"line_number":469,"context_line":"            \u0027socket_timeout\u0027: self.client_socket_timeout"}],"source_content_type":"text/x-python","patch_set":3,"id":"3cfae495_a62c1fbe","side":"PARENT","line":466,"in_reply_to":"7b0c90ef_e546a753","updated":"2025-04-17 14:49:54.000000000","message":"https://review.opendev.org/c/openstack/nova/+/947595","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":true,"context_lines":[{"line_number":465,"context_line":"            \u0027log\u0027: self._logger,"},{"line_number":466,"context_line":"            \u0027log_format\u0027: CONF.wsgi.wsgi_log_format,"},{"line_number":467,"context_line":"            \u0027debug\u0027: False,"},{"line_number":468,"context_line":"            \u0027keepalive\u0027: CONF.wsgi.keep_alive,"},{"line_number":469,"context_line":"            \u0027socket_timeout\u0027: self.client_socket_timeout"},{"line_number":470,"context_line":"            }"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"4d37e1f6_86d9b028","side":"PARENT","line":468,"updated":"2025-04-17 13:30:51.000000000","message":"ditto","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac0d994e29bed4b1a94ec280f4a6e291f4adda14","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            \u0027log\u0027: self._logger,"},{"line_number":466,"context_line":"            \u0027log_format\u0027: CONF.wsgi.wsgi_log_format,"},{"line_number":467,"context_line":"            \u0027debug\u0027: False,"},{"line_number":468,"context_line":"            \u0027keepalive\u0027: CONF.wsgi.keep_alive,"},{"line_number":469,"context_line":"            \u0027socket_timeout\u0027: self.client_socket_timeout"},{"line_number":470,"context_line":"            }"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7baa6fb3_46c53e96","side":"PARENT","line":468,"in_reply_to":"4d37e1f6_86d9b028","updated":"2025-04-17 14:49:54.000000000","message":"https://review.opendev.org/c/openstack/nova/+/947595","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"}],"nova/tests/fixtures/nova.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b205891dc141af1b76f53a103d6fce952fc2a46","unresolved":true,"context_lines":[{"line_number":1113,"context_line":"        super(OSMetadataServer, self).setUp()"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        # A unique hostname for the wsgi-intercept."},{"line_number":1116,"context_line":"        hostname \u003d uuidsentinel.metadata_host"},{"line_number":1117,"context_line":"        port \u003d 80"},{"line_number":1118,"context_line":"        service_name \u003d \u0027metadata\u0027"},{"line_number":1119,"context_line":"        endpoint \u003d \u0027http://%s:%s/\u0027 % (hostname, port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1cd04f7e_72568045","line":1116,"updated":"2025-04-17 10:28:37.000000000","message":"ok i guess this is more for debugablity then anythin else.","commit_id":"b1d32e5e53f1cc6ee26bf7dd6f4f9ef3b84843ff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"        super(OSMetadataServer, self).setUp()"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        # A unique hostname for the wsgi-intercept."},{"line_number":1116,"context_line":"        hostname \u003d uuidsentinel.metadata_host"},{"line_number":1117,"context_line":"        port \u003d 80"},{"line_number":1118,"context_line":"        service_name \u003d \u0027metadata\u0027"},{"line_number":1119,"context_line":"        endpoint \u003d \u0027http://%s:%s/\u0027 % (hostname, port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e6bc7d97_a073f497","line":1116,"in_reply_to":"1cd04f7e_72568045","updated":"2025-04-17 13:30:51.000000000","message":"Just followed the pattern form the API fixture","commit_id":"b1d32e5e53f1cc6ee26bf7dd6f4f9ef3b84843ff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b205891dc141af1b76f53a103d6fce952fc2a46","unresolved":true,"context_lines":[{"line_number":1119,"context_line":"        endpoint \u003d \u0027http://%s:%s/\u0027 % (hostname, port)"},{"line_number":1120,"context_line":"        conf_overrides \u003d {"},{"line_number":1121,"context_line":"            \u0027metadata_listen\u0027: hostname,"},{"line_number":1122,"context_line":"            \u0027metadata_listen_port\u0027: port,"},{"line_number":1123,"context_line":"            \u0027debug\u0027: True,"},{"line_number":1124,"context_line":"        }"},{"line_number":1125,"context_line":"        self.useFixture(ConfPatcher(**conf_overrides))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe09b70_a6c74486","line":1122,"updated":"2025-04-17 10:28:37.000000000","message":"the intersepter is not actully gong to listent on these port right it hooks the client request before we ever get to the wire?\n\nother wise using 80 is not a great idea.\n\nbefore we were using 0 to ensure that we woudl select a random free port in the event we actuly needed to listen on a socket.","commit_id":"b1d32e5e53f1cc6ee26bf7dd6f4f9ef3b84843ff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"        endpoint \u003d \u0027http://%s:%s/\u0027 % (hostname, port)"},{"line_number":1120,"context_line":"        conf_overrides \u003d {"},{"line_number":1121,"context_line":"            \u0027metadata_listen\u0027: hostname,"},{"line_number":1122,"context_line":"            \u0027metadata_listen_port\u0027: port,"},{"line_number":1123,"context_line":"            \u0027debug\u0027: True,"},{"line_number":1124,"context_line":"        }"},{"line_number":1125,"context_line":"        self.useFixture(ConfPatcher(**conf_overrides))"}],"source_content_type":"text/x-python","patch_set":3,"id":"654709e5_a7c659f8","line":1122,"in_reply_to":"ffe09b70_a6c74486","updated":"2025-04-17 13:30:51.000000000","message":"I believe that we actually not listening on any socket in this setup as i) test runs unprivileged and opening a listening socket on 80 would need privilege ii) on my machine 80 is already used by another process, but the test still passes.\n\nI cannot set this to 0 though as the request lib on the client side checks the port number before hits the intercept.\n\nAnyhow I can drop the explicit port definition all together.","commit_id":"b1d32e5e53f1cc6ee26bf7dd6f4f9ef3b84843ff"}],"nova/tests/functional/test_service.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e7ebd8d86c07693cc120efd86e38d544e03c8a5f","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        # Cell cache should be empty after the service reset."},{"line_number":65,"context_line":"        self.assertEqual({}, nova_context.CELL_CACHE)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Now test the WSGI service."},{"line_number":68,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_req})"},{"line_number":69,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":70,"context_line":"        # Cell cache should be populated after creating a server."},{"line_number":71,"context_line":"        self.assertTrue(nova_context.CELL_CACHE)"},{"line_number":72,"context_line":"        self.metadata.reset()"},{"line_number":73,"context_line":"        # Cell cache should be empty after the service reset."},{"line_number":74,"context_line":"        self.assertEqual({}, nova_context.CELL_CACHE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"20e57267_70c3b2c5","side":"PARENT","line":71,"range":{"start_line":67,"start_character":0,"end_line":71,"end_character":48},"updated":"2025-04-16 19:13:58.000000000","message":"I think you can remove this part also as it is covered in L58-62. L67-74 were solely for WSGIService.\n\nI guess what you could also do if you wanted is add an assert before the post_server to assert the CELL_CACHE is empty before creating a server. Since that\u0027s what this part is verifying in the absence of WSGIService, that CELL_CACHE goes from empty to populated before and after creating a server.","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # Cell cache should be empty after the service reset."},{"line_number":65,"context_line":"        self.assertEqual({}, nova_context.CELL_CACHE)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Now test the WSGI service."},{"line_number":68,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_req})"},{"line_number":69,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":70,"context_line":"        # Cell cache should be populated after creating a server."},{"line_number":71,"context_line":"        self.assertTrue(nova_context.CELL_CACHE)"},{"line_number":72,"context_line":"        self.metadata.reset()"},{"line_number":73,"context_line":"        # Cell cache should be empty after the service reset."},{"line_number":74,"context_line":"        self.assertEqual({}, nova_context.CELL_CACHE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"96c8fb11_00782572","side":"PARENT","line":71,"range":{"start_line":67,"start_character":0,"end_line":71,"end_character":48},"in_reply_to":"20e57267_70c3b2c5","updated":"2025-04-17 13:30:51.000000000","message":"Good idea. Done","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e7ebd8d86c07693cc120efd86e38d544e03c8a5f","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        # Cell cache should be empty after the service start."},{"line_number":97,"context_line":"        self.assertEqual({}, nova_context.CELL_CACHE)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Now test the WSGI service."},{"line_number":100,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_req})"},{"line_number":101,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":102,"context_line":"        # Cell cache should be populated after creating a server."},{"line_number":103,"context_line":"        self.assertTrue(nova_context.CELL_CACHE)"},{"line_number":104,"context_line":"        # we need to mock nova.utils.raise_if_old_compute() that is run at"},{"line_number":105,"context_line":"        # service startup as that will check the global service level which"},{"line_number":106,"context_line":"        # populates the cell cache"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f44997f_c309ba76","side":"PARENT","line":103,"range":{"start_line":99,"start_character":0,"end_line":103,"end_character":48},"updated":"2025-04-16 19:13:58.000000000","message":"Same.","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"182fc716395f7684b16efce5aa5c0a372bcddec9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # Cell cache should be empty after the service start."},{"line_number":97,"context_line":"        self.assertEqual({}, nova_context.CELL_CACHE)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Now test the WSGI service."},{"line_number":100,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_req})"},{"line_number":101,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":102,"context_line":"        # Cell cache should be populated after creating a server."},{"line_number":103,"context_line":"        self.assertTrue(nova_context.CELL_CACHE)"},{"line_number":104,"context_line":"        # we need to mock nova.utils.raise_if_old_compute() that is run at"},{"line_number":105,"context_line":"        # service startup as that will check the global service level which"},{"line_number":106,"context_line":"        # populates the cell cache"}],"source_content_type":"text/x-python","patch_set":3,"id":"04ac253f_20e8d67a","side":"PARENT","line":103,"range":{"start_line":99,"start_character":0,"end_line":103,"end_character":48},"in_reply_to":"5f44997f_c309ba76","updated":"2025-04-17 13:30:51.000000000","message":"Done","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"}],"nova/tests/unit/test_service.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b205891dc141af1b76f53a103d6fce952fc2a46","unresolved":true,"context_lines":[{"line_number":342,"context_line":"        server.start()"},{"line_number":343,"context_line":"        self.assertNotEqual(0, server.port)"},{"line_number":344,"context_line":"        server.stop()"},{"line_number":345,"context_line":"        server.wait()"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @testtools.skipIf(not utils.is_ipv6_supported(), \"no ipv6 support\")"},{"line_number":348,"context_line":"    def test_start_random_port_with_ipv6(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"cfffd735_bdeb6459","side":"PARENT","line":345,"updated":"2025-04-17 10:28:37.000000000","message":"at least that what this test is implying.","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd9e5cf9359a87329dd216c5dac9d5ef502c3996","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        server.start()"},{"line_number":343,"context_line":"        self.assertNotEqual(0, server.port)"},{"line_number":344,"context_line":"        server.stop()"},{"line_number":345,"context_line":"        server.wait()"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @testtools.skipIf(not utils.is_ipv6_supported(), \"no ipv6 support\")"},{"line_number":348,"context_line":"    def test_start_random_port_with_ipv6(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"4e8a62b5_a3cefa39","side":"PARENT","line":345,"in_reply_to":"cfffd735_bdeb6459","updated":"2025-04-17 15:51:15.000000000","message":"Acknowledged","commit_id":"05b219746f38a2b4ad7a44eb3125111d417ca303"}]}