)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd06205f08141e181682e3bf808f492e2514f997","unresolved":true,"context_lines":[{"line_number":30,"context_line":"specified."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-Bug: #2061701"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: Id033a5760272e4fb06dee2342414b26aa16ffe24"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d0075850_fe7aaa23","line":33,"updated":"2025-05-08 17:02:01.000000000","message":"ya so this is fine the other way we agreed to fix it long term was via https://blueprints.launchpad.net/nova/+spec/allow-disabling-ephemeral-disk-formatting\n\nwhich i was wag going to do last cycle before watcher got in the way.\n\nclamping the lenght to confrom is a backportable bugfix but i think allowign the formating to be disable and makign tha tthe default would be good to do on master as well separately.\n\nif we combine that with not creating backign files for ephmeral disks it will improve the overall expericne and security of them alot.","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fa2781df0b0939adc9e0c8ea156ddc3036759450","unresolved":true,"context_lines":[{"line_number":30,"context_line":"specified."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-Bug: #2061701"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: Id033a5760272e4fb06dee2342414b26aa16ffe24"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"69941af3_3ba4fa12","line":33,"in_reply_to":"d0075850_fe7aaa23","updated":"2025-05-08 17:34:51.000000000","message":"+1 agree that stopping disk formatting for ephemeral is the longterm solution.\n\nThis was just such a small and easy thing to fix and backport in the meantime IMHO.","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"38cc9f350763245fa548d823968e025cfed28376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c72a2d5_135317b9","updated":"2025-05-12 18:13:22.000000000","message":"recheck \"Image d670941d-afd8-478d-a0c2-b0c47e78fb77 could not be deleted because it is in use: The image cannot be deleted because it is in use through the backend store outside of Glance.: glance_store.exceptions.InUseByStore: The image cannot be deleted because it is in use through the backend store outside of Glance.\"","commit_id":"77b9d5188db19a13eb62d9f3d6b12ca8a6bf1b36"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dfcb2cc4a95ee5bb07c1951704c8a538d36e008a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eeed621e_44846a29","updated":"2025-05-08 20:31:47.000000000","message":"recheck guest kernel panic\n\n[   11.748846] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000 ]---","commit_id":"77b9d5188db19a13eb62d9f3d6b12ca8a6bf1b36"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"577b6a5cb90688b7dd10607cc1cd321ba327151e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c8fd9f0_0610c3a4","updated":"2025-05-19 09:28:05.000000000","message":"im not sure the rebase will be any more successfl the a recheck but its good to keep the patch current regradelss.","commit_id":"82856f95c69bb07bd2a61decae9abe827a2a1567"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5d4b5fe72d399901cc175092445f70c4a26a4261","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba4e495a_16cb0d07","updated":"2025-05-19 23:15:30.000000000","message":"recheck Remove image ce37b229-cb89-4961-b64e-b2a4e903b0da failed. It is in use.: rbd.ImageBusy: [errno 16] RBD image is busy (error removing image)\n\nI don\u0027t see how this could possibly be related? Have hit the same failure 3 times now ...","commit_id":"82856f95c69bb07bd2a61decae9abe827a2a1567"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e423bfae00b4714986e2ddc7264024693427efbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f090500b_50f81c7b","updated":"2025-05-19 18:01:02.000000000","message":"recheck glanceclient.exc.HTTPConflict: HTTP 409 Conflict: Image dc4f8b90-5531-4575-be37-dadf0aeddd12 could not be deleted because it is in use: The image cannot be deleted because it is in use through the backend store outside of Glance.","commit_id":"82856f95c69bb07bd2a61decae9abe827a2a1567"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"96dc3e122b511aa68f392c65a44d4b1c965fbe7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"332dc742_23442fba","updated":"2025-05-29 16:32:23.000000000","message":"recheck guest kernel panic [    2.802416] ---[ end Kernel panic - not syncing: IO-APIC + timer doesn\u0027t work!  Boot with apic\u003ddebug and send a report.  Then try booting with the \u0027noapic\u0027 option. ]---","commit_id":"82856f95c69bb07bd2a61decae9abe827a2a1567"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4db2f16c7a1f3f961b946dc377646341d8dc132b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09ee5874_246736e3","in_reply_to":"ba4e495a_16cb0d07","updated":"2025-05-19 23:30:04.000000000","message":"I think this is a known gate issue that rene mentioned in the last IRC meeting, so we might need to investirage why this is happenign and reach out to the cinder or glance teams.\n\nim not sure hwo we woudl be seeting this and they are not but i agree that i dont think this is related to this patch.","commit_id":"82856f95c69bb07bd2a61decae9abe827a2a1567"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd06205f08141e181682e3bf808f492e2514f997","unresolved":true,"context_lines":[{"line_number":15196,"context_line":"            ]"},{"line_number":15197,"context_line":""},{"line_number":15198,"context_line":"            create_ephemeral_mock.assert_called_once_with("},{"line_number":15199,"context_line":"                ephemeral_size\u003d1, fs_label\u003d\u0027ephemeral0\u0027,"},{"line_number":15200,"context_line":"                os_type\u003d\u0027linux\u0027, target\u003dephemeral_backing)"},{"line_number":15201,"context_line":""},{"line_number":15202,"context_line":"            fetch_image_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"a02a45c3_5ca1cc33","line":15199,"updated":"2025-05-08 17:02:01.000000000","message":"This indirectly test what i was asking for at a lwoer level rahter then on the cache call but honestly it end up beign the same.","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"15d490fce67dbce27ace0b9a066599b68226e925","unresolved":false,"context_lines":[{"line_number":15196,"context_line":"            ]"},{"line_number":15197,"context_line":""},{"line_number":15198,"context_line":"            create_ephemeral_mock.assert_called_once_with("},{"line_number":15199,"context_line":"                ephemeral_size\u003d1, fs_label\u003d\u0027ephemeral0\u0027,"},{"line_number":15200,"context_line":"                os_type\u003d\u0027linux\u0027, target\u003dephemeral_backing)"},{"line_number":15201,"context_line":""},{"line_number":15202,"context_line":"            fetch_image_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"39be9f5f_dea247c5","line":15199,"in_reply_to":"60a183db_597e55b9","updated":"2025-05-08 18:26:32.000000000","message":"Done","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"167c9b865030543ce7b1036aabb232da6c2ad256","unresolved":true,"context_lines":[{"line_number":15196,"context_line":"            ]"},{"line_number":15197,"context_line":""},{"line_number":15198,"context_line":"            create_ephemeral_mock.assert_called_once_with("},{"line_number":15199,"context_line":"                ephemeral_size\u003d1, fs_label\u003d\u0027ephemeral0\u0027,"},{"line_number":15200,"context_line":"                os_type\u003d\u0027linux\u0027, target\u003dephemeral_backing)"},{"line_number":15201,"context_line":""},{"line_number":15202,"context_line":"            fetch_image_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"60a183db_597e55b9","line":15199,"in_reply_to":"a02a45c3_5ca1cc33","updated":"2025-05-08 17:08:21.000000000","message":"if you end up resping, can you put a comment above this refering to the bug\njust so we know this is preventign the bug form regressing.\n\nwe coudl also add a fixes release note but i dont think this is going to be very common. altough if tis related to the mkfs verison maybe more peopel will start hithing it so haveign a fixes release not might be a good idea.","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd06205f08141e181682e3bf808f492e2514f997","unresolved":true,"context_lines":[{"line_number":5154,"context_line":"                              instance\u003dinstance)"},{"line_number":5155,"context_line":""},{"line_number":5156,"context_line":"    @staticmethod"},{"line_number":5157,"context_line":"    def _get_fs_label_ephemeral(index: int) -\u003e str:"},{"line_number":5158,"context_line":"        # Use a consistent naming convention for FS labels. We need to be"},{"line_number":5159,"context_line":"        # mindful of various filesystems label name length limitations."},{"line_number":5160,"context_line":"        # See for example: https://bugs.launchpad.net/nova/+bug/2061701"}],"source_content_type":"text/x-python","patch_set":1,"id":"36770892_a9524a5d","line":5157,"updated":"2025-05-08 17:02:01.000000000","message":"so this function is more for documenttation and perhasp testing right\n\nto avoid just using the fsting everywhere we currently vary.","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"15d490fce67dbce27ace0b9a066599b68226e925","unresolved":false,"context_lines":[{"line_number":5154,"context_line":"                              instance\u003dinstance)"},{"line_number":5155,"context_line":""},{"line_number":5156,"context_line":"    @staticmethod"},{"line_number":5157,"context_line":"    def _get_fs_label_ephemeral(index: int) -\u003e str:"},{"line_number":5158,"context_line":"        # Use a consistent naming convention for FS labels. We need to be"},{"line_number":5159,"context_line":"        # mindful of various filesystems label name length limitations."},{"line_number":5160,"context_line":"        # See for example: https://bugs.launchpad.net/nova/+bug/2061701"}],"source_content_type":"text/x-python","patch_set":1,"id":"f902491a_8c8004ef","line":5157,"in_reply_to":"2ef659ec_445a51cc","updated":"2025-05-08 18:26:32.000000000","message":"Acknowledged","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fa2781df0b0939adc9e0c8ea156ddc3036759450","unresolved":true,"context_lines":[{"line_number":5154,"context_line":"                              instance\u003dinstance)"},{"line_number":5155,"context_line":""},{"line_number":5156,"context_line":"    @staticmethod"},{"line_number":5157,"context_line":"    def _get_fs_label_ephemeral(index: int) -\u003e str:"},{"line_number":5158,"context_line":"        # Use a consistent naming convention for FS labels. We need to be"},{"line_number":5159,"context_line":"        # mindful of various filesystems label name length limitations."},{"line_number":5160,"context_line":"        # See for example: https://bugs.launchpad.net/nova/+bug/2061701"}],"source_content_type":"text/x-python","patch_set":1,"id":"906227a9_9b72dae4","line":5157,"in_reply_to":"36770892_a9524a5d","updated":"2025-05-08 17:34:51.000000000","message":"No, my thinking was that making a function will encourage consistency and make it more obvious that this label name needs to be consistent across all call sites.\n\nFor example, if someone came along later and needed to generate a label for ephemeral disk for some reason, the hope is they would easily find this function and use the helper instead of creating a one-off (the root cause of this bug).\n\nMy thinking and hope might be wrong but that was the idea behind it 🙂","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ecf9913e48404390ee2d2369ce6b6e94b014b78","unresolved":true,"context_lines":[{"line_number":5154,"context_line":"                              instance\u003dinstance)"},{"line_number":5155,"context_line":""},{"line_number":5156,"context_line":"    @staticmethod"},{"line_number":5157,"context_line":"    def _get_fs_label_ephemeral(index: int) -\u003e str:"},{"line_number":5158,"context_line":"        # Use a consistent naming convention for FS labels. We need to be"},{"line_number":5159,"context_line":"        # mindful of various filesystems label name length limitations."},{"line_number":5160,"context_line":"        # See for example: https://bugs.launchpad.net/nova/+bug/2061701"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ef659ec_445a51cc","line":5157,"in_reply_to":"906227a9_9b72dae4","updated":"2025-05-08 17:39:54.000000000","message":"no that makes sense the other way woudl have been to save the f string a as constant/template but a trivial funciton it totally fine and readble.","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd06205f08141e181682e3bf808f492e2514f997","unresolved":true,"context_lines":[{"line_number":11707,"context_line":"                # good, concerning operators etc so for now just pass."},{"line_number":11708,"context_line":"                pass"},{"line_number":11709,"context_line":""},{"line_number":11710,"context_line":"    def _create_images_and_backing(self, context, instance, instance_dir,"},{"line_number":11711,"context_line":"                                   disk_info, fallback_from_host\u003dNone):"},{"line_number":11712,"context_line":"        \"\"\":param context: security context"},{"line_number":11713,"context_line":"           :param instance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1cc55db1_e4b9f21f","line":11710,"range":{"start_line":11710,"start_character":8,"end_line":11710,"end_character":34},"updated":"2025-05-08 17:02:01.000000000","message":"part of me wants to ask for a repoducer unit test that calls this and asset \ndisk.cache is called incorrectly before with the filename and now is called with the index but your kind fo already doign that via the unit test update.\n\nits just not clearly assocated with this bug fix via the test name or a comment.\nalthough git blame will do that for us.","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fa2781df0b0939adc9e0c8ea156ddc3036759450","unresolved":true,"context_lines":[{"line_number":11707,"context_line":"                # good, concerning operators etc so for now just pass."},{"line_number":11708,"context_line":"                pass"},{"line_number":11709,"context_line":""},{"line_number":11710,"context_line":"    def _create_images_and_backing(self, context, instance, instance_dir,"},{"line_number":11711,"context_line":"                                   disk_info, fallback_from_host\u003dNone):"},{"line_number":11712,"context_line":"        \"\"\":param context: security context"},{"line_number":11713,"context_line":"           :param instance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f69ccbf6_6244d2d4","line":11710,"range":{"start_line":11710,"start_character":8,"end_line":11710,"end_character":34},"in_reply_to":"1cc55db1_e4b9f21f","updated":"2025-05-08 17:34:51.000000000","message":"That\u0027s fair, I will add a code comment to reference the bug.","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd06205f08141e181682e3bf808f492e2514f997","unresolved":true,"context_lines":[{"line_number":11755,"context_line":"                    # cached."},{"line_number":11756,"context_line":"                    disk.cache("},{"line_number":11757,"context_line":"                        fetch_func\u003dself._create_ephemeral,"},{"line_number":11758,"context_line":"                        fs_label\u003dself._get_fs_label_ephemeral(0),"},{"line_number":11759,"context_line":"                        os_type\u003dinstance.os_type,"},{"line_number":11760,"context_line":"                        filename\u003dcache_name,"},{"line_number":11761,"context_line":"                        size\u003dinfo[\u0027virt_disk_size\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"792dbee5_2a7646ab","line":11758,"updated":"2025-05-08 17:02:01.000000000","message":"This is the actual fix for the bug.","commit_id":"eb28a3c1b9e5bb4fda3174a00e8d6779ddfd1e16"}]}