)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7281443d8b21838d251866d12bda3063e14f2047","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It can happen that we have instances in build_requests table."},{"line_number":10,"context_line":"It could also be in nova_cell1."},{"line_number":11,"context_line":"In that situation the API was not returning the correct number (limit)"},{"line_number":12,"context_line":"of instances and failed giving the servers_links (next) marker."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"By collecting more instances from the DB, we can fill the number of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0af598ba_a555c6ff","line":11,"updated":"2025-05-19 12:54:03.000000000","message":"That by itself is not a bug. \nThe limit is the max amount, but we don\u0027t guarantee that you will recive that amount even if there are \u003e limit avaible.","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"69481d5e759c3905d21e683109055813754e0107","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It can happen that we have instances in build_requests table."},{"line_number":10,"context_line":"It could also be in nova_cell1."},{"line_number":11,"context_line":"In that situation the API was not returning the correct number (limit)"},{"line_number":12,"context_line":"of instances and failed giving the servers_links (next) marker."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"By collecting more instances from the DB, we can fill the number of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c85749f6_d82058d1","line":11,"in_reply_to":"0af598ba_a555c6ff","updated":"2025-05-21 06:26:52.000000000","message":"Acknowledged","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7281443d8b21838d251866d12bda3063e14f2047","unresolved":true,"context_lines":[{"line_number":9,"context_line":"It can happen that we have instances in build_requests table."},{"line_number":10,"context_line":"It could also be in nova_cell1."},{"line_number":11,"context_line":"In that situation the API was not returning the correct number (limit)"},{"line_number":12,"context_line":"of instances and failed giving the servers_links (next) marker."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"By collecting more instances from the DB, we can fill the number of"},{"line_number":15,"context_line":"instances up to the correct number."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"361b8007_026907eb","line":12,"updated":"2025-05-19 12:54:03.000000000","message":"the marker is the actual bug and that is what we really need to correct","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"69481d5e759c3905d21e683109055813754e0107","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It can happen that we have instances in build_requests table."},{"line_number":10,"context_line":"It could also be in nova_cell1."},{"line_number":11,"context_line":"In that situation the API was not returning the correct number (limit)"},{"line_number":12,"context_line":"of instances and failed giving the servers_links (next) marker."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"By collecting more instances from the DB, we can fill the number of"},{"line_number":15,"context_line":"instances up to the correct number."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c31dfd2a_dea4a127","line":12,"in_reply_to":"361b8007_026907eb","updated":"2025-05-21 06:26:52.000000000","message":"Acknowledged","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7281443d8b21838d251866d12bda3063e14f2047","unresolved":true,"context_lines":[{"line_number":12,"context_line":"of instances and failed giving the servers_links (next) marker."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"By collecting more instances from the DB, we can fill the number of"},{"line_number":15,"context_line":"instances up to the correct number."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 2110044"},{"line_number":18,"context_line":"Change-Id: I0c90e7ed46bd0235de33a72a31aeeaafc09a980a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"751f1cf2_fde8af99","line":15,"updated":"2025-05-19 12:54:03.000000000","message":"we can but if that all we do it does nto resolve the actual bug which is the missing marker","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"69481d5e759c3905d21e683109055813754e0107","unresolved":false,"context_lines":[{"line_number":12,"context_line":"of instances and failed giving the servers_links (next) marker."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"By collecting more instances from the DB, we can fill the number of"},{"line_number":15,"context_line":"instances up to the correct number."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 2110044"},{"line_number":18,"context_line":"Change-Id: I0c90e7ed46bd0235de33a72a31aeeaafc09a980a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d4337fd5_a7ed9a9a","line":15,"in_reply_to":"751f1cf2_fde8af99","updated":"2025-05-21 06:26:52.000000000","message":"Acknowledged","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7281443d8b21838d251866d12bda3063e14f2047","unresolved":true,"context_lines":[{"line_number":14,"context_line":"By collecting more instances from the DB, we can fill the number of"},{"line_number":15,"context_line":"instances up to the correct number."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 2110044"},{"line_number":18,"context_line":"Change-Id: I0c90e7ed46bd0235de33a72a31aeeaafc09a980a"},{"line_number":19,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"958752b7_5631f0f0","line":17,"updated":"2025-05-19 12:54:03.000000000","message":"i think we need to take a sep back and create a repoducer unit or funtional test to demonstrate the actul bug first and then ensure this actully fixes it\n\nright now this patch does nto make any assertions that the marker is not present with the changes you have done so it does not close the bug.","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"efe1b14bd0fc46af507151ddf1a4b8a9d1dbcc99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f74777a_dbcd9142","updated":"2025-05-19 12:28:26.000000000","message":"We are suffering same situation, thanks for you change !","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7281443d8b21838d251866d12bda3063e14f2047","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ac6b252a_108c5b8c","updated":"2025-05-19 12:54:03.000000000","message":"it would be nice to have a very short fixes release note for this too.","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"ad24d7a8c3bafb1522769105d8fd8bee644ebe06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"69206dbd_5408d9a8","updated":"2025-05-07 12:36:22.000000000","message":"recheck nova-ceph-multistore","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"}],"nova/compute/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d625497d74b2c96d959af0584dbc00254be8d8c8","unresolved":true,"context_lines":[{"line_number":3170,"context_line":"            cell_down_support\u003dcell_down_support)"},{"line_number":3171,"context_line":""},{"line_number":3172,"context_line":"        # Only subtract from limit if it is not None"},{"line_number":3173,"context_line":"        limit \u003d (limit - len(build_req_instances)) if limit else limit"},{"line_number":3174,"context_line":""},{"line_number":3175,"context_line":"        def _get_unique_filter_method():"},{"line_number":3176,"context_line":"            seen_uuids \u003d set()"}],"source_content_type":"text/x-python","patch_set":3,"id":"b909722f_460c5b80","line":3173,"updated":"2025-05-19 12:48:47.000000000","message":"so the effect of this change is we pass the original limit to the cell call\ninstead of subtracting the build build_req_instances\n\n\nso if you request limit\u003d100\n\nIn the prior logic, if there were 100 instances in build, we would not have got back any instance from the cells.\n\nwith this change we now will get back 100 instance from each cell so we have signifcnatly increased the amount of data in memory.\n\nthis may be ok but this will have a perfroamce impact espically for larger limits.","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d625497d74b2c96d959af0584dbc00254be8d8c8","unresolved":true,"context_lines":[{"line_number":3205,"context_line":"        limit \u003d (limit - len(insts)) if limit else limit"},{"line_number":3206,"context_line":"        # TODO(alaski): Clean up the objects concatenation when List objects"},{"line_number":3207,"context_line":"        # support it natively."},{"line_number":3208,"context_line":"        instances \u003d objects.InstanceList("},{"line_number":3209,"context_line":"            objects\u003dlist(filter(filter_method,"},{"line_number":3210,"context_line":"                           build_req_instances.objects +"},{"line_number":3211,"context_line":"                           insts.objects)))"},{"line_number":3212,"context_line":""},{"line_number":3213,"context_line":"        instances \u003d instances[:orig_limit]"},{"line_number":3214,"context_line":""},{"line_number":3215,"context_line":"        if filter_ip:"},{"line_number":3216,"context_line":"            instances \u003d self._ip_filter(instances, filters, orig_limit)"}],"source_content_type":"text/x-python","patch_set":3,"id":"25723389_f35747f0","line":3213,"range":{"start_line":3208,"start_character":4,"end_line":3213,"end_character":42},"updated":"2025-05-19 12:48:47.000000000","message":"this is changing the data type of instances form an InstanceList or a list(instances) which are not the same.\n\nthis is proably more correct.\n\n```suggestion\n        instances \u003d list(\n            filter(filter_method,\n                build_req_instances.objects +\n                insts.objects))[:orig_limit]\n        instances \u003d objects.InstanceList(objects\u003dinstances)\n```","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1d602e86b9c9b05c14c4d435d4961e5c40942e25","unresolved":true,"context_lines":[{"line_number":3205,"context_line":"        limit \u003d (limit - len(insts)) if limit else limit"},{"line_number":3206,"context_line":"        # TODO(alaski): Clean up the objects concatenation when List objects"},{"line_number":3207,"context_line":"        # support it natively."},{"line_number":3208,"context_line":"        instances \u003d objects.InstanceList("},{"line_number":3209,"context_line":"            objects\u003dlist(filter(filter_method,"},{"line_number":3210,"context_line":"                           build_req_instances.objects +"},{"line_number":3211,"context_line":"                           insts.objects)))"},{"line_number":3212,"context_line":""},{"line_number":3213,"context_line":"        instances \u003d instances[:orig_limit]"},{"line_number":3214,"context_line":""},{"line_number":3215,"context_line":"        if filter_ip:"},{"line_number":3216,"context_line":"            instances \u003d self._ip_filter(instances, filters, orig_limit)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c53b0743_48a20822","line":3213,"range":{"start_line":3208,"start_character":4,"end_line":3213,"end_character":42},"in_reply_to":"25723389_f35747f0","updated":"2025-05-19 12:57:38.000000000","message":"depending on how we overloaded the magic method in oslo \n\n instances \u003d instances[:orig_limit]\n \n might actually be ok, but we don\u0027t want to accidentally change the type.","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"69481d5e759c3905d21e683109055813754e0107","unresolved":false,"context_lines":[{"line_number":3205,"context_line":"        limit \u003d (limit - len(insts)) if limit else limit"},{"line_number":3206,"context_line":"        # TODO(alaski): Clean up the objects concatenation when List objects"},{"line_number":3207,"context_line":"        # support it natively."},{"line_number":3208,"context_line":"        instances \u003d objects.InstanceList("},{"line_number":3209,"context_line":"            objects\u003dlist(filter(filter_method,"},{"line_number":3210,"context_line":"                           build_req_instances.objects +"},{"line_number":3211,"context_line":"                           insts.objects)))"},{"line_number":3212,"context_line":""},{"line_number":3213,"context_line":"        instances \u003d instances[:orig_limit]"},{"line_number":3214,"context_line":""},{"line_number":3215,"context_line":"        if filter_ip:"},{"line_number":3216,"context_line":"            instances \u003d self._ip_filter(instances, filters, orig_limit)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f8d416a_8a7c9d16","line":3213,"range":{"start_line":3208,"start_character":4,"end_line":3213,"end_character":42},"in_reply_to":"c53b0743_48a20822","updated":"2025-05-21 06:26:52.000000000","message":"Fix applied.","commit_id":"f7e4b9c4aaf5ff13054fbd86bc2ced73eef4d844"}],"nova/tests/unit/compute/test_api.py":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"18a170cfb06f3d2c94fd8ab9d54116580d71475f","unresolved":true,"context_lines":[{"line_number":7143,"context_line":""},{"line_number":7144,"context_line":"            instances \u003d self.compute_api.get_all("},{"line_number":7145,"context_line":"                self.context, search_opts\u003d{\u0027foo\u0027: \u0027bar\u0027},"},{"line_number":7146,"context_line":"                limit\u003d10, marker\u003d\u0027fake-marker\u0027, sort_keys\u003d[\u0027baz\u0027],"},{"line_number":7147,"context_line":"                sort_dirs\u003d[\u0027desc\u0027])"},{"line_number":7148,"context_line":""},{"line_number":7149,"context_line":"            mock_buildreq_get.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"bc5e4b0a_210852cd","line":7146,"updated":"2025-05-21 06:34:22.000000000","message":"I am still missing the unit test","commit_id":"77b1cafca5784d577326a1ed550d11160bccaa71"}],"releasenotes/notes/build-requests-marker-missing-5457140ab09c6afe.yaml":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"18a170cfb06f3d2c94fd8ab9d54116580d71475f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ce90aa5b_6070734f","line":9,"updated":"2025-05-21 06:34:22.000000000","message":"not sure about what was expected for the reno, let me know","commit_id":"77b1cafca5784d577326a1ed550d11160bccaa71"}]}