)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2293843706b350ed6a17c5d9fe40fd8b7d3b8171","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cgibi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-19 10:54:58 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that we are using executors we can clarify the naming of the global"},{"line_number":10,"context_line":"and the function accessing it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"6ec5be2f_a4c68e3d","line":7,"updated":"2025-05-26 15:03:40.000000000","message":"+1 ya i was debating if i should comment on this earlier\n\ni prefer this nameing","commit_id":"ceacb72cee7cfe79e1ea15120069f438928a5d2d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"950e124bd1b73fc6602ececb9d44510f5c0de83c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cgibi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-19 10:54:58 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that we are using executors we can clarify the naming of the global"},{"line_number":10,"context_line":"and the function accessing it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7eea5c9e_0794dd9a","line":7,"in_reply_to":"6ec5be2f_a4c68e3d","updated":"2025-05-27 11:55:00.000000000","message":"yepp I just wanted to do the naming change independently from the logic change.","commit_id":"ceacb72cee7cfe79e1ea15120069f438928a5d2d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"ae689d60c44c6b1ea3a51794c745d309952bb70f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f155f53c_bd7e4b33","updated":"2025-06-10 15:49:47.000000000","message":"Soft -1 because I think it will be great to rename  CONF.default_green_pool_size in this path too.","commit_id":"c0974e08c4931ecb1c8ea3ed15a8daea43535907"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3b5df8f19e4e127afe4d270a08d22fb9a26c27a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"1231a0bd_2f321427","updated":"2025-06-16 12:28:06.000000000","message":"recheck \n* grenade-skip-level-always: bug/2114732\n* nova-ceph-multistore: ceph install failure: bug/2114734\n```\nError: mgr not available after 15 tries\n```","commit_id":"91a7e06306d36e9a79b0932728fa81a33830ea24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"79e4b0651300e0c1db7992a073087de6e899c994","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":24,"id":"dae4014a_71a2e4e4","updated":"2025-07-08 12:59:08.000000000","message":"im still ok with this but il will highlight ugglas comment inline.\ni don\u0027t agree but we we shoudl agree on unifying the config options or not.\ni prefer fer to keep them separate and minimise renaming of existing config options  during the eventlet removal\n\nwe can and should IMO add new config options for the threaded executor where we want to support turning each mode seperately","commit_id":"87a9a4310a84f4f7e2216a0025527cd801e69db2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"19ab92104efcb1e576c3581650af43266cd566be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"c93c1ab6_1e7988f6","updated":"2025-07-22 11:29:26.000000000","message":"recheck bug 2116336","commit_id":"cc0c57b73a01bd9175d2dfe13d669ced3761c177"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a05580f32419f0a74a99a08aaca63683cdc0b4fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"5de9ca01_ff6caa14","updated":"2025-07-21 15:26:15.000000000","message":"recheck cannot ssh into the guest","commit_id":"cc0c57b73a01bd9175d2dfe13d669ced3761c177"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ec9e5fbdc9500c4363656b21b061e3e81de47e70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"834078fc_ec81d64b","updated":"2025-07-18 13:35:02.000000000","message":"recheck nova-next timed out during stack.sh lets see if it was a one-off","commit_id":"cc0c57b73a01bd9175d2dfe13d669ced3761c177"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"27137332762f516b433f2a27052896c82fdff5e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"604c5314_165a2c34","updated":"2025-07-21 07:02:12.000000000","message":"recheck tempest-integrated-compute timed out. \n\nIt looks like it executed the same tempest run command twice and the second timed out.\n\n```\n2025-07-18 14:06:31.836654 | controller | integrated-compute run-test: commands[1] | tempest run --slowest --regex \u0027(?!.*\\[.*\\bslow\\b.*\\])(^tempest\\.api)\u0027 --exclude-list ./tools/tempest-integrated-gate-compute-exclude-list.txt --concurrency\u003d4 --exclude-regex\u003d\n```\n\n```\n2025-07-18 15:13:34.668968 | controller | integrated-compute run-test: commands[1] | tempest run --slowest --regex \u0027(?!.*\\[.*\\bslow\\b.*\\])(^tempest\\.api)\u0027 --exclude-list ./tools/tempest-integrated-gate-compute-exclude-list.txt --concurrency\u003d4 --exclude-regex\u003d\n```\n\nhttps://a96e38bf7825cd25c740-9f001e5f5ba768b81be8f04331a61031.ssl.cf2.rackcdn.com/openstack/1fd5bb3b5457461285aaf2a77e03e438/job-output.txt","commit_id":"cc0c57b73a01bd9175d2dfe13d669ced3761c177"}],"nova/tests/fixtures/nova.py":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"882211d64f50c74923bc8f24a06649b1ce4ebc56","unresolved":true,"context_lines":[{"line_number":1185,"context_line":"        self.addCleanup(self.cleanup)"},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"class IsolatedGreenPoolFixture(fixtures.Fixture):"},{"line_number":1189,"context_line":"    \"\"\"isolate each test to a dedicated greenpool."},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    Replace the default shared greenpool with a pre test greenpool"},{"line_number":1192,"context_line":"    and wait for all greenthreads to finish in test cleanup."},{"line_number":1193,"context_line":"    \"\"\""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def __init__(self, test):"}],"source_content_type":"text/x-python","patch_set":25,"id":"cf3f08fc_26bf3e3a","line":1192,"range":{"start_line":1188,"start_character":0,"end_line":1192,"end_character":60},"updated":"2025-07-18 06:31:25.000000000","message":"Dont we need to change classname and description as well ?","commit_id":"cc0c57b73a01bd9175d2dfe13d669ced3761c177"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b29f93d35119299d2db67a9c97124f18164612bc","unresolved":true,"context_lines":[{"line_number":1185,"context_line":"        self.addCleanup(self.cleanup)"},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"class IsolatedGreenPoolFixture(fixtures.Fixture):"},{"line_number":1189,"context_line":"    \"\"\"isolate each test to a dedicated greenpool."},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    Replace the default shared greenpool with a pre test greenpool"},{"line_number":1192,"context_line":"    and wait for all greenthreads to finish in test cleanup."},{"line_number":1193,"context_line":"    \"\"\""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def __init__(self, test):"}],"source_content_type":"text/x-python","patch_set":25,"id":"f44f32b2_6e1d5c3c","line":1192,"range":{"start_line":1188,"start_character":0,"end_line":1192,"end_character":60},"in_reply_to":"92b61996_8e0d7fa9","updated":"2025-07-18 11:00:30.000000000","message":"its actully renmaed there which is the correct patch to do it in \nhttps://review.opendev.org/c/openstack/nova/+/948087/26/nova/tests/fixtures/nova.py","commit_id":"cc0c57b73a01bd9175d2dfe13d669ced3761c177"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9362939cd7c8b87fa7dd57e61a047e0824011ed8","unresolved":true,"context_lines":[{"line_number":1185,"context_line":"        self.addCleanup(self.cleanup)"},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"class IsolatedGreenPoolFixture(fixtures.Fixture):"},{"line_number":1189,"context_line":"    \"\"\"isolate each test to a dedicated greenpool."},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    Replace the default shared greenpool with a pre test greenpool"},{"line_number":1192,"context_line":"    and wait for all greenthreads to finish in test cleanup."},{"line_number":1193,"context_line":"    \"\"\""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def __init__(self, test):"}],"source_content_type":"text/x-python","patch_set":25,"id":"92b61996_8e0d7fa9","line":1192,"range":{"start_line":1188,"start_character":0,"end_line":1192,"end_character":60},"in_reply_to":"cf3f08fc_26bf3e3a","updated":"2025-07-18 10:59:32.000000000","message":"not really we could but its still correct \n\noiver time it will hcange when we remove eventlet and this is jsut used fo thread pools i guess.\n\n\nwe can update this but im inclined to say that should be in a followup.\n\nits not actully confgiurable until the next patch so its still using greenpools/greenthereads","commit_id":"cc0c57b73a01bd9175d2dfe13d669ced3761c177"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"25541697364267670799dd017d22b8acc0ecd9d6","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"        self.addCleanup(self.cleanup)"},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"class IsolatedGreenPoolFixture(fixtures.Fixture):"},{"line_number":1189,"context_line":"    \"\"\"isolate each test to a dedicated greenpool."},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    Replace the default shared greenpool with a pre test greenpool"},{"line_number":1192,"context_line":"    and wait for all greenthreads to finish in test cleanup."},{"line_number":1193,"context_line":"    \"\"\""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def __init__(self, test):"}],"source_content_type":"text/x-python","patch_set":25,"id":"8eaa0f56_7c09cdd6","line":1192,"range":{"start_line":1188,"start_character":0,"end_line":1192,"end_character":60},"in_reply_to":"f44f32b2_6e1d5c3c","updated":"2025-07-18 11:21:36.000000000","message":"Acknowledged","commit_id":"cc0c57b73a01bd9175d2dfe13d669ced3761c177"}],"nova/utils.py":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"ae689d60c44c6b1ea3a51794c745d309952bb70f","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    if not DEFAULT_EXECUTOR:"},{"line_number":114,"context_line":"        DEFAULT_EXECUTOR \u003d futurist.GreenThreadPoolExecutor("},{"line_number":115,"context_line":"            CONF.default_green_pool_size"},{"line_number":116,"context_line":"        )"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        pname \u003d multiprocessing.current_process().name"}],"source_content_type":"text/x-python","patch_set":16,"id":"917b2d69_746c8af6","line":115,"range":{"start_line":115,"start_character":17,"end_line":115,"end_character":40},"updated":"2025-06-10 15:49:47.000000000","message":"I suggest to rename the configuration parameter too.\nAnd so the parameter in nova/conf/base.py.\n\nhttps://opendev.org/openstack/nova/src/commit/c4c513436920525cff9e45f3dd4016a80f0371c5/nova/conf/base.py#L64","commit_id":"c0974e08c4931ecb1c8ea3ed15a8daea43535907"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"853f97acfdd15a4725a41014d9f7dcbce863300f","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    if not DEFAULT_EXECUTOR:"},{"line_number":114,"context_line":"        DEFAULT_EXECUTOR \u003d futurist.GreenThreadPoolExecutor("},{"line_number":115,"context_line":"            CONF.default_green_pool_size"},{"line_number":116,"context_line":"        )"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        pname \u003d multiprocessing.current_process().name"}],"source_content_type":"text/x-python","patch_set":16,"id":"8cbc7b96_3cd94ee2","line":115,"range":{"start_line":115,"start_character":17,"end_line":115,"end_character":40},"in_reply_to":"3bb5d276_7b9f5760","updated":"2025-07-17 13:41:16.000000000","message":"Thans gibi","commit_id":"c0974e08c4931ecb1c8ea3ed15a8daea43535907"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c5ce1574a393c79de607cd0fd1c74dbb0f372b52","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    if not DEFAULT_EXECUTOR:"},{"line_number":114,"context_line":"        DEFAULT_EXECUTOR \u003d futurist.GreenThreadPoolExecutor("},{"line_number":115,"context_line":"            CONF.default_green_pool_size"},{"line_number":116,"context_line":"        )"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        pname \u003d multiprocessing.current_process().name"}],"source_content_type":"text/x-python","patch_set":16,"id":"3bb5d276_7b9f5760","line":115,"range":{"start_line":115,"start_character":17,"end_line":115,"end_character":40},"in_reply_to":"530b7402_8bff6d8f","updated":"2025-07-11 13:00:07.000000000","message":"I agree to deprecate the eventlet related config options once we can give the alternative. For the executor size config option it is a bit tricky. Even if we have the config option for the threaded executor we cannot give it yet as an alternative for the user as it is only implemented for some of our services like nova-scheduler. So we cannot deprecate the old config yet.\n\nI will keep an eye for doing the deprecation in G when all the threaded executor is applicable for all our services.","commit_id":"c0974e08c4931ecb1c8ea3ed15a8daea43535907"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb57cbf6a2d3780289e705c8b39fc637a5a0b338","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    if not DEFAULT_EXECUTOR:"},{"line_number":114,"context_line":"        DEFAULT_EXECUTOR \u003d futurist.GreenThreadPoolExecutor("},{"line_number":115,"context_line":"            CONF.default_green_pool_size"},{"line_number":116,"context_line":"        )"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        pname \u003d multiprocessing.current_process().name"}],"source_content_type":"text/x-python","patch_set":16,"id":"530b7402_8bff6d8f","line":115,"range":{"start_line":115,"start_character":17,"end_line":115,"end_character":40},"in_reply_to":"5ca23071_128e5fa7","updated":"2025-07-10 09:57:51.000000000","message":"yeah, we can\u0027t modify the option name unless we continue to use the older as a deprecated_name value : https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.cfg.Opt\n\nthat said, I agree with sean : instead of changing the name, we should rather deprecate the option in a later release once we\u0027re done.","commit_id":"c0974e08c4931ecb1c8ea3ed15a8daea43535907"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"42cdab598cfc1efc474fae3a959925bfe5d44bf6","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    if not DEFAULT_EXECUTOR:"},{"line_number":114,"context_line":"        DEFAULT_EXECUTOR \u003d futurist.GreenThreadPoolExecutor("},{"line_number":115,"context_line":"            CONF.default_green_pool_size"},{"line_number":116,"context_line":"        )"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        pname \u003d multiprocessing.current_process().name"}],"source_content_type":"text/x-python","patch_set":16,"id":"fdfd2393_56292a91","line":115,"range":{"start_line":115,"start_character":17,"end_line":115,"end_character":40},"in_reply_to":"917b2d69_746c8af6","updated":"2025-06-13 10:55:20.000000000","message":"The config options are an interface so we cannot just rename an existing config option that will break existing deplolyments using the old name. We need to keep the old name for backward compatibility.\n\nAlso due to the fact that nova needs to support running both in eventlet and threading mode we will eventually have to config options to define the size of the pool one for the eventlet case and one for the threading case. This will allow a smooth transition from event to threading or back by allowing defining both config options with different values. \n\nHaving two config options also allows us to define two separate default value one for threading and one for eventlet.\n\nSo I would like to keep this as is.","commit_id":"c0974e08c4931ecb1c8ea3ed15a8daea43535907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"79e4b0651300e0c1db7992a073087de6e899c994","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    if not DEFAULT_EXECUTOR:"},{"line_number":114,"context_line":"        DEFAULT_EXECUTOR \u003d futurist.GreenThreadPoolExecutor("},{"line_number":115,"context_line":"            CONF.default_green_pool_size"},{"line_number":116,"context_line":"        )"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        pname \u003d multiprocessing.current_process().name"}],"source_content_type":"text/x-python","patch_set":16,"id":"5ca23071_128e5fa7","line":115,"range":{"start_line":115,"start_character":17,"end_line":115,"end_character":40},"in_reply_to":"fdfd2393_56292a91","updated":"2025-07-08 12:59:08.000000000","message":"well we could use the oslo decorator to rename them but i also diagree.\n\nthis config option is specific to eventlet so we shoudl keep it default_green_pool_size\n\nwhen we remvoe eventlet supprot in the future, the config option will be removed then so i think keeping the existing name rahter then using the oslo.config supprot for deprecating old name and renaming is simpler.\n\ni also agree that we are going to want an independent config option for the eventlet and non-eventlet executor pools.","commit_id":"c0974e08c4931ecb1c8ea3ed15a8daea43535907"}]}