)]}'
{"id":"openstack%2Fnova~948251","triplet_id":"openstack%2Fnova~stable%2F2025.1~I3e9b1af23245a15a22450aba11ae1955a1696051","project":"openstack/nova","branch":"stable/2025.1","hashtags":[],"change_id":"I3e9b1af23245a15a22450aba11ae1955a1696051","subject":"FUP Remove unnecessary PCI check","status":"ABANDONED","created":"2025-04-25 16:23:15.000000000","updated":"2025-04-25 22:13:23.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"663c9f773ae5eaa9d7c82ef828e49fa126d9c8e0","_number":948251,"virtual_id_number":948251,"owner":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"actions":{},"labels":{"Verified":{"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-25 22:13:23.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"fd79c94c85861fbee01e42259a5a927d773f7849","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"date":"2025-04-25 16:23:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dde965c0fca648e76f6b140077e681ab48027038","tag":"autogenerated:gerrit:abandon","author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"date":"2025-04-25 16:30:46.000000000","message":"Abandoned\n\nMistake doing backport","accounts_in_message":[],"_revision_number":1},{"id":"663c9f773ae5eaa9d7c82ef828e49fa126d9c8e0","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-04-25 22:13:23.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-948251-nsh62/index.html\u003e","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4f98f32e1b2db2a1dde069884662403452cf75b1","revisions":{"4f98f32e1b2db2a1dde069884662403452cf75b1":{"kind":"REWORK","_number":1,"created":"2025-04-25 16:23:15.000000000","uploader":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"ref":"refs/changes/51/948251/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/51/948251/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/948251/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/948251/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/948251/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/51/948251/1"}}},"commit":{"parents":[{"commit":"3242cde34232d0c65629f8c6866d0f2ddef7cda3","subject":"ironic: fix logging of validation errors","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3242cde34232d0c65629f8c6866d0f2ddef7cda3"}]}],"author":{"name":"René Ribaud","email":"rribaud@redhat.com","date":"2025-03-12 10:37:50.000000000","tz":60},"committer":{"name":"René Ribaud","email":"rribaud@redhat.com","date":"2025-04-25 16:22:15.000000000","tz":120},"subject":"FUP Remove unnecessary PCI check","message":"FUP Remove unnecessary PCI check\n\nThis patch removes the _test_pci() method, which is no longer necessary\nsince flavor-based requests can now be live migrated.\n\nThe related tests have also been removed.\n\nThis fixes a bug where a user requests a live migration with a\nflavor-based request and NUMA constraints (e.g., CPU affinity). In\nthis case, the code encounters the _test_pci() method and fails because\nthe check was originally designed to enforce port-based requests only,\ncausing an unnecessary failure.\n\nNotes: This issue was discovered through functional tests that involve\na mix of port-based and flavor-based requests. The failure in this\nscenario highlighted the unnecessary constraint.\nA functional test reproducing this issue in a mixed-mode scenario\n(port request + flavor-based request) will be provided in a subsequent\nFUP patch.\n\nThe _test_pci() check was redundant, as a similar verification\nis already performed earlier in the migration process.\n\nCloses-Bug: 2103636\nImplements: blueprint migrate-vfio-devices-using-kernel-variant-drivers\nChange-Id: Icbeaadd94658ed44917d724446d484f6497f29e5\n(cherry-picked from commit 4e4262cd3dfc6e2c1b0859882d2bd4dceb8ed7d8)\n\nChange-Id: I3e9b1af23245a15a22450aba11ae1955a1696051\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4f98f32e1b2db2a1dde069884662403452cf75b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4f98f32e1b2db2a1dde069884662403452cf75b1"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
