)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ccf16baf2347d68efb4d6872ccee83843621bae","unresolved":true,"context_lines":[{"line_number":7,"context_line":"libvirt: Allow using the system page (4KiB)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It was prohibited due to the limitation in libvirt, which was resolved"},{"line_number":10,"context_line":"in v1.2.12[1] ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://gitlab.com/libvirt/libvirt/-/commit/311b4a6"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f629743_6731daa9","line":10,"updated":"2025-09-01 11:00:05.000000000","message":"that not why these coments are there in general\n\n\nits good to know we cna now specirfy a 4k page size in the xml\n\nwe can likely consider doing that in the future however 4k pages are nto valid for hugepages i.e. hw:mem_page_size\u003dlarge. more comments inline.","commit_id":"20670b5c52ddd6aace50456f6ed922503011ffa8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b78ef479c8ed193c8d5a9989404aa521a4216b4a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"It was prohibited due to the limitation in libvirt, which was resolved"},{"line_number":10,"context_line":"in v1.2.12[1] ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://gitlab.com/libvirt/libvirt/-/commit/311b4a6"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I768ef9063aa1c8b608e6e64be052a349510e3a65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ab7360c_18d436f5","line":12,"updated":"2025-09-01 11:03:37.000000000","message":"this change does not really help use in any way so im not sure we want to make this chagne.\n\nif we did i would want an explation of why we shoudl do this and what benifit ti give to nova.\n\nthere isnt an upgrade impact in the sense that libvirt will supprot it given how old this is but i dont think there is any benifit to this either","commit_id":"20670b5c52ddd6aace50456f6ed922503011ffa8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e59868ddc522832daad3edfdf192bcfde3e163c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0e36b1b3_02db9f04","updated":"2025-09-01 10:06:27.000000000","message":"recheck unrelated failure","commit_id":"20670b5c52ddd6aace50456f6ed922503011ffa8"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ccf16baf2347d68efb4d6872ccee83843621bae","unresolved":true,"context_lines":[{"line_number":6351,"context_line":"                          for page in host_topology.cells[0].mempages]"},{"line_number":6352,"context_line":"        avail_pagesize.sort()"},{"line_number":6353,"context_line":"        # Remove smallest page size as that\u0027s not classed as a largepage"},{"line_number":6354,"context_line":"        avail_pagesize \u003d avail_pagesize[1:]"},{"line_number":6355,"context_line":""},{"line_number":6356,"context_line":"        # See if we have page size set"},{"line_number":6357,"context_line":"        for cell in instance_topology.cells:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d488e3e3_c632cad3","side":"PARENT","line":6354,"updated":"2025-09-01 11:00:05.000000000","message":"this is incorerct for hugepage requests.\n\ni we want hugepages i.e. hw:mem_page_size\u003dlarge it not valid to include the smallest page size.","commit_id":"023be4f5615255d06f61b393605da1308f045220"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ccf16baf2347d68efb4d6872ccee83843621bae","unresolved":true,"context_lines":[{"line_number":6978,"context_line":"        avail_pagesize \u003d [page.size_kb"},{"line_number":6979,"context_line":"                          for page in host_topology.cells[0].mempages]"},{"line_number":6980,"context_line":"        avail_pagesize.sort()"},{"line_number":6981,"context_line":"        smallest \u003d avail_pagesize[0]"},{"line_number":6982,"context_line":""},{"line_number":6983,"context_line":"        pages \u003d []"},{"line_number":6984,"context_line":"        for guest_cellid, inst_cell in enumerate(inst_topology.cells):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cacb7268_bd29c25d","side":"PARENT","line":6981,"updated":"2025-09-01 11:00:05.000000000","message":"again we do not consider 4k small pages valid for backign hugepages so this is also not corect.","commit_id":"023be4f5615255d06f61b393605da1308f045220"}]}