)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a0460e74ef775cc20da4e64d1c5c6de3f5e434eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"18f889a6_9437a8db","updated":"2025-05-22 04:39:44.000000000","message":"ok this fixed the bug but it found another one\n\n```\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest Traceback (most recent call last):\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest   File \"/opt/stack/nova/nova/virt/libvirt/guest.py\", line 165, in launch\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest     return self._domain.createWithFlags(flags)\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest   File \"/opt/stack/data/venv/lib/python3.12/site-packages/eventlet/tpool.py\", line 186, in doit\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest     result \u003d proxy_call(self._autowrap, f, *args, **kwargs)\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest   File \"/opt/stack/data/venv/lib/python3.12/site-packages/eventlet/tpool.py\", line 144, in proxy_call\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest     rv \u003d execute(f, *args, **kwargs)\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest          ^^^^^^^^^^^^^^^^^^^^^^^^^^^\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest   File \"/opt/stack/data/venv/lib/python3.12/site-packages/eventlet/tpool.py\", line 125, in execute\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest     raise e.with_traceback(tb)\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest   File \"/opt/stack/data/venv/lib/python3.12/site-packages/eventlet/tpool.py\", line 82, in tworker\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest     rv \u003d meth(*args, **kwargs)\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest          ^^^^^^^^^^^^^^^^^^^^^\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest   File \"/usr/lib/python3/dist-packages/libvirt.py\", line 1415, in createWithFlags\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest     raise libvirtError(\u0027virDomainCreateWithFlags() failed\u0027)\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest libvirt.libvirtError: Requested operation is not valid: mediated device /sys/bus/mdev/devices/6dc8d190-2bc9-45ed-a4b8-d4f0708f92bb is in use by driver QEMU, domain instance-00000001\nMay 21 19:34:48.087398 np0040852503 nova-compute[42281]: ERROR nova.virt.libvirt.guest \n```\n\nlibvirt.libvirtError: Requested operation is not valid: mediated device /sys/bus/mdev/devices/6dc8d190-2bc9-45ed-a4b8-d4f0708f92bb is in use by driver QEMU, domain instance-00000001\n\nthis is a bug in novas logic.","commit_id":"e49e0387c5845968d51441424d1c5eb70998ecf4"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"e382c000ec3a0345c841dfe4e288f82ccb6cd9bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"77d78eac_e15b1acb","in_reply_to":"18f889a6_9437a8db","updated":"2026-06-17 13:56:12.000000000","message":"Done","commit_id":"e49e0387c5845968d51441424d1c5eb70998ecf4"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"4388b30cc43cd32839fe0276a8cf1ed3531fec29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f344860e_f200771d","updated":"2026-06-02 15:10:27.000000000","message":"recheck stale ci results","commit_id":"f8786d126aa3484f762f2cc820ba5d60bec7cbb9"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"74fdbe9a1a798b8175fd569d3b31eb5ec252ae7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a5e969e5_ef1862d8","updated":"2026-06-09 09:18:46.000000000","message":"recheck","commit_id":"f8db9594b443cc5a24e8916d32db313cb5d71417"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3489769f57fe4cc4fb287e4009c3394de175b95","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9cb23598_ec62175d","updated":"2026-06-17 13:29:48.000000000","message":"as noted the libvirt restart is now not needed on moderen distos so im fine with removeing that if other prefer.\n\ni think this is stable enough to proceed with but lest see how other feel \n\nyour fix to whitebox land the ci job is also green form teh last patch in this seies\n\nhttps://ec204f0f86fc79eca0f1-757cbada98b2345898c3deef0a647dfa.ssl.cf2.rackcdn.com/openstack/7566e167c5d9441daab252d52372a58a/testr_results.html","commit_id":"607632d480ead63621265973c4b2e66dba84d7e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66a65939f9a987dcd37c26fefb2e837a9c12aa44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c4ed90e8_98d22c50","updated":"2026-06-17 13:30:33.000000000","message":"recheck test_refresh_nfs_swap_cache_stale was known flaky when this ran","commit_id":"607632d480ead63621265973c4b2e66dba84d7e8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"08da6184d06ae4d2a676a462f2ee22aea2d4cdb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f2ebc030_f8db9a87","updated":"2026-06-23 16:30:09.000000000","message":"Looks good, thanks","commit_id":"6d52ef14b602396d3bc5298fc7c827d6c56cc708"}],"devstack/plugin.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"22702c135bafb711dd4c8b9e74845a3018001eb9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"            async_wait compile_mdev_samples"},{"line_number":16,"context_line":"            sudo virsh nodedev-list"},{"line_number":17,"context_line":"            restart_service libvirtd"},{"line_number":18,"context_line":"            sudo virsh nodedev-list"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1869becf_297898af","line":18,"updated":"2025-05-21 16:02:15.000000000","message":"so this did not print so im going to add extra logging.\n\neithe this is not beign run or it is and tracign is off.","commit_id":"fd4c071a69fd163ef6b3396a4ca30712999d0a71"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df2ea19ad00ffdd572143ac49aac3c52a43854e5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"            async_wait compile_mdev_samples"},{"line_number":16,"context_line":"            sudo virsh nodedev-list"},{"line_number":17,"context_line":"            restart_service libvirtd"},{"line_number":18,"context_line":"            sudo virsh nodedev-list"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4e0f8995_44eedb2e","line":18,"in_reply_to":"1869becf_297898af","updated":"2025-05-22 07:28:40.000000000","message":"now that thsi is workign the output show that we have the mtty device aviabel without the libvir trestart btu it also does nto hurt\n\n```\n2025-05-21 19:33:41.045 | [3346 Async compile_mdev_samples:28834]: finished compile_mdev_samples with result 0 in 45 seconds\n2025-05-21 19:33:41.048 | ++ inc/async:async_wait:197                 :   return 0\n2025-05-21 19:33:41.049 | ++ /opt/stack/nova/devstack/plugin.sh:source:24 :   sudo virsh nodedev-list\n2025-05-21 19:33:41.067 | block_sr0_QEMU_DVD_ROM_QM00001\n2025-05-21 19:33:41.067 | block_vda\n2025-05-21 19:33:41.067 | block_vdb\n2025-05-21 19:33:41.067 | block_vdc\n2025-05-21 19:33:41.067 | computer\n2025-05-21 19:33:41.067 | drm_card0\n2025-05-21 19:33:41.068 | mtty_mtty\n2025-05-21 19:33:41.068 | net_br_ex_c2_f2_25_e1_9f_45\n2025-05-21 19:33:41.068 | net_br_infra_e6_18_0f_7c_41_48\n2025-05-21 19:33:41.068 | net_br_int_66_d0_a3_f3_94_4a\n2025-05-21 19:33:41.068 | net_ens3_fa_16_3e_d1_77_98\n2025-05-21 19:33:41.068 | net_lo_00_00_00_00_00_00\n2025-05-21 19:33:41.068 | net_ovs_system_82_de_8e_b0_63_fc\n2025-05-21 19:33:41.068 | pci_0000_00_00_0\n2025-05-21 19:33:41.068 | pci_0000_00_01_0\n2025-05-21 19:33:41.068 | pci_0000_00_01_1\n2025-05-21 19:33:41.068 | pci_0000_00_01_2\n2025-05-21 19:33:41.068 | pci_0000_00_01_3\n2025-05-21 19:33:41.068 | pci_0000_00_02_0\n2025-05-21 19:33:41.068 | pci_0000_00_03_0\n2025-05-21 19:33:41.068 | pci_0000_00_04_0\n2025-05-21 19:33:41.068 | pci_0000_00_05_0\n2025-05-21 19:33:41.068 | pci_0000_00_06_0\n2025-05-21 19:33:41.068 | pci_0000_00_07_0\n2025-05-21 19:33:41.068 | pci_0000_00_08_0\n2025-05-21 19:33:41.068 | scsi_0_0_0_0\n2025-05-21 19:33:41.068 | scsi_generic_sg0\n2025-05-21 19:33:41.068 | scsi_host0\n2025-05-21 19:33:41.068 | scsi_host1\n2025-05-21 19:33:41.068 | scsi_target0_0_0\n2025-05-21 19:33:41.068 | usb_1_0_1_0\n2025-05-21 19:33:41.068 | usb_1_1\n2025-05-21 19:33:41.068 | usb_1_1_1_0\n2025-05-21 19:33:41.068 | usb_usb1\n2025-05-21 19:33:41.068 | \n2025-05-21 19:33:41.072 | ++ /opt/stack/nova/devstack/plugin.sh:source:25 :   restart_service libvirtd\n2025-05-21 19:33:41.074 | ++ functions-common:restart_service:2305    :   \u0027[\u0027 -x /bin/systemctl \u0027]\u0027\n2025-05-21 19:33:41.076 | ++ functions-common:restart_service:2306    :   sudo /bin/systemctl restart libvirtd\n2025-05-21 19:33:41.118 | ++ /opt/stack/nova/devstack/plugin.sh:source:26 :   sudo virsh nodedev-list\n2025-05-21 19:33:41.486 | block_sr0_QEMU_DVD_ROM_QM00001\n2025-05-21 19:33:41.486 | block_vda\n2025-05-21 19:33:41.486 | block_vdb\n2025-05-21 19:33:41.486 | block_vdc\n2025-05-21 19:33:41.486 | computer\n2025-05-21 19:33:41.486 | drm_card0\n2025-05-21 19:33:41.486 | mtty_mtty\n2025-05-21 19:33:41.486 | net_br_ex_c2_f2_25_e1_9f_45\n2025-05-21 19:33:41.486 | net_br_infra_e6_18_0f_7c_41_48\n2025-05-21 19:33:41.486 | net_br_int_66_d0_a3_f3_94_4a\n2025-05-21 19:33:41.486 | net_ens3_fa_16_3e_d1_77_98\n2025-05-21 19:33:41.486 | net_lo_00_00_00_00_00_00\n2025-05-21 19:33:41.486 | net_ovs_system_82_de_8e_b0_63_fc\n2025-05-21 19:33:41.486 | pci_0000_00_00_0\n2025-05-21 19:33:41.486 | pci_0000_00_01_0\n2025-05-21 19:33:41.486 | pci_0000_00_01_1\n2025-05-21 19:33:41.486 | pci_0000_00_01_2\n2025-05-21 19:33:41.486 | pci_0000_00_01_3\n2025-05-21 19:33:41.486 | pci_0000_00_02_0\n2025-05-21 19:33:41.486 | pci_0000_00_03_0\n2025-05-21 19:33:41.486 | pci_0000_00_04_0\n2025-05-21 19:33:41.486 | pci_0000_00_05_0\n2025-05-21 19:33:41.486 | pci_0000_00_06_0\n2025-05-21 19:33:41.486 | pci_0000_00_07_0\n2025-05-21 19:33:41.486 | pci_0000_00_08_0\n2025-05-21 19:33:41.486 | scsi_0_0_0_0\n2025-05-21 19:33:41.486 | scsi_generic_sg0\n2025-05-21 19:33:41.486 | scsi_host0\n2025-05-21 19:33:41.486 | scsi_host1\n2025-05-21 19:33:41.487 | scsi_target0_0_0\n2025-05-21 19:33:41.487 | usb_1_0_1_0\n2025-05-21 19:33:41.487 | usb_1_1\n2025-05-21 19:33:41.487 | usb_1_1_1_0\n2025-05-21 19:33:41.487 | usb_usb1\n```\n\nso we can remove the restart and second print if we want to and this need a reabse other wise ill liave it as is unless someoen want this to be changed?","commit_id":"fd4c071a69fd163ef6b3396a4ca30712999d0a71"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"5770371440cfaf33092d6130b4dace181a2d5266","unresolved":true,"context_lines":[{"line_number":15,"context_line":"            async_wait compile_mdev_samples"},{"line_number":16,"context_line":"            sudo virsh nodedev-list"},{"line_number":17,"context_line":"            restart_service libvirtd"},{"line_number":18,"context_line":"            sudo virsh nodedev-list"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"text/x-sh","patch_set":2,"id":"95dd6929_11a7701c","line":18,"in_reply_to":"37462b5f_49364f1b","updated":"2026-06-15 09:30:30.000000000","message":"I\u0027m not sure we need to restart libvirt, we just need to ensure the devstack plugin function that compiles the kernel modules is done before the nova compute service starts so the configured mdev devices exist in the host","commit_id":"fd4c071a69fd163ef6b3396a4ca30712999d0a71"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"04f79fbf9046f659340bd830aaf4e56ac92e35bc","unresolved":true,"context_lines":[{"line_number":15,"context_line":"            async_wait compile_mdev_samples"},{"line_number":16,"context_line":"            sudo virsh nodedev-list"},{"line_number":17,"context_line":"            restart_service libvirtd"},{"line_number":18,"context_line":"            sudo virsh nodedev-list"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"text/x-sh","patch_set":2,"id":"37462b5f_49364f1b","line":18,"in_reply_to":"4e0f8995_44eedb2e","updated":"2026-06-12 15:19:50.000000000","message":"Why do we need to do this in post-config instead of extra if we\u0027re going to restart libvirtd?","commit_id":"fd4c071a69fd163ef6b3396a4ca30712999d0a71"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9aa8a511f1de8fad33d618017ac431bd07a2db40","unresolved":true,"context_lines":[{"line_number":15,"context_line":"            async_wait compile_mdev_samples"},{"line_number":16,"context_line":"            sudo virsh nodedev-list"},{"line_number":17,"context_line":"            restart_service libvirtd"},{"line_number":18,"context_line":"            sudo virsh nodedev-list"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"text/x-sh","patch_set":2,"id":"b36b5a47_73ed97a3","line":18,"in_reply_to":"95dd6929_11a7701c","updated":"2026-06-15 10:01:41.000000000","message":"the libvirt restart orginally was because there is a nodedev cache in libivrt that is cleared by the restart.\n\nin thoery lbivrt shoudl see the device if it recvied a udev event even if its not resarted but that has not alwasy been reliable. \n\nits been a while but i belive this was moved to post config since that is the last hook point before nova is started and we were tryign to maximise the amount of time the compile could be running in the background.\n\nif we do it in extra we also need to restart nova-compute because we also cache the devices in nova.","commit_id":"fd4c071a69fd163ef6b3396a4ca30712999d0a71"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"994eb143b3ba489960b7b0a22e5006aee387c0a9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"            async_wait compile_mdev_samples"},{"line_number":16,"context_line":"            sudo virsh nodedev-list"},{"line_number":17,"context_line":"            restart_service libvirtd"},{"line_number":18,"context_line":"            sudo virsh nodedev-list"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"text/x-sh","patch_set":2,"id":"baacd891_b7538e78","line":18,"in_reply_to":"b36b5a47_73ed97a3","updated":"2026-06-15 10:04:59.000000000","message":"https://docs.openstack.org/devstack/latest/plugins.html#plugin-sh-contract\n\n```\nThe current full list of mode and phase are:\n\n    stack - Called by stack.sh four times for different phases of its run:\n\n        pre-install - Called after system (OS) setup is complete and before project source is installed.\n\n        install - Called after the layer 1 and 2 projects source and their dependencies have been installed.\n\n        post-config - Called after the layer 1 and 2 services have been configured. All configuration files for enabled services should exist at this point.\n\n        extra - Called near the end after layer 1 and 2 services have been started.\n\n        test-config - Called at the end of devstack used to configure tempest or any other test environments\n\n    unstack - Called by unstack.sh before other services are shut down.\n\n    clean - Called by clean.sh before other services are cleaned, but after unstack.sh has been called.\n\n```","commit_id":"fd4c071a69fd163ef6b3396a4ca30712999d0a71"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4e569ee5e3c6bb17e78967e29cc953959567cc2b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"            async_wait compile_mdev_samples"},{"line_number":16,"context_line":"            sudo virsh nodedev-list"},{"line_number":17,"context_line":"            restart_service libvirtd"},{"line_number":18,"context_line":"            sudo virsh nodedev-list"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bb450382_bb56d5e5","line":18,"in_reply_to":"baacd891_b7538e78","updated":"2026-06-15 10:12:26.000000000","message":"also th original output abov show the restart is not requried at leat on ubuntu 24.04 so we can siblify this but post-config is impoant to make sure that nova does not cache device view before the module is loaded","commit_id":"fd4c071a69fd163ef6b3396a4ca30712999d0a71"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a0460e74ef775cc20da4e64d1c5c6de3f5e434eb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            install_package mdevctl"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    ;;"},{"line_number":21,"context_line":"    post-install)"},{"line_number":22,"context_line":"        if [[ \"$NOVA_COMPILE_MDEV_SAMPLES\" \u003d\u003d True ]]; then"},{"line_number":23,"context_line":"            async_wait compile_mdev_samples"},{"line_number":24,"context_line":"            sudo virsh nodedev-list"}],"source_content_type":"text/x-sh","patch_set":3,"id":"cc90777f_d863ab31","line":21,"range":{"start_line":21,"start_character":9,"end_line":21,"end_character":16},"updated":"2025-05-22 04:39:44.000000000","message":"this is post-config...","commit_id":"645f9538382a2a147f63da10d779849216b52e11"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d8a75b411af1cf9925e1204e48e137b31829670b","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"local xtrace\u003d$(set +o | grep xtrace)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"if [ \"$VERBOSE\" \u003d\u003d \u0027True\u0027 ]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"00f1e245_eec6d44a","line":1,"updated":"2026-06-22 23:16:54.000000000","message":"Ah, so this is where the strange blank line came from in the nova-whitebox job patch 🙂","commit_id":"607632d480ead63621265973c4b2e66dba84d7e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a47604a252d766c7b7260cce984fbc85d5d36b08","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"local xtrace\u003d$(set +o | grep xtrace)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"if [ \"$VERBOSE\" \u003d\u003d \u0027True\u0027 ]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ca478cb1_33eb825e","line":1,"in_reply_to":"00f1e245_eec6d44a","updated":"2026-06-23 10:35:48.000000000","message":"Done","commit_id":"607632d480ead63621265973c4b2e66dba84d7e8"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"96bd35e0a173c254cda3deea2356b138a1ea5acc","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"local xtrace\u003d$(set +o | grep xtrace)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"if [ \"$VERBOSE\" \u003d\u003d \u0027True\u0027 ]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"2790e5b2_e0f6f787","line":1,"in_reply_to":"00f1e245_eec6d44a","updated":"2026-06-23 11:19:20.000000000","message":"fixed","commit_id":"607632d480ead63621265973c4b2e66dba84d7e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a47604a252d766c7b7260cce984fbc85d5d36b08","unresolved":true,"context_lines":[{"line_number":15,"context_line":"        if [[ \"$NOVA_COMPILE_MDEV_SAMPLES\" \u003d\u003d True ]]; then"},{"line_number":16,"context_line":"            async_runfunc compile_mdev_samples"},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        ;;"},{"line_number":19,"context_line":"    post-config)"},{"line_number":20,"context_line":"        if [[ \"$NOVA_COMPILE_MDEV_SAMPLES\" \u003d\u003d True ]]; then"},{"line_number":21,"context_line":"            async_wait compile_mdev_samples"}],"source_content_type":"text/x-sh","patch_set":8,"id":"f3f0d6b1_60793ee9","line":18,"updated":"2026-06-23 10:35:48.000000000","message":":) i guess as long as it consten i dont really care but again not our coding convention","commit_id":"1365c528aa3640f1c7bfaf0b5b83291911480390"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"96bd35e0a173c254cda3deea2356b138a1ea5acc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        if [[ \"$NOVA_COMPILE_MDEV_SAMPLES\" \u003d\u003d True ]]; then"},{"line_number":16,"context_line":"            async_runfunc compile_mdev_samples"},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        ;;"},{"line_number":19,"context_line":"    post-config)"},{"line_number":20,"context_line":"        if [[ \"$NOVA_COMPILE_MDEV_SAMPLES\" \u003d\u003d True ]]; then"},{"line_number":21,"context_line":"            async_wait compile_mdev_samples"}],"source_content_type":"text/x-sh","patch_set":8,"id":"f9152604_e537a896","line":18,"in_reply_to":"f3f0d6b1_60793ee9","updated":"2026-06-23 11:19:20.000000000","message":"sorry about that, I thought I had completely disabled the formatter that was doing it, but it looks like I did not, it should be good now, hopefully","commit_id":"1365c528aa3640f1c7bfaf0b5b83291911480390"}]}