)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5a766028437528dfdc6e8a7a0a716bddf0696a94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c278c4b6_32e4dc35","updated":"2025-05-26 13:26:55.000000000","message":"+1 because i have not reviewd the 3/3 patch yet and i want to confrim the correctness of that first.","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21e81fc003c014ffaddf21463bc5e19b4dc0c79c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d60ae4d_6b686d6c","updated":"2025-06-05 22:51:49.000000000","message":"I am with this but let me know if you want to fix my below comments in this or separate followup\n\n- https://review.opendev.org/c/openstack/nova/+/937246/comment/c5740e8e_dabe8207/\n- https://review.opendev.org/c/openstack/nova/+/937246/comment/9126b316_dcdc2b19/\n- https://review.opendev.org/c/openstack/nova/+/937247/comment/b8d45c24_2d5fbf61/","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a814d64087a3037b6743386f234a6c29a09d5f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f7eed9d_09b5d3a4","updated":"2025-05-26 13:57:12.000000000","message":"ok after looking at the parent patch and comparign the fixes to the comments i had leve on the prior 2 i think this adresses all my feedback on the hyperviors api so +2","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0b1a17cf0ae0d3b0254284d580d65803950c6627","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a9910a9a_609f23cb","updated":"2025-06-09 21:10:14.000000000","message":"lgtm","commit_id":"6fbac7aaaf9ccd5bff378b0c98c53059d88e1e26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9133ae02cd0e4a82db047bdab3869afaa4e66733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18a11fbb_94a6ba5a","updated":"2025-06-11 08:54:38.000000000","message":"recheck","commit_id":"6fbac7aaaf9ccd5bff378b0c98c53059d88e1e26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"95aae2ddfda64266fd9b62d87e7ca52f113bd054","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f3d2d7f_65565c4e","updated":"2025-06-10 09:55:27.000000000","message":"recheck\n\nI\u0027m going to assume @smooney@redhat.com is happy with this and keep the merge train going","commit_id":"6fbac7aaaf9ccd5bff378b0c98c53059d88e1e26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c2ce8c4456e4dcf0e0d10497d105f42823512fca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d8b97ecd_709f58e4","updated":"2025-06-10 09:21:17.000000000","message":"recheck timeout","commit_id":"6fbac7aaaf9ccd5bff378b0c98c53059d88e1e26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a580df3092b397b15c35eeea5c2ada9bce307113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38f2c1c9_d3518335","updated":"2025-06-09 11:23:48.000000000","message":"recheck unrelated failure","commit_id":"6fbac7aaaf9ccd5bff378b0c98c53059d88e1e26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7fe972df64b740490fde00d2dd43b6aec8f46a57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"399cbc6c_c2c16e44","updated":"2025-06-11 12:08:52.000000000","message":"Fixed the nits. I\u0027m assuming this is good and am carrying the +2s forward @gmaan@ghanshyammann.com @smooney@redhat.com","commit_id":"a0af4648b5940e3c1c524b647b29d947061c97ba"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f92b35823733cc237cdb0552d050388dc4da2810","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3366b34a_72021d8f","updated":"2025-06-11 18:07:12.000000000","message":"recheck","commit_id":"a0af4648b5940e3c1c524b647b29d947061c97ba"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5a766028437528dfdc6e8a7a0a716bddf0696a94","unresolved":true,"context_lines":[{"line_number":3846,"context_line":"    A list of ``server`` objects."},{"line_number":3847,"context_line":"    This field has become mandatory in microversion 2.75 unless the"},{"line_number":3848,"context_line":"    ``with_servers`` query parameter is provided and set to ``false``."},{"line_number":3849,"context_line":"    If no servers is on hypervisor then an empty list is returned."},{"line_number":3850,"context_line":"  in: body"},{"line_number":3851,"context_line":"  required: false"},{"line_number":3852,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"231f829a_4f6b8f5a","line":3849,"updated":"2025-05-26 13:26:55.000000000","message":"oh i see\nso if if there are server on the host and you set with_servers\u003dfalse then we\ndo not include the field.","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21e81fc003c014ffaddf21463bc5e19b4dc0c79c","unresolved":true,"context_lines":[{"line_number":3846,"context_line":"    A list of ``server`` objects."},{"line_number":3847,"context_line":"    This field has become mandatory in microversion 2.75 unless the"},{"line_number":3848,"context_line":"    ``with_servers`` query parameter is provided and set to ``false``."},{"line_number":3849,"context_line":"    If no servers is on hypervisor then an empty list is returned."},{"line_number":3850,"context_line":"  in: body"},{"line_number":3851,"context_line":"  required: false"},{"line_number":3852,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"384a0e1f_524fe4c4","line":3849,"range":{"start_line":3849,"start_character":0,"end_line":3849,"end_character":66},"updated":"2025-06-05 22:51:49.000000000","message":"this line again confuse the things if that is for 2.75 microversion or for all microversion. Maybe we can add microversion here explicitly:\n\nMicroversion 2.75 onwards, if no servers is on hypervisor then an empty list is returned.","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7fe972df64b740490fde00d2dd43b6aec8f46a57","unresolved":false,"context_lines":[{"line_number":3846,"context_line":"    A list of ``server`` objects."},{"line_number":3847,"context_line":"    This field has become mandatory in microversion 2.75 unless the"},{"line_number":3848,"context_line":"    ``with_servers`` query parameter is provided and set to ``false``."},{"line_number":3849,"context_line":"    If no servers is on hypervisor then an empty list is returned."},{"line_number":3850,"context_line":"  in: body"},{"line_number":3851,"context_line":"  required: false"},{"line_number":3852,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"04fac2e2_c6164d3f","line":3849,"in_reply_to":"231f829a_4f6b8f5a","updated":"2025-06-11 12:08:52.000000000","message":"Acknowledged","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7fe972df64b740490fde00d2dd43b6aec8f46a57","unresolved":false,"context_lines":[{"line_number":3846,"context_line":"    A list of ``server`` objects."},{"line_number":3847,"context_line":"    This field has become mandatory in microversion 2.75 unless the"},{"line_number":3848,"context_line":"    ``with_servers`` query parameter is provided and set to ``false``."},{"line_number":3849,"context_line":"    If no servers is on hypervisor then an empty list is returned."},{"line_number":3850,"context_line":"  in: body"},{"line_number":3851,"context_line":"  required: false"},{"line_number":3852,"context_line":"  type: array"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"85f0a92f_0de8f1a9","line":3849,"range":{"start_line":3849,"start_character":0,"end_line":3849,"end_character":66},"in_reply_to":"384a0e1f_524fe4c4","updated":"2025-06-11 12:08:52.000000000","message":"Done","commit_id":"22598022324950a7fa427d0828f5713ef832f222"}],"nova/api/openstack/compute/schemas/hypervisors.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5a766028437528dfdc6e8a7a0a716bddf0696a94","unresolved":true,"context_lines":[{"line_number":231,"context_line":"# v2.75 makes the \u0027servers\u0027 property always present even if empty *unless* the"},{"line_number":232,"context_line":"# \u0027with_servers\u0027 query parameter is \u0027false\u0027. This dependency between a query"},{"line_number":233,"context_line":"# parameter and a response parameter is not something we can capture with"},{"line_number":234,"context_line":"# jsonschema and we can\u0027t update \u0027required\u0027 as a result"},{"line_number":235,"context_line":"index_response_v253 \u003d copy.deepcopy(index_response_v233)"},{"line_number":236,"context_line":"index_response_v253[\u0027properties\u0027][\u0027hypervisors\u0027][\u0027items\u0027] \u003d ("},{"line_number":237,"context_line":"    _hypervisor_response_v253"}],"source_content_type":"text/x-python","patch_set":1,"id":"fe75de06_b438c210","line":234,"updated":"2025-05-26 13:26:55.000000000","message":"thanks that makes a lot more sense","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7fe972df64b740490fde00d2dd43b6aec8f46a57","unresolved":false,"context_lines":[{"line_number":231,"context_line":"# v2.75 makes the \u0027servers\u0027 property always present even if empty *unless* the"},{"line_number":232,"context_line":"# \u0027with_servers\u0027 query parameter is \u0027false\u0027. This dependency between a query"},{"line_number":233,"context_line":"# parameter and a response parameter is not something we can capture with"},{"line_number":234,"context_line":"# jsonschema and we can\u0027t update \u0027required\u0027 as a result"},{"line_number":235,"context_line":"index_response_v253 \u003d copy.deepcopy(index_response_v233)"},{"line_number":236,"context_line":"index_response_v253[\u0027properties\u0027][\u0027hypervisors\u0027][\u0027items\u0027] \u003d ("},{"line_number":237,"context_line":"    _hypervisor_response_v253"}],"source_content_type":"text/x-python","patch_set":1,"id":"8a977451_5ce25938","line":234,"in_reply_to":"fe75de06_b438c210","updated":"2025-06-11 12:08:52.000000000","message":"Acknowledged","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a814d64087a3037b6743386f234a6c29a09d5f00","unresolved":true,"context_lines":[{"line_number":264,"context_line":"# v2.53 adds the \u0027servers\u0027 field but only if a user requests it via the"},{"line_number":265,"context_line":"# \u0027with_servers\u0027 query arg. It also changes the \u0027id\u0027 field to a UUID. Note that"},{"line_number":266,"context_line":"# v2.75 makes the \u0027servers\u0027 property always present even if empty, but that\u0027s"},{"line_number":267,"context_line":"# not something we can capture with jsonschema so we don\u0027t try"},{"line_number":268,"context_line":"detail_response_v253 \u003d copy.deepcopy(detail_response_v233)"},{"line_number":269,"context_line":"detail_response_v253[\u0027properties\u0027][\u0027hypervisors\u0027]["},{"line_number":270,"context_line":"    \u0027items\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a3fd3c8_b40fb270","line":267,"updated":"2025-05-26 13:57:12.000000000","message":"nit: you have the same comment here as line 229 but you didnt update this copy.\n\nif you respin, please do.","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5c3d0928b875f5940ae41a9142dba900eea4ae11","unresolved":true,"context_lines":[{"line_number":264,"context_line":"# v2.53 adds the \u0027servers\u0027 field but only if a user requests it via the"},{"line_number":265,"context_line":"# \u0027with_servers\u0027 query arg. It also changes the \u0027id\u0027 field to a UUID. Note that"},{"line_number":266,"context_line":"# v2.75 makes the \u0027servers\u0027 property always present even if empty, but that\u0027s"},{"line_number":267,"context_line":"# not something we can capture with jsonschema so we don\u0027t try"},{"line_number":268,"context_line":"detail_response_v253 \u003d copy.deepcopy(detail_response_v233)"},{"line_number":269,"context_line":"detail_response_v253[\u0027properties\u0027][\u0027hypervisors\u0027]["},{"line_number":270,"context_line":"    \u0027items\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"a07943af_8c616cce","line":267,"in_reply_to":"3a3fd3c8_b40fb270","updated":"2025-06-10 12:07:33.000000000","message":"this comment was still not upddated but yes im ok iwth merging this\nif you need to respine it pleas efix this comemnt also","commit_id":"22598022324950a7fa427d0828f5713ef832f222"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7fe972df64b740490fde00d2dd43b6aec8f46a57","unresolved":false,"context_lines":[{"line_number":264,"context_line":"# v2.53 adds the \u0027servers\u0027 field but only if a user requests it via the"},{"line_number":265,"context_line":"# \u0027with_servers\u0027 query arg. It also changes the \u0027id\u0027 field to a UUID. Note that"},{"line_number":266,"context_line":"# v2.75 makes the \u0027servers\u0027 property always present even if empty, but that\u0027s"},{"line_number":267,"context_line":"# not something we can capture with jsonschema so we don\u0027t try"},{"line_number":268,"context_line":"detail_response_v253 \u003d copy.deepcopy(detail_response_v233)"},{"line_number":269,"context_line":"detail_response_v253[\u0027properties\u0027][\u0027hypervisors\u0027]["},{"line_number":270,"context_line":"    \u0027items\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"0fa63fdb_e69b5734","line":267,"in_reply_to":"a07943af_8c616cce","updated":"2025-06-11 12:08:52.000000000","message":"Done","commit_id":"22598022324950a7fa427d0828f5713ef832f222"}]}