)]}'
{"nova/tests/virt/libvirt/test_driver.py":[{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"76758f2f007c5ccdaac5caacf7930119ec9e5f06","unresolved":false,"context_lines":[{"line_number":5872,"context_line":""},{"line_number":5873,"context_line":"        def list_instances():"},{"line_number":5874,"context_line":"            return [\u0027fake1\u0027, \u0027fake2\u0027]"},{"line_number":5875,"context_line":"        self.stubs.Set(conn, \u0027list_instances\u0027, list_instances)"},{"line_number":5876,"context_line":""},{"line_number":5877,"context_line":"        fake_disks \u003d {\u0027fake1\u0027: [{\u0027type\u0027: \u0027qcow2\u0027, \u0027path\u0027: \u0027/somepath/disk1\u0027,"},{"line_number":5878,"context_line":"                                 \u0027virt_disk_size\u0027: \u002710737418240\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_fdfae841","line":5875,"updated":"2014-06-17 19:21:37.000000000","message":"We have switched to using mock and this is a mox test setup.  Please change this to a mock setup.","commit_id":"599abee3b51da74a308e3fda8190e55befb33ff7"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"5baab6aff812da223af1d51b4bc1c39522f023f4","unresolved":false,"context_lines":[{"line_number":5892,"context_line":""},{"line_number":5893,"context_line":"        self.mox.ReplayAll()"},{"line_number":5894,"context_line":"        result \u003d driver.get_disk_over_committed_size_total()"},{"line_number":5895,"context_line":"        self.assertEqual(21474836480, result)"},{"line_number":5896,"context_line":""},{"line_number":5897,"context_line":"    def test_cpu_info(self):"},{"line_number":5898,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_469db156","line":5895,"updated":"2014-06-18 09:58:19.000000000","message":"Agree with the previous commenter. This test is obviously based on the previous one, but refactored to use mox instead of stubs. If we\u0027re refactoring tests they should use mock.","commit_id":"24959886096104f297555537e4c4831552c5da8f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"cc6f420a98e424cda50130141b2189dc75728c97","unresolved":false,"context_lines":[{"line_number":5892,"context_line":""},{"line_number":5893,"context_line":"        self.mox.ReplayAll()"},{"line_number":5894,"context_line":"        result \u003d driver.get_disk_over_committed_size_total()"},{"line_number":5895,"context_line":"        self.assertEqual(21474836480, result)"},{"line_number":5896,"context_line":""},{"line_number":5897,"context_line":"    def test_cpu_info(self):"},{"line_number":5898,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_fccc8abd","line":5895,"in_reply_to":"1ae5cdf2_41be7b01","updated":"2014-06-18 12:40:13.000000000","message":"It\u0027s a policy thing: the project has decided that tests should use mock. I understand a major driver was compatibility with Python 3.\n\nYou can read a thread on it here: http://lists.openstack.org/pipermail/openstack-dev/2013-July/thread.html#12474","commit_id":"24959886096104f297555537e4c4831552c5da8f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b82026478a932bba44498af598922fe1e6c5209b","unresolved":false,"context_lines":[{"line_number":5892,"context_line":""},{"line_number":5893,"context_line":"        self.mox.ReplayAll()"},{"line_number":5894,"context_line":"        result \u003d driver.get_disk_over_committed_size_total()"},{"line_number":5895,"context_line":"        self.assertEqual(21474836480, result)"},{"line_number":5896,"context_line":""},{"line_number":5897,"context_line":"    def test_cpu_info(self):"},{"line_number":5898,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_48f84e7c","line":5895,"in_reply_to":"1ae5cdf2_45ff5e34","updated":"2014-06-18 15:51:48.000000000","message":"See #4 here:\n\nhttps://wiki.openstack.org/wiki/ReviewChecklist#Common_Review_Checklist\n\nThis is a new test so it should be using mock.","commit_id":"24959886096104f297555537e4c4831552c5da8f"},{"author":{"_account_id":9223,"name":"Eric Zhou","email":"zhengyoucloud@gmail.com","username":"ericzhou"},"change_message_id":"9118b3bc11e636f4db8cbdcea00843407b2e3126","unresolved":false,"context_lines":[{"line_number":5892,"context_line":""},{"line_number":5893,"context_line":"        self.mox.ReplayAll()"},{"line_number":5894,"context_line":"        result \u003d driver.get_disk_over_committed_size_total()"},{"line_number":5895,"context_line":"        self.assertEqual(21474836480, result)"},{"line_number":5896,"context_line":""},{"line_number":5897,"context_line":"    def test_cpu_info(self):"},{"line_number":5898,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_41be7b01","line":5895,"in_reply_to":"1ae5cdf2_469db156","updated":"2014-06-18 10:12:59.000000000","message":"why this is not correct for mox/mock? could you give any example?","commit_id":"24959886096104f297555537e4c4831552c5da8f"},{"author":{"_account_id":9223,"name":"Eric Zhou","email":"zhengyoucloud@gmail.com","username":"ericzhou"},"change_message_id":"57362669dabf6a5ea10e57d9f4b5e4b24eeb9da3","unresolved":false,"context_lines":[{"line_number":5892,"context_line":""},{"line_number":5893,"context_line":"        self.mox.ReplayAll()"},{"line_number":5894,"context_line":"        result \u003d driver.get_disk_over_committed_size_total()"},{"line_number":5895,"context_line":"        self.assertEqual(21474836480, result)"},{"line_number":5896,"context_line":""},{"line_number":5897,"context_line":"    def test_cpu_info(self):"},{"line_number":5898,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_a51d3dc0","line":5895,"in_reply_to":"1ae5cdf2_48f84e7c","updated":"2014-06-20 00:44:14.000000000","message":"I have rewritten this test using mock. Thanks.","commit_id":"24959886096104f297555537e4c4831552c5da8f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e81bbfe7d792fd349a0039d06efc3b70f3716593","unresolved":false,"context_lines":[{"line_number":5892,"context_line":""},{"line_number":5893,"context_line":"        self.mox.ReplayAll()"},{"line_number":5894,"context_line":"        result \u003d driver.get_disk_over_committed_size_total()"},{"line_number":5895,"context_line":"        self.assertEqual(21474836480, result)"},{"line_number":5896,"context_line":""},{"line_number":5897,"context_line":"    def test_cpu_info(self):"},{"line_number":5898,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_45ff5e34","line":5895,"in_reply_to":"1ae5cdf2_fccc8abd","updated":"2014-06-18 14:05:45.000000000","message":"i think that if it is an existing test we we can continue to use mox. If it is a new one we should use mock.","commit_id":"24959886096104f297555537e4c4831552c5da8f"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"90fb22b55c4c3c6ded99beea24fffab4bbaa9bb3","unresolved":false,"context_lines":[{"line_number":5886,"context_line":"           if arg \u003d\u003d \u0027fake1\u0027:"},{"line_number":5887,"context_line":"                raise OSError(errno.EACCES, \u0027Permission denied\u0027)"},{"line_number":5888,"context_line":"           if arg \u003d\u003d \u0027fake2\u0027:"},{"line_number":5889,"context_line":"                return jsonutils.dumps(fake_disks.get(arg)) "},{"line_number":5890,"context_line":"        get_disk_info \u003d mock.Mock()"},{"line_number":5891,"context_line":"        get_disk_info.side_effect \u003d side_effect"},{"line_number":5892,"context_line":"        driver.get_instance_disk_info \u003d get_disk_info"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_29e831b2","line":5889,"updated":"2014-06-19 19:09:20.000000000","message":"Whitespace at end of line.. Though I\u0027m surprised pep8 didn\u0027t pick this up.","commit_id":"8044efd557509642023bdab17de8a5085701257e"},{"author":{"_account_id":9223,"name":"Eric Zhou","email":"zhengyoucloud@gmail.com","username":"ericzhou"},"change_message_id":"5f0c557cceb153c70cafe4e877b57d3495f1a82a","unresolved":false,"context_lines":[{"line_number":5886,"context_line":"           if arg \u003d\u003d \u0027fake1\u0027:"},{"line_number":5887,"context_line":"                raise OSError(errno.EACCES, \u0027Permission denied\u0027)"},{"line_number":5888,"context_line":"           if arg \u003d\u003d \u0027fake2\u0027:"},{"line_number":5889,"context_line":"                return jsonutils.dumps(fake_disks.get(arg)) "},{"line_number":5890,"context_line":"        get_disk_info \u003d mock.Mock()"},{"line_number":5891,"context_line":"        get_disk_info.side_effect \u003d side_effect"},{"line_number":5892,"context_line":"        driver.get_instance_disk_info \u003d get_disk_info"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_654c1543","line":5889,"in_reply_to":"1ae5cdf2_29e831b2","updated":"2014-06-20 00:21:34.000000000","message":"Actually pep8 did find this. Thanks :)","commit_id":"8044efd557509642023bdab17de8a5085701257e"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7be816bb7345fc95616f36849c9b1620903d8cba","unresolved":false,"context_lines":[{"line_number":4846,"context_line":"                    LOG.warning(_(\u0027Periodic task is updating the host stat, \u0027"},{"line_number":4847,"context_line":"                                  \u0027it is trying to get disk %(i_name)s, \u0027"},{"line_number":4848,"context_line":"                                  \u0027but disk file is not allowed to access \u0027"},{"line_number":4849,"context_line":"                                  \u0027by nova non-root user.\u0027),"},{"line_number":4850,"context_line":"                                {\u0027i_name\u0027: i_name})"},{"line_number":4851,"context_line":"                else:"},{"line_number":4852,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_226c489c","line":4849,"updated":"2014-06-09 21:38:41.000000000","message":"I would add to the above error message:\n\n This is most likely due to a VM that exists on the compute node\n but is not managed by Nova.","commit_id":"2b008192327e3056b3c79440789ccaf661ae3eb1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"5102288e6985ba3ff3b92e309860a377f3e4e677","unresolved":false,"context_lines":[{"line_number":4839,"context_line":"                                  \u0027but disk file is not allowed to access \u0027"},{"line_number":4840,"context_line":"                                  \u0027by nova non-root user. This is most likely \u0027"},{"line_number":4841,"context_line":"                                  \u0027due to a VM that exists on the compute \u0027"},{"line_number":4842,"context_line":"                                  \u0027node but is not managed by Nova.\u0027),"},{"line_number":4843,"context_line":"                                {\u0027i_name\u0027: i_name})"},{"line_number":4844,"context_line":"                else:"},{"line_number":4845,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_4b4fa36a","line":4842,"updated":"2014-06-17 16:06:17.000000000","message":"I would remove \u0027This is most likely...\u0027. Access denied should be plenty for the sysadmin, and who knows?\n\nAlso, \u0027but disk file is not allowed to access\u0027 isn\u0027t quite right. I\u0027d put:\n\n\u0027Periodic task is updating the host stat, it is trying to get disk %(i_name)s, but access is denied.\u0027","commit_id":"a289f4fe456ae5ab70b269090ef34188d214b5aa"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"76758f2f007c5ccdaac5caacf7930119ec9e5f06","unresolved":false,"context_lines":[{"line_number":4810,"context_line":"                                  \u0027operations such as resize.\u0027),"},{"line_number":4811,"context_line":"                                {\u0027i_name\u0027: i_name})"},{"line_number":4812,"context_line":"                if e.errno \u003d\u003d errno.EACCES:"},{"line_number":4813,"context_line":"                    LOG.warning(_(\u0027Periodic task is updating the host stat, \u0027"},{"line_number":4814,"context_line":"                                  \u0027it is trying to get disk %(i_name)s, \u0027"},{"line_number":4815,"context_line":"                                  \u0027but disk file is not allowed to access \u0027"},{"line_number":4816,"context_line":"                                  \u0027by nova non-root user. This is most likely \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_f88e7678","line":4813,"updated":"2014-06-17 19:21:37.000000000","message":"We are transitioning to new logging standards at https://wiki.openstack.org/wiki/LoggingStandards#Log_Translation.\n\nWe should update to reflect new standard.  It\u0027ll save the poor soul who is trouncing through the code mindlessly making the change for all locations.","commit_id":"599abee3b51da74a308e3fda8190e55befb33ff7"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"90fb22b55c4c3c6ded99beea24fffab4bbaa9bb3","unresolved":false,"context_lines":[{"line_number":4810,"context_line":"                                  \u0027operations such as resize.\u0027),"},{"line_number":4811,"context_line":"                                {\u0027i_name\u0027: i_name})"},{"line_number":4812,"context_line":"                if e.errno \u003d\u003d errno.EACCES:"},{"line_number":4813,"context_line":"                    LOG.warning(_LW(\u0027Periodic task is updating the host stat, \u0027"},{"line_number":4814,"context_line":"                                    \u0027it is trying to get disk %(i_name)s, \u0027"},{"line_number":4815,"context_line":"                                    \u0027but access is denied. It is most likely \u0027"},{"line_number":4816,"context_line":"                                    \u0027due to a VM that exists on the compute \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_49f9fd7e","line":4813,"updated":"2014-06-19 19:09:20.000000000","message":"I believe the preferred at this point is LOG.warn.","commit_id":"8044efd557509642023bdab17de8a5085701257e"},{"author":{"_account_id":9223,"name":"Eric Zhou","email":"zhengyoucloud@gmail.com","username":"ericzhou"},"change_message_id":"5f0c557cceb153c70cafe4e877b57d3495f1a82a","unresolved":false,"context_lines":[{"line_number":4810,"context_line":"                                  \u0027operations such as resize.\u0027),"},{"line_number":4811,"context_line":"                                {\u0027i_name\u0027: i_name})"},{"line_number":4812,"context_line":"                if e.errno \u003d\u003d errno.EACCES:"},{"line_number":4813,"context_line":"                    LOG.warning(_LW(\u0027Periodic task is updating the host stat, \u0027"},{"line_number":4814,"context_line":"                                    \u0027it is trying to get disk %(i_name)s, \u0027"},{"line_number":4815,"context_line":"                                    \u0027but access is denied. It is most likely \u0027"},{"line_number":4816,"context_line":"                                    \u0027due to a VM that exists on the compute \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_253f6d88","line":4813,"in_reply_to":"1ae5cdf2_49f9fd7e","updated":"2014-06-20 00:21:34.000000000","message":"good point. Done.","commit_id":"8044efd557509642023bdab17de8a5085701257e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c871c867e1b8b79526d8c96a0e5b0745706ac0f9","unresolved":false,"context_lines":[{"line_number":4811,"context_line":"                                {\u0027i_name\u0027: i_name})"},{"line_number":4812,"context_line":"                if e.errno \u003d\u003d errno.EACCES:"},{"line_number":4813,"context_line":"                    LOG.warn(_LW(\u0027Periodic task is updating the host stat, \u0027"},{"line_number":4814,"context_line":"                                    \u0027it is trying to get disk %(i_name)s, \u0027"},{"line_number":4815,"context_line":"                                    \u0027but access is denied. It is most likely \u0027"},{"line_number":4816,"context_line":"                                    \u0027due to a VM that exists on the compute \u0027"},{"line_number":4817,"context_line":"                                    \u0027node but is not managed by Nova.\u0027),"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_6dc14a2e","line":4814,"updated":"2014-06-20 13:35:55.000000000","message":"I know this is a little nit picky, but can we line the message up better and the substitution parameter var.","commit_id":"7ff111ff49ba57e0f73451bdee59594e28bc31cc"},{"author":{"_account_id":9223,"name":"Eric Zhou","email":"zhengyoucloud@gmail.com","username":"ericzhou"},"change_message_id":"0198310c6d107b9050726f779ed4c9683418b77a","unresolved":false,"context_lines":[{"line_number":4811,"context_line":"                                {\u0027i_name\u0027: i_name})"},{"line_number":4812,"context_line":"                if e.errno \u003d\u003d errno.EACCES:"},{"line_number":4813,"context_line":"                    LOG.warn(_LW(\u0027Periodic task is updating the host stat, \u0027"},{"line_number":4814,"context_line":"                                    \u0027it is trying to get disk %(i_name)s, \u0027"},{"line_number":4815,"context_line":"                                    \u0027but access is denied. It is most likely \u0027"},{"line_number":4816,"context_line":"                                    \u0027due to a VM that exists on the compute \u0027"},{"line_number":4817,"context_line":"                                    \u0027node but is not managed by Nova.\u0027),"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_adb18d02","line":4814,"in_reply_to":"1ae5cdf2_6dc14a2e","updated":"2014-06-20 15:55:04.000000000","message":"Thanks for pointing it out.  Done.","commit_id":"7ff111ff49ba57e0f73451bdee59594e28bc31cc"}]}