)]}'
{"nova/pci/request.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2d527a3e0fe8977c63f31e2281405d99c777545c","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                % \",\".join(sorted(alias_without_ids)))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"def _validate_aliases(aliases):"},{"line_number":169,"context_line":"    \"\"\"Checks the parsed aliases for common mistakes and raise easy to parse"},{"line_number":170,"context_line":"    error messages"},{"line_number":171,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"b688f2f6_de831790","line":168,"updated":"2025-06-11 14:07:00.000000000","message":"This gets called every time we pull an alias from a flavor, right? That means we\u0027re constantly re-verifying the same config over and over right? While it\u0027s not a ton of work, we are doing multiple nested loops on each execution, which seems unfortunate...","commit_id":"d18e76ea6a42d7899c6d66d9ea5a94195f1e08b2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b798f86b026e5d0ffd414754d8e0b87dc07ce6b4","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                % \",\".join(sorted(alias_without_ids)))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"def _validate_aliases(aliases):"},{"line_number":169,"context_line":"    \"\"\"Checks the parsed aliases for common mistakes and raise easy to parse"},{"line_number":170,"context_line":"    error messages"},{"line_number":171,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"342e8a90_9a306f93","line":168,"in_reply_to":"b688f2f6_de831790","updated":"2025-06-11 14:09:52.000000000","message":"Okay, should have read the whole series :)","commit_id":"d18e76ea6a42d7899c6d66d9ea5a94195f1e08b2"}],"nova/tests/functional/regressions/test_bug_2111440.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"745bebf048e39efa3cd2438cc6a1285811d4cac6","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            flavor_id\u003dflavor_id,"},{"line_number":42,"context_line":"            networks\u003d[],"},{"line_number":43,"context_line":"        )"},{"line_number":44,"context_line":"        self.assertEqual(400, exc.response.status_code)"},{"line_number":45,"context_line":"        self.assertIn("},{"line_number":46,"context_line":"            \"The PCI alias(es) a-vf does not have vendor_id and product_id \""},{"line_number":47,"context_line":"            \"fields set or resource_class field set.\","}],"source_content_type":"text/x-python","patch_set":4,"id":"bcd2bdc3_3b5f3a08","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":55},"updated":"2025-06-11 23:16:21.000000000","message":"as an assied every time i see this is a 400 i kind of wish there was a better error we coudl return a 5xx becuase this is an error caused by how the admin configured nova, not the content of the clients request.\n\nhttps://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_server_errors\nNone of those seam right either so as much as i would prefer this not to be a 400 i agree that it more or less the best option we have.","commit_id":"acc6221660d5113314c66361cace9e3982fa76bf"}]}