)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8edf62bf5ec42daef1dde20a0340ded569030aa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ce55c224_43766e64","updated":"2025-06-04 16:31:27.000000000","message":"lgtm, thanks for fixing","commit_id":"4a15c4841a37f9a071c802465a4c7c2e6795443a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"96ab6d192f262a6df00d2edeb4110c190ec730b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2151e8c_0460d567","updated":"2025-06-05 16:29:35.000000000","message":"recheck failure on base patch","commit_id":"4a15c4841a37f9a071c802465a4c7c2e6795443a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e9444e4b041feb646b090bcd39272e3f2c4ba64d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"672f6d8f_b51e7175","updated":"2025-06-04 14:55:53.000000000","message":"recheck timeout","commit_id":"4a15c4841a37f9a071c802465a4c7c2e6795443a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cfc057a1aeefee7fd0f5ef46bbb41ea3c06d5f4d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4396c776_6458cd22","updated":"2025-06-06 09:47:04.000000000","message":"this does seam to adress all of gmanns comments.","commit_id":"4a15c4841a37f9a071c802465a4c7c2e6795443a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ace073ec809f36bb501fcb44eccb19711b26efae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff923569_dd066952","in_reply_to":"4396c776_6458cd22","updated":"2025-06-06 10:31:38.000000000","message":"Acknowledged","commit_id":"4a15c4841a37f9a071c802465a4c7c2e6795443a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"086f8c7c3b7ea973f7dac36d0b01e215ce885d96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98ff5a12_4d243cbb","updated":"2025-06-19 16:42:18.000000000","message":"Resolved trivial merge conflict. Carrying the +2s forward.","commit_id":"9953cf8d5c14371e82012dd38386ecd6d1854e2c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7f24b9f9320bfc6b3d8e42b4f0b16c497f0d391","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66f20e91_15da1354","updated":"2025-06-24 12:40:45.000000000","message":"recheck","commit_id":"9953cf8d5c14371e82012dd38386ecd6d1854e2c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"239d541986377f4d0c7f05a88be87aae51188121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d23afba1_abeeedff","updated":"2025-06-23 14:16:36.000000000","message":"recheck","commit_id":"9953cf8d5c14371e82012dd38386ecd6d1854e2c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"20f7beb43df95f993b43e70798b7ef2ef86db18b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e83d3ad1_4f4e14a0","updated":"2025-06-23 21:49:03.000000000","message":"recheck","commit_id":"9953cf8d5c14371e82012dd38386ecd6d1854e2c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fe739564ea037836146c12fd723e369e275bbf1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7916e1c2_8305ce73","updated":"2025-06-24 07:35:26.000000000","message":"recheck post failure","commit_id":"9953cf8d5c14371e82012dd38386ecd6d1854e2c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fd6a391f6df01766994756d48be6f9fd0ef666f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8e478fe3_0c4a1ff3","updated":"2025-07-01 16:08:41.000000000","message":"Trivial merge conflict (again)","commit_id":"95e60fd58a1ae19ad7669ad1b3a0e01e5d99e5f9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"82348665fa3ca472353fe0b5509b63f04eb36e56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c042bf9_4bc4fca1","updated":"2025-08-29 18:26:10.000000000","message":"reapplying +w","commit_id":"95e60fd58a1ae19ad7669ad1b3a0e01e5d99e5f9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"175ba54b0af92a4ec38e9116b82ba6f0107b18d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d5a62e9_f2669303","updated":"2025-07-04 10:18:13.000000000","message":"recheck","commit_id":"95e60fd58a1ae19ad7669ad1b3a0e01e5d99e5f9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e8e9dcfd9a7fceb76a788b717ad6b0936ca63588","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bcc964f2_94dd9aa7","updated":"2025-08-29 09:49:17.000000000","message":"recheck interface attach failed as libvirt connection broke\n```\nAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [None req-93ae4bd4-d242-4a68-99c3-9b29e6cf8bee tempest-QoSBandwidthAndPacketRateTests-506926038 tempest-QoSBandwidthAndPacketRateTests-506926038-project-member] [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b] attaching network adapter failed.: libvirt.libvirtError: Unable to read from monitor: Connection reset by peer\n77394\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b] Traceback (most recent call last):\n77395\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]   File \"/opt/stack/nova/nova/virt/libvirt/driver.py\", line 3017, in attach_interface\n77396\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]     guest.attach_device(cfg, persistent\u003dTrue, live\u003dlive)\n77397\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]   File \"/opt/stack/nova/nova/virt/libvirt/guest.py\", line 337, in attach_device\n77398\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]     self._domain.attachDeviceFlags(device_xml, flags\u003dflags)\n77399\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]   File \"/opt/stack/data/venv/lib/python3.12/site-packages/eventlet/tpool.py\", line 186, in doit\n77400\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]     result \u003d proxy_call(self._autowrap, f, *args, **kwargs)\n77401\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n77402\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]   File \"/opt/stack/data/venv/lib/python3.12/site-packages/eventlet/tpool.py\", line 144, in proxy_call\n77403\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]     rv \u003d execute(f, *args, **kwargs)\n77404\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]          ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n77405\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]   File \"/opt/stack/data/venv/lib/python3.12/site-packages/eventlet/tpool.py\", line 125, in execute\n77406\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]     raise e.with_traceback(tb)\n77407\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]   File \"/opt/stack/data/venv/lib/python3.12/site-packages/eventlet/tpool.py\", line 82, in tworker\n77408\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]     rv \u003d meth(*args, **kwargs)\n77409\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]          ^^^^^^^^^^^^^^^^^^^^^\n77410\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]   File \"/usr/lib/python3/dist-packages/libvirt.py\", line 716, in attachDeviceFlags\n77411\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b]     raise libvirtError(\u0027virDomainAttachDeviceFlags() failed\u0027)\n77412\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b] libvirt.libvirtError: Unable to read from monitor: Connection reset by peer\n77413\tAug 29 00:04:49.465514 np99a799be802b4 nova-compute[87548]: ERROR nova.virt.libvirt.driver [instance: 4ebfb559-56cb-45de-bfb9-e1078bccbf4b] ```","commit_id":"95e60fd58a1ae19ad7669ad1b3a0e01e5d99e5f9"}],"nova/api/openstack/compute/keypairs.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cfc057a1aeefee7fd0f5ef46bbb41ea3c06d5f4d","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    @validation.query_schema(keypairs.index_query_schema_v235, \u00272.35\u0027, \u00272.74\u0027)"},{"line_number":173,"context_line":"    @validation.query_schema(keypairs.index_query_schema_v275, \u00272.75\u0027)"},{"line_number":174,"context_line":"    @wsgi.expected_errors((), \u00272.0\u0027, \u00272.34\u0027)"},{"line_number":175,"context_line":"    @wsgi.expected_errors(400, \u00272.35\u0027)"},{"line_number":176,"context_line":"    def index(self, req):"},{"line_number":177,"context_line":"        key_type \u003d False"},{"line_number":178,"context_line":"        if api_version_request.is_supported(req, \u00272.2\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d957ea43_c9dbe182","line":175,"updated":"2025-06-06 09:47:04.000000000","message":"ack so this adressses https://review.opendev.org/c/openstack/nova/+/936366/comment/267d2422_8bb5f775/","commit_id":"4a15c4841a37f9a071c802465a4c7c2e6795443a"}],"nova/api/openstack/compute/quota_sets.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cfc057a1aeefee7fd0f5ef46bbb41ea3c06d5f4d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        else:"},{"line_number":111,"context_line":"            return []"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @wsgi.Controller.api_version(\u00272.1\u0027)"},{"line_number":114,"context_line":"    @wsgi.expected_errors(400)"},{"line_number":115,"context_line":"    @validation.query_schema(quota_sets.show_query, \u00272.0\u0027, \u00272.74\u0027)"},{"line_number":116,"context_line":"    @validation.query_schema(quota_sets.show_query_v275, \u00272.75\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4e8b1c2_0d4a7440","side":"PARENT","line":113,"updated":"2025-06-06 09:47:04.000000000","message":"teses are part of this metata comment on usign 2.1 liek this in general\nhttps://review.opendev.org/c/openstack/nova/+/936366/comment/3572fc60_4c122c70/\n\n```\n for v2.0, it come from LegacyV2CompatibleWrapper and it deletet the api version if passed and router use default version (2.1). That is why all 2.1 version controller method are used for v2.0 also.\n ```","commit_id":"d73a0861f881a2a88064c93cbd2313ca5cb447ea"}],"nova/api/openstack/compute/server_groups.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cfc057a1aeefee7fd0f5ef46bbb41ea3c06d5f4d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        result \u003d [self._format_server_group(context, group, req)"},{"line_number":175,"context_line":"                  for group in limited_list]"},{"line_number":176,"context_line":"        return {\u0027server_groups\u0027: result}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @wsgi.Controller.api_version(\"2.1\")"},{"line_number":179,"context_line":"    @wsgi.expected_errors((400, 403, 409))"},{"line_number":180,"context_line":"    @validation.schema(schema.create, \"2.0\", \"2.14\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"29387a67_0d72cc70","side":"PARENT","line":177,"updated":"2025-06-06 09:47:04.000000000","message":"same here","commit_id":"d73a0861f881a2a88064c93cbd2313ca5cb447ea"}]}