)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"f29c8d4ee8c7c51dfee0286791aecf5d6ae82853","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56c32770_93e31895","updated":"2025-06-10 13:48:15.000000000","message":"Looks good to me. Thanks for all the efforts.","commit_id":"541a38be95e3ae60e8792e7811a994fc0252b8c4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4f4ee2f29921017397b9a1e79e51f2d1b64387d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa6767ea_7da885e8","updated":"2025-06-26 16:44:03.000000000","message":"I am ok but one question before approval.","commit_id":"be5fc8a5c951b9c426ac07fa81968f745de82c05"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a6cf4e58e6a29900d503329d845d1f577b93e84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3e520fe9_42d6c71a","updated":"2025-06-27 00:15:21.000000000","message":"thanks for updates, lgtm","commit_id":"c4f81a54d5cd5ff88eae13d9b95ed181985b13ae"}],"api-ref/source/servers-actions.inc":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2f2176c512889aaeb3048d91d66c35050f3b10b","unresolved":true,"context_lines":[{"line_number":22,"context_line":"* You can add a security group to or remove a security group from a server"},{"line_number":23,"context_line":"* You can trigger a crash dump into a server"},{"line_number":24,"context_line":"* You can get a graphical or serial console for a server"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"...among others."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Add (Associate) Floating Ip (addFloatingIp Action) (DEPRECATED)"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"6fb8873f_14606af0","line":25,"updated":"2025-06-27 11:58:46.000000000","message":"this reads better to me +1","commit_id":"c4f81a54d5cd5ff88eae13d9b95ed181985b13ae"}],"nova/api/openstack/compute/schemas/remote_consoles.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d611e5d0adbe2fede0f8c658909c040ff69dc66a","unresolved":true,"context_lines":[{"line_number":196,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":197,"context_line":"}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"# NOTE(stephenfin): This schema is intentionally empty since the action has"},{"line_number":200,"context_line":"# been removed"},{"line_number":201,"context_line":"get_rdp_console_response \u003d {}"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"get_serial_console_response \u003d {"},{"line_number":204,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b79d27a_e5e10915","line":201,"range":{"start_line":199,"start_character":0,"end_line":201,"end_character":29},"updated":"2025-06-10 16:04:51.000000000","message":"replied in original change, empty schema (like delete API etc) indicate that there is response body return from this API which is not the case. We should show this API always error without response schema.\n\nhttps://review.opendev.org/c/openstack/nova/+/940114/comment/02d786aa_8d883500/","commit_id":"541a38be95e3ae60e8792e7811a994fc0252b8c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1f56ba94001c9a07bd67dc7a771017ad5463b55c","unresolved":true,"context_lines":[{"line_number":196,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":197,"context_line":"}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"# NOTE(stephenfin): This schema is intentionally empty since the action has"},{"line_number":200,"context_line":"# been removed"},{"line_number":201,"context_line":"get_rdp_console_response \u003d {}"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"get_serial_console_response \u003d {"},{"line_number":204,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9e557e63_0d490657","line":201,"range":{"start_line":199,"start_character":0,"end_line":201,"end_character":29},"in_reply_to":"5b79d27a_e5e10915","updated":"2025-06-10 16:40:25.000000000","message":"We can\u0027t do that because it\u0027s not true against a pre-Caracal release using the Hyper-V driver, which results in our docs and any generated clients being invalid. Ditto for any APIs that now respond with HTTP 410 (Gone). Unfortunately we can\u0027t rely on schema validation for these cases and need to do it inside the method","commit_id":"541a38be95e3ae60e8792e7811a994fc0252b8c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9a6a56a88ac4f4c6920395b4e29bd7e47013b7d2","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":197,"context_line":"}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"# NOTE(stephenfin): This schema is intentionally empty since the action has"},{"line_number":200,"context_line":"# been removed"},{"line_number":201,"context_line":"get_rdp_console_response \u003d {}"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"get_serial_console_response \u003d {"},{"line_number":204,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1e84749_2903558a","line":201,"range":{"start_line":199,"start_character":0,"end_line":201,"end_character":29},"in_reply_to":"81a6792d_9164f0df","updated":"2025-06-11 09:13:50.000000000","message":"Done","commit_id":"541a38be95e3ae60e8792e7811a994fc0252b8c4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe72d3025e4c62994d07cc3720fe90fb9ed07639","unresolved":true,"context_lines":[{"line_number":196,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":197,"context_line":"}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"# NOTE(stephenfin): This schema is intentionally empty since the action has"},{"line_number":200,"context_line":"# been removed"},{"line_number":201,"context_line":"get_rdp_console_response \u003d {}"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"get_serial_console_response \u003d {"},{"line_number":204,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"81a6792d_9164f0df","line":201,"range":{"start_line":199,"start_character":0,"end_line":201,"end_character":29},"in_reply_to":"9e557e63_0d490657","updated":"2025-06-10 21:32:19.000000000","message":"agree with the pre-caracel usage. let\u0027s keep it as it is and let\u0027s not make it empty.","commit_id":"541a38be95e3ae60e8792e7811a994fc0252b8c4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe72d3025e4c62994d07cc3720fe90fb9ed07639","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":243,"context_line":"                },"},{"line_number":244,"context_line":"            },"},{"line_number":245,"context_line":"            \u0027required\u0027: [\u0027protocol\u0027, \u0027type\u0027],"},{"line_number":246,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":247,"context_line":"        },"},{"line_number":248,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa8da32_2021e9e6","line":245,"range":{"start_line":245,"start_character":43,"end_line":245,"end_character":45},"updated":"2025-06-10 21:32:19.000000000","message":"url is mandatory also https://review.opendev.org/c/openstack/nova/+/940114/comment/a98ef8a8_0ebac9f4/","commit_id":"541a38be95e3ae60e8792e7811a994fc0252b8c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9a6a56a88ac4f4c6920395b4e29bd7e47013b7d2","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":243,"context_line":"                },"},{"line_number":244,"context_line":"            },"},{"line_number":245,"context_line":"            \u0027required\u0027: [\u0027protocol\u0027, \u0027type\u0027],"},{"line_number":246,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":247,"context_line":"        },"},{"line_number":248,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c88adb8_acb86fad","line":245,"range":{"start_line":245,"start_character":43,"end_line":245,"end_character":45},"in_reply_to":"9aa8da32_2021e9e6","updated":"2025-06-11 09:13:50.000000000","message":"Done","commit_id":"541a38be95e3ae60e8792e7811a994fc0252b8c4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4f4ee2f29921017397b9a1e79e51f2d1b64387d3","unresolved":true,"context_lines":[{"line_number":87,"context_line":"            \u0027properties\u0027: {"},{"line_number":88,"context_line":"                \u0027protocol\u0027: {"},{"line_number":89,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":90,"context_line":"                    # While we no longer support the rdp console type, we still"},{"line_number":91,"context_line":"                    # list it here for documentation purposes. It is rejected"},{"line_number":92,"context_line":"                    # at the controller level."},{"line_number":93,"context_line":"                    \u0027enum\u0027: [\u0027vnc\u0027, \u0027spice\u0027, \u0027serial\u0027, \u0027rdp\u0027],"},{"line_number":94,"context_line":"                },"},{"line_number":95,"context_line":"                \u0027type\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"e644f810_7e7b50c2","line":92,"range":{"start_line":90,"start_character":21,"end_line":92,"end_character":46},"updated":"2025-06-26 16:44:03.000000000","message":"Current api-ref (as those are sourced from other source than this schema) does not have it https://docs.openstack.org/api-ref/compute/#create-console (removed in )https://review.opendev.org/c/openstack/nova/+/906809\n\nI am not sure we need to allow it here and raise error in controller but one question about \u0027documentation purposes\u0027. if this schema is going to be doc source then how we will make sure it is reflected as \u0027removed after caracal for all microversion\u0027?","commit_id":"be5fc8a5c951b9c426ac07fa81968f745de82c05"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3b426460fc8ddcb424f02032043c97b4e85aa570","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            \u0027properties\u0027: {"},{"line_number":88,"context_line":"                \u0027protocol\u0027: {"},{"line_number":89,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":90,"context_line":"                    # While we no longer support the rdp console type, we still"},{"line_number":91,"context_line":"                    # list it here for documentation purposes. It is rejected"},{"line_number":92,"context_line":"                    # at the controller level."},{"line_number":93,"context_line":"                    \u0027enum\u0027: [\u0027vnc\u0027, \u0027spice\u0027, \u0027serial\u0027, \u0027rdp\u0027],"},{"line_number":94,"context_line":"                },"},{"line_number":95,"context_line":"                \u0027type\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa40101_1866ae39","line":92,"range":{"start_line":90,"start_character":21,"end_line":92,"end_character":46},"in_reply_to":"e644f810_7e7b50c2","updated":"2025-06-26 21:29:07.000000000","message":"Discussed on IRC. I wanted to do this but thought it might be too contentious. Happy to see you think it should be done too.","commit_id":"be5fc8a5c951b9c426ac07fa81968f745de82c05"}]}