)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35884fb8d6ccb1ca32df10416e9466b393926e64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fed93048_480936fa","updated":"2025-06-24 15:49:45.000000000","message":"+2 but holding +w based on the use of addtional propereise true","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"72737d6f7c939ad215451b53c22be82fe62a72fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"805d7f45_10178df1","updated":"2025-06-11 15:57:30.000000000","message":"Compared with API documentation.\nLgtm.","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6f6285993d22191bdd90c83f6209389d6b55c829","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98f74255_91ad944d","updated":"2025-06-26 13:25:58.000000000","message":"fixed in https://review.opendev.org/c/openstack/nova/+/953281 so we can proceeed","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1152461600348264c9f2489d8bf25d94d3054a56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd6fc743_4790edb0","updated":"2025-06-10 23:30:16.000000000","message":"lgtm","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b2637bd28f22b6d1efbf2c231dc9c57551132de5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84301523_fed886b3","updated":"2025-07-05 17:40:20.000000000","message":"recheck","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb4236116fe67fff3d19f650d1faead33fb2a0c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a5defef_e988a47a","updated":"2025-07-04 09:15:02.000000000","message":"recheck","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83295d0e70eb46ea8a54839a39462b18446d5308","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"34b65db8_09b2669b","updated":"2025-07-17 10:14:28.000000000","message":"recheck","commit_id":"04589a4530d794c8d3e3ac025035abdd7f141f2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c674734380346161a5d5bfd143db036df870bb7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"92fa6cd8_4ef1ae07","updated":"2025-07-17 14:45:52.000000000","message":"recheck","commit_id":"04589a4530d794c8d3e3ac025035abdd7f141f2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"39e17369d9f7b3650effe23da65bd79e6df3478c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a86d4fda_6dbe37a5","updated":"2025-07-16 16:01:53.000000000","message":"recheck","commit_id":"04589a4530d794c8d3e3ac025035abdd7f141f2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af2b204344ac697b9896c701887daadb10035f35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5459c873_1d82abe0","updated":"2025-07-10 17:49:46.000000000","message":"recheck timeout","commit_id":"04589a4530d794c8d3e3ac025035abdd7f141f2d"}],"nova/api/openstack/compute/schemas/server_groups.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35884fb8d6ccb1ca32df10416e9466b393926e64","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_server_group_response \u003d {"},{"line_number":103,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":104,"context_line":"    \u0027properties\u0027: {"},{"line_number":105,"context_line":"        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"17e5ccf1_e12fe6d9","line":102,"updated":"2025-06-24 15:49:45.000000000","message":"https://docs.openstack.org/api-ref/compute/#id347\n\nThe main changes were 2.13, 2.15, 2.64.","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35884fb8d6ccb1ca32df10416e9466b393926e64","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    },"},{"line_number":133,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027members\u0027, \u0027metadata\u0027, \u0027name\u0027, \u0027policies\u0027],"},{"line_number":134,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":135,"context_line":"}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"_server_group_response_v213 \u003d copy.deepcopy(_server_group_response)"},{"line_number":138,"context_line":"_server_group_response_v213[\u0027properties\u0027].update({"}],"source_content_type":"text/x-python","patch_set":1,"id":"68e11a63_1561220d","line":135,"updated":"2025-06-24 15:49:45.000000000","message":"+1 this is correct","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35884fb8d6ccb1ca32df10416e9466b393926e64","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    \u0027project_id\u0027: parameter_types.project_id,"},{"line_number":140,"context_line":"    \u0027user_id\u0027: parameter_types.user_id,"},{"line_number":141,"context_line":"})"},{"line_number":142,"context_line":"_server_group_response_v213[\u0027required\u0027].extend([\u0027project_id\u0027, \u0027user_id\u0027])"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"_server_group_response_v215 \u003d copy.deepcopy(_server_group_response_v213)"},{"line_number":145,"context_line":"_server_group_response_v215[\u0027properties\u0027][\u0027policies\u0027][\u0027prefixItems\u0027][0]["}],"source_content_type":"text/x-python","patch_set":1,"id":"4e472978_44c7fe48","line":142,"updated":"2025-06-24 15:49:45.000000000","message":"yep 2.13 aded project and user.","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35884fb8d6ccb1ca32df10416e9466b393926e64","unresolved":false,"context_lines":[{"line_number":144,"context_line":"_server_group_response_v215 \u003d copy.deepcopy(_server_group_response_v213)"},{"line_number":145,"context_line":"_server_group_response_v215[\u0027properties\u0027][\u0027policies\u0027][\u0027prefixItems\u0027][0]["},{"line_number":146,"context_line":"    \u0027enum\u0027"},{"line_number":147,"context_line":"].extend([\u0027soft-affinity\u0027, \u0027soft-anti-affinity\u0027])"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"_server_group_response_v264 \u003d copy.deepcopy(_server_group_response_v215)"},{"line_number":150,"context_line":"del _server_group_response_v264[\u0027properties\u0027][\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"be38e3c8_0c45941a","line":147,"updated":"2025-06-24 15:49:45.000000000","message":"correct","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35884fb8d6ccb1ca32df10416e9466b393926e64","unresolved":false,"context_lines":[{"line_number":170,"context_line":"})"},{"line_number":171,"context_line":"_server_group_response_v264[\u0027required\u0027].remove(\u0027metadata\u0027)"},{"line_number":172,"context_line":"_server_group_response_v264[\u0027required\u0027].remove(\u0027policies\u0027)"},{"line_number":173,"context_line":"_server_group_response_v264[\u0027required\u0027].extend([\u0027policy\u0027, \u0027rules\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"show_response \u003d {"},{"line_number":176,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b71c8695_d6222657","line":173,"updated":"2025-06-24 15:49:45.000000000","message":"this is correct","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35884fb8d6ccb1ca32df10416e9466b393926e64","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        \u0027server_group\u0027: copy.deepcopy(_server_group_response),"},{"line_number":179,"context_line":"    },"},{"line_number":180,"context_line":"    \u0027required\u0027: [\u0027server_group\u0027],"},{"line_number":181,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"show_response_v213 \u003d copy.deepcopy(show_response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ddc9b076_e8b66d72","line":181,"updated":"2025-06-24 15:49:45.000000000","message":"why do we need additional properties true?\n\nbased on https://docs.openstack.org/api-ref/compute/#id351","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ca9bc5519a72b8bc5129eecc1721c40ceebf447","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        \u0027server_group\u0027: copy.deepcopy(_server_group_response),"},{"line_number":179,"context_line":"    },"},{"line_number":180,"context_line":"    \u0027required\u0027: [\u0027server_group\u0027],"},{"line_number":181,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"show_response_v213 \u003d copy.deepcopy(show_response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dd3a9754_5d4c6684","line":181,"in_reply_to":"848bada5_03e632c3","updated":"2025-06-25 08:06:14.000000000","message":"Fixed here https://review.opendev.org/c/openstack/nova/+/953281","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b820028cb625b13cdc138cb2a26fe13aef9cb5cd","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        \u0027server_group\u0027: copy.deepcopy(_server_group_response),"},{"line_number":179,"context_line":"    },"},{"line_number":180,"context_line":"    \u0027required\u0027: [\u0027server_group\u0027],"},{"line_number":181,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"show_response_v213 \u003d copy.deepcopy(show_response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"848bada5_03e632c3","line":181,"in_reply_to":"ddc9b076_e8b66d72","updated":"2025-06-25 08:05:49.000000000","message":"I don\u0027t think so. I don\u0027t know how this got in here 😅","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35884fb8d6ccb1ca32df10416e9466b393926e64","unresolved":true,"context_lines":[{"line_number":201,"context_line":"        },"},{"line_number":202,"context_line":"    },"},{"line_number":203,"context_line":"    \u0027required\u0027: [\u0027server_groups\u0027],"},{"line_number":204,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":205,"context_line":"}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"index_response_v213 \u003d copy.deepcopy(index_response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9c8ab53_cc9049a2","line":204,"updated":"2025-06-24 15:49:45.000000000","message":"same here is this really needed?","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b820028cb625b13cdc138cb2a26fe13aef9cb5cd","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        },"},{"line_number":202,"context_line":"    },"},{"line_number":203,"context_line":"    \u0027required\u0027: [\u0027server_groups\u0027],"},{"line_number":204,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":205,"context_line":"}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"index_response_v213 \u003d copy.deepcopy(index_response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae64ec07_27c73dc4","line":204,"in_reply_to":"c9c8ab53_cc9049a2","updated":"2025-06-25 08:05:49.000000000","message":"As above.","commit_id":"75a0bd79296f75a53f920fefaea2fac980a898aa"}]}