)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"72394cc501c01db039f8bb591530ac48f00d4de8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9dd80a32_e83abefc","updated":"2025-07-16 16:02:35.000000000","message":"recheck","commit_id":"a5f18777be28ea5b5febf3f8acd7e15ac8eba127"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"867dc6e332601477958165f81cef5df3645bb91b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ea23414b_3a03d901","updated":"2025-11-18 12:26:10.000000000","message":"recheck","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a0facf68d3bcb79df8397d1c81cc7f5e59db020","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b8e91fc2_aa27a33b","updated":"2025-11-12 13:10:45.000000000","message":"recheck failure on base patch","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"}],"nova/api/openstack/compute/schemas/volume_attachments.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88bcceea22c975ef71404e25a172390d148f6b02","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":102,"context_line":"}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"_volume_attachment_response \u003d {"},{"line_number":105,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":106,"context_line":"    \u0027properties\u0027: {"},{"line_number":107,"context_line":"        \u0027id\u0027: parameter_types.volume_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ce6958cb_cbcad7ac","line":104,"updated":"2025-11-11 17:47:41.000000000","message":"https://docs.openstack.org/api-ref/compute/#id194\n\nthis is waht i orgianly was exepctign for the oher volume patch, \nso in this case the schma is for the volume attachemtns api\n\nthat has microvversion fro 2.70 2.79 2.88 and 2.89","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1936471518475d455f8adf85897209d7ff26850e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":102,"context_line":"}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"_volume_attachment_response \u003d {"},{"line_number":105,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":106,"context_line":"    \u0027properties\u0027: {"},{"line_number":107,"context_line":"        \u0027id\u0027: parameter_types.volume_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf378a9a_65d5cb9b","line":104,"in_reply_to":"ce6958cb_cbcad7ac","updated":"2025-11-11 18:35:50.000000000","message":"Acknowledged","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88bcceea22c975ef71404e25a172390d148f6b02","unresolved":true,"context_lines":[{"line_number":126,"context_line":"            {\u0027type\u0027: \u0027null\u0027},"},{"line_number":127,"context_line":"        ],"},{"line_number":128,"context_line":"    },"},{"line_number":129,"context_line":"})"},{"line_number":130,"context_line":"_volume_attachment_response_v270[\u0027required\u0027].append(\u0027tag\u0027)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"_volume_attachment_response_v279 \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":11,"id":"5dff3a99_5b6e6524","line":129,"updated":"2025-11-11 17:47:41.000000000","message":"+1 yep device role tagging added tag in 2.70","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1936471518475d455f8adf85897209d7ff26850e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            {\u0027type\u0027: \u0027null\u0027},"},{"line_number":127,"context_line":"        ],"},{"line_number":128,"context_line":"    },"},{"line_number":129,"context_line":"})"},{"line_number":130,"context_line":"_volume_attachment_response_v270[\u0027required\u0027].append(\u0027tag\u0027)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"_volume_attachment_response_v279 \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":11,"id":"71e61d20_bd401941","line":129,"in_reply_to":"5dff3a99_5b6e6524","updated":"2025-11-11 18:35:50.000000000","message":"Acknowledged","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88bcceea22c975ef71404e25a172390d148f6b02","unresolved":true,"context_lines":[{"line_number":135,"context_line":"_volume_attachment_response_v279[\u0027properties\u0027].update({"},{"line_number":136,"context_line":"    \u0027delete_on_termination\u0027: parameter_types.boolean,"},{"line_number":137,"context_line":"})"},{"line_number":138,"context_line":"_volume_attachment_response_v279[\u0027required\u0027].append(\u0027delete_on_termination\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"_volume_attachment_response_v289 \u003d copy.deepcopy("},{"line_number":141,"context_line":"    _volume_attachment_response_v279"}],"source_content_type":"text/x-python","patch_set":11,"id":"970e6540_9cf47483","line":138,"updated":"2025-11-11 17:47:41.000000000","message":"yep the ablity to set an update delete on termination was in 2.79","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1936471518475d455f8adf85897209d7ff26850e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"_volume_attachment_response_v279[\u0027properties\u0027].update({"},{"line_number":136,"context_line":"    \u0027delete_on_termination\u0027: parameter_types.boolean,"},{"line_number":137,"context_line":"})"},{"line_number":138,"context_line":"_volume_attachment_response_v279[\u0027required\u0027].append(\u0027delete_on_termination\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"_volume_attachment_response_v289 \u003d copy.deepcopy("},{"line_number":141,"context_line":"    _volume_attachment_response_v279"}],"source_content_type":"text/x-python","patch_set":11,"id":"f3993ea7_66e451ef","line":138,"in_reply_to":"970e6540_9cf47483","updated":"2025-11-11 18:35:50.000000000","message":"Acknowledged","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88bcceea22c975ef71404e25a172390d148f6b02","unresolved":true,"context_lines":[{"line_number":144,"context_line":"_volume_attachment_response_v289[\u0027properties\u0027].update({"},{"line_number":145,"context_line":"    \u0027attachment_id\u0027: parameter_types.attachment_id,"},{"line_number":146,"context_line":"    \u0027bdm_uuid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":147,"context_line":"})"},{"line_number":148,"context_line":"_volume_attachment_response_v289[\u0027required\u0027].pop("},{"line_number":149,"context_line":"    _volume_attachment_response_v289[\u0027required\u0027].index(\u0027id\u0027)"},{"line_number":150,"context_line":")"}],"source_content_type":"text/x-python","patch_set":11,"id":"fe4d720e_d9780079","line":147,"updated":"2025-11-11 17:47:41.000000000","message":"ah right id was aviabel until 2.88 and atachment_id and bdm_uuid replaced them","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1936471518475d455f8adf85897209d7ff26850e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"_volume_attachment_response_v289[\u0027properties\u0027].update({"},{"line_number":145,"context_line":"    \u0027attachment_id\u0027: parameter_types.attachment_id,"},{"line_number":146,"context_line":"    \u0027bdm_uuid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":147,"context_line":"})"},{"line_number":148,"context_line":"_volume_attachment_response_v289[\u0027required\u0027].pop("},{"line_number":149,"context_line":"    _volume_attachment_response_v289[\u0027required\u0027].index(\u0027id\u0027)"},{"line_number":150,"context_line":")"}],"source_content_type":"text/x-python","patch_set":11,"id":"4ddf6268_b3c365a6","line":147,"in_reply_to":"fe4d720e_d9780079","updated":"2025-11-11 18:35:50.000000000","message":"Acknowledged","commit_id":"0dbc190e096674532179361a6c878dc1297b6e7c"}],"nova/api/openstack/compute/volume_attachments.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fd9bab96ddb8227cf953c75d8b80e43641adf4d","unresolved":true,"context_lines":[{"line_number":246,"context_line":"            attachment[\u0027tag\u0027] \u003d tag"},{"line_number":247,"context_line":"        if api_version_request.is_supported(req, \u00272.79\u0027):"},{"line_number":248,"context_line":"            attachment[\u0027delete_on_termination\u0027] \u003d delete_on_termination"},{"line_number":249,"context_line":"        # TODO(stephenfin): We forgot to apply 2.89 here. We should return"},{"line_number":250,"context_line":"        # \u0027bdm_uuid\u0027 and \u0027attachment_id\u0027 and stop returning \u0027id\u0027"},{"line_number":251,"context_line":"        return {\u0027volumeAttachment\u0027: attachment}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def _update_volume_swap(self, req, instance, id, body):"}],"source_content_type":"text/x-python","patch_set":6,"id":"30770990_71efbace","line":250,"range":{"start_line":249,"start_character":0,"end_line":250,"end_character":64},"updated":"2025-07-30 02:12:51.000000000","message":"++, yeah somehow we missed to look into create API while doing 2.89 microversion.","commit_id":"5e5586553005b94a511d4ae97c1d52156a11e33d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"563d56d6e9bca476faa67da056d570d85e6e2201","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            attachment[\u0027tag\u0027] \u003d tag"},{"line_number":247,"context_line":"        if api_version_request.is_supported(req, \u00272.79\u0027):"},{"line_number":248,"context_line":"            attachment[\u0027delete_on_termination\u0027] \u003d delete_on_termination"},{"line_number":249,"context_line":"        # TODO(stephenfin): We forgot to apply 2.89 here. We should return"},{"line_number":250,"context_line":"        # \u0027bdm_uuid\u0027 and \u0027attachment_id\u0027 and stop returning \u0027id\u0027"},{"line_number":251,"context_line":"        return {\u0027volumeAttachment\u0027: attachment}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def _update_volume_swap(self, req, instance, id, body):"}],"source_content_type":"text/x-python","patch_set":6,"id":"a7a52d8f_c37c1a24","line":250,"range":{"start_line":249,"start_character":0,"end_line":250,"end_character":64},"in_reply_to":"30770990_71efbace","updated":"2025-07-30 09:31:04.000000000","message":"Acknowledged","commit_id":"5e5586553005b94a511d4ae97c1d52156a11e33d"}]}