)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"56e91fdb049adb2e8402b97ddd780c8490eee6b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fa16c4a_6c3e9c50","updated":"2025-09-02 22:08:30.000000000","message":"lgtm, this can be fixed as bug and no need to bump microversion. some comment on comment/commit msg update.","commit_id":"d54d10fd570773c120a693e8aaf0f153af1bb565"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"43ca6193c5b3d7dbb893c84eb95b6370b78ac73b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8a8d2d8c_b312d4ca","updated":"2025-09-05 10:03:16.000000000","message":"LGTM","commit_id":"1593dddfaf6992db63a0f00bec5e6998fa70c02a"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"257505f7f2f3dac9a6212d6cc7885eeff5fc7494","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34b37688_134e5819","updated":"2025-09-10 09:00:27.000000000","message":"recheck nova next timeout (File \"/opt/stack/tempest/tempest/common/waiters.py\", line 101, in wait_for_server_status raise lib_exc.TimeoutException(message)","commit_id":"1593dddfaf6992db63a0f00bec5e6998fa70c02a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"794df9eaa95df0201efedb85ca87eea253b6ebf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc922163_595c128f","updated":"2025-09-03 18:37:42.000000000","message":"thanks, lgtm.","commit_id":"1593dddfaf6992db63a0f00bec5e6998fa70c02a"}],"nova/api/openstack/compute/schemas/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"56e91fdb049adb2e8402b97ddd780c8490eee6b9","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        \u0027volume_id\u0027: parameter_types.volume_id,"},{"line_number":28,"context_line":"        \u0027snapshot_id\u0027: parameter_types.image_id,"},{"line_number":29,"context_line":"        \u0027volume_size\u0027: parameter_types.volume_size,"},{"line_number":30,"context_line":"        # Do not allow empty device names and number values and"},{"line_number":31,"context_line":"        # containing spaces(defined in nova/block_device.py:from_api())"},{"line_number":32,"context_line":"        \u0027device_name\u0027: {"},{"line_number":33,"context_line":"            \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3df10ee_ff1525ca","line":30,"range":{"start_line":30,"start_character":46,"end_line":30,"end_character":59},"updated":"2025-09-02 22:08:30.000000000","message":"I am not sure why this is mentioned here as we do allow number in device_name. Maybe we can rename this comment to something below:\n\n    # Do not allow empty device names or spaces in name (defined in\n    # nova/block_device.py:validate_device_name())","commit_id":"d54d10fd570773c120a693e8aaf0f153af1bb565"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"d3a1c7ffc6aef776cda9e5d658be395456e8309a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027volume_id\u0027: parameter_types.volume_id,"},{"line_number":28,"context_line":"        \u0027snapshot_id\u0027: parameter_types.image_id,"},{"line_number":29,"context_line":"        \u0027volume_size\u0027: parameter_types.volume_size,"},{"line_number":30,"context_line":"        # Do not allow empty device names and number values and"},{"line_number":31,"context_line":"        # containing spaces(defined in nova/block_device.py:from_api())"},{"line_number":32,"context_line":"        \u0027device_name\u0027: {"},{"line_number":33,"context_line":"            \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2274cbd3_181727e2","line":30,"range":{"start_line":30,"start_character":46,"end_line":30,"end_character":59},"in_reply_to":"f3df10ee_ff1525ca","updated":"2025-09-03 08:18:46.000000000","message":"Done","commit_id":"d54d10fd570773c120a693e8aaf0f153af1bb565"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"d3a1c7ffc6aef776cda9e5d658be395456e8309a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027volume_id\u0027: parameter_types.volume_id,"},{"line_number":28,"context_line":"        \u0027snapshot_id\u0027: parameter_types.image_id,"},{"line_number":29,"context_line":"        \u0027volume_size\u0027: parameter_types.volume_size,"},{"line_number":30,"context_line":"        # Do not allow empty device names and number values and"},{"line_number":31,"context_line":"        # containing spaces(defined in nova/block_device.py:from_api())"},{"line_number":32,"context_line":"        \u0027device_name\u0027: {"},{"line_number":33,"context_line":"            \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dcb3103b_39f47781","line":30,"range":{"start_line":30,"start_character":46,"end_line":30,"end_character":59},"in_reply_to":"f3df10ee_ff1525ca","updated":"2025-09-03 08:18:46.000000000","message":"Done","commit_id":"d54d10fd570773c120a693e8aaf0f153af1bb565"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"56e91fdb049adb2e8402b97ddd780c8490eee6b9","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        \u0027snapshot_id\u0027: parameter_types.image_id,"},{"line_number":29,"context_line":"        \u0027volume_size\u0027: parameter_types.volume_size,"},{"line_number":30,"context_line":"        # Do not allow empty device names and number values and"},{"line_number":31,"context_line":"        # containing spaces(defined in nova/block_device.py:from_api())"},{"line_number":32,"context_line":"        \u0027device_name\u0027: {"},{"line_number":33,"context_line":"            \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"},{"line_number":34,"context_line":"            \u0027pattern\u0027: \u0027^[a-zA-Z0-9._/-]*$\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"34583328_eb7ff8da","line":31,"range":{"start_line":31,"start_character":60,"end_line":31,"end_character":70},"updated":"2025-09-02 22:08:30.000000000","message":"decvice_name is validated in validate_device_name() may be we can mention that method name.","commit_id":"d54d10fd570773c120a693e8aaf0f153af1bb565"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"d3a1c7ffc6aef776cda9e5d658be395456e8309a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \u0027snapshot_id\u0027: parameter_types.image_id,"},{"line_number":29,"context_line":"        \u0027volume_size\u0027: parameter_types.volume_size,"},{"line_number":30,"context_line":"        # Do not allow empty device names and number values and"},{"line_number":31,"context_line":"        # containing spaces(defined in nova/block_device.py:from_api())"},{"line_number":32,"context_line":"        \u0027device_name\u0027: {"},{"line_number":33,"context_line":"            \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"},{"line_number":34,"context_line":"            \u0027pattern\u0027: \u0027^[a-zA-Z0-9._/-]*$\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"86807229_fb7e5206","line":31,"range":{"start_line":31,"start_character":60,"end_line":31,"end_character":70},"in_reply_to":"34583328_eb7ff8da","updated":"2025-09-03 08:18:46.000000000","message":"Done","commit_id":"d54d10fd570773c120a693e8aaf0f153af1bb565"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"d3a1c7ffc6aef776cda9e5d658be395456e8309a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \u0027snapshot_id\u0027: parameter_types.image_id,"},{"line_number":29,"context_line":"        \u0027volume_size\u0027: parameter_types.volume_size,"},{"line_number":30,"context_line":"        # Do not allow empty device names and number values and"},{"line_number":31,"context_line":"        # containing spaces(defined in nova/block_device.py:from_api())"},{"line_number":32,"context_line":"        \u0027device_name\u0027: {"},{"line_number":33,"context_line":"            \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"},{"line_number":34,"context_line":"            \u0027pattern\u0027: \u0027^[a-zA-Z0-9._/-]*$\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8e015a1f_b159e910","line":31,"range":{"start_line":31,"start_character":60,"end_line":31,"end_character":70},"in_reply_to":"34583328_eb7ff8da","updated":"2025-09-03 08:18:46.000000000","message":"Done","commit_id":"d54d10fd570773c120a693e8aaf0f153af1bb565"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"56e91fdb049adb2e8402b97ddd780c8490eee6b9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        # containing spaces(defined in nova/block_device.py:from_api())"},{"line_number":32,"context_line":"        \u0027device_name\u0027: {"},{"line_number":33,"context_line":"            \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"},{"line_number":34,"context_line":"            \u0027pattern\u0027: \u0027^[a-zA-Z0-9._/-]*$\u0027,"},{"line_number":35,"context_line":"        },"},{"line_number":36,"context_line":"        # Defined as boolean in nova/block_device.py:from_api()"},{"line_number":37,"context_line":"        \u0027delete_on_termination\u0027: parameter_types.boolean,"}],"source_content_type":"text/x-python","patch_set":1,"id":"35fd0ba4_ae85f2ad","line":34,"range":{"start_line":34,"start_character":43,"end_line":34,"end_character":44},"updated":"2025-09-02 22:08:30.000000000","message":"yeah, I built these schema in Ib8857d9f725e277f27ccfab83335142b05e2cdf1 and do not know why I kept \u0027r\u0027 which made \u0027_-r\u0027 a range of items from -  to r.  The whole point was to add schema mapped to block_device.py-\u003evalidate_device_name()[1]. \n\nThis is matching with what is allowed in block_device.py and it is ok to fix as bug and no need to bump the microversion for this. If you can add these info (I mentioned in this comment) in commit msg so that it will be easy to review it and the reason of why we do not need to bump the microversion.\n\n[1] https://github.com/openstack/nova/blob/73724fef9a66c4df3d018e7368067f883b1ed9e2/nova/block_device.py#L378","commit_id":"d54d10fd570773c120a693e8aaf0f153af1bb565"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"befa2c863eee9c869f3a8c03661d84109f404fbf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \u0027snapshot_id\u0027: parameter_types.image_id,"},{"line_number":29,"context_line":"        \u0027volume_size\u0027: parameter_types.volume_size,"},{"line_number":30,"context_line":"        # Do not allow empty device names or spaces in name (defined in"},{"line_number":31,"context_line":"        # nova/block_device.py:validate_device_name())"},{"line_number":32,"context_line":"        \u0027device_name\u0027: {"},{"line_number":33,"context_line":"            \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"},{"line_number":34,"context_line":"            \u0027pattern\u0027: \u0027^[a-zA-Z0-9._/-]*$\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d92bb4c6_6d3ae72e","line":31,"updated":"2025-09-08 14:18:53.000000000","message":"thanks for updating it","commit_id":"1593dddfaf6992db63a0f00bec5e6998fa70c02a"}]}