)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2811e3d90168f6cfa95c73dfed62ce7841d648b3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"it should also able to obtain the same server via server get api."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This may not sound critical or blocking, but inability to use get server"},{"line_number":13,"context_line":"api by \"system reader\" roles results in a bad UX as users are unable to"},{"line_number":14,"context_line":"use simple `openstack server show` CLI."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2dfcee27965789df8b390eaa130693222773bc04"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d04272c4_78d60993","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":23},"updated":"2025-06-20 18:03:53.000000000","message":"there is no \u0027system reader\u0027 role now but I think you mean to say custom role allowed for list details APIs...","commit_id":"2207163d4c54575367c99c5273aa8c2ea061922e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2811e3d90168f6cfa95c73dfed62ce7841d648b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68a69f51_1dfa5b4e","updated":"2025-06-20 18:03:53.000000000","message":"User can achieve the same via below cli param, before we fix this as bug I would like to know why user cannot do it and want to do via show server only.\n\n\"openstack server list --all-projects --project \u003cproject\u003e\"\n\n- https://docs.openstack.org/python-openstackclient/latest/cli/command-objects...\n\nAlso, let\u0027s discuss it in nova weekly meeting to know if any objection to fix it as bug. Feel free to add/attend it in meeting agenda - https://wiki.openstack.org/wiki/Meetings/Nova#Weekly_Nova_team_meeting","commit_id":"2207163d4c54575367c99c5273aa8c2ea061922e"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2811e3d90168f6cfa95c73dfed62ce7841d648b3","unresolved":true,"context_lines":[{"line_number":465,"context_line":"        show_server_groups \u003d api_version_request.is_supported(req, \u00272.71\u0027)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        elevated \u003d None"},{"line_number":468,"context_line":"        if context.can(server_policies.SERVERS % \u0027detail:get_all_tenants\u0027,"},{"line_number":469,"context_line":"                       fatal\u003dFalse):"},{"line_number":470,"context_line":"            elevated \u003d context.elevated()"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"31ab607a_b47fe256","line":468,"range":{"start_line":468,"start_character":49,"end_line":468,"end_character":73},"updated":"2025-06-20 18:03:53.000000000","message":"it make sense to use same policy but please modify the policy description to say it control list details as well as show server APIs.","commit_id":"2207163d4c54575367c99c5273aa8c2ea061922e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2811e3d90168f6cfa95c73dfed62ce7841d648b3","unresolved":true,"context_lines":[{"line_number":464,"context_line":"        cell_down_support \u003d api_version_request.is_supported(req, \u00272.69\u0027)"},{"line_number":465,"context_line":"        show_server_groups \u003d api_version_request.is_supported(req, \u00272.71\u0027)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        elevated \u003d None"},{"line_number":468,"context_line":"        if context.can(server_policies.SERVERS % \u0027detail:get_all_tenants\u0027,"},{"line_number":469,"context_line":"                       fatal\u003dFalse):"},{"line_number":470,"context_line":"            elevated \u003d context.elevated()"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        instance \u003d self._get_server("},{"line_number":473,"context_line":"            elevated or context, req, id, is_detail\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5cf70548_a834298a","line":470,"range":{"start_line":467,"start_character":0,"end_line":470,"end_character":41},"updated":"2025-06-20 18:03:53.000000000","message":"I am ok with this. I replied in email also but adding my checking here on why this is ok to fix as bug fix.\n\n* Backward compatibility: OK\nNew policy default to \u0027Admin\u0027 keep it backward compatible.\n- With default policies (new policy default to Admin), nothing changed here for existing use case where admin query\nother projects or project query their own instance.\n- If anyone overridden \u0027servers:show\u0027 policy then it continue working same way for the above use case. new policy is\nnot in effect for existing use cases.\n- There is difference in response from list detail vs show API so we are not going to expose any new info to non-admin\nusers which they can do currently.","commit_id":"2207163d4c54575367c99c5273aa8c2ea061922e"}],"nova/tests/unit/api/openstack/compute/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2811e3d90168f6cfa95c73dfed62ce7841d648b3","unresolved":true,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        another_project_id \u003d \"318330b4-21ab-4036-9691-696032c11b84\""},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        def fake_get(ctxt, *args, **kwargs):"},{"line_number":466,"context_line":"            if not ctxt.is_admin and self.project_id !\u003d another_project_id:"},{"line_number":467,"context_line":"                raise exception.InstanceNotFound(instance_id\u003d\u0027fake\u0027)"},{"line_number":468,"context_line":"            return fakes.stub_instance_obj("},{"line_number":469,"context_line":"                ctxt,"},{"line_number":470,"context_line":"                id\u003d2, availability_zone\u003d\u0027nova\u0027,"},{"line_number":471,"context_line":"                launched_at\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bdb6cfa6_ed3ad8b7","line":468,"range":{"start_line":465,"start_character":0,"end_line":468,"end_character":43},"updated":"2025-06-20 18:03:53.000000000","message":"this is ok but we do have hard coded admin checks down in DB/object layer and this mick skip all those.\n\nAlong with this test, I would like to see a functional test to see if all works fine non-admin users.","commit_id":"2207163d4c54575367c99c5273aa8c2ea061922e"}]}