)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"595c56123e6ed23323833e26e477b207e73ab4ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"932dc419_19def0fe","updated":"2025-07-29 19:19:07.000000000","message":"lgtm but I am not sure doing GENERATE_SAMPLE in base tox is good idea.","commit_id":"800c4d9b7dc96dc2efc77bf5237abc9334c6df23"}],"tox.ini":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"595c56123e6ed23323833e26e477b207e73ab4ab","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  LOCALE_ARCHIVE"},{"line_number":33,"context_line":"  OS_DEBUG"},{"line_number":34,"context_line":"  GENERATE_HASHES"},{"line_number":35,"context_line":"  GENERATE_SAMPLES"},{"line_number":36,"context_line":"# Note(sean-k-mooney):"},{"line_number":37,"context_line":"# leaking greanthreads between tests is a bug so we should fail if it happens"},{"line_number":38,"context_line":"# however unlike greenthreads, greenlets cannot be killed via a test fixture."}],"source_content_type":"text/x-properties","patch_set":4,"id":"11c993e5_b53f5e0c","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":18},"updated":"2025-07-29 19:19:07.000000000","message":"do we want to do that? We have separate tox env api-samples to do that. Doing it in base can unnecessarily generate an outdated sample?","commit_id":"800c4d9b7dc96dc2efc77bf5237abc9334c6df23"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7af83fd18d78140f4da003cf3233860216b0eda","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  LOCALE_ARCHIVE"},{"line_number":33,"context_line":"  OS_DEBUG"},{"line_number":34,"context_line":"  GENERATE_HASHES"},{"line_number":35,"context_line":"  GENERATE_SAMPLES"},{"line_number":36,"context_line":"# Note(sean-k-mooney):"},{"line_number":37,"context_line":"# leaking greanthreads between tests is a bug so we should fail if it happens"},{"line_number":38,"context_line":"# however unlike greenthreads, greenlets cannot be killed via a test fixture."}],"source_content_type":"text/x-properties","patch_set":4,"id":"ef68007f_60af7eba","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":18},"in_reply_to":"11c993e5_b53f5e0c","updated":"2025-07-30 09:01:43.000000000","message":"Note that this is in the `passenv` section, not `setenv`. Unless something sets this in CI, this should be a no-op. I was using it so that I could run functional tests and generate new samples on-the-fly. I\u0027ll strip it out of here though and re-add it at the end of the series.","commit_id":"800c4d9b7dc96dc2efc77bf5237abc9334c6df23"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"771212dd73145aa9e92f9ef2d030dfd3a1c15bc2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  LOCALE_ARCHIVE"},{"line_number":33,"context_line":"  OS_DEBUG"},{"line_number":34,"context_line":"  GENERATE_HASHES"},{"line_number":35,"context_line":"  GENERATE_SAMPLES"},{"line_number":36,"context_line":"# Note(sean-k-mooney):"},{"line_number":37,"context_line":"# leaking greanthreads between tests is a bug so we should fail if it happens"},{"line_number":38,"context_line":"# however unlike greenthreads, greenlets cannot be killed via a test fixture."}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fef362b_63894d90","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":18},"in_reply_to":"ef68007f_60af7eba","updated":"2025-07-30 15:25:36.000000000","message":"yeah, that will be better. thanks","commit_id":"800c4d9b7dc96dc2efc77bf5237abc9334c6df23"}]}