)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"782b0a98e21c6ca98c1fca7fdf9f1040a6f8e6f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d069a58_80adfabb","updated":"2025-06-23 15:04:08.000000000","message":"ill try an do a full review tomorrow but over all i think this all makes sense\n\nthanks for adding the code comment to call out the delta in behaviour form the other manager methods","commit_id":"a593b176d8bd70c6d0a618c0b331769b376ab838"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"40222b5ca56e4ea6d03e69d75e40743b8e66b0d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0f599e9_3c393040","updated":"2025-06-25 16:25:26.000000000","message":"Thanks gibi!","commit_id":"1cd1c472bd8a2dafe4219c7b61b8d75a67f1bf16"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c3a9ecb36b578b00853a1a87f298c2645393a567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab5f7575_fb969c20","updated":"2025-06-27 07:16:53.000000000","message":"recheck both nova-live-migration and nova-mutli-cell failed to deploy due to etcd fails to start.\n```\n2025-06-25 16:22:55.113994 | controller | Job for devstack@etcd.service failed because the control process exited with error code.\n12730\t2025-06-25 16:22:55.114015 | controller | See \"systemctl status devstack@etcd.service\" and \"journalctl -xeu devstack@etcd.service\" for details.\n```\ncaused by\n```\nJun 25 16:22:56.007913 np0041230136 etcd[49480]: Running http and grpc server on single port. This is not recommended for production.\nJun 25 16:22:56.008136 np0041230136 etcd[49480]: listen tcp 63.131.145.245:2379: bind: cannot assign requested address\nJun 25 16:22:56.009652 np0041230136 systemd[1]: devstack@etcd.service: Main process exited, code\u003dexited, status\u003d1/FAILURE\n```\n\n*","commit_id":"1cd1c472bd8a2dafe4219c7b61b8d75a67f1bf16"}],"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"985ad1288f229138ddb3bc3ffb09e21d57b313cd","unresolved":true,"context_lines":[{"line_number":2340,"context_line":""},{"line_number":2341,"context_line":"    @wrap_exception()"},{"line_number":2342,"context_line":"    @reverts_task_state"},{"line_number":2343,"context_line":"    @wrap_instance_fault"},{"line_number":2344,"context_line":"    def build_and_run_instance(self, context, instance, image, request_spec,"},{"line_number":2345,"context_line":"                     filter_properties, accel_uuids, admin_password\u003dNone,"},{"line_number":2346,"context_line":"                     injected_files\u003dNone, requested_networks\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"cdefd629_b9d324c6","side":"PARENT","line":2343,"updated":"2025-06-23 16:15:24.000000000","message":"Do we really need to remove these? The only thing we do is spawn, but spawn could potentially fail and we wouldn\u0027t want to avoid recording that fault, right? If we left these in place but kept the comment to explain that they\u0027re really only used for that purpose, it seems like it might be better, no?","commit_id":"41773f8c6515021eb037e6d9d385b34e89191c8c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"63a05a2936d43126f44c905f6a03b48451c50678","unresolved":false,"context_lines":[{"line_number":2340,"context_line":""},{"line_number":2341,"context_line":"    @wrap_exception()"},{"line_number":2342,"context_line":"    @reverts_task_state"},{"line_number":2343,"context_line":"    @wrap_instance_fault"},{"line_number":2344,"context_line":"    def build_and_run_instance(self, context, instance, image, request_spec,"},{"line_number":2345,"context_line":"                     filter_properties, accel_uuids, admin_password\u003dNone,"},{"line_number":2346,"context_line":"                     injected_files\u003dNone, requested_networks\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"78f0925b_9bb16c46","side":"PARENT","line":2343,"in_reply_to":"cdefd629_b9d324c6","updated":"2025-06-25 16:01:32.000000000","message":"I considered this as dead code. But I can accept that it can catch something coming from the spawn call itself. Also we discussed that we are changing what spawn does in the eventlet-removal series so I accept keeping the decorator here not to change to many things at the same time .","commit_id":"41773f8c6515021eb037e6d9d385b34e89191c8c"}]}
