)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83617d1f2e0a9582e41c40023f04f80753bc569d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de662877_17850069","updated":"2025-07-02 13:09:49.000000000","message":"it appears this is being proposed because of https://security-tracker.debian.org/tracker/CVE-2024-6174 and https://bugs.debian.org/cgi-bin/bugreport.cgi?bug\u003d1108403 and i do not agree that that is a valid cve\n\nthe link local adress is inteded to be used if the openstack or ec2 ata souces are aviable.\n\nbut ingnoring that for a second \n\nthe information presetned in the dmi info by qemu is an internal impelation detail of the libvirt driver and is not portable across cirt driver to ironic or vmware.\n\nit is not a public interface that shoudl be reliaed on by cloud init.\n\nthis is a major breaking change in cloud-init and i would stonctly suggested that a revert shoudl be condiered.","commit_id":"1c703cd1c749c42dc482af36e8afcf6f44409a32"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"f3d62328ce6c5d7b6f80ea03f2be979d1c577452","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c3892cb_d574a7a5","updated":"2025-07-02 13:43:54.000000000","message":"recheck","commit_id":"1c703cd1c749c42dc482af36e8afcf6f44409a32"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"096dccf859228188bb44b7075147231a4c82f0af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"efd11aa7_b81c24c7","updated":"2025-07-01 10:13:45.000000000","message":"recheck post failure","commit_id":"1c703cd1c749c42dc482af36e8afcf6f44409a32"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4b4612e6e0df55f7eac888d7f39112f5e5787781","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de3dd5f7_d2e090c6","in_reply_to":"4012f44f_2f1571a8","updated":"2025-07-02 14:27:01.000000000","message":"We use SATA because when we were choosing the new default for the q35 machine type Windows could not use virtio-scis, raw virtio, and problem with our min version and IDE was not supported with q35.\n\nSo we chose SATA.\n\nIf our min libvirt/qemu now supports virtio for CD-ROM i think we can make that change the same way we updated from Cirrus Graphics to virtio-gpu.\n\n\nwith the spec/blueprint freeze tomorrow im not sure we will have time to do ti this cycle but we proably shoudl bring it up in the next nova team meeting on tusday.","commit_id":"1c703cd1c749c42dc482af36e8afcf6f44409a32"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"3216faf865437df8796d0c0b97aeb6ff2a1a07bf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4012f44f_2f1571a8","in_reply_to":"de662877_17850069","updated":"2025-07-02 13:43:47.000000000","message":"Sean, no, this patch is *not* about the CVE. It\u0027s about OpenStack defaulting to AHCI, and the Debian cloud image (in fact cloud kernel) having no support for it. Rightly, IMO, as AHCI is a very old hardware, with poor performance.","commit_id":"1c703cd1c749c42dc482af36e8afcf6f44409a32"}],"nova/conf/libvirt.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"210a629b0e565467dbc38212e15fbdaf03b449bc","unresolved":true,"context_lines":[{"line_number":1106,"context_line":"libvirt_force_virtio_cd \u003d ["},{"line_number":1107,"context_line":"    cfg.BoolOpt(\u0027force_virtio_cd\u0027,"},{"line_number":1108,"context_line":"                default\u003dFalse,"},{"line_number":1109,"context_line":"                help\u003d\u0027Foce the use of virtio driver for CDROM\u0027),"},{"line_number":1110,"context_line":"]"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"libvirt_volume_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"00169118_b3b7a055","line":1109,"range":{"start_line":1109,"start_character":22,"end_line":1109,"end_character":26},"updated":"2025-06-30 12:47:16.000000000","message":"Typo: \"force\"","commit_id":"53211b76b0f0b5b58a5f5eff6632ece54f9df1da"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"8fc74d7da32168bf4f68df257f14b3afe77f89d9","unresolved":false,"context_lines":[{"line_number":1106,"context_line":"libvirt_force_virtio_cd \u003d ["},{"line_number":1107,"context_line":"    cfg.BoolOpt(\u0027force_virtio_cd\u0027,"},{"line_number":1108,"context_line":"                default\u003dFalse,"},{"line_number":1109,"context_line":"                help\u003d\u0027Foce the use of virtio driver for CDROM\u0027),"},{"line_number":1110,"context_line":"]"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"libvirt_volume_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"37f452d8_77f0a898","line":1109,"range":{"start_line":1109,"start_character":22,"end_line":1109,"end_character":26},"in_reply_to":"00169118_b3b7a055","updated":"2025-07-01 10:13:56.000000000","message":"Done","commit_id":"53211b76b0f0b5b58a5f5eff6632ece54f9df1da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83617d1f2e0a9582e41c40023f04f80753bc569d","unresolved":true,"context_lines":[{"line_number":1107,"context_line":"    cfg.BoolOpt(\u0027force_virtio_cd\u0027,"},{"line_number":1108,"context_line":"                default\u003dFalse,"},{"line_number":1109,"context_line":"                help\u003d\u0027Force the use of virtio driver for CDROM\u0027),"},{"line_number":1110,"context_line":"]"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"libvirt_volume_opts \u003d ["},{"line_number":1113,"context_line":"    cfg.BoolOpt(\u0027volume_use_multipath\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ac92d03f_e5b79ca1","line":1110,"updated":"2025-07-02 13:09:49.000000000","message":"this is already the default as we default the conig drive format to iso.\n\nits only not a iso if you configure it to be vfat.","commit_id":"1c703cd1c749c42dc482af36e8afcf6f44409a32"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4b4612e6e0df55f7eac888d7f39112f5e5787781","unresolved":true,"context_lines":[{"line_number":1107,"context_line":"    cfg.BoolOpt(\u0027force_virtio_cd\u0027,"},{"line_number":1108,"context_line":"                default\u003dFalse,"},{"line_number":1109,"context_line":"                help\u003d\u0027Force the use of virtio driver for CDROM\u0027),"},{"line_number":1110,"context_line":"]"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"libvirt_volume_opts \u003d ["},{"line_number":1113,"context_line":"    cfg.BoolOpt(\u0027volume_use_multipath\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"85721458_197cacfd","line":1110,"in_reply_to":"6168d747_58372d76","updated":"2025-07-02 14:27:01.000000000","message":"so we dont want to contol the device model via config in general as that can cause cause issue with live migration.\n\n\nlike the \nlibvirt_vif_opts \u003d [\n    cfg.BoolOpt(\u0027use_virtio_for_bridges\u0027,\n                default\u003dTrue,\n                help\u003d\u0027Use virtio for bridge interfaces with KVM/QEMU\u0027),\n]\n\nconfig option has been planed to be removed for a very long time but we jsut never got aroudn to it.\n\nso i dont want use to continue building more tech debt by adding another way for the device model to vary per host.\n\n\nwe can look into change the overall default but i am not supprotive of a config driveen approch.\n\nbut thnaks for expaling..\n\nthe reason i asked about the cve was the link in the comments back to this patch.","commit_id":"1c703cd1c749c42dc482af36e8afcf6f44409a32"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"3216faf865437df8796d0c0b97aeb6ff2a1a07bf","unresolved":true,"context_lines":[{"line_number":1107,"context_line":"    cfg.BoolOpt(\u0027force_virtio_cd\u0027,"},{"line_number":1108,"context_line":"                default\u003dFalse,"},{"line_number":1109,"context_line":"                help\u003d\u0027Force the use of virtio driver for CDROM\u0027),"},{"line_number":1110,"context_line":"]"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"libvirt_volume_opts \u003d ["},{"line_number":1113,"context_line":"    cfg.BoolOpt(\u0027volume_use_multipath\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"6168d747_58372d76","line":1110,"in_reply_to":"ac92d03f_e5b79ca1","updated":"2025-07-02 13:43:47.000000000","message":"It\u0027s not. The config drive by default is AHCI, unless someone sets the metadata manually in the image or flavor. Though this doesn\u0027t work when a customer uploads their own image.","commit_id":"1c703cd1c749c42dc482af36e8afcf6f44409a32"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5100380464d2dacfbe59d0f3f7af2e0506da11bb","unresolved":true,"context_lines":[{"line_number":248,"context_line":"    if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":249,"context_line":"        if device_type \u003d\u003d \"cdrom\":"},{"line_number":250,"context_line":"            if CONF.libvirt.force_virtio_cd:"},{"line_number":251,"context_line":"                return \"virtio\""},{"line_number":252,"context_line":"            else:"},{"line_number":253,"context_line":"                guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":254,"context_line":"                if guestarch in ("}],"source_content_type":"text/x-python","patch_set":4,"id":"fafadb7d_309f1818","line":251,"updated":"2025-08-12 11:14:38.000000000","message":"by the way this error is why we did not do this in the past.\n\nwhen did libvirt and qemu gain supprot for this?\n```\n55483 351a77fcd964442da5f6f249c079ccba 7de9aa156fdf4642a493ed476f44a2fd - - default default] [instance: d2b5e998-ee86-4b9b-a410-b01b67df915a] Instance failed to spawn: libvirt.libvirtError: │\ndf915a] Traceback (most recent call last):                                                                                                                                                    │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/nova/compute/manager.py\", line 2886, in _build_resources                                                                     │\ndf915a]     yield resources                                                                                                                                                                   │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/nova/compute/manager.py\", line 2633, in _build_and_run_instance                                                              │\ndf915a]     self.driver.spawn(context, instance, image_meta,                                                                                                                                  │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/nova/virt/libvirt/driver.py\", line 4661, in spawn                                                                            │\ndf915a]     self._create_guest_with_network(                                                                                                                                                  │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/nova/virt/libvirt/driver.py\", line 8051, in _create_guest_with_network                                                       │\ndf915a]     with excutils.save_and_reraise_exception():                                                                                                                                       │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/oslo_utils/excutils.py\", line 227, in __exit__                                                                               │\ndf915a]     self.force_reraise()                                                                                                                                                              │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/oslo_utils/excutils.py\", line 200, in force_reraise                                                                          │\ndf915a]     raise self.value                                                                                                                                                                  │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/nova/virt/libvirt/driver.py\", line 8029, in _create_guest_with_network                                                       │\ndf915a]     guest \u003d self._create_guest(                                                                                                                                                       │\ndf915a]             ^^^^^^^^^^^^^^^^^^^                                                                                                                                                       │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/nova/virt/libvirt/driver.py\", line 7962, in _create_guest                                                                    │\ndf915a]     guest \u003d libvirt_guest.Guest.create(xml, self._host)                                                                                                                               │\ndf915a]             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                               │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/nova/virt/libvirt/guest.py\", line 153, in create                                                                             │\ndf915a]     with excutils.save_and_reraise_exception():                                                                                                                                       │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/oslo_utils/excutils.py\", line 227, in __exit__                                                                               │\ndf915a]     self.force_reraise()                                                                                                                                                              │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/oslo_utils/excutils.py\", line 200, in force_reraise                                                                          │\ndf915a]     raise self.value                                                                                                                                                                  │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/nova/virt/libvirt/guest.py\", line 151, in create                                                                             │\ndf915a]     guest \u003d host.write_instance_config(xml)                                                                                                                                           │\ndf915a]             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                           │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/nova/virt/libvirt/host.py\", line 1246, in write_instance_config                                                              │\ndf915a]     domain \u003d self.get_connection().defineXML(xml)                                                                                                                                     │\ndf915a]              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                     │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/eventlet/tpool.py\", line 186, in doit                                                                                        │\ndf915a]     result \u003d proxy_call(self._autowrap, f, *args, **kwargs)                                                                                                                           │\ndf915a]              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                           │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/eventlet/tpool.py\", line 144, in proxy_call                                                                                  │\ndf915a]     rv \u003d execute(f, *args, **kwargs)                                                                                                                                                  │\ndf915a]          ^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                  │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/eventlet/tpool.py\", line 125, in execute                                                                                     │\ndf915a]     raise e.with_traceback(tb)                                                                                                                                                        │\ndf915a]   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/eventlet/tpool.py\", line 82, in tworker                                                                                      │\ndf915a]     rv \u003d meth(*args, **kwargs)                                                                                                                                                        │\ndf915a]          ^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                        │\ndf915a]   File \"/usr/lib/python3/dist-packages/libvirt.py\", line 4495, in defineXML                                                                                                           │\ndf915a]     raise libvirtError(\u0027virDomainDefineXML() failed\u0027)                                                                                                                                 │\ndf915a] libvirt.libvirtError: unsupported configuration: disk type of \u0027vda\u0027 does not support ejectable media\n```\nthat is form my come cloud which is using a slithgly old version but ill try and test this in a newer libvirt env when i have time.\n\nby the way using hw_cdrom_bus scsi works, that uses virtio-scsi by default\nbut the reason not to use that int he past was windows.","commit_id":"1c703cd1c749c42dc482af36e8afcf6f44409a32"}]}