)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6e63732f6d8ba3655f54a891445249fc38676e2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-07-07 21:19:09 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clarify that [pci]device_spec\u003d{} matches all devices"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This changes adds a note in the conf parameter ``device_spec``"},{"line_number":10,"context_line":"to specify that setting empty device_spec ``device_spec\u003d{} in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"25b592be_d7434c50","line":7,"updated":"2025-07-07 16:14:35.000000000","message":"ah no that is ment to be invliad","commit_id":"ee356e92ffb07982f5a122ce1ad86b5eaa0eaa3c"}],"nova/conf/pci.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6e63732f6d8ba3655f54a891445249fc38676e2","unresolved":true,"context_lines":[{"line_number":326,"context_line":"   as the filter for matching devices and rest of the fields for enhancing"},{"line_number":327,"context_line":"   the matched device. That way an empty device_spec ``device_spec \u003d {}``"},{"line_number":328,"context_line":"   or a device_spec with only enhancing attributes will match all the devices"},{"line_number":329,"context_line":"   on the hypervisor."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  The following are invalid, as they specify mutually exclusive options::"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f1988c2c_06d2a487","line":329,"updated":"2025-07-07 16:14:35.000000000","message":"this is a bug it not intetional\n\nyou are require to pass either device id and vendor id \nor one of the 3 ways or passing an address or the deprecated devname\n\nbut an empty devstack shoudl alwasy be condired a config error.","commit_id":"ee356e92ffb07982f5a122ce1ad86b5eaa0eaa3c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffbc01128cccd1bb1e7a572e5bd104876e1967d6","unresolved":true,"context_lines":[{"line_number":326,"context_line":"   as the filter for matching devices and rest of the fields for enhancing"},{"line_number":327,"context_line":"   the matched device. That way an empty device_spec ``device_spec \u003d {}``"},{"line_number":328,"context_line":"   or a device_spec with only enhancing attributes will match all the devices"},{"line_number":329,"context_line":"   on the hypervisor."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  The following are invalid, as they specify mutually exclusive options::"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"655085a0_2bfb77a8","line":329,"in_reply_to":"dcd0b58c_1e0d1352","updated":"2025-07-07 17:14:06.000000000","message":"note that before that chagne the vendor id and product id were alwasy requried to pass the json schema validation \n\n\nhttps://github.com/openstack/nova/blob/fa2f139e22ed1317f4afe01faaf7ee3943444715/nova/pci/pci_whitelist.py#L40-L82\n\n\nthe docstring for the calss also capture the desired behvior\n\n```\n    White list class to decide assignable pci devices.\n\n    Not all devices on compute node can be assigned to guest, the\n    cloud administrator decides the devices that can be assigned\n    based on vendor_id or product_id etc. If no white list specified,\n    no device will be assignable.\n```\n\nhttps://github.com/openstack/nova/commit/5a8ae0f1d0c115b488992f98ceb077e1c23ea330\n\nadded the ability to use the address field with the glob to select specific devices, but also removed the assertion that vendor and product ID were always required, and failed to block an empty whitelist object from being accepted.\n\nits the combination of both patches that result in the bug.\n\nform a pci in palcmeent persecitive creating 10s or 100s  of nested resouce providers per host is very problmetic form a performance point of view.\n\nteh performance impact on the nova deb normlaly is less drastic but its still goign ot increase memory usage alot.\n\nweither we make it a hard error for nova when we are not suing pci in placment i think we shoudl make it a hard error when pci in placment reporting is enabled.\n\ni woudl prefer it to be an error in both cases but the pci in placemetn case it the most concerning one.","commit_id":"ee356e92ffb07982f5a122ce1ad86b5eaa0eaa3c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6bc9542d55e0c6164d1b2ed17ebe24e9198fbbe","unresolved":true,"context_lines":[{"line_number":326,"context_line":"   as the filter for matching devices and rest of the fields for enhancing"},{"line_number":327,"context_line":"   the matched device. That way an empty device_spec ``device_spec \u003d {}``"},{"line_number":328,"context_line":"   or a device_spec with only enhancing attributes will match all the devices"},{"line_number":329,"context_line":"   on the hypervisor."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  The following are invalid, as they specify mutually exclusive options::"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dcd0b58c_1e0d1352","line":329,"in_reply_to":"f1988c2c_06d2a487","updated":"2025-07-07 16:54:19.000000000","message":"this was unitnitlly added by the bash glob supprot\n\nhttps://review.opendev.org/c/openstack/nova/+/99043\n\n\nspecificly it intoduced this fallback to all  addreses\n\nhttps://github.com/openstack/nova/blob/juno-eol/nova/pci/pci_devspec.py#L147-L154\n\nhowever that was not part of the aggreed spec desging\n\nhttps://github.com/openstack/nova-specs/blob/79cce1f9aedcb02d99cd38abab05e53cd1aca452/specs/juno/implemented/pci-passthrough-sriov.rst#pci-whitelist\n\ndetials such as the intetionaly be have  to allow VF to be whitelisted usign teh PF address were captured in the spec\n\n```\nIf the device defined by the address or devname corresponds to a SR-IOV PF, all the VFs under the PF will match the entry.\n```\n\nbut the behavior to match everything was never discussed in the spec nor was it documented anywehre or tested.\n\nso this was from my perspective, an unintentional latent bug.\n\nwe shoudl create a functional repoducer for this and then make it an explict config error.","commit_id":"ee356e92ffb07982f5a122ce1ad86b5eaa0eaa3c"}]}