)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"094f4615ec698f10ad7780d612dd7d0014d17397","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f81b885_69f19f71","updated":"2025-07-25 13:15:51.000000000","message":"check experimental","commit_id":"508da63179a610cdf8021bd8afa107228a04a030"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b49637459787dbcfe41b0379c30da6de4c78188a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef4ceecd_d97976df","updated":"2025-07-25 13:14:26.000000000","message":"check-experimental","commit_id":"508da63179a610cdf8021bd8afa107228a04a030"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3f04c49360b2bc79c602804381dc3a37062abb10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5df4651e_1e006da4","updated":"2025-07-18 00:31:27.000000000","message":"recheck https://review.opendev.org/c/openstack/tempest/+/954949 has unblock nova-ceph-multistore","commit_id":"508da63179a610cdf8021bd8afa107228a04a030"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3abe4e6d993715893a879ae28ddc4e4d03709060","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bca374bf_aa4c2422","in_reply_to":"179a6757_c5a6c260","updated":"2025-07-25 13:15:08.000000000","message":"actully im not sure if devstack-plugin-nfs-tempest-full is nova on nfs or if its cinder nfs btu we will see when it runs.","commit_id":"508da63179a610cdf8021bd8afa107228a04a030"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35a0991c67a2dc892fef7b286f6daddf4b007907","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9d6d0ab_1579d21e","in_reply_to":"5df4651e_1e006da4","updated":"2025-07-24 22:36:52.000000000","message":"so the issue that htis is related to only happen with nfs voluem correct?\n\nim not going to ask you to finally go impleht the chagne to add cinder nfs to oen fo rour josb but we shoudl add it to nova-ovs-hybrid-plug in teh future.\n\nthats a multi node job that we can trivally add nfs too without impacting the other tests its running.\n\nthat leave nova-live-migration to test with lvm and nova-live-migration-cpeh obviouly will cover the ceph case.\n\n\nwe aslo need to test with /var/lib/nova on nfs at some point but that can be done in one of the other jobs if needed. we currently don have any testing of nova on an nfs share for \"local\" storage that im aware of in the ci.","commit_id":"508da63179a610cdf8021bd8afa107228a04a030"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b49637459787dbcfe41b0379c30da6de4c78188a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"179a6757_c5a6c260","in_reply_to":"c74f6bdf_eadbf3d3","updated":"2025-07-25 13:14:26.000000000","message":"we actully have an experimatl job so ill trigger that now.","commit_id":"508da63179a610cdf8021bd8afa107228a04a030"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6829d4b5770fb6fd6bba6be1e3c263f9a6ac6ece","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c74f6bdf_eadbf3d3","in_reply_to":"c9d6d0ab_1579d21e","updated":"2025-07-24 23:04:43.000000000","message":"I would expect so, yes.\n\nYep definitely agree with you, we have no NFS testing that I\u0027m aware of and I think we really need it. My plan for this patch was literally to run Cinder\u0027s NFS job and write a Tempest test to run on it to repro and to verify if this fix works.\n\nIt would be nice to have NFS in our own gate. I\u0027ll probably look into it to see how difficult or easy it might be. I\u0027ve tinkered with NFS job in the past to test stuff one-off for myself so there is a chance I could do it.","commit_id":"508da63179a610cdf8021bd8afa107228a04a030"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"80d04a162fddc35542b236725dd031ba96bb3233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"265fc8c2_be1bd9f4","updated":"2025-07-31 22:25:24.000000000","message":"Bug is reproduced here:\n\nhttps://review.opendev.org/c/openstack/nova/+/956282/3#message-79ced999e785e8781a2d158c6b6fbb5b8e398f4c\n\nwhere deleting the latest snapshot works but the attempt to delete the older snapshot fails.","commit_id":"9aee091e969439049565dede53199a22bf92b50b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"84614b8d70124042b7d97aa128cd74fadb8cfd75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bdb2281a_1ed1ff36","updated":"2025-07-31 22:29:35.000000000","message":"recheck updated tempest test to create and delete 3 snapshots","commit_id":"9aee091e969439049565dede53199a22bf92b50b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"06131b639bb6951e4888ded1309c2816d9440b53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8235e74_6dd82698","in_reply_to":"265fc8c2_be1bd9f4","updated":"2025-08-01 00:36:29.000000000","message":"++ we cna see cinder error also about invalid backing file\n\nhttps://zuul.opendev.org/t/openstack/build/c68c0479054f47d08d47535f2625a7b8/log/controller/logs/screen-c-vol.txt#9067","commit_id":"9aee091e969439049565dede53199a22bf92b50b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e5897e21cb785afc586fdc06d7ccb85a2af74a80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d4d74883_3ae8f489","updated":"2025-08-27 02:41:30.000000000","message":"Thanks for the review!","commit_id":"668d9d37f8ec1e8c9729c13f4d9f0435303a22fb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bdbe5594398bb6dde8240bf408aea1354c5b69c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e06ae2f6_0f1bf7f3","updated":"2025-08-06 00:07:25.000000000","message":"check experimental","commit_id":"668d9d37f8ec1e8c9729c13f4d9f0435303a22fb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"447357a57e770fbda0bbf092750ba98c85ca9b25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"af08b455_919b163b","updated":"2025-08-06 03:39:17.000000000","message":"lgtm.\n\nNew Test is added in tempest to reproduce the bug and test the fix - https://zuul.opendev.org/t/openstack/build/5eb6603d701e41a0a43ed8b50ca0d67a/log/job-output.txt#24206\n\nBug was reproduced - https://review.opendev.org/c/openstack/nova/+/956282/3#message-79ced999e785e8781a2d158c6b6fbb5b8e398f4c\n\nWith this fix, test passing - https://zuul.opendev.org/t/openstack/build/5eb6603d701e41a0a43ed8b50ca0d67a/log/job-output.txt#24206","commit_id":"668d9d37f8ec1e8c9729c13f4d9f0435303a22fb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c7ec375290354f484864763b0001b2040e7b703a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"31a1c66a_7ba84f5f","in_reply_to":"e06ae2f6_0f1bf7f3","updated":"2025-08-06 00:11:25.000000000","message":"ah this would not run the test as tempest chnage depends on it.","commit_id":"668d9d37f8ec1e8c9729c13f4d9f0435303a22fb"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77ab4b4a9ed829ca9990eda3118e7c972b8cdeb2","unresolved":false,"context_lines":[{"line_number":3816,"context_line":"            backing_file \u003d \"\""},{"line_number":3817,"context_line":"            qemu_img_extra_arg \u003d []"},{"line_number":3818,"context_line":"        else:"},{"line_number":3819,"context_line":"            # If the rebased image is going to have a backing file then"},{"line_number":3820,"context_line":"            # explicitly set the backing file format to avoid any security"},{"line_number":3821,"context_line":"            # concerns related to file format auto detection."},{"line_number":3822,"context_line":"            backing_file \u003d rebase_base"},{"line_number":3823,"context_line":""},{"line_number":3824,"context_line":"            # We will need the absolute path to the backing file in order to"}],"source_content_type":"text/x-python","patch_set":4,"id":"ad7fe482_cf0753c5","line":3821,"range":{"start_line":3819,"start_character":11,"end_line":3821,"end_character":61},"updated":"2025-08-27 02:34:08.000000000","message":"nit this comment feels like it should be on line 3838\n\nbut i guess it a comment for the entire else branch it just feels a bit odd to be so far form where we actully doing the format setting.\n\nanyway im not askign you to change this it just took me 3 time to undersatned that this comment applied ot the full else branch and not just line 3822","commit_id":"668d9d37f8ec1e8c9729c13f4d9f0435303a22fb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e5897e21cb785afc586fdc06d7ccb85a2af74a80","unresolved":false,"context_lines":[{"line_number":3816,"context_line":"            backing_file \u003d \"\""},{"line_number":3817,"context_line":"            qemu_img_extra_arg \u003d []"},{"line_number":3818,"context_line":"        else:"},{"line_number":3819,"context_line":"            # If the rebased image is going to have a backing file then"},{"line_number":3820,"context_line":"            # explicitly set the backing file format to avoid any security"},{"line_number":3821,"context_line":"            # concerns related to file format auto detection."},{"line_number":3822,"context_line":"            backing_file \u003d rebase_base"},{"line_number":3823,"context_line":""},{"line_number":3824,"context_line":"            # We will need the absolute path to the backing file in order to"}],"source_content_type":"text/x-python","patch_set":4,"id":"be8ce8e7_195cdc62","line":3821,"range":{"start_line":3819,"start_character":11,"end_line":3821,"end_character":61},"in_reply_to":"ad7fe482_cf0753c5","updated":"2025-08-27 02:41:30.000000000","message":"I see what you mean, I just had not thought about moving the comment from its original location 🙁","commit_id":"668d9d37f8ec1e8c9729c13f4d9f0435303a22fb"}]}
