)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a2c7726744038f45ff5954d41ebdeb51feedb87","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Watson \u003cianwatson92@hotmail.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-07-23 12:14:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing provider_tree removal upon 409 in set_aggregates_for_provider for race condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #2117697"},{"line_number":10,"context_line":"Change-Id: Iead20354a067573a71efe742ebc504621460d6a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7fb3382f_f7e25ac8","line":7,"updated":"2025-07-23 13:57:39.000000000","message":"Please also take a moment to read https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure and update the commit message structure accordingly.\n\nAlso it\u0027s considered to be a best practice to explain why we need this change, instead of how code is changed actually.","commit_id":"e11836c3e9f351a20725ce363fac4bb286c387fa"},{"author":{"_account_id":38234,"name":"Ian Watson","display_name":"Ian Watson","email":"ianwatson92@hotmail.co.uk","username":"ianwatsonit"},"change_message_id":"fa1f5afb5f1afa37c9b736ebbc2de1c413de40fb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Watson \u003cianwatson92@hotmail.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-07-23 12:14:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing provider_tree removal upon 409 in set_aggregates_for_provider for race condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #2117697"},{"line_number":10,"context_line":"Change-Id: Iead20354a067573a71efe742ebc504621460d6a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8cb505d8_686d438c","line":7,"in_reply_to":"7fb3382f_f7e25ac8","updated":"2025-07-30 09:34:36.000000000","message":"Done","commit_id":"e11836c3e9f351a20725ce363fac4bb286c387fa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"79df1f05a1c2f5ea4698256a810a81f454c0fcfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9aa6d591_8c0207bc","updated":"2025-09-22 09:59:45.000000000","message":"-1 for the invalid comment, though I think there may be more wrong here.","commit_id":"9a60536aff2d2db2d70e7d303e20a4d16cb51234"},{"author":{"_account_id":38234,"name":"Ian Watson","display_name":"Ian Watson","email":"ianwatson92@hotmail.co.uk","username":"ianwatsonit"},"change_message_id":"bfd002188b4eeb33a5de3d4be12e7e09753564ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"43bac527_82a0b0c5","updated":"2025-08-06 14:12:12.000000000","message":"recheck","commit_id":"9a60536aff2d2db2d70e7d303e20a4d16cb51234"},{"author":{"_account_id":38234,"name":"Ian Watson","display_name":"Ian Watson","email":"ianwatson92@hotmail.co.uk","username":"ianwatsonit"},"change_message_id":"fa1f5afb5f1afa37c9b736ebbc2de1c413de40fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8ad667c4_1ecb8a6d","updated":"2025-07-30 09:34:36.000000000","message":"recheck","commit_id":"9a60536aff2d2db2d70e7d303e20a4d16cb51234"},{"author":{"_account_id":38234,"name":"Ian Watson","display_name":"Ian Watson","email":"ianwatson92@hotmail.co.uk","username":"ianwatsonit"},"change_message_id":"c2245ef6e0ad87faf37561d85be2a348e88a5c33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f1710c0_161e9cd8","updated":"2025-07-30 15:00:24.000000000","message":"recheck","commit_id":"9a60536aff2d2db2d70e7d303e20a4d16cb51234"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"79df1f05a1c2f5ea4698256a810a81f454c0fcfb","unresolved":true,"context_lines":[{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"        # If a conflict, invalidate the cache and raise special exception"},{"line_number":1216,"context_line":"        if resp.status_code \u003d\u003d 409:"},{"line_number":1217,"context_line":"            # No reason to condition cache invalidation on use_cache - if we"},{"line_number":1218,"context_line":"            # got a 409, the cache entry is still bogus if it exists; and the"},{"line_number":1219,"context_line":"            # below is a no-op if it doesn\u0027t."},{"line_number":1220,"context_line":"            try:"},{"line_number":1221,"context_line":"                self._provider_tree.remove(rp_uuid)"},{"line_number":1222,"context_line":"            except ValueError:"},{"line_number":1223,"context_line":"                pass"},{"line_number":1224,"context_line":"            self._association_refresh_time.pop(rp_uuid, None)"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"            LOG.warning(msg, args)"},{"line_number":1227,"context_line":"            raise exception.ResourceProviderUpdateConflict("}],"source_content_type":"text/x-python","patch_set":3,"id":"d66542ec_858ae9ec","side":"PARENT","line":1224,"range":{"start_line":1217,"start_character":0,"end_line":1224,"end_character":61},"updated":"2025-09-22 09:59:45.000000000","message":"Won\u0027t us *not* doing this put us in a permafailing state going forward? We don\u0027t provide a generation in the call to this method from `update_from_provider_tree`, which in turn means we will always use the (incorrect) generation from the cache, as highlighted above? Have I missed something (we could probably do with a comment here if I have)","commit_id":"6053bb27228d5f43a3112fcdece5c01229feef31"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"79df1f05a1c2f5ea4698256a810a81f454c0fcfb","unresolved":true,"context_lines":[{"line_number":1159,"context_line":"                 failure."},{"line_number":1160,"context_line":"        \"\"\""},{"line_number":1161,"context_line":"        # If a generation is specified, it trumps whatever\u0027s in the cache."},{"line_number":1162,"context_line":"        # Otherwise..."},{"line_number":1163,"context_line":"        if generation is None:"},{"line_number":1164,"context_line":"            if use_cache:"},{"line_number":1165,"context_line":"                generation \u003d self._provider_tree.data(rp_uuid).generation"},{"line_number":1166,"context_line":"            else:"},{"line_number":1167,"context_line":"                # Either cache or generation is required"},{"line_number":1168,"context_line":"                raise ValueError("}],"source_content_type":"text/x-python","patch_set":3,"id":"be0eca07_d97bea42","line":1165,"range":{"start_line":1162,"start_character":22,"end_line":1165,"end_character":73},"updated":"2025-09-22 09:59:45.000000000","message":"Here","commit_id":"9a60536aff2d2db2d70e7d303e20a4d16cb51234"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"79df1f05a1c2f5ea4698256a810a81f454c0fcfb","unresolved":true,"context_lines":[{"line_number":1212,"context_line":"            \u0027err_text\u0027: resp.text,"},{"line_number":1213,"context_line":"        }"},{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"        # If a conflict, invalidate the cache and raise special exception"},{"line_number":1216,"context_line":"        if resp.status_code \u003d\u003d 409:"},{"line_number":1217,"context_line":"            LOG.warning(msg, args)"},{"line_number":1218,"context_line":"            raise exception.ResourceProviderUpdateConflict("}],"source_content_type":"text/x-python","patch_set":3,"id":"62d6f0ce_23dbbbfb","line":1215,"updated":"2025-09-22 09:59:45.000000000","message":"This is no longer true","commit_id":"9a60536aff2d2db2d70e7d303e20a4d16cb51234"}]}