)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"283c0863d49e763503224969b37f795a1d27e69d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7bc5fdcb_43bddd44","updated":"2025-12-12 17:49:48.000000000","message":"+1\nthere is an exisging but in the logic of the in_use calualtion \ncan you submit a fix up patch for this and ill upgrade to +2","commit_id":"8eae0ecdd95d040dfb4a7d5b4d6d8653e2fc9dd5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1662ae87691d80f1607171e0a26104fd7dec8cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b82980c_da9eef5f","updated":"2026-01-15 03:06:01.000000000","message":"lgtm","commit_id":"8eae0ecdd95d040dfb4a7d5b4d6d8653e2fc9dd5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c2315311af730c008603cbd7f1c54aa717973fb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0cd9b6db_f7314583","updated":"2025-12-16 16:54:05.000000000","message":"thanks we can discuss the follow up patch seperate on that review","commit_id":"8eae0ecdd95d040dfb4a7d5b4d6d8653e2fc9dd5"}],"nova/api/openstack/compute/schemas/limits.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"283c0863d49e763503224969b37f795a1d27e69d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"index_query_v275 \u003d copy.deepcopy(index_query)"},{"line_number":31,"context_line":"index_query_v275[\u0027additionalProperties\u0027] \u003d False"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_absolute_quota_response \u003d {"},{"line_number":34,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":35,"context_line":"    \u0027properties\u0027: {"},{"line_number":36,"context_line":"        \u0027maxImageMeta\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"af3ab072_9d08c310","line":33,"updated":"2025-12-12 17:49:48.000000000","message":"https://docs.openstack.org/api-ref/compute/#id247","commit_id":"8eae0ecdd95d040dfb4a7d5b4d6d8653e2fc9dd5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"283c0863d49e763503224969b37f795a1d27e69d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \u0027totalRAMUsed\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":53,"context_line":"        \u0027totalSecurityGroupsUsed\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":54,"context_line":"        \u0027totalServerGroupsUsed\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":55,"context_line":"    },"},{"line_number":56,"context_line":"    \u0027required\u0027: ["},{"line_number":57,"context_line":"        \u0027maxImageMeta\u0027,"},{"line_number":58,"context_line":"        \u0027maxPersonality\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"79e9a83a_a18ff0c3","line":55,"updated":"2025-12-12 17:49:48.000000000","message":"the -1 is very imporant to supprot for unlimted qutoas -2 would be wrong however so setting minium makes sense","commit_id":"8eae0ecdd95d040dfb4a7d5b4d6d8653e2fc9dd5"}],"nova/tests/unit/api/openstack/compute/test_limits.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"283c0863d49e763503224969b37f795a1d27e69d","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    return {"},{"line_number":60,"context_line":"        k: {\u0027limit\u0027: v, \u0027in_use\u0027: v // 2}"},{"line_number":61,"context_line":"        for k, v in absolute_limits.items()"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1b7672d7_2506fe19","line":60,"updated":"2025-12-12 17:49:48.000000000","message":"`v // 2` is not the same as int(v/2)\n\nso for -1\n\n\n\u003e\u003e\u003e int(-3/2)\n-1\n\u003e\u003e\u003e -3 // 2\n-2\n\u003e\u003e\u003e -1 // 2\n-1\n\u003e\u003e\u003e int(-1/2)\n0\n\nsetting in use to half for finite limits is fine but if its -1 we ether need to \nclamp this to a min value of 0 or we shoudul be doing somethign esle bcuase it never makes sense to have in use be less the 0\n\n\n\n```suggestion\n        k: {\u0027limit\u0027: v, \u0027in_use\u0027: min(0,v // 2)}\n```","commit_id":"8eae0ecdd95d040dfb4a7d5b4d6d8653e2fc9dd5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6dbd882ac8fa45ac7160373e3018e924218fbea1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    return {"},{"line_number":60,"context_line":"        k: {\u0027limit\u0027: v, \u0027in_use\u0027: v // 2}"},{"line_number":61,"context_line":"        for k, v in absolute_limits.items()"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"59120e41_e7f183bc","line":60,"in_reply_to":"1b7672d7_2506fe19","updated":"2025-12-15 13:11:47.000000000","message":"Good point. Done https://review.opendev.org/c/openstack/nova/+/971038","commit_id":"8eae0ecdd95d040dfb4a7d5b4d6d8653e2fc9dd5"}]}