)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"339131a718aff24f9b9c99fcd8472d56aea27cbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f333147e_fa01773e","updated":"2026-01-15 03:29:55.000000000","message":"lgtm, one comment about \u0027network\u0027 field.","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"65669e5eeaed7600f44b6c69299ff702254e8062","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cc769027_9fef9914","updated":"2025-12-15 13:11:57.000000000","message":"recheck unhappy CI","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"737cf87aa8f8b9a56c68b9ed38c0cc3aac50633b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d052c272_24739d45","updated":"2025-11-12 13:19:37.000000000","message":"recheck unrelated failure","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f6f42273afbfa265fa552192afe7e9e9e7f32369","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b0ee363f_5950fbd8","updated":"2026-01-24 02:34:50.000000000","message":"recheck timeout in test_rebuild_server_with_auto_disk_config","commit_id":"c63a2bba9d103fe7e52e128b964762a258cfa583"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a002f574ff5ad82260635a1fd84abcec54a71b45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"80d352e5_337b62a2","updated":"2026-01-23 13:47:26.000000000","message":"recheck unrelated qemu issue","commit_id":"c63a2bba9d103fe7e52e128b964762a258cfa583"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"89164682badcc32f0b496b9bcb4534fcd8e09662","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"326926b9_1272f71a","updated":"2026-01-23 17:18:09.000000000","message":"recheck volume status issue in test_attach_cloned_encrypted_volume","commit_id":"c63a2bba9d103fe7e52e128b964762a258cfa583"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a28f0c338487421119d78ff92f512fa7374072d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e5a0306e_ac9eb9aa","updated":"2026-01-23 17:17:58.000000000","message":"thanks for followup, lgtm","commit_id":"c63a2bba9d103fe7e52e128b964762a258cfa583"}],"nova/api/openstack/compute/schemas/quota_classes.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"413005357572925ad29efc5e2b43ec36888d5e49","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"_quota_response \u003d {"},{"line_number":57,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":58,"context_line":"    \u0027properties\u0027: {"},{"line_number":59,"context_line":"        \u0027cores\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"c8f4a3c5_aecda378","line":56,"updated":"2025-12-12 17:57:57.000000000","message":"https://docs.openstack.org/api-ref/compute/#id343\nwe expect change in 2.50 and 2.57","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"339131a718aff24f9b9c99fcd8472d56aea27cbb","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        \u0027instances\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":66,"context_line":"        \u0027key_pairs\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":67,"context_line":"        \u0027metadata_items\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":68,"context_line":"        \u0027networks\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":69,"context_line":"        \u0027ram\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":70,"context_line":"        \u0027security_groups\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":71,"context_line":"        \u0027security_group_rules\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"29c18757_baf254ab","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":55},"updated":"2026-01-15 03:29:55.000000000","message":"I could not find where we return \u0027network\u0027 from API?","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ca3c0f7c995c6bb057b306bf0d1c858df438718","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027instances\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":66,"context_line":"        \u0027key_pairs\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":67,"context_line":"        \u0027metadata_items\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":68,"context_line":"        \u0027networks\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":69,"context_line":"        \u0027ram\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":70,"context_line":"        \u0027security_groups\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":71,"context_line":"        \u0027security_group_rules\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"62454086_83ef7b61","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":55},"in_reply_to":"1a1f5699_fec92b36","updated":"2026-01-23 13:47:14.000000000","message":"Okay, let\u0027s continue this discussion on a follow-up https://review.opendev.org/c/openstack/nova/+/974417","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af4c26a95fd45dae00ac6d58cfcd1af5529e88c0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027instances\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":66,"context_line":"        \u0027key_pairs\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":67,"context_line":"        \u0027metadata_items\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":68,"context_line":"        \u0027networks\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":69,"context_line":"        \u0027ram\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":70,"context_line":"        \u0027security_groups\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":71,"context_line":"        \u0027security_group_rules\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"fce9ade2_a3b38045","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":55},"in_reply_to":"29c18757_baf254ab","updated":"2026-01-21 14:23:44.000000000","message":"We don\u0027t return it any more but we used to. We removed it in I352b71b5976d008c2b8fab8a6d6939c0e0b305be. Our API schemas should be unversioned like our api-ref docs are. That means we need to document all fields and APIs, even those that we have now removed.","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d69ece231b72b974a58f0c6612387da8af2347dd","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        \u0027instances\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":66,"context_line":"        \u0027key_pairs\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":67,"context_line":"        \u0027metadata_items\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":68,"context_line":"        \u0027networks\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":69,"context_line":"        \u0027ram\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":70,"context_line":"        \u0027security_groups\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":71,"context_line":"        \u0027security_group_rules\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"c894ae63_b2385173","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":55},"in_reply_to":"bbce0589_2b61d597","updated":"2026-01-21 18:35:53.000000000","message":"but do you think client will support train? I am ok to support old versions but keeping removed stuff/fields in master or supported stable release schema will create the confusion. If these schema are imported into the api-ref then user will be confused seeing this \u0027network\u0027 field.\n\nIMO, if we want to let client handle it then we can keep it as commented field with notes and client can add it manually or with additional schema.","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0dec3d3e8edbc8f47dcd41a79295ab3fc9bbd0ba","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        \u0027instances\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":66,"context_line":"        \u0027key_pairs\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":67,"context_line":"        \u0027metadata_items\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":68,"context_line":"        \u0027networks\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":69,"context_line":"        \u0027ram\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":70,"context_line":"        \u0027security_groups\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":71,"context_line":"        \u0027security_group_rules\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1f5699_fec92b36","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":55},"in_reply_to":"c894ae63_b2385173","updated":"2026-01-22 18:49:39.000000000","message":"just a note, I am ok to fix it (if you agree) in followup and do not want whole series to rebase for this comemnt.","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3938111070b89dc2984ab76e5f418639c1f59c38","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027instances\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":66,"context_line":"        \u0027key_pairs\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":67,"context_line":"        \u0027metadata_items\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":68,"context_line":"        \u0027networks\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":69,"context_line":"        \u0027ram\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":70,"context_line":"        \u0027security_groups\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":71,"context_line":"        \u0027security_group_rules\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"bbce0589_2b61d597","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":55},"in_reply_to":"ee59da15_85536e6d","updated":"2026-01-21 16:58:57.000000000","message":"It\u0027s present in version 20.x.x (Train) and before. If we want to be able to generate clients from our schemas then those clients need to support the older versions, which means our schemas need to document these. The alternative is to do something like \"layer on\" these additional fields via our client generator, but the presents its own set of problems and complexity.\n\nI have a `NOTE` left in this file regarding the fact that these fields don\u0027t actually exist anymore. Could we defer a decision on this for now and revisit when we get to the point of generating docs and clients from these schemas?","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69ee9e732ccac3c7951c4baa1e4b8a0fec4c3866","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027instances\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":66,"context_line":"        \u0027key_pairs\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":67,"context_line":"        \u0027metadata_items\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":68,"context_line":"        \u0027networks\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":69,"context_line":"        \u0027ram\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":70,"context_line":"        \u0027security_groups\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":71,"context_line":"        \u0027security_group_rules\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"}],"source_content_type":"text/x-python","patch_set":5,"id":"ee59da15_85536e6d","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":55},"in_reply_to":"fce9ade2_a3b38045","updated":"2026-01-21 16:36:18.000000000","message":"but my point is that it is removed from all versions right and keeping it here will create confusion that it is still retunred. If we want to keep the old release ref then I think we keep them in obsolete or deprecated section but not in the main schema/api-ref. or we explicitly mention about the last release for this field (like we do for microversions) but I do not know if we can do that in json schema","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"339131a718aff24f9b9c99fcd8472d56aea27cbb","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        \u0027security_group_rules\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":72,"context_line":"    },"},{"line_number":73,"context_line":"    \u0027required\u0027: ["},{"line_number":74,"context_line":"        # only networks is optional (it only appears under nova-network)"},{"line_number":75,"context_line":"        \u0027cores\u0027,"},{"line_number":76,"context_line":"        \u0027fixed_ips\u0027,"},{"line_number":77,"context_line":"        \u0027floating_ips\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"89279c2f_f50d5e3f","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":72},"updated":"2026-01-15 03:29:55.000000000","message":"it means it is not returned now as nova-network is gone","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af4c26a95fd45dae00ac6d58cfcd1af5529e88c0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \u0027security_group_rules\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: -1},"},{"line_number":72,"context_line":"    },"},{"line_number":73,"context_line":"    \u0027required\u0027: ["},{"line_number":74,"context_line":"        # only networks is optional (it only appears under nova-network)"},{"line_number":75,"context_line":"        \u0027cores\u0027,"},{"line_number":76,"context_line":"        \u0027fixed_ips\u0027,"},{"line_number":77,"context_line":"        \u0027floating_ips\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d99de9b3_80baf1aa","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":72},"in_reply_to":"89279c2f_f50d5e3f","updated":"2026-01-21 14:23:44.000000000","message":"Correct. However, as noted above, our API schemas are supposed to document all versions of the nova API including those found on older Nova releases. We need to document this field because an older release of nova included it.","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"413005357572925ad29efc5e2b43ec36888d5e49","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    del _quota_response_v257[\u0027properties\u0027][field]"},{"line_number":112,"context_line":"    _quota_response_v257[\u0027required\u0027].pop("},{"line_number":113,"context_line":"        _quota_response_v257[\u0027required\u0027].index(field)"},{"line_number":114,"context_line":"    )"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"show_response \u003d {"},{"line_number":117,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"2fcd4b85_251187bc","line":114,"updated":"2025-12-12 17:57:57.000000000","message":"yep these all checkout","commit_id":"16ec92c3d65a2634ef0a8a01b0fe9d7e1cf359c8"}]}