)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9dbb98e5d8ff5f060a0aa035b14651f0c0e955b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0e0a825_8dc0ad9f","updated":"2025-08-08 15:24:16.000000000","message":"the tap createion woudl be delegate to os-vif\n\nthe enablment for this need to come form a flag in the prot binding:details filed\nthat shoudl be set by neutron\u0027s ml2 driver.\n\nthis will requrie changes to the nova/network/neutron module","commit_id":"24a8515b857f3263e4e4a6b6bbfa3d7d8234b95a"},{"author":{"_account_id":26832,"name":"Stefan Hoffmann","email":"stefan.hoffmann@cloudandheat.com","username":"shoffmann"},"change_message_id":"188dd60463b28fc861fb1eca8e0976e76d92d4c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"92c2bbc4_9cdb2ff6","in_reply_to":"d0e0a825_8dc0ad9f","updated":"2025-08-11 08:43:10.000000000","message":"I also had in mind, that the enablement should come from port binding, but wanted it easy for the POC. But if you want, I can add it here already.","commit_id":"24a8515b857f3263e4e4a6b6bbfa3d7d8234b95a"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9dbb98e5d8ff5f060a0aa035b14651f0c0e955b1","unresolved":true,"context_lines":[{"line_number":736,"context_line":"            # neutron if port fits the requirements"},{"line_number":737,"context_line":"            # let nova create the interface -\u003e neutron/ovn sees if the"},{"line_number":738,"context_line":"            # interface is configured"},{"line_number":739,"context_line":"            self.plug_tap(instance, vif)"},{"line_number":740,"context_line":"            return"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        # Legacy non-os-vif codepath"}],"source_content_type":"text/x-python","patch_set":2,"id":"17b0daa9_9ab42317","line":739,"updated":"2025-08-08 15:24:16.000000000","message":"-1 this shoudl be done in os_vif","commit_id":"24a8515b857f3263e4e4a6b6bbfa3d7d8234b95a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"05ceedc36bbe13bbacaf08e1215be76628d5e79a","unresolved":true,"context_lines":[{"line_number":736,"context_line":"            # neutron if port fits the requirements"},{"line_number":737,"context_line":"            # let nova create the interface -\u003e neutron/ovn sees if the"},{"line_number":738,"context_line":"            # interface is configured"},{"line_number":739,"context_line":"            self.plug_tap(instance, vif)"},{"line_number":740,"context_line":"            return"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        # Legacy non-os-vif codepath"}],"source_content_type":"text/x-python","patch_set":2,"id":"d7acbdee_e63497e0","line":739,"range":{"start_line":739,"start_character":17,"end_line":739,"end_character":25},"updated":"2025-08-08 15:33:57.000000000","message":"by the way moving plug_tap to os-vif has been a todo for like 10 years. as has been remvoing the non os-vif codepaths we have just not gotten around to it so we shoudl avoid adding more usage of the legacy functions.","commit_id":"24a8515b857f3263e4e4a6b6bbfa3d7d8234b95a"},{"author":{"_account_id":26832,"name":"Stefan Hoffmann","email":"stefan.hoffmann@cloudandheat.com","username":"shoffmann"},"change_message_id":"188dd60463b28fc861fb1eca8e0976e76d92d4c5","unresolved":true,"context_lines":[{"line_number":736,"context_line":"            # neutron if port fits the requirements"},{"line_number":737,"context_line":"            # let nova create the interface -\u003e neutron/ovn sees if the"},{"line_number":738,"context_line":"            # interface is configured"},{"line_number":739,"context_line":"            self.plug_tap(instance, vif)"},{"line_number":740,"context_line":"            return"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        # Legacy non-os-vif codepath"}],"source_content_type":"text/x-python","patch_set":2,"id":"6155f431_0d52f92d","line":739,"in_reply_to":"17b0daa9_9ab42317","updated":"2025-08-11 08:43:10.000000000","message":"Good hint. Should I do that in the POC or keep it for the actual implementation and add it to the spec/neutron rfc for now?","commit_id":"24a8515b857f3263e4e4a6b6bbfa3d7d8234b95a"},{"author":{"_account_id":26832,"name":"Stefan Hoffmann","email":"stefan.hoffmann@cloudandheat.com","username":"shoffmann"},"change_message_id":"ac89588bb01a1a66888b6731c180fe0ae3bf2420","unresolved":true,"context_lines":[{"line_number":736,"context_line":"            # neutron if port fits the requirements"},{"line_number":737,"context_line":"            # let nova create the interface -\u003e neutron/ovn sees if the"},{"line_number":738,"context_line":"            # interface is configured"},{"line_number":739,"context_line":"            self.plug_tap(instance, vif)"},{"line_number":740,"context_line":"            return"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        # Legacy non-os-vif codepath"}],"source_content_type":"text/x-python","patch_set":2,"id":"2266fd9b_cc278da0","line":739,"in_reply_to":"6155f431_0d52f92d","updated":"2025-08-11 09:14:22.000000000","message":"I updated the rfe: https://bugs.launchpad.net/neutron/+bug/2069718\n\nWe need a good name for the flag.","commit_id":"24a8515b857f3263e4e4a6b6bbfa3d7d8234b95a"}]}