)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"8fb1476c0f78964378751918bccd1a40cf42a237","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d3787a9e_9c715910","updated":"2025-08-12 06:03:35.000000000","message":"minor nits, otherwise LGTM.","commit_id":"0e0ff1e0f9c054110db4a226dc91b66575b36703"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"8fb1476c0f78964378751918bccd1a40cf42a237","unresolved":true,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"# VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":316,"context_line":"def _nova_to_osvif_vif_bridge(vif):"},{"line_number":317,"context_line":"    obj \u003d _get_vif_instance("},{"line_number":318,"context_line":"        vif,"},{"line_number":319,"context_line":"        objects.vif.VIFBridge,"}],"source_content_type":"text/x-python","patch_set":1,"id":"79da2b04_47fd6a18","line":316,"range":{"start_line":316,"start_character":4,"end_line":316,"end_character":29},"updated":"2025-08-12 06:03:35.000000000","message":"we should remove this function as well.","commit_id":"0e0ff1e0f9c054110db4a226dc91b66575b36703"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2bee4201e8ba3fa4b27dd7f2b867d4fd78376c2","unresolved":true,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"# VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":316,"context_line":"def _nova_to_osvif_vif_bridge(vif):"},{"line_number":317,"context_line":"    obj \u003d _get_vif_instance("},{"line_number":318,"context_line":"        vif,"},{"line_number":319,"context_line":"        objects.vif.VIFBridge,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2bace5f_7eff2c53","line":316,"range":{"start_line":316,"start_character":4,"end_line":316,"end_character":29},"in_reply_to":"79da2b04_47fd6a18","updated":"2025-08-12 10:51:28.000000000","message":"ya we can its now unused.","commit_id":"0e0ff1e0f9c054110db4a226dc91b66575b36703"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e478979d64d205cf74359991b70c680db2e06506","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"# VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":316,"context_line":"def _nova_to_osvif_vif_bridge(vif):"},{"line_number":317,"context_line":"    obj \u003d _get_vif_instance("},{"line_number":318,"context_line":"        vif,"},{"line_number":319,"context_line":"        objects.vif.VIFBridge,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fc8dbd60_888cb703","line":316,"range":{"start_line":316,"start_character":4,"end_line":316,"end_character":29},"in_reply_to":"a2bace5f_7eff2c53","updated":"2025-08-13 19:11:51.000000000","message":"Done","commit_id":"0e0ff1e0f9c054110db4a226dc91b66575b36703"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c761861f2b9bf031b2c14721fa166fa80ba5f1b4","unresolved":true,"context_lines":[{"line_number":533,"context_line":"    if vif_type \u003d\u003d model.VIF_TYPE_OVS:"},{"line_number":534,"context_line":"        vif_obj \u003d _nova_to_osvif_vif_ovs(vif)"},{"line_number":535,"context_line":"    elif vif_type \u003d\u003d model.VIF_TYPE_IVS:"},{"line_number":536,"context_line":"        vif_obj \u003d _nova_to_osvif_vif_ivs(vif)"},{"line_number":537,"context_line":"    elif vif_type \u003d\u003d model.VIF_TYPE_BRIDGE:"},{"line_number":538,"context_line":"        # Linux bridge support has been removed from Nova"},{"line_number":539,"context_line":"        raise exception.NovaException("},{"line_number":540,"context_line":"            \u0027Linux bridge VIF type is no longer supported\u0027)"},{"line_number":541,"context_line":"    elif vif_type \u003d\u003d model.VIF_TYPE_AGILIO_OVS:"},{"line_number":542,"context_line":"        vif_obj \u003d _nova_to_osvif_vif_agilio_ovs(vif)"},{"line_number":543,"context_line":"    elif vif_type \u003d\u003d model.VIF_TYPE_VHOSTUSER:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fadde2bd_5017f086","line":540,"range":{"start_line":536,"start_character":45,"end_line":540,"end_character":59},"updated":"2026-05-06 13:36:02.000000000","message":"nit: This might make more sense to just delete and let the fallthrough kick in","commit_id":"7de4947868e6a0de04c33b8a34ef113c20454f6f"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"8fb1476c0f78964378751918bccd1a40cf42a237","unresolved":true,"context_lines":[{"line_number":417,"context_line":"                objects\u003d[]),"},{"line_number":418,"context_line":"            mtu\u003d9000)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        self.os_vif_bridge \u003d osv_objects.vif.VIFBridge("},{"line_number":421,"context_line":"            id\u003d\"dc065497-3c8d-4f44-8fb4-e1d33c16a536\","},{"line_number":422,"context_line":"            address\u003d\"22:52:25:62:e2:aa\","},{"line_number":423,"context_line":"            plugin\u003d\"linux_bridge\","},{"line_number":424,"context_line":"            vif_name\u003d\"nicdc065497-3c\","},{"line_number":425,"context_line":"            bridge_name\u003d\"br100\","},{"line_number":426,"context_line":"            has_traffic_filtering\u003dFalse,"},{"line_number":427,"context_line":"            network\u003dself.os_vif_network)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        self.os_vif_ovs_prof \u003d osv_objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":430,"context_line":"            interface_id\u003d\"07bd6cea-fb37-4594-b769-90fc51854ee9\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ff4596b8_f1716be0","line":427,"range":{"start_line":420,"start_character":0,"end_line":427,"end_character":40},"updated":"2025-08-12 06:03:35.000000000","message":"Not sure if we need to remove this and its usage in this test file ? OR update the relevant tests which are using it ?","commit_id":"0e0ff1e0f9c054110db4a226dc91b66575b36703"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e478979d64d205cf74359991b70c680db2e06506","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                objects\u003d[]),"},{"line_number":418,"context_line":"            mtu\u003d9000)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        self.os_vif_bridge \u003d osv_objects.vif.VIFBridge("},{"line_number":421,"context_line":"            id\u003d\"dc065497-3c8d-4f44-8fb4-e1d33c16a536\","},{"line_number":422,"context_line":"            address\u003d\"22:52:25:62:e2:aa\","},{"line_number":423,"context_line":"            plugin\u003d\"linux_bridge\","},{"line_number":424,"context_line":"            vif_name\u003d\"nicdc065497-3c\","},{"line_number":425,"context_line":"            bridge_name\u003d\"br100\","},{"line_number":426,"context_line":"            has_traffic_filtering\u003dFalse,"},{"line_number":427,"context_line":"            network\u003dself.os_vif_network)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        self.os_vif_ovs_prof \u003d osv_objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":430,"context_line":"            interface_id\u003d\"07bd6cea-fb37-4594-b769-90fc51854ee9\","}],"source_content_type":"text/x-python","patch_set":1,"id":"65dea1df_152ea2a9","line":427,"range":{"start_line":420,"start_character":0,"end_line":427,"end_character":40},"in_reply_to":"f600b8da_cf33496b","updated":"2025-08-13 19:11:51.000000000","message":"Done","commit_id":"0e0ff1e0f9c054110db4a226dc91b66575b36703"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2bee4201e8ba3fa4b27dd7f2b867d4fd78376c2","unresolved":true,"context_lines":[{"line_number":417,"context_line":"                objects\u003d[]),"},{"line_number":418,"context_line":"            mtu\u003d9000)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        self.os_vif_bridge \u003d osv_objects.vif.VIFBridge("},{"line_number":421,"context_line":"            id\u003d\"dc065497-3c8d-4f44-8fb4-e1d33c16a536\","},{"line_number":422,"context_line":"            address\u003d\"22:52:25:62:e2:aa\","},{"line_number":423,"context_line":"            plugin\u003d\"linux_bridge\","},{"line_number":424,"context_line":"            vif_name\u003d\"nicdc065497-3c\","},{"line_number":425,"context_line":"            bridge_name\u003d\"br100\","},{"line_number":426,"context_line":"            has_traffic_filtering\u003dFalse,"},{"line_number":427,"context_line":"            network\u003dself.os_vif_network)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        self.os_vif_ovs_prof \u003d osv_objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":430,"context_line":"            interface_id\u003d\"07bd6cea-fb37-4594-b769-90fc51854ee9\","}],"source_content_type":"text/x-python","patch_set":1,"id":"f600b8da_cf33496b","line":427,"range":{"start_line":420,"start_character":0,"end_line":427,"end_character":40},"in_reply_to":"ff4596b8_f1716be0","updated":"2025-08-12 10:51:28.000000000","message":"ya i should, its currently testing the _nova_to_osvif_vif_bridge i belive but we can remove that now so ill take a look at this again","commit_id":"0e0ff1e0f9c054110db4a226dc91b66575b36703"}]}