)]}'
{"nova/tests/virt/libvirt/test_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6790533275631d97e015e34488e1e619f58c556","unresolved":false,"context_lines":[{"line_number":1891,"context_line":"                {\u0027quota:cpu_shares\u0027: \u002710000\u0027,"},{"line_number":1892,"context_line":"                 \u0027quota:cpu_period\u0027: \u002720000\u0027})"},{"line_number":1893,"context_line":""},{"line_number":1894,"context_line":"        instance_ref \u003d db.instance_create(self.context, self.test_instance)"},{"line_number":1895,"context_line":""},{"line_number":1896,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":1897,"context_line":"                                            instance_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_687901fc","line":1894,"updated":"2014-05-27 14:56:08.000000000","message":"the instance ref should be an object. please see https://github.com/openstack/nova/blob/master/nova/tests/virt/vmwareapi/test_driver_api.py#L468 for an example","commit_id":"bc14dabb93117f483fb70536a2cca23304348209"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4d0655f895590213a07a1886cd6b8bccc0a797db","unresolved":false,"context_lines":[{"line_number":1891,"context_line":"                {\u0027quota:cpu_shares\u0027: \u002710000\u0027,"},{"line_number":1892,"context_line":"                 \u0027quota:cpu_period\u0027: \u002720000\u0027})"},{"line_number":1893,"context_line":""},{"line_number":1894,"context_line":"        instance_ref \u003d db.instance_create(self.context, self.test_instance)"},{"line_number":1895,"context_line":""},{"line_number":1896,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":1897,"context_line":"                                            instance_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_c7aae218","line":1894,"in_reply_to":"3ae8d1ca_687901fc","updated":"2014-05-28 09:53:42.000000000","message":"The other tests in this file do it the way I\u0027ve done it here (ie the one immediately before this which I copied from). Consistency across tests within the scope of a single file is more important here. Any cleanup of the instance_ref usage should be done as a whole across the file in a separate patch, not adhoc when adding individual tests.","commit_id":"bc14dabb93117f483fb70536a2cca23304348209"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6790533275631d97e015e34488e1e619f58c556","unresolved":false,"context_lines":[{"line_number":1898,"context_line":""},{"line_number":1899,"context_line":"        cfg \u003d conn.get_guest_config(instance_ref, [], {}, disk_info)"},{"line_number":1900,"context_line":""},{"line_number":1901,"context_line":"        db.flavor_extra_specs_delete(self.context,"},{"line_number":1902,"context_line":"                                     flavor[\u0027flavorid\u0027],"},{"line_number":1903,"context_line":"                                     \u0027quota:cpu_shares\u0027)"},{"line_number":1904,"context_line":"        db.flavor_extra_specs_delete(self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_2877f903","line":1901,"updated":"2014-05-27 14:56:08.000000000","message":"if you the object above you will not need to to the cleanuop","commit_id":"bc14dabb93117f483fb70536a2cca23304348209"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6790533275631d97e015e34488e1e619f58c556","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"                                     flavor[\u0027flavorid\u0027],"},{"line_number":1906,"context_line":"                                     \u0027quota:cpu_period\u0027)"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"        self.assertEqual(cfg.cpu_shares, 10000)"},{"line_number":1909,"context_line":"        self.assertEqual(cfg.cpu_period, 20000)"},{"line_number":1910,"context_line":""},{"line_number":1911,"context_line":"    def _create_fake_service_compute(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_48efe5b0","line":1908,"updated":"2014-05-27 14:56:08.000000000","message":"minor nit - the first value should be the expected one","commit_id":"bc14dabb93117f483fb70536a2cca23304348209"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4eaaa88e03c2ee8ba126b85f656742271494d49f","unresolved":false,"context_lines":[{"line_number":1916,"context_line":"                self.context,"},{"line_number":1917,"context_line":"                flavor[\u0027flavorid\u0027],"},{"line_number":1918,"context_line":"                {\u0027quota:cpu_shares\u0027: \u002710000\u0027,"},{"line_number":1919,"context_line":"                 \u0027quota:cpu_period\u0027: \u002720000\u0027})"},{"line_number":1920,"context_line":""},{"line_number":1921,"context_line":"        instance_ref \u003d db.instance_create(self.context, self.test_instance)"},{"line_number":1922,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_9be73512","line":1919,"updated":"2014-05-29 01:31:43.000000000","message":"You can remove the db.flavor_get() call here and use objects, which would also alleviate the need for lines 1928-1933:\n\n        fake_flavour \u003d flavor_obj.Flavor.get_by_id(\n                                 self.context,\n                                 self.test_instance[\u0027instance_type_id\u0027])\n        fake_flavour.extra_specs \u003d {\u0027quota:cpu_shares\u0027: \u002710000\u0027,\n                             \u0027quota:cpu_period\u0027: \u002720000\u0027}","commit_id":"6904ed97510fcfd35cd30d562b25bbd0704943ce"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4eaaa88e03c2ee8ba126b85f656742271494d49f","unresolved":false,"context_lines":[{"line_number":1942,"context_line":""},{"line_number":1943,"context_line":"        flavor \u003d db.flavor_get(self.context,"},{"line_number":1944,"context_line":"                               self.test_instance[\u0027instance_type_id\u0027])"},{"line_number":1945,"context_line":"        db.flavor_extra_specs_update_or_create("},{"line_number":1946,"context_line":"                self.context,"},{"line_number":1947,"context_line":"                flavor[\u0027flavorid\u0027],"},{"line_number":1948,"context_line":"                {\u0027quota:cpu_shares\u0027: \u0027fishfood\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_dbf1bdce","line":1945,"updated":"2014-05-29 01:31:43.000000000","message":"ditto...","commit_id":"6904ed97510fcfd35cd30d562b25bbd0704943ce"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"52db8229651ceb660500d7f0047a3e789e0147cc","unresolved":false,"context_lines":[{"line_number":1948,"context_line":""},{"line_number":1949,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":1950,"context_line":""},{"line_number":1951,"context_line":"        fake_flavour \u003d flavor_obj.Flavor.get_by_id("},{"line_number":1952,"context_line":"                                 self.context,"},{"line_number":1953,"context_line":"                                 self.test_instance[\u0027instance_type_id\u0027])"},{"line_number":1954,"context_line":"        fake_flavour.extra_specs \u003d {\u0027quota:cpu_shares\u0027: \u0027fishfood\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_31816bc3","line":1951,"updated":"2014-06-20 04:33:19.000000000","message":"heh flavor vs. flavour. ohh english\n\nfor the sake of uniformity I am not a fan of using flavour as well.\n\ngit grep flavour, shows only one other file uses this.\n\nbut this is just a -0 for me.","commit_id":"d3dbf03ac6e5140e680208b04e18c776040cc028"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"645c7c11bbe37b10dff14d8e19025b417fafff2f","unresolved":false,"context_lines":[{"line_number":3145,"context_line":"            scope \u003d key.split(\u0027:\u0027)"},{"line_number":3146,"context_line":"            if len(scope) \u003e 1 and scope[0] \u003d\u003d \u0027quota\u0027:"},{"line_number":3147,"context_line":"                if scope[1] in quota_items:"},{"line_number":3148,"context_line":"                    setattr(guest, scope[1], int(value))"},{"line_number":3149,"context_line":""},{"line_number":3150,"context_line":"        guest.cpu \u003d self.get_guest_cpu_config()"},{"line_number":3151,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_a8407057","line":3148,"updated":"2014-05-27 12:03:46.000000000","message":"I mean: int(\u0027abc\u0027)","commit_id":"bc14dabb93117f483fb70536a2cca23304348209"}]}