)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"110d267ca9bb6ef64b4184159009998a02fd812c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae8546d1_c062c022","updated":"2025-08-18 15:19:48.000000000","message":"+1 we shoudl discuss how to test this but i can confrim \n\nhttps://github.com/openstack/glance/blob/master/etc/metadefs/compute-vcputopology.json\n\nthis was just a typo in the orginal patch reversing the order.","commit_id":"e1c22d36db680f7150842c3ca97fb84512d41e91"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f267ee29d7beda82cf42a53d422c60e71dbf6153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fef5e1a3_01b94781","updated":"2025-08-18 15:16:34.000000000","message":"Do we have any unit test to cover these changes?","commit_id":"e1c22d36db680f7150842c3ca97fb84512d41e91"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71a0039365ad2c48c535d04e3ef82089c7fb0b92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe3af9a0_523e82da","updated":"2025-08-18 15:20:41.000000000","message":"For reviewers, these options are already tested in `nova/tests/functional/libvirt/test_numa_servers.py` but that\u0027s clearly using an older microversion. We could change that but I suspect this will make it harder to backport this. I also don\u0027t think adding a unit test would be helpful, since the test is every bit as prone to being fat-fingered as the code itself, and we already have tests for the general \"extra spec validation\" feature.","commit_id":"e1c22d36db680f7150842c3ca97fb84512d41e91"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ae95debc263b12f65fb63c924ae43e8bc210ed99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d66e7aa5_d0e35e41","updated":"2025-08-21 06:33:59.000000000","message":"minor nit in description, otherwise LGTM.\ngiving -1 so that it gets attention and doesn\u0027t get merged accidentally, otherwise we have to do in follow-up patch.","commit_id":"e1c22d36db680f7150842c3ca97fb84512d41e91"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4e25d6803903e8cee0cf322566d200ecf397533c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c37e7c3f_200b7809","updated":"2025-08-19 09:30:25.000000000","message":"recheck","commit_id":"e1c22d36db680f7150842c3ca97fb84512d41e91"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5857fededbabf16869ce1c23d9a7ba37a4c20efe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecf53a84_1a32d94c","in_reply_to":"d66e7aa5_d0e35e41","updated":"2025-08-22 13:49:51.000000000","message":"its technically and unrelated pre exsiting but so that would actully be more correct.\n\n\nas i said i dont object to fixing it while we are here btu this isnt a  reasond to hold this patch. it is at most a nit to be adressed fi the patch was updated.","commit_id":"e1c22d36db680f7150842c3ca97fb84512d41e91"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a5b1e208ef0b7203ab7edaf8515c085c485b270c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48e0a341_b8182bd8","updated":"2025-08-27 02:53:15.000000000","message":"For now, the names are wrong and cause these extra specs to be unusable. Given that 1) this fixes the names and 2) the test coverage would be fairly involved, I think this is reasonable. LGTM.","commit_id":"4119634bf1f35f2c6ac3c388b5f53d509bd4ed48"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"879444c506e342e889f5f813bf32daac3760dfcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"976e55e8_7dae4079","updated":"2025-08-22 05:13:54.000000000","message":"LGTM","commit_id":"4119634bf1f35f2c6ac3c388b5f53d509bd4ed48"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5857fededbabf16869ce1c23d9a7ba37a4c20efe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5d54162_50e248d0","updated":"2025-08-22 13:49:51.000000000","message":"it would be still nice to see a test for this is you need to respin but its a tivial change so its proablhy better to just get this fixed and backported.","commit_id":"4119634bf1f35f2c6ac3c388b5f53d509bd4ed48"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f1bc083d01f79e0c9c52314f9437c4bb0937915e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f60dee9_116c86c7","updated":"2025-08-21 16:54:52.000000000","message":"recheck","commit_id":"4119634bf1f35f2c6ac3c388b5f53d509bd4ed48"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8ae08482627dcca8e9501ef27478a453d1620d8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"634c5d96_6592e7ea","updated":"2025-08-29 09:45:08.000000000","message":"recheck \nDetails: {\u0027type\u0027: \u0027SecurityGroupInUse\u0027, \u0027message\u0027: \u0027Security Group None cannot perform precommit_delete due to Callback neutron.plugins.ml2.drivers.ovn.mech_driver.mech_driver.OVNMechanismDriver._delete_security_group_precommit-8076864 failed with \"Cannot find Port_Group with name\u003dpg_4513e1b7_9d85_416e_a1e3_120e030cb015\".\u0027, \u0027detail\u0027: \u0027\u0027}","commit_id":"4119634bf1f35f2c6ac3c388b5f53d509bd4ed48"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f8087972d8f3c0075ed039eb9661300465279d37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d800fce_c048d031","updated":"2025-08-31 13:18:19.000000000","message":"recheck volume creation failure","commit_id":"4119634bf1f35f2c6ac3c388b5f53d509bd4ed48"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a5b1e208ef0b7203ab7edaf8515c085c485b270c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b801de8d_be10caf1","in_reply_to":"c5d54162_50e248d0","updated":"2025-08-27 02:53:15.000000000","message":"Agree we really need some test coverage to validate the validators, I guess 😝 and it would be nice if could do so against the real extra specs in the code too. I think that would take a lot more effort, if it is even possible.","commit_id":"4119634bf1f35f2c6ac3c388b5f53d509bd4ed48"}],"nova/api/validation/extra_specs/hw.py":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ae95debc263b12f65fb63c924ae43e8bc210ed99","unresolved":true,"context_lines":[{"line_number":320,"context_line":"    base.ExtraSpecValidator("},{"line_number":321,"context_line":"        name\u003d\u0027hw:cpu_max_sockets\u0027,"},{"line_number":322,"context_line":"        description\u003d("},{"line_number":323,"context_line":"            \u0027The max number of virtual CPU threads to emulate in the \u0027"},{"line_number":324,"context_line":"            \u0027guest CPU topology. \u0027"},{"line_number":325,"context_line":"            \u0027This is used to limit the topologies that can be requested by \u0027"},{"line_number":326,"context_line":"            \u0027an image and will be used to validate the ``hw_cpu_sockets`` \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"58a0ef4d_64162cf7","line":323,"range":{"start_line":323,"start_character":43,"end_line":323,"end_character":50},"updated":"2025-08-21 06:33:59.000000000","message":"IMO this should be changed to sockets ?","commit_id":"e1c22d36db680f7150842c3ca97fb84512d41e91"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7298345a4f7b236228b694f8fc5e7aa5d7c0032","unresolved":true,"context_lines":[{"line_number":320,"context_line":"    base.ExtraSpecValidator("},{"line_number":321,"context_line":"        name\u003d\u0027hw:cpu_max_sockets\u0027,"},{"line_number":322,"context_line":"        description\u003d("},{"line_number":323,"context_line":"            \u0027The max number of virtual CPU threads to emulate in the \u0027"},{"line_number":324,"context_line":"            \u0027guest CPU topology. \u0027"},{"line_number":325,"context_line":"            \u0027This is used to limit the topologies that can be requested by \u0027"},{"line_number":326,"context_line":"            \u0027an image and will be used to validate the ``hw_cpu_sockets`` \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8d2001_8eecef15","line":323,"range":{"start_line":323,"start_character":43,"end_line":323,"end_character":50},"in_reply_to":"58a0ef4d_64162cf7","updated":"2025-08-21 11:52:32.000000000","message":"ya that an unrelated preexisting bug but i dont object to adressing it in this patch.","commit_id":"e1c22d36db680f7150842c3ca97fb84512d41e91"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f15a91a77bea1f3fa3d84349d4af48047e2dc3","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    base.ExtraSpecValidator("},{"line_number":321,"context_line":"        name\u003d\u0027hw:cpu_max_sockets\u0027,"},{"line_number":322,"context_line":"        description\u003d("},{"line_number":323,"context_line":"            \u0027The max number of virtual CPU threads to emulate in the \u0027"},{"line_number":324,"context_line":"            \u0027guest CPU topology. \u0027"},{"line_number":325,"context_line":"            \u0027This is used to limit the topologies that can be requested by \u0027"},{"line_number":326,"context_line":"            \u0027an image and will be used to validate the ``hw_cpu_sockets`` \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1529f13c_8c4161e4","line":323,"range":{"start_line":323,"start_character":43,"end_line":323,"end_character":50},"in_reply_to":"ba8d2001_8eecef15","updated":"2025-08-21 14:56:39.000000000","message":"Done","commit_id":"e1c22d36db680f7150842c3ca97fb84512d41e91"}]}