)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3befbe6b0def9d605f4be789f77c540b346bfdb4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9284486_46404781","updated":"2025-08-26 10:25:42.000000000","message":"you can read it either way but i agree the current working is imprecise.","commit_id":"b3e346a121292bc18f2805c2716a8c11c805c14d"}],"nova/api/validation/extra_specs/hw.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3befbe6b0def9d605f4be789f77c540b346bfdb4","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            \u0027The policy to apply when determining what host CPUs the guest \u0027"},{"line_number":68,"context_line":"            \u0027CPUs can run on. \u0027"},{"line_number":69,"context_line":"            \u0027If ``shared`` (default), guest CPUs can be overallocated but \u0027"},{"line_number":70,"context_line":"            \u0027cannot float across host cores. \u0027"},{"line_number":71,"context_line":"            \u0027If ``dedicated``, guest CPUs cannot be overallocated but are \u0027"},{"line_number":72,"context_line":"            \u0027individually pinned to their own host core. \u0027"},{"line_number":73,"context_line":"            \u0027If ``mixed``, the policy for each instance CPU can be specified \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"717375e5_f1a70c04","side":"PARENT","line":70,"updated":"2025-08-26 10:25:42.000000000","message":"actully both are true because which cores they can float across are determine by if you define \n\n```\n[compute]\ncpu_shared_set\u003d\u003ccore list\u003e\n```\n\nor \n\n```\n[DEFAULT]\nvcpu_pin_set\u003d\u003ccore list\u003e\n```\n\nif neither are defiend they will float over all host cpus\n\nif either are used they will be soft pinned to float over the subset of shared cores.","commit_id":"2e666e768a7130c4502ca808a180eacb7c2d03f2"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"eed0eebd8673a169b80b810af6718ac8be4ad025","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            \u0027The policy to apply when determining what host CPUs the guest \u0027"},{"line_number":68,"context_line":"            \u0027CPUs can run on. \u0027"},{"line_number":69,"context_line":"            \u0027If ``shared`` (default), guest CPUs can be overallocated but \u0027"},{"line_number":70,"context_line":"            \u0027cannot float across host cores. \u0027"},{"line_number":71,"context_line":"            \u0027If ``dedicated``, guest CPUs cannot be overallocated but are \u0027"},{"line_number":72,"context_line":"            \u0027individually pinned to their own host core. \u0027"},{"line_number":73,"context_line":"            \u0027If ``mixed``, the policy for each instance CPU can be specified \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0d8f65e_bff18bff","side":"PARENT","line":70,"in_reply_to":"4fec2661_588c4fa8","updated":"2025-08-26 12:53:51.000000000","message":"so smth like this might be better\n\n\".. but can float across (a subset of) host cores\"","commit_id":"2e666e768a7130c4502ca808a180eacb7c2d03f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"19904dfc5758d331bd3ab0d25709db0c3775c92a","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            \u0027The policy to apply when determining what host CPUs the guest \u0027"},{"line_number":68,"context_line":"            \u0027CPUs can run on. \u0027"},{"line_number":69,"context_line":"            \u0027If ``shared`` (default), guest CPUs can be overallocated but \u0027"},{"line_number":70,"context_line":"            \u0027cannot float across host cores. \u0027"},{"line_number":71,"context_line":"            \u0027If ``dedicated``, guest CPUs cannot be overallocated but are \u0027"},{"line_number":72,"context_line":"            \u0027individually pinned to their own host core. \u0027"},{"line_number":73,"context_line":"            \u0027If ``mixed``, the policy for each instance CPU can be specified \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"4fec2661_588c4fa8","side":"PARENT","line":70,"in_reply_to":"717375e5_f1a70c04","updated":"2025-08-26 10:33:51.000000000","message":"if you are wondering what i mean by soft pineed\n\nwe actully do pin the core but we pin them to a range of cores\nthe only thing that is diffent between how we do the pinning in the xml between dedicated cpus and shared cpus is that dedicated cpus are a 1:1 pinning with only one vm using a given host core. for shared cpus its a 1:many pinning with many vms using the same range.","commit_id":"2e666e768a7130c4502ca808a180eacb7c2d03f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3befbe6b0def9d605f4be789f77c540b346bfdb4","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            \u0027The policy to apply when determining what host CPUs the guest \u0027"},{"line_number":68,"context_line":"            \u0027CPUs can run on. \u0027"},{"line_number":69,"context_line":"            \u0027If ``shared`` (default), guest CPUs can be overallocated but \u0027"},{"line_number":70,"context_line":"            \u0027can float across host cores. \u0027"},{"line_number":71,"context_line":"            \u0027If ``dedicated``, guest CPUs cannot be overallocated but are \u0027"},{"line_number":72,"context_line":"            \u0027individually pinned to their own host core. \u0027"},{"line_number":73,"context_line":"            \u0027If ``mixed``, the policy for each instance CPU can be specified \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"27cdd4bc_c74bc25b","line":70,"range":{"start_line":70,"start_character":12,"end_line":70,"end_character":43},"updated":"2025-08-26 10:25:42.000000000","message":"i\n```suggestion\n            \u0027will float across host cores. when defiend shared cpus\u0027\n            \u0027will be restricted to the `cpu_shared_set` or legacy `vcpu_pin_set`\u0027\n```","commit_id":"b3e346a121292bc18f2805c2716a8c11c805c14d"}]}