)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"78567bfa7ec02837771bee1a993ee18434c64519","unresolved":true,"context_lines":[{"line_number":11,"context_line":"API version and policy. We can therefore move the checks inside the"},{"line_number":12,"context_line":"functions that generate the response rather than duplicating them"},{"line_number":13,"context_line":"elsewhere."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I86aa4e1c62a0b0e6fa4d27e559d3197fb73851ba"},{"line_number":16,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f84076e0_cdf6e8b2","line":14,"updated":"2025-08-28 11:44:31.000000000","message":"+1","commit_id":"6fb03d48fe6a0df0fa39774336ecd83f92614ddf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da7592e58e02796c336665e7421603c36c4a3ce0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"API version and policy. We can therefore move the checks inside the"},{"line_number":12,"context_line":"functions that generate the response rather than duplicating them"},{"line_number":13,"context_line":"elsewhere."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I86aa4e1c62a0b0e6fa4d27e559d3197fb73851ba"},{"line_number":16,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1323e698_1fe4edd0","line":14,"in_reply_to":"f84076e0_cdf6e8b2","updated":"2025-09-01 08:59:10.000000000","message":"Acknowledged","commit_id":"6fb03d48fe6a0df0fa39774336ecd83f92614ddf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"387cd7d6bbf63788aa7d886e928d7a1fa35175dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e368a24_7a7c8121","updated":"2025-08-28 14:21:48.000000000","message":"I\u0027m still amazed about our unittests : we\u0027re refactoring but no calls are verified by our existing coverage so we can silently change those internal usage \\o/\n\nAnyway, again +1 but wondering why we need to do that for filtering flavors by their names...","commit_id":"6fb03d48fe6a0df0fa39774336ecd83f92614ddf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"78567bfa7ec02837771bee1a993ee18434c64519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1cf619d9_674058c0","updated":"2025-08-28 11:44:31.000000000","message":"ya this is a nice improvment","commit_id":"6fb03d48fe6a0df0fa39774336ecd83f92614ddf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50970078f5ce866e56ff49e948a2cacdfcd77703","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac9dcbcd_7a298fd7","in_reply_to":"3e368a24_7a7c8121","updated":"2025-08-28 16:23:39.000000000","message":"if we had to change unit test for every implention change that woudl eb a sign of a poorly written test suite.\n\nwe shoudl not expect to need to do that.\n\ni was expecting a need to update the test for the signiture change\nhttps://review.opendev.org/c/openstack/nova/+/958747/1/nova/api/openstack/compute/views/flavors.py\nbut we also tend to test the api with api sampel functionla tests so i was not that surpised for this specific code given we rely more on the functional and api sample tests here.\n\nif this was in the libvirt driver ro else where i woudl be very supproised by the lack fo unit test change.","commit_id":"6fb03d48fe6a0df0fa39774336ecd83f92614ddf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da7592e58e02796c336665e7421603c36c4a3ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05fdd33c_bdf69497","updated":"2025-09-01 08:59:10.000000000","message":"recheck unrelated failure","commit_id":"67af0b37228c14b84b2229726f6683a3c7fa842c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ac18569805ba94b6099c783f3260827a89a99b05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ac41597e_775a9dd9","updated":"2026-01-08 16:21:55.000000000","message":"recheck unreatlated functionl test timeout","commit_id":"951ae6683c38c0b6fbe068bf245824432774e3b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea82fad9acb03f644195c37f895f9663d68027d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d107c5b8_e1875c6f","updated":"2026-02-23 19:44:11.000000000","message":"recheck","commit_id":"a4452d1621eac4ff30a2de079055f2f9c91990f6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dc1d511a9485524408ebfe23ed642a4e39b7e268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"907cac95_67931435","updated":"2026-02-23 16:26:43.000000000","message":"recheck timeout","commit_id":"a4452d1621eac4ff30a2de079055f2f9c91990f6"}]}