)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e873433444b3aa42fd625d92a4a29d8c1ac1ba5a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-11-21 18:10:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api: Add ability to filter flavors by name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0d51d29339d1380b93ccb1501e33891082f930ec"},{"line_number":10,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c499c911_81f538b8","line":8,"updated":"2025-12-12 16:58:52.000000000","message":"nit:\nImplements: bluepirnt flavor-search-by-name","commit_id":"248784a04619d68076123db4a26b5c05f8d4017e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d5224f47cf8a6b145660b260095e9367c1c5f74","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-11-21 18:10:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api: Add ability to filter flavors by name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0d51d29339d1380b93ccb1501e33891082f930ec"},{"line_number":10,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"705a79be_c35c05b2","line":8,"in_reply_to":"c499c911_81f538b8","updated":"2026-02-25 17:23:31.000000000","message":"I haven\u0027t bothered with this for the rest of them. I have the Gerrit topic which I think it enough.","commit_id":"248784a04619d68076123db4a26b5c05f8d4017e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"866b7979e13b8d8edfa23a1380e5ca4732fd66d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"459ca0cb_b42657a8","updated":"2025-09-01 08:59:19.000000000","message":"recheck unrelated failure","commit_id":"694ed9bdb49c8612f0e5d66ef4c3fdc35c330b24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"59b5daa62615b66ddc25448361568509543c8617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d1cab13b_6712f4f8","updated":"2025-12-12 17:00:10.000000000","message":"actully do we not need to extend the openapi schmea for this too.\n\ni think we already merged trhe falvor ones.\nim ok with having a follow up patch for that if we have not merged that yet otherwise we shoudl doin it in thi one right","commit_id":"248784a04619d68076123db4a26b5c05f8d4017e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b487fd20d5c053067cd667ffe8ecd898d1e405cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b4c5ca73_892d8ed0","updated":"2026-02-24 09:25:40.000000000","message":"recheck","commit_id":"d2d5fdbdeb818f79a7d7f9ac3082b6c9bd2ca5dc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9f2c292c7f1ad70872a88a9e9c15b3daf513abaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"59ca73f4_a4153912","updated":"2026-02-23 16:26:52.000000000","message":"recheck timeout","commit_id":"d2d5fdbdeb818f79a7d7f9ac3082b6c9bd2ca5dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d84d232ab587694f2844d89540b82197bd1d323f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6710aea3_7b6a0e71","updated":"2026-02-23 17:27:58.000000000","message":"some minor isseus\n\nrest_api_version_history.rst hwas not been updated in this patch to document 2.101\ni know that is partly because you wanted to combine\n\nhttps://review.opendev.org/c/openstack/nova/+/958749/5\nand\nhttps://review.opendev.org/c/openstack/nova/+/958750/6\ninto the same micoveroisn but it proably would be better to amend the \nrest_api_version_history.rst doc in each change.\n\nthis could be adress in a followup patch just for the api doc so +2 over all.\n\ni asked ai to review this too and it also noted the following\n\n\"\"\"\n### 3.3 `LIKE` Fallback Inconsistency (Low)\n\n**File**: `nova/db/utils.py:154-155`\n\nWhen the database type is unknown, `get_regexp_ops()` falls back to `LIKE` with\nno wrapping of `%` wildcards. In the instance filter code\n(`nova/db/main/api.py:1985-1986`), the `LIKE` case explicitly wraps the value\nwith `%` for substring matching:\n\n```python\nif db_regexp_op \u003d\u003d \u0027LIKE\u0027:\n    query \u003d query.filter(column_attr.op(db_regexp_op)(\u0027%\u0027 + filter_val + \u0027%\u0027))\n```\n\nBut in the flavor filter (`nova/objects/flavor.py:622-625`), there is **no such\nwrapping**:\n\n```python\nquery \u003d query.filter(\n    api_models.Flavors.name.op(db_regexp_op)(\n        safe_regex_filter(filters[\u0027name\u0027])\n    )\n)\n```\n\nThis means on an unknown database backend using the `LIKE` fallback, the name\nfilter would require an **exact match** rather than a substring match. This is\nunlikely to matter in practice (all supported backends are covered), but it\u0027s\nan inconsistency.\n\n**Recommendation**: Add `%` wrapping for the `LIKE` case in the flavor filter,\nmatching the pattern in instance filtering, or document that only MySQL,\nPostgreSQL, and SQLite are supported.\n\n\"\"\"\n\ni think that could also be addressed in a followup but its valid feedback to consider.","commit_id":"d2d5fdbdeb818f79a7d7f9ac3082b6c9bd2ca5dc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d5224f47cf8a6b145660b260095e9367c1c5f74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dd884cd3_6fec83d1","in_reply_to":"6710aea3_7b6a0e71","updated":"2026-02-25 17:23:31.000000000","message":"history doc update is here https://review.opendev.org/c/openstack/nova/+/978002\n\nI think the other issue isn\u0027t really worth considering: as the bot says, we are already covering all supported backends.","commit_id":"d2d5fdbdeb818f79a7d7f9ac3082b6c9bd2ca5dc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"23416bc486325aea9d3594cc5fb5390a601291c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"06be2241_128f678a","updated":"2026-02-26 19:41:30.000000000","message":"lgtm, as discussed on IRC, let\u0027s resolve the microversion version first and after that it is good to go","commit_id":"65e871d21ee8ae319bd0b39250a19c37062f62fb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"edb79b3c6c09b99569715c947c9749cd6af814d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0c398dbd_ec7a600c","updated":"2026-02-26 21:00:22.000000000","message":"lgtm","commit_id":"e73a0bc84bb8b33e2fdcb4dcdf642584a3fb4221"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3aef0af0afbb8e48c4a3b09e0332527b5cc0e889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b0c1540_3eddc3a5","updated":"2026-02-27 02:08:22.000000000","message":"recheck live migration error","commit_id":"e73a0bc84bb8b33e2fdcb4dcdf642584a3fb4221"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3295c1f7761c2d8ec0bdd3b2ba8be18dac8d170b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ad445923_07a7908f","updated":"2026-02-27 07:24:22.000000000","message":"recheck volume error","commit_id":"e73a0bc84bb8b33e2fdcb4dcdf642584a3fb4221"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"357aef57636416233eaf525d98ade6c4fa9cdfee","unresolved":true,"context_lines":[{"line_number":3175,"context_line":"  in: body"},{"line_number":3176,"context_line":"  required: true"},{"line_number":3177,"context_line":"  type: string"},{"line_number":3178,"context_line":"flavor_name_query:"},{"line_number":3179,"context_line":"  description: |"},{"line_number":3180,"context_line":"    Filters the response by a flavor name, as a string.  You can use regular expressions"},{"line_number":3181,"context_line":"    in the query. For example, the ``?name\u003dbob`` regular expression returns both bob"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"612c194d_a51ef0cd","line":3178,"updated":"2025-08-28 16:44:16.000000000","message":"so this need to be later after the body\nthats causeing the api-ref failure.\n\nWARNING: Section out of order. All parameters in section ``body`` should be after section ``query``. (see ``flavor_name``)","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7000442fb14fd381aedc1ad594379417b1442772","unresolved":false,"context_lines":[{"line_number":3175,"context_line":"  in: body"},{"line_number":3176,"context_line":"  required: true"},{"line_number":3177,"context_line":"  type: string"},{"line_number":3178,"context_line":"flavor_name_query:"},{"line_number":3179,"context_line":"  description: |"},{"line_number":3180,"context_line":"    Filters the response by a flavor name, as a string.  You can use regular expressions"},{"line_number":3181,"context_line":"    in the query. For example, the ``?name\u003dbob`` regular expression returns both bob"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"75310a76_0cc752a1","line":3178,"in_reply_to":"612c194d_a51ef0cd","updated":"2025-08-29 09:45:18.000000000","message":"Done","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc7638f9e8f6f7c01f2717e5d8b5458f37f578fa","unresolved":true,"context_lines":[{"line_number":3181,"context_line":"    in the query. For example, the ``?name\u003dbob`` regular expression returns both bob"},{"line_number":3182,"context_line":"    and bobb. If you must match on only bob, you can use a regular expression that"},{"line_number":3183,"context_line":"    matches the syntax of the underlying database server that is implemented for Compute,"},{"line_number":3184,"context_line":"    such as MySQL or PostgreSQL."},{"line_number":3185,"context_line":"  format: regexp"},{"line_number":3186,"context_line":"  in: query"},{"line_number":3187,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"de4a8e2d_af57ad46","line":3184,"updated":"2025-08-28 11:51:31.000000000","message":"note to others, this is how all our other regex based seach queries work in the api today.\n\nwe discussed the possiblity of moving the python or pcre2 regex format to decouple form the db but that never happened so its good to docuemtn this IMO","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d43c957be718e944314119924da21434c17211eb","unresolved":true,"context_lines":[{"line_number":3181,"context_line":"    in the query. For example, the ``?name\u003dbob`` regular expression returns both bob"},{"line_number":3182,"context_line":"    and bobb. If you must match on only bob, you can use a regular expression that"},{"line_number":3183,"context_line":"    matches the syntax of the underlying database server that is implemented for Compute,"},{"line_number":3184,"context_line":"    such as MySQL or PostgreSQL."},{"line_number":3185,"context_line":"  format: regexp"},{"line_number":3186,"context_line":"  in: query"},{"line_number":3187,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3c361cd8_03fdbb2e","line":3184,"range":{"start_line":3184,"start_character":17,"end_line":3184,"end_character":32},"updated":"2025-08-28 14:26:23.000000000","message":"please remove it, AFAIK even if we can use postgresql, we don\u0027t support it.\n\nIf we add this in a document, then our operators would ask us why we have issues with it, while we don\u0027t have any CI job...","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f42083ab643b899106ea790ca539b02a81bf69f0","unresolved":true,"context_lines":[{"line_number":3181,"context_line":"    in the query. For example, the ``?name\u003dbob`` regular expression returns both bob"},{"line_number":3182,"context_line":"    and bobb. If you must match on only bob, you can use a regular expression that"},{"line_number":3183,"context_line":"    matches the syntax of the underlying database server that is implemented for Compute,"},{"line_number":3184,"context_line":"    such as MySQL or PostgreSQL."},{"line_number":3185,"context_line":"  format: regexp"},{"line_number":3186,"context_line":"  in: query"},{"line_number":3187,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"aabd8948_13aa67a0","line":3184,"range":{"start_line":3184,"start_character":17,"end_line":3184,"end_character":32},"in_reply_to":"3c361cd8_03fdbb2e","updated":"2025-08-28 16:29:17.000000000","message":"we do supprot postgress fully in nova.\nwe have never deprecated support and we stilll test it\nin teh unit tests via the oslo.db opertunistic test fixture.\n\nwe do not have a tempest/devstack job but if you want one we can add it.\n\nwe have never deprecated support for postgress in nova.\n\nwe can remove the refnce to PostgreSQL if you really want but we cant say its unsupported without fomally deprecating support. if you want to do that then lets dicuss it at the ptg. neutron already did it so we can follow suit but its a reasonable thing for oeprator to expect use to support today.\n\nnot advisable based on our limited testing but reasonable.","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7000442fb14fd381aedc1ad594379417b1442772","unresolved":false,"context_lines":[{"line_number":3181,"context_line":"    in the query. For example, the ``?name\u003dbob`` regular expression returns both bob"},{"line_number":3182,"context_line":"    and bobb. If you must match on only bob, you can use a regular expression that"},{"line_number":3183,"context_line":"    matches the syntax of the underlying database server that is implemented for Compute,"},{"line_number":3184,"context_line":"    such as MySQL or PostgreSQL."},{"line_number":3185,"context_line":"  format: regexp"},{"line_number":3186,"context_line":"  in: query"},{"line_number":3187,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ed1fabd7_bb8a65f5","line":3184,"range":{"start_line":3184,"start_character":17,"end_line":3184,"end_character":32},"in_reply_to":"aabd8948_13aa67a0","updated":"2025-08-29 09:45:18.000000000","message":"\u003e please remove it, AFAIK even if we can use postgresql, we don\u0027t support it.\n\nI copied this from the `server_name_query` parameter. I would change it, but that would be an unrelated change. 🙃","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7000442fb14fd381aedc1ad594379417b1442772","unresolved":false,"context_lines":[{"line_number":3181,"context_line":"    in the query. For example, the ``?name\u003dbob`` regular expression returns both bob"},{"line_number":3182,"context_line":"    and bobb. If you must match on only bob, you can use a regular expression that"},{"line_number":3183,"context_line":"    matches the syntax of the underlying database server that is implemented for Compute,"},{"line_number":3184,"context_line":"    such as MySQL or PostgreSQL."},{"line_number":3185,"context_line":"  format: regexp"},{"line_number":3186,"context_line":"  in: query"},{"line_number":3187,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bc08093b_5928c65e","line":3184,"in_reply_to":"de4a8e2d_af57ad46","updated":"2025-08-29 09:45:18.000000000","message":"Acknowledged","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"}],"nova/api/openstack/compute/schemas/flavors.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d43c957be718e944314119924da21434c17211eb","unresolved":true,"context_lines":[{"line_number":137,"context_line":"}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"index_query_v275 \u003d copy.deepcopy(index_query)"},{"line_number":140,"context_line":"index_query_v275[\u0027additionalProperties\u0027] \u003d False"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"index_query_v2101 \u003d copy.deepcopy(index_query_v275)"},{"line_number":143,"context_line":"index_query_v2101[\u0027properties\u0027][\u0027name\u0027] \u003d parameter_types.multi_params("}],"source_content_type":"text/x-python","patch_set":1,"id":"3efe302d_905a5b69","line":140,"updated":"2025-08-28 14:26:23.000000000","message":"yet again, unnecessary change...","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7000442fb14fd381aedc1ad594379417b1442772","unresolved":false,"context_lines":[{"line_number":137,"context_line":"}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"index_query_v275 \u003d copy.deepcopy(index_query)"},{"line_number":140,"context_line":"index_query_v275[\u0027additionalProperties\u0027] \u003d False"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"index_query_v2101 \u003d copy.deepcopy(index_query_v275)"},{"line_number":143,"context_line":"index_query_v2101[\u0027properties\u0027][\u0027name\u0027] \u003d parameter_types.multi_params("}],"source_content_type":"text/x-python","patch_set":1,"id":"75a0bde9_cdfaa257","line":140,"in_reply_to":"3efe302d_905a5b69","updated":"2025-08-29 09:45:18.000000000","message":"Acknowledged","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"}],"nova/objects/flavor.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d43c957be718e944314119924da21434c17211eb","unresolved":true,"context_lines":[{"line_number":629,"context_line":"            query \u003d query.filter(sa.or_(*the_filter))"},{"line_number":630,"context_line":"        else:"},{"line_number":631,"context_line":"            query \u003d query.filter(the_filter[0])"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    marker_row \u003d None"},{"line_number":634,"context_line":"    if marker is not None:"},{"line_number":635,"context_line":"        marker_row \u003d Flavor._flavor_get_query_from_db(context).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"28e44d4a_92d278d5","line":632,"updated":"2025-08-28 14:26:23.000000000","message":"unnecessary cosmetic change","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7000442fb14fd381aedc1ad594379417b1442772","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            query \u003d query.filter(sa.or_(*the_filter))"},{"line_number":630,"context_line":"        else:"},{"line_number":631,"context_line":"            query \u003d query.filter(the_filter[0])"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    marker_row \u003d None"},{"line_number":634,"context_line":"    if marker is not None:"},{"line_number":635,"context_line":"        marker_row \u003d Flavor._flavor_get_query_from_db(context).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f07d2ab_6375ea4b","line":632,"in_reply_to":"28e44d4a_92d278d5","updated":"2025-08-29 09:45:18.000000000","message":"Acknowledged","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"}],"nova/tests/unit/api/openstack/compute/test_flavors.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d43c957be718e944314119924da21434c17211eb","unresolved":true,"context_lines":[{"line_number":321,"context_line":"                        \"href\": \"http://localhost/flavors/1\","},{"line_number":322,"context_line":"                    }"},{"line_number":323,"context_line":"                ]"},{"line_number":324,"context_line":"            }"},{"line_number":325,"context_line":"        ]"},{"line_number":326,"context_line":"        if self.expect_description:"},{"line_number":327,"context_line":"            expected_flavors[0][\u0027description\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"d731e0c9_35a3afdb","line":324,"range":{"start_line":324,"start_character":10,"end_line":324,"end_character":13},"updated":"2025-08-28 14:26:23.000000000","message":"mmm, really ?","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7000442fb14fd381aedc1ad594379417b1442772","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                        \"href\": \"http://localhost/flavors/1\","},{"line_number":322,"context_line":"                    }"},{"line_number":323,"context_line":"                ]"},{"line_number":324,"context_line":"            }"},{"line_number":325,"context_line":"        ]"},{"line_number":326,"context_line":"        if self.expect_description:"},{"line_number":327,"context_line":"            expected_flavors[0][\u0027description\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"77b8cfd6_8de161c1","line":324,"range":{"start_line":324,"start_character":10,"end_line":324,"end_character":13},"in_reply_to":"30c37074_648c68b9","updated":"2025-08-29 09:45:18.000000000","message":"Acknowledged","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46afc189d6792d34f9cabcd22daea499a71a0be6","unresolved":true,"context_lines":[{"line_number":321,"context_line":"                        \"href\": \"http://localhost/flavors/1\","},{"line_number":322,"context_line":"                    }"},{"line_number":323,"context_line":"                ]"},{"line_number":324,"context_line":"            }"},{"line_number":325,"context_line":"        ]"},{"line_number":326,"context_line":"        if self.expect_description:"},{"line_number":327,"context_line":"            expected_flavors[0][\u0027description\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"30c37074_648c68b9","line":324,"range":{"start_line":324,"start_character":10,"end_line":324,"end_character":13},"in_reply_to":"d731e0c9_35a3afdb","updated":"2025-08-28 16:32:18.000000000","message":"please dont leave reveiw coment like this this is passive agressive and you do it a lot.\n\nwe have tooling that will fix formating error like this (it was incorrectly indented) \n\nthat runs if you edit a file.\ni suspect that is what happend here which is why i did not comemnt on it.","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e873433444b3aa42fd625d92a4a29d8c1ac1ba5a","unresolved":false,"context_lines":[{"line_number":877,"context_line":"            \u0027flavors\u0027: ["},{"line_number":878,"context_line":"                {"},{"line_number":879,"context_line":"                    \u0027description\u0027: \u0027flavor 2 description\u0027,"},{"line_number":880,"context_line":"                    \u0027id\u0027: \u00272\u0027,"},{"line_number":881,"context_line":"                    \u0027links\u0027: ["},{"line_number":882,"context_line":"                        {"},{"line_number":883,"context_line":"                            \u0027href\u0027: \u0027http://localhost/v2.1/flavors/2\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"279d837c_b19efee3","line":880,"range":{"start_line":880,"start_character":20,"end_line":880,"end_character":30},"updated":"2025-12-12 16:58:52.000000000","message":"nit it woudl be alittle clearer if the id was not 2 that this works because 2 matches \"flavor 2\"\n\nbut ya this works.\n\nwe are not actully trying to test the regex parsing here som there is no point in addint `$` or `^` to be more explcit which is why we are fakging the regex suprot just doing a substring match","commit_id":"248784a04619d68076123db4a26b5c05f8d4017e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d84d232ab587694f2844d89540b82197bd1d323f","unresolved":false,"context_lines":[{"line_number":859,"context_line":""},{"line_number":860,"context_line":"    def test_list_flavors_with_name_filter_old_version(self):"},{"line_number":861,"context_line":"        req \u003d fakes.HTTPRequestV21.blank("},{"line_number":862,"context_line":"            \u0027/flavors?name\u003dfalse\u0027, version\u003d\u00272.100\u0027)"},{"line_number":863,"context_line":"        self.assertRaises("},{"line_number":864,"context_line":"            exception.ValidationError, self.controller.index, req)"},{"line_number":865,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"48420578_14cc6afe","line":862,"range":{"start_line":862,"start_character":27,"end_line":862,"end_character":32},"updated":"2026-02-23 17:27:58.000000000","message":"nit: fake or test woudl make it clearer that this is not failign because its \"false\" but rather because the parmter is past but that a trivial nit.","commit_id":"d2d5fdbdeb818f79a7d7f9ac3082b6c9bd2ca5dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d84d232ab587694f2844d89540b82197bd1d323f","unresolved":false,"context_lines":[{"line_number":877,"context_line":"            \u0027flavors\u0027: ["},{"line_number":878,"context_line":"                {"},{"line_number":879,"context_line":"                    \u0027description\u0027: \u0027flavor 2 description\u0027,"},{"line_number":880,"context_line":"                    \u0027id\u0027: \u00272\u0027,"},{"line_number":881,"context_line":"                    \u0027links\u0027: ["},{"line_number":882,"context_line":"                        {"},{"line_number":883,"context_line":"                            \u0027href\u0027: \u0027http://localhost/v2.1/flavors/2\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"0090b1f6_283678a4","line":880,"updated":"2026-02-23 17:27:58.000000000","message":"nit: similar to above using an id other then 2 woudl make it clear that its matching on name: flavor 2 rather then the id\n\nbut again this is fine and just a nit that you can ignore","commit_id":"d2d5fdbdeb818f79a7d7f9ac3082b6c9bd2ca5dc"}],"nova/tests/unit/api/openstack/fakes.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc7638f9e8f6f7c01f2717e5d8b5458f37f578fa","unresolved":true,"context_lines":[{"line_number":780,"context_line":"            elif reject_min(\u0027root_gb\u0027, \u0027min_root_gb\u0027):"},{"line_number":781,"context_line":"                continue"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"            if \u0027name\u0027 in filters and filters[\u0027name\u0027] not in flavor.name:"},{"line_number":784,"context_line":"                continue"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"            res.append(flavor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"44e1484d_36ed1013","line":783,"range":{"start_line":783,"start_character":37,"end_line":783,"end_character":72},"updated":"2025-08-28 11:51:31.000000000","message":"this is not really simulating a regex so i would consider adding a coment but\nit should be enough for the testing you added which i think is sufficent so ok.\n\nplease do add a comment that this is only a partil implation however if you respin.","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46afc189d6792d34f9cabcd22daea499a71a0be6","unresolved":true,"context_lines":[{"line_number":780,"context_line":"            elif reject_min(\u0027root_gb\u0027, \u0027min_root_gb\u0027):"},{"line_number":781,"context_line":"                continue"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"            if \u0027name\u0027 in filters and filters[\u0027name\u0027] not in flavor.name:"},{"line_number":784,"context_line":"                continue"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"            res.append(flavor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"496af2f8_28dd796d","line":783,"range":{"start_line":783,"start_character":37,"end_line":783,"end_character":72},"in_reply_to":"22f939a2_fe37c4df","updated":"2025-08-28 16:32:18.000000000","message":"the mysql regex format is not compatiable with pytons regex which is why i did not ask for it.","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d43c957be718e944314119924da21434c17211eb","unresolved":true,"context_lines":[{"line_number":780,"context_line":"            elif reject_min(\u0027root_gb\u0027, \u0027min_root_gb\u0027):"},{"line_number":781,"context_line":"                continue"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"            if \u0027name\u0027 in filters and filters[\u0027name\u0027] not in flavor.name:"},{"line_number":784,"context_line":"                continue"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"            res.append(flavor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"22f939a2_fe37c4df","line":783,"range":{"start_line":783,"start_character":37,"end_line":783,"end_character":72},"in_reply_to":"44e1484d_36ed1013","updated":"2025-08-28 14:26:23.000000000","message":"agreed, I think this would be able to use a regex","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7000442fb14fd381aedc1ad594379417b1442772","unresolved":false,"context_lines":[{"line_number":780,"context_line":"            elif reject_min(\u0027root_gb\u0027, \u0027min_root_gb\u0027):"},{"line_number":781,"context_line":"                continue"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"            if \u0027name\u0027 in filters and filters[\u0027name\u0027] not in flavor.name:"},{"line_number":784,"context_line":"                continue"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"            res.append(flavor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3c6ce4b_51f4ebf5","line":783,"range":{"start_line":783,"start_character":37,"end_line":783,"end_character":72},"in_reply_to":"496af2f8_28dd796d","updated":"2025-08-29 09:45:18.000000000","message":"Ack, left a comment.","commit_id":"cb636b69c66a91d2256ac6e8dedfec7ea9be1e69"}]}