)]}'
{"id":"openstack%2Fnova~959309","triplet_id":"openstack%2Fnova~stable%2F2025.1~I2711be9605618c1b93104d1dbddd8c7ee73b577e","project":"openstack/nova","branch":"stable/2025.1","topic":"bug/2115729","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2025-09-05 14:40:46.000000000","reason":"Change was submitted"},"20733":{"account":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"last_update":"2025-09-05 14:40:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2711be9605618c1b93104d1dbddd8c7ee73b577e","subject":"Fix pci_tracker.save to delete all removed devs","status":"MERGED","created":"2025-09-03 12:10:28.000000000","updated":"2025-09-05 14:43:40.000000000","submitted":"2025-09-05 14:40:46.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"959309-bug/2115729","meta_rev_id":"d512f4016ef075fa9c22f9b3057b0333476f7588","_number":959309,"virtual_id_number":959309,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-09-05 14:40:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2025-09-05 12:25:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-09-05 09:52:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2025-09-05 12:25:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"}],"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-03 14:34:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-09-03 14:39:58.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2025-09-05 09:52:30.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2025-09-05 10:05:34.000000000","updated_by":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"reviewer":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"state":"CC"},{"updated":"2025-09-05 12:25:08.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"7ada313fdebfa377a68fd9c19f7ffd88c6bd1a80","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2025-09-03 12:10:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d0acd906736629fbac06e470e33cb2b646a097b0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-03 14:34:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/615d5ba66b904547aefba68cf5c2730f\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/fa24694ba67941f6a5353988c6ec147a : SUCCESS in 58m 14s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/c7e342b9cd5f482583b29f55ec418116 : SUCCESS in 1h 44m 51s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/73b93528debe47c6ac88874f0144ce98 : SUCCESS in 1h 00m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4af16083c3e849838a02f7596893f2c5 : SUCCESS in 25m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a5d942e3882a423cad8e3bc7fe3d8d3a : SUCCESS in 8m 21s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0cb95a3412a34d5982149e9d0f556b89 : SUCCESS in 12m 28s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/f1336c699ab7484886977da911c0281b : SUCCESS in 13m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cd927a3e405b4e299dff37a3d36a9e07 : SUCCESS in 13m 41s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/b2d61c493cde465e869a7cb8e90518af : SUCCESS in 52m 38s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/aaea60e66bae4fde8ceeb1480f8b4905 : SUCCESS in 1h 48m 55s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/db1e6e3124f24f3289d395174d83d0c7 : SUCCESS in 56m 50s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/079cd8751b384acca902d4ddea2bd0fb : SUCCESS in 27m 58s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/2604f24f764d434f87fdeb9fb785ceed : SUCCESS in 2h 01m 20s\n- nova-next https://zuul.opendev.org/t/openstack/build/724df5b89b394613aae7f982d4dd6e2d : SUCCESS in 2h 10m 14s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/95309e0e2268463c99d5618b7d65eef8 : SUCCESS in 44m 47s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/8f97bbc29b1d4726889e9c9501cde88c : SUCCESS in 5m 26s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/7fcaf1bf54eb4c94b3dd9b99d07741b3 : SUCCESS in 24m 16s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/9f290d860e054213a66ad1677f5399e2 : SUCCESS in 25m 06s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/cbe3ee7e9910492e843868467230b1d2 : SUCCESS in 32m 20s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f4dbb4d8445a46138f10439347cdef0f : SUCCESS in 1h 23m 38s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ef5dea8e8b8040d7b8e1baec28144198 : SUCCESS in 53m 20s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/c2fce3f3449f4bf485917b55f5669ca8 : FAILURE in 27m 34s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/73094200c27e458f95a934fe4942a955 : SUCCESS in 33m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a59922c6754470e7d5b34bf566369c6fb0dc40f1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2025-09-03 14:39:58.000000000","message":"Patch Set 1:\n\nBuild succeeded. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":1},{"id":"c6f8df127a96200682c1c9eb35c18ecb3b79dc54","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-03 16:23:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d4fbc5532178444897a14272a03ff747\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/a1b7c4b2b7b2411281d0a0e5785df120 : SUCCESS in 25m 46s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/650b024befb04166a7871b2637a17b7f : SUCCESS in 33m 54s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2931d8521ad65c834c4b93b865634b2ee88238e9","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2025-09-05 09:52:30.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"19453c7149c9945456fdc5b77db5c6f8c607e8f2","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2025-09-05 10:05:34.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d7294aab9a7409f58cc8bd298d685b9fbba7d49d","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-09-05 12:25:08.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"30e7b0c9abe1304b29fe2667e1a1eff00d0ef118","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-05 12:29:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"be8c18fb45f9221ecd7b3bd0a3091794ea35fa44","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-05 14:40:46.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dadfb47c0b4b42cfad7f14b38b6680bb\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/cbbbbb1568e141469db25f7341d08cfc : SUCCESS in 54m 59s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/1dac0e0342cb4bce99367cc7909bc486 : SUCCESS in 2h 05m 32s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/89c8e5fd1e444ef38120c7cade940c2e : SUCCESS in 1h 01m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9a3db90669f94f19b615a715d2acd698 : SUCCESS in 7m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2932c393ef534d8faa8da3a7e70093c8 : SUCCESS in 8m 53s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/c7dd771e0fa643cd8e75a0a254883922 : SUCCESS in 10m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b6aa16e37948468e9a7024af6162bf42 : SUCCESS in 12m 39s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/4e95da54249b4cd68abef808df831301 : SUCCESS in 43m 03s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d120b257bca04395afe5d66cf899ddb9 : SUCCESS in 26m 55s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/27c829a0839c497484d62d552794b37b : SUCCESS in 29m 25s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/b8e526ce59f8425e85220e76050f594f : SUCCESS in 24m 03s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/dd1b45b5ace8411a9f59a2b4865e0d35 : SUCCESS in 1h 06m 18s\n- nova-next https://zuul.opendev.org/t/openstack/build/b13d4caa52b0487c9437186478c85300 : SUCCESS in 1h 18m 28s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/736b161930064c408df2a4ef391e2393 : SUCCESS in 7m 12s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/51c602f1445f4143b92ce286c5d05ee6 : SUCCESS in 1h 22m 52s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/576812cd556c4bf9b8272b53a6f3b234 : SUCCESS in 54m 32s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7cfa8e6e163e4a6eb5813684b49fc6e7 : SUCCESS in 1h 04m 29s","accounts_in_message":[],"_revision_number":1},{"id":"7368269281145db8df0762204786fff07e08944a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-05 14:40:46.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"d512f4016ef075fa9c22f9b3057b0333476f7588","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-05 14:43:40.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c02836e782fd419e9bb10679c18810dd\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5028085f0b004f62b8d35b18a7978036 : SUCCESS in 2m 41s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e3695702a2b671268949a1d760e753dab796c1ae","revisions":{"e3695702a2b671268949a1d760e753dab796c1ae":{"kind":"REWORK","_number":1,"created":"2025-09-03 12:10:28.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/09/959309/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/959309/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/959309/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/959309/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/959309/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/959309/1"}}},"commit":{"parents":[{"commit":"5269fcd8f1b6306118a7d19530e81443914f21aa","subject":"Reproduce that only half of the PCI devs are removed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5269fcd8f1b6306118a7d19530e81443914f21aa"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2025-07-02 16:01:41.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2025-09-03 12:10:03.000000000","tz":120},"subject":"Fix pci_tracker.save to delete all removed devs","message":"Fix pci_tracker.save to delete all removed devs\n\nThe bug is that the save code modifies the self.pci_devs.object list\nwhile iterating it. This resulted in only half of the removed devs was\ndeleted at each save() run. Iterating on a shallow copy of that list\nfixes it.\n\nCloses-Bug: #2115729\nChange-Id: I2711be9605618c1b93104d1dbddd8c7ee73b577e\nSigned-off-by: Balazs Gibizer \u003cgibi@redhat.com\u003e\n(cherry picked from commit 0208be629c3853863bcd49b8bdbe2b9889b85012)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e3695702a2b671268949a1d760e753dab796c1ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e3695702a2b671268949a1d760e753dab796c1ae"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
