)]}'
{"id":"openstack%2Fnova~959314","triplet_id":"openstack%2Fnova~stable%2F2024.1~I2711be9605618c1b93104d1dbddd8c7ee73b577e","project":"openstack/nova","branch":"stable/2024.1","topic":"bug/2115729","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2025-09-05 21:55:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2711be9605618c1b93104d1dbddd8c7ee73b577e","subject":"Fix pci_tracker.save to delete all removed devs","status":"MERGED","created":"2025-09-03 12:13:15.000000000","updated":"2025-09-05 21:58:15.000000000","submitted":"2025-09-05 21:55:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"959314-bug/2115729","meta_rev_id":"0aae18a73f40ab6346dc9e0252225267fbf7f286","_number":959314,"virtual_id_number":959314,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-09-05 21:55:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-09-05 09:53:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":2,"date":"2025-09-05 20:16:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":1,"date":"2025-09-05 20:16:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"}],"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-03 14:05:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-09-03 14:10:41.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2025-09-05 09:53:24.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2025-09-05 20:16:45.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"43775531cb0d0826b04bd537f9fb3101808fe2be","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2025-09-03 12:13:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"592e8f351b1e89e940bb4c909367f0cb45582f45","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-03 14:05:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/834a305389ee49259abdea873ea2b682\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/a6da6c86bda44ffe8615a7414edc8bdd : SUCCESS in 56m 01s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/0813d4a8fbe141ef878a1c724783ef87 : SUCCESS in 1h 41m 58s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/1520e7503d2142ee900e732bcb36b179 : SUCCESS in 28m 00s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/436535907d184aa6af182a7eba696e01 : SUCCESS in 30m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d8a19d349ada4c6b9190cdd042038568 : SUCCESS in 6m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b2e09afd3e2647c99578f1e141250ebe : SUCCESS in 13m 27s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/fc06e5373062468ab85730cd497eb313 : SUCCESS in 12m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e196bc463dcb4a8f903d13590f27c25d : SUCCESS in 9m 08s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/2af06f48508f42008d05adf643a6bf8b : SUCCESS in 45m 16s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/5b4c4687d0874ee8b7f7df1d255bc2df : SUCCESS in 1h 46m 29s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/1bfd72e3701c408b900b7c5097b1b828 : FAILURE in 5m 28s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/c7fe23333b424bc1bc024cf77ef2eb60 : SUCCESS in 25m 16s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a993b0cf84c240009474e2fae8d86101 : SUCCESS in 25m 13s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/d696674d096847cd913ce17ce98eb6e3 : SUCCESS in 22m 32s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/47ad143592864807af49dfe3c66dc186 : SUCCESS in 1h 27m 20s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/49064cbf31df4284aa2285d6749afa3f : SUCCESS in 1h 35m 14s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/3c7f50ab1cbd4efe8bc1eda6bd385b9f : SUCCESS in 43m 16s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/57b0d0a363ac47edbdd4ada43fcb4109 : SUCCESS in 52m 39s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/24882cfc5868452ba36ec9765d18dfed : FAILURE in 13m 42s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/9c637f30c19a4d168b262dd7c2c6723d : SUCCESS in 14m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8e2ce9b05bb4a4a7f5b89de9ba2ada4e4365de61","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2025-09-03 14:10:41.000000000","message":"Patch Set 1:\n\nBuild succeeded. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":1},{"id":"42e379d5ea334dd1451de31a1f27fbb53389ce43","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-03 16:16:23.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ff346121b34d4ac68ebc3a064a1bb9d5\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/b20c93f2d895470e881ccf35a607db8e : SUCCESS in 33m 00s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/b1ade2c9bff54deea81f440c52307d48 : SUCCESS in 16m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b89cc5113a2638c70da86c03279aff6aca41b405","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2025-09-05 09:53:24.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6e8c02aa9758fa0de05b93ac962f66728f64731c","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-09-05 20:16:45.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"37d5d064428c595f1bc2e30b7b10d481b6e0a35c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-05 20:17:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"35eec997d584599a016f1473456f9e7480c55721","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-05 21:55:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1c79c856774741ed80a72d0e26fb279d\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/c76843cd81e6405f98df492f66551e4b : SUCCESS in 37m 10s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/782752131bf94e5f9a1cd73ee077fb74 : SUCCESS in 1h 08m 32s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/4be591e1d9994ef5b2feabe1eb374f7b : SUCCESS in 25m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/98f993ca39e14d1dbe178b4b954372f4 : SUCCESS in 8m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/94a2687ebc0646f39059b0bc6e4ff58e : SUCCESS in 14m 20s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/a7c2aa70995943b18148a3bcca51629f : SUCCESS in 8m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eaa77f9fe0684eaf8be2d752e5d1cfdc : SUCCESS in 8m 44s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/e3c8ec548fbd4d46a273d9fd1e7ec2a5 : SUCCESS in 23m 46s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/27f890d678c440b38eca0670cde99727 : SUCCESS in 22m 49s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/97c4ea0b6722467898ae7f98792dc2c3 : SUCCESS in 22m 36s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/60fc8837b74d43d39d6b3ca53750cca4 : SUCCESS in 6m 10s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/aee84dd601044eb482e491194b32643f : SUCCESS in 1h 30m 37s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/875fb618893a4bfeb9e10664c5bc2738 : SUCCESS in 1h 33m 44s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/73286b4083534eaeb08b1249d1df09df : SUCCESS in 1h 25m 25s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/d489794e0ea2402893ce9e8b5ea3cdb8 : SUCCESS in 53m 58s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/60c376a26ef547f1a6c00dc5cb6d9667 : SUCCESS in 45m 36s","accounts_in_message":[],"_revision_number":1},{"id":"d2727ec8411d3704d67c7cbf67345c2abd663dcc","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-05 21:55:34.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"0aae18a73f40ab6346dc9e0252225267fbf7f286","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-05 21:58:15.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a797ffd9afc0467a80fcc850d1fe7ae7\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b23649d6a710440482ba04469eda4398 : SUCCESS in 2m 31s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b45a9ba8361b3e8c32aeb7d97bd9e62a70123831","revisions":{"b45a9ba8361b3e8c32aeb7d97bd9e62a70123831":{"kind":"REWORK","_number":1,"created":"2025-09-03 12:13:15.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/14/959314/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/959314/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/959314/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/959314/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/959314/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/959314/1"}}},"commit":{"parents":[{"commit":"1c50b3b0498b86763dee3f95a729312c00d4471f","subject":"Reproduce that only half of the PCI devs are removed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1c50b3b0498b86763dee3f95a729312c00d4471f"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2025-07-02 16:01:41.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2025-09-03 12:13:08.000000000","tz":120},"subject":"Fix pci_tracker.save to delete all removed devs","message":"Fix pci_tracker.save to delete all removed devs\n\nThe bug is that the save code modifies the self.pci_devs.object list\nwhile iterating it. This resulted in only half of the removed devs was\ndeleted at each save() run. Iterating on a shallow copy of that list\nfixes it.\n\nCloses-Bug: #2115729\nChange-Id: I2711be9605618c1b93104d1dbddd8c7ee73b577e\nSigned-off-by: Balazs Gibizer \u003cgibi@redhat.com\u003e\n(cherry picked from commit 0208be629c3853863bcd49b8bdbe2b9889b85012)\n(cherry picked from commit e3695702a2b671268949a1d760e753dab796c1ae)\n(cherry picked from commit 8a129522479e703983169c77434fc44c20578cf0)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b45a9ba8361b3e8c32aeb7d97bd9e62a70123831"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b45a9ba8361b3e8c32aeb7d97bd9e62a70123831"}]},"branch":"refs/heads/stable/2024.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}