)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eef98cf9c32d12a2b53fe29437fa34270b40ff09","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update the \u0027mapped\u0027 field of the created node to be coherent with"},{"line_number":10,"context_line":"what it\u0027s done in _check_and_create_node_host_mappings function [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://opendev.org/openstack/nova/src/commit/cc742602bcdeff185ff120452e4f301398f6aa7b/nova/objects/host_mapping.py#L209"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9965932adc521756e4583d1bcfc75c83cc630626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"31c40e73_de02b1f2","line":11,"updated":"2025-10-08 07:55:52.000000000","message":"does it create a specific issue ?","commit_id":"4de68c1f7b1bbc32c85589cde7d09ed02fe6b44f"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"859de6f08570389540067db87dcac98904caa445","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update the \u0027mapped\u0027 field of the created node to be coherent with"},{"line_number":10,"context_line":"what it\u0027s done in _check_and_create_node_host_mappings function [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://opendev.org/openstack/nova/src/commit/cc742602bcdeff185ff120452e4f301398f6aa7b/nova/objects/host_mapping.py#L209"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9965932adc521756e4583d1bcfc75c83cc630626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"913d86b4_acaf2ce9","line":11,"in_reply_to":"31c40e73_de02b1f2","updated":"2025-10-08 08:12:49.000000000","message":"It is simply more representative of how it works in reality","commit_id":"4de68c1f7b1bbc32c85589cde7d09ed02fe6b44f"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"7730e58d0d12cd5ca305429a028b23a87bf2f7fb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update the \u0027mapped\u0027 field of the created node to be coherent with"},{"line_number":10,"context_line":"what it\u0027s done in _check_and_create_node_host_mappings function [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://opendev.org/openstack/nova/src/commit/cc742602bcdeff185ff120452e4f301398f6aa7b/nova/objects/host_mapping.py#L209"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9965932adc521756e4583d1bcfc75c83cc630626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1b0dd463_36e9092f","line":11,"in_reply_to":"913d86b4_acaf2ce9","updated":"2025-10-08 08:33:59.000000000","message":"I\u0027ve added the related bug in the commit message","commit_id":"4de68c1f7b1bbc32c85589cde7d09ed02fe6b44f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5e3f3cb72d94dd463a000f56b439219b300dee79","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://opendev.org/openstack/nova/src/commit/cc742602bcdeff185ff120452e4f301398f6aa7b/nova/objects/host_mapping.py#L209"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #2085135"},{"line_number":15,"context_line":"Change-Id: I9965932adc521756e4583d1bcfc75c83cc630626"},{"line_number":16,"context_line":"Signed-off-by: Julien Le Jeune \u003cjulien.le-jeune@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"d327a3f2_46c40824","line":14,"updated":"2025-10-08 08:39:15.000000000","message":"thanks","commit_id":"38d1b141705f7118fbb519ac9c56bf1f425ad3fd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee3a2e94e4bd87624f0890041193c3c435f6c315","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"648d57b1_2a43add8","updated":"2025-10-08 08:24:47.000000000","message":"changing my view given your comments","commit_id":"4de68c1f7b1bbc32c85589cde7d09ed02fe6b44f"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"90dc382d657fbe2fd2f2bd39b460328c1c3f646a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cf59617e_82712677","updated":"2025-11-27 09:12:52.000000000","message":"run-Quobyte CI","commit_id":"38d1b141705f7118fbb519ac9c56bf1f425ad3fd"}],"nova/test.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eef98cf9c32d12a2b53fe29437fa34270b40ff09","unresolved":true,"context_lines":[{"line_number":490,"context_line":"                    node.save()"},{"line_number":491,"context_line":"        else:"},{"line_number":492,"context_line":"            svc \u003d self.useFixture("},{"line_number":493,"context_line":"                nova_fixtures.ServiceFixture(name, host, cell\u003dcell, **kwargs))"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        # Keep track of how many instances of this service are running."},{"line_number":496,"context_line":"        self._service_fixture_count[name] +\u003d 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"99e3f6f8_7844baec","line":493,"updated":"2025-10-08 07:55:52.000000000","message":"you could just have moved this fixture call in L463 instead of calling it twice, right?","commit_id":"4de68c1f7b1bbc32c85589cde7d09ed02fe6b44f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee3a2e94e4bd87624f0890041193c3c435f6c315","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                    node.save()"},{"line_number":491,"context_line":"        else:"},{"line_number":492,"context_line":"            svc \u003d self.useFixture("},{"line_number":493,"context_line":"                nova_fixtures.ServiceFixture(name, host, cell\u003dcell, **kwargs))"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        # Keep track of how many instances of this service are running."},{"line_number":496,"context_line":"        self._service_fixture_count[name] +\u003d 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"7dac5cb6_db548a0a","line":493,"in_reply_to":"555ee552_3e85ee3e","updated":"2025-10-08 08:24:47.000000000","message":"Oh, right, we need to create a service record but we need to know the cell value... but if you want to get a compute node, you need to provide the right service record...","commit_id":"4de68c1f7b1bbc32c85589cde7d09ed02fe6b44f"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"04a614236d5c0e2c037143e29f7efee80b0ef611","unresolved":true,"context_lines":[{"line_number":490,"context_line":"                    node.save()"},{"line_number":491,"context_line":"        else:"},{"line_number":492,"context_line":"            svc \u003d self.useFixture("},{"line_number":493,"context_line":"                nova_fixtures.ServiceFixture(name, host, cell\u003dcell, **kwargs))"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        # Keep track of how many instances of this service are running."},{"line_number":496,"context_line":"        self._service_fixture_count[name] +\u003d 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"555ee552_3e85ee3e","line":493,"in_reply_to":"99e3f6f8_7844baec","updated":"2025-10-08 08:10:45.000000000","message":"not exactly, because the cell parameter is updated in the if statement","commit_id":"4de68c1f7b1bbc32c85589cde7d09ed02fe6b44f"}],"nova/tests/functional/test_service.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eef98cf9c32d12a2b53fe29437fa34270b40ff09","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        \"\"\"Tests that the cell cache for database transaction context managers"},{"line_number":52,"context_line":"        is cleared after a service reset (example scenario: SIGHUP)."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        self.assertFalse(nova_context.CELL_CACHE)"},{"line_number":55,"context_line":"        server_req \u003d self._build_server()"},{"line_number":56,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_req})"},{"line_number":57,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ddb3ba97_4d2bb404","side":"PARENT","line":54,"updated":"2025-10-08 07:55:52.000000000","message":"isn\u0027t that a behavioural change ?","commit_id":"cc742602bcdeff185ff120452e4f301398f6aa7b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5e3f3cb72d94dd463a000f56b439219b300dee79","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"\"\"Tests that the cell cache for database transaction context managers"},{"line_number":52,"context_line":"        is cleared after a service reset (example scenario: SIGHUP)."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        self.assertFalse(nova_context.CELL_CACHE)"},{"line_number":55,"context_line":"        server_req \u003d self._build_server()"},{"line_number":56,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_req})"},{"line_number":57,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"6a53ac9a_db6c81e8","side":"PARENT","line":54,"in_reply_to":"687d4ddf_a00e573a","updated":"2025-10-08 08:39:15.000000000","message":"I just verified and the nested cell cache in the context object is mostly private, nothing really loookups at it, so I think this patch wouldn\u0027t hit any check.","commit_id":"cc742602bcdeff185ff120452e4f301398f6aa7b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee3a2e94e4bd87624f0890041193c3c435f6c315","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        \"\"\"Tests that the cell cache for database transaction context managers"},{"line_number":52,"context_line":"        is cleared after a service reset (example scenario: SIGHUP)."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        self.assertFalse(nova_context.CELL_CACHE)"},{"line_number":55,"context_line":"        server_req \u003d self._build_server()"},{"line_number":56,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_req})"},{"line_number":57,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"687d4ddf_a00e573a","side":"PARENT","line":54,"in_reply_to":"d532bba8_8125ac4a","updated":"2025-10-08 08:24:47.000000000","message":"Hmmmm, I see, I just wonder whether it would create another bug if some code wants to make sure that the cell cache is False when we start the compute. \nI need to look at the whole code in order to make sure that we wouldn\u0027t regress.","commit_id":"cc742602bcdeff185ff120452e4f301398f6aa7b"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"04a614236d5c0e2c037143e29f7efee80b0ef611","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        \"\"\"Tests that the cell cache for database transaction context managers"},{"line_number":52,"context_line":"        is cleared after a service reset (example scenario: SIGHUP)."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        self.assertFalse(nova_context.CELL_CACHE)"},{"line_number":55,"context_line":"        server_req \u003d self._build_server()"},{"line_number":56,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_req})"},{"line_number":57,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"d532bba8_8125ac4a","side":"PARENT","line":54,"in_reply_to":"ddb3ba97_4d2bb404","updated":"2025-10-08 08:10:45.000000000","message":"Now when the start_service() function is called in test, it will update nova_context.CELL_CACHE object, that\u0027s why, in that specific test, that variable is not anymore empty.\nBut I don\u0027t think that assert is necessary because what we want to check in that test is if the reset() call purge the content of CELL_CACHE, and that\u0027s still the case","commit_id":"cc742602bcdeff185ff120452e4f301398f6aa7b"}]}