)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ecb67c572675babb494df19b0a05fe2ff61b39a0","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The alternative would be to only raise this exception"},{"line_number":23,"context_line":"when it is a boot from volume instance and rebuild has"},{"line_number":24,"context_line":"been called."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #2127017"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa88b5da_e633aaa6","line":24,"updated":"2025-10-08 01:24:22.000000000","message":"Is it possible for an Ironic instance to be volume-backed? If so, then I think we would want to do what\u0027s described in this sentence.\n\nWhen I commented last time, I had been thinking that it is not possible for an Ironic instance to be volume-backed, but if it can, then what would be the reason to not do this?","commit_id":"171dd76f7abb4a13075912faa469ce89c10a4a2b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ffc3c55bc0ac8004f9b5121eddc4cf2a282f058","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The alternative would be to only raise this exception"},{"line_number":23,"context_line":"when it is a boot from volume instance and rebuild has"},{"line_number":24,"context_line":"been called."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #2127017"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f5c4b63_197a9978","line":24,"in_reply_to":"8b18873e_17cbd63a","updated":"2026-01-28 09:45:35.000000000","message":"Yeah, I think we should error out on boot from volume, but I haven\u0027t had time to revisit this on I am afraid :( Although I can try take a look at that today.","commit_id":"171dd76f7abb4a13075912faa469ce89c10a4a2b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7daf0b960743614e5b8091f25e49f073d159936b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The alternative would be to only raise this exception"},{"line_number":23,"context_line":"when it is a boot from volume instance and rebuild has"},{"line_number":24,"context_line":"been called."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #2127017"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da57b613_b66f6b31","line":24,"in_reply_to":"9f5c4b63_197a9978","updated":"2026-01-28 10:57:20.000000000","message":"Done","commit_id":"171dd76f7abb4a13075912faa469ce89c10a4a2b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"70f46e0372668ed20824050c615e0b54c5791fd8","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The alternative would be to only raise this exception"},{"line_number":23,"context_line":"when it is a boot from volume instance and rebuild has"},{"line_number":24,"context_line":"been called."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #2127017"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8b18873e_17cbd63a","line":24,"in_reply_to":"fa88b5da_e633aaa6","updated":"2025-12-09 10:42:47.000000000","message":"I\u0027ve certainly used the boot from volume feature in the past (not for many years), so I guess this was the original of the check. Could we check to see if any volumes are attached to the instance and only fail the check if that is the case?","commit_id":"171dd76f7abb4a13075912faa469ce89c10a4a2b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38234,"name":"Ian Watson","display_name":"Ian Watson","email":"ianwatson92@hotmail.co.uk","username":"ianwatsonit"},"change_message_id":"388321a71bedf3011f6b5ab9204da50d6fc58c25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9197a32d_73030120","updated":"2026-01-28 20:15:53.000000000","message":"I have tested this patch against a live deployment and is working as intended.\n\nTest used openstack server rebuild $name --os-compute-api-version 2.93 before and after the patch. Before fails, after works","commit_id":"2c8f0e0b3a9c42260e86b894c4e5344a16b187bc"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e7cbf99482745e14bc2f403b6058387ae5fe01f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"537699c8_6dc4111f","updated":"2026-02-19 14:49:39.000000000","message":"Tested with a 2024.1 cherry-pick and the issue for me","commit_id":"2c8f0e0b3a9c42260e86b894c4e5344a16b187bc"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cb9187d6064da5e6644ef80fc88a370994401543","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8094af24_c571f844","in_reply_to":"9197a32d_73030120","updated":"2026-01-29 08:51:58.000000000","message":"\u003e I have tested this patch against a live deployment and is working as intended.\n\u003e \n\u003e Test used openstack server rebuild $name --os-compute-api-version 2.93 before and after the patch. Before fails, after works\n\nAh sweet, thank you Ian!","commit_id":"2c8f0e0b3a9c42260e86b894c4e5344a16b187bc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c4afe8d239045bd788f6763103e17e6b296e8376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7c6e5e61_5406783a","updated":"2026-04-13 22:23:50.000000000","message":"This looks OK to me.","commit_id":"c612c3886cee1b7136afdc65d471bcdaf32419e6"}],"nova/tests/unit/virt/ironic/test_driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c4afe8d239045bd788f6763103e17e6b296e8376","unresolved":true,"context_lines":[{"line_number":2352,"context_line":"    @mock.patch.object(ironic_driver.IronicDriver, \u0027_generate_configdrive\u0027)"},{"line_number":2353,"context_line":"    @mock.patch.object(configdrive, \u0027required_by\u0027)"},{"line_number":2354,"context_line":"    def test_rebuild_bfv_fails(self, mock_required_by,"},{"line_number":2355,"context_line":"                                      mock_configdrive):"},{"line_number":2356,"context_line":"        mock_required_by.return_value \u003d False"},{"line_number":2357,"context_line":"        block_device_info \u003d self._create_fake_block_device_info()"},{"line_number":2358,"context_line":"        e \u003d self.assertRaises(exception.NovaException,"}],"source_content_type":"text/x-python","patch_set":7,"id":"089f8c9b_78c02c01","line":2355,"updated":"2026-04-13 22:23:50.000000000","message":"Indentation got messed up here.","commit_id":"c612c3886cee1b7136afdc65d471bcdaf32419e6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c17679e3c76daf8331f13fa9762f6275d560e9cd","unresolved":true,"context_lines":[{"line_number":2352,"context_line":"    @mock.patch.object(ironic_driver.IronicDriver, \u0027_generate_configdrive\u0027)"},{"line_number":2353,"context_line":"    @mock.patch.object(configdrive, \u0027required_by\u0027)"},{"line_number":2354,"context_line":"    def test_rebuild_bfv_fails(self, mock_required_by,"},{"line_number":2355,"context_line":"                                      mock_configdrive):"},{"line_number":2356,"context_line":"        mock_required_by.return_value \u003d False"},{"line_number":2357,"context_line":"        block_device_info \u003d self._create_fake_block_device_info()"},{"line_number":2358,"context_line":"        e \u003d self.assertRaises(exception.NovaException,"}],"source_content_type":"text/x-python","patch_set":7,"id":"29620e14_324bf991","line":2355,"in_reply_to":"089f8c9b_78c02c01","updated":"2026-05-29 17:08:01.000000000","message":"hum agreed althouh i think its not worth a respine just for thsi.\n\nif the patch need a rebsase or respine for somethign else however lets fix that","commit_id":"c612c3886cee1b7136afdc65d471bcdaf32419e6"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1d12909bb639d82f38a346ea1be247772ee8771e","unresolved":true,"context_lines":[{"line_number":1732,"context_line":"        :param preserve_ephemeral: Boolean value; if True the ephemeral"},{"line_number":1733,"context_line":"            must be preserved on rebuild."},{"line_number":1734,"context_line":"        :param accel_uuids: Accelerator UUIDs. Ignored by this driver."},{"line_number":1735,"context_line":"        :param reimage_boot_volume: Re-image the volume backed instance."},{"line_number":1736,"context_line":"        \"\"\""},{"line_number":1737,"context_line":"        LOG.debug(\u0027Rebuild called for instance\u0027, instance\u003dinstance)"},{"line_number":1738,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a6b409e_5c792446","line":1735,"updated":"2025-10-07 15:48:38.000000000","message":"Just a suggestion: I think it might be helpful to include a sentence to the docstring for reimage_boot_volume to explain why the param is ignored for ironic driver.","commit_id":"0995bbf23a5c1ac292969e8d30bc9f237da8e8e5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c34141c59111c7cafc4fe3af77e1641e9c449d7d","unresolved":true,"context_lines":[{"line_number":1732,"context_line":"        :param preserve_ephemeral: Boolean value; if True the ephemeral"},{"line_number":1733,"context_line":"            must be preserved on rebuild."},{"line_number":1734,"context_line":"        :param accel_uuids: Accelerator UUIDs. Ignored by this driver."},{"line_number":1735,"context_line":"        :param reimage_boot_volume: Re-image the volume backed instance."},{"line_number":1736,"context_line":"        \"\"\""},{"line_number":1737,"context_line":"        LOG.debug(\u0027Rebuild called for instance\u0027, instance\u003dinstance)"},{"line_number":1738,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6ab72f57_ec10248c","line":1735,"in_reply_to":"3a6b409e_5c792446","updated":"2025-10-07 15:55:55.000000000","message":"oh, good idea.","commit_id":"0995bbf23a5c1ac292969e8d30bc9f237da8e8e5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7daf0b960743614e5b8091f25e49f073d159936b","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"        :param preserve_ephemeral: Boolean value; if True the ephemeral"},{"line_number":1733,"context_line":"            must be preserved on rebuild."},{"line_number":1734,"context_line":"        :param accel_uuids: Accelerator UUIDs. Ignored by this driver."},{"line_number":1735,"context_line":"        :param reimage_boot_volume: Re-image the volume backed instance."},{"line_number":1736,"context_line":"        \"\"\""},{"line_number":1737,"context_line":"        LOG.debug(\u0027Rebuild called for instance\u0027, instance\u003dinstance)"},{"line_number":1738,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b4fee99d_62f2d924","line":1735,"in_reply_to":"6ab72f57_ec10248c","updated":"2026-01-28 10:57:20.000000000","message":"Oops, updated that to reflect what is happening now.","commit_id":"0995bbf23a5c1ac292969e8d30bc9f237da8e8e5"}]}