)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1dab0809d5abdc85c406dc044160691532641ab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f2d935a_123acb54","updated":"2025-10-08 11:56:52.000000000","message":"when you have time plase also rebase the fix patch on top of this change","commit_id":"3a61a33c1c7d6e0ccdcf40a0fecc45f963311be9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"86a96a43c406bec1cf6e40fe916c2bce97b49e53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b9bb3b82_e2489640","updated":"2025-10-09 11:35:51.000000000","message":"i think this is reaonsble im wondering if we shoudl use restart_compute_service hence +1","commit_id":"05db317d702e552a39983d9923156a4f76a80612"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd3520ecc41998e97f46420c686888db2bbc7eeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"60ebb8d8_59a8180d","in_reply_to":"35cc90db_18cc5616","updated":"2025-10-10 09:53:15.000000000","message":"you cant assuem that that will happen.\n\nthe compute node can be arcived and undeleting is potitally actully a bug in the current logic.\n\nif you delete the compute service the compute node is expect to be deleted\ni think the undeleting behavior you are seeing is form the deprectead ironci code that is on trintended for use with the libvirt driver for example.\n\nthat code will be going away eventually and is actully over due for removal but we can likely move forward as is.","commit_id":"05db317d702e552a39983d9923156a4f76a80612"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"511c087d969d467d4fee6fd087e27033fdf652ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"35cc90db_18cc5616","in_reply_to":"b9bb3b82_e2489640","updated":"2025-10-09 12:19:06.000000000","message":"no because the restart_compute_service() function necessary creates a new compute node instead of undeleting the previous one","commit_id":"05db317d702e552a39983d9923156a4f76a80612"}],"nova/tests/functional/db/test_host_mapping.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6c50d5ca3db2a383cd14020a0f5cab0005a48bae","unresolved":true,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"class HostMappingDiscoveryTestFail(test.TestCase):"},{"line_number":224,"context_line":"    def setUp(self):"},{"line_number":225,"context_line":"        super(HostMappingDiscoveryTestFail, self).setUp()"},{"line_number":226,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        api_fixture \u003d self.useFixture(fixtures.OSAPIFixture("}],"source_content_type":"text/x-python","patch_set":1,"id":"a6b06b05_c2f409a7","line":225,"range":{"start_line":225,"start_character":7,"end_line":225,"end_character":57},"updated":"2025-10-08 11:56:23.000000000","message":"nit: this will work but you shoudl prefer\n```suggestion\n        super().setUp()\n```\nwhen writign new code.","commit_id":"3a61a33c1c7d6e0ccdcf40a0fecc45f963311be9"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"cad2c7e5e5732cb0e9c16f93bbf7a064148fa60e","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"class HostMappingDiscoveryTestFail(test.TestCase):"},{"line_number":224,"context_line":"    def setUp(self):"},{"line_number":225,"context_line":"        super(HostMappingDiscoveryTestFail, self).setUp()"},{"line_number":226,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        api_fixture \u003d self.useFixture(fixtures.OSAPIFixture("}],"source_content_type":"text/x-python","patch_set":1,"id":"173fa796_964d77e3","line":225,"range":{"start_line":225,"start_character":7,"end_line":225,"end_character":57},"in_reply_to":"a6b06b05_c2f409a7","updated":"2025-10-08 12:20:57.000000000","message":"done","commit_id":"3a61a33c1c7d6e0ccdcf40a0fecc45f963311be9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6c50d5ca3db2a383cd14020a0f5cab0005a48bae","unresolved":true,"context_lines":[{"line_number":270,"context_line":"        # Bug #2085135: node should be unmapped and be discoverable"},{"line_number":271,"context_line":"        self.assertEqual(node[\u0027mapped\u0027], 1)"},{"line_number":272,"context_line":"        mappings \u003d host_mapping.discover_hosts(self.ctxt, status_fn\u003dstatus)"},{"line_number":273,"context_line":"        self.assertEqual(0, len(mappings))"}],"source_content_type":"text/x-python","patch_set":1,"id":"d81a96df_fe1fa1f4","line":273,"updated":"2025-10-08 11:56:23.000000000","message":"this is corectly written as a repoducer regression test but its not in the correct folder can you move it to here https://github.com/openstack/nova/tree/master/nova/tests/functional/regressions","commit_id":"3a61a33c1c7d6e0ccdcf40a0fecc45f963311be9"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"cad2c7e5e5732cb0e9c16f93bbf7a064148fa60e","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        # Bug #2085135: node should be unmapped and be discoverable"},{"line_number":271,"context_line":"        self.assertEqual(node[\u0027mapped\u0027], 1)"},{"line_number":272,"context_line":"        mappings \u003d host_mapping.discover_hosts(self.ctxt, status_fn\u003dstatus)"},{"line_number":273,"context_line":"        self.assertEqual(0, len(mappings))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ed28308_91dc5e64","line":273,"in_reply_to":"d81a96df_fe1fa1f4","updated":"2025-10-08 12:20:57.000000000","message":"done","commit_id":"3a61a33c1c7d6e0ccdcf40a0fecc45f963311be9"}],"nova/tests/functional/regressions/test_bug_2085135.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"86a96a43c406bec1cf6e40fe916c2bce97b49e53","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        self.admin_api.microversion \u003d \u0027latest\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_discover_host_fail_after_service_deletion(self):"},{"line_number":37,"context_line":"        status \u003d lambda m: None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        # Create compute"},{"line_number":40,"context_line":"        host_name \u003d \"compute-1\""}],"source_content_type":"text/x-python","patch_set":3,"id":"30190661_675be7e8","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":31},"updated":"2025-10-09 11:35:51.000000000","message":"nit: hum i guess nova is not one of the project that has a lint check that prevent you saving lambdas to a variable. actully we might in production code and have it disabled in tests where its a loot more reaonsble.\n\nwe generally prefer inline fucntions if we want to name it.\nthis is because if we ever need to dubug it it show up better in a trace back and its eiaser to add logging but i guess in thei case neither are relevent.\n\nif you need to respien can you consider movign thie to line 75 right before its used or just update line 75 with\n\nmappings \u003d host_mapping.discover_hosts(self.ctxt, status_fn\u003dlambda m: None)\n\nthis si not a must we can merge this as is just a suggestion so no need to respin just for this.","commit_id":"05db317d702e552a39983d9923156a4f76a80612"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"a1a40d827f0494fff6b70f5d6ad1941f468b9478","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.admin_api.microversion \u003d \u0027latest\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_discover_host_fail_after_service_deletion(self):"},{"line_number":37,"context_line":"        status \u003d lambda m: None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        # Create compute"},{"line_number":40,"context_line":"        host_name \u003d \"compute-1\""}],"source_content_type":"text/x-python","patch_set":3,"id":"15813a8d_bd4a2ef0","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":31},"in_reply_to":"30190661_675be7e8","updated":"2025-10-09 12:32:20.000000000","message":"Done","commit_id":"05db317d702e552a39983d9923156a4f76a80612"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"86a96a43c406bec1cf6e40fe916c2bce97b49e53","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            objects.HostMapping.get_by_host,"},{"line_number":61,"context_line":"            self.ctxt, host_name)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Now recreate the service and compute node by updating its resources"},{"line_number":64,"context_line":"        # like if the services restarts"},{"line_number":65,"context_line":"        service.manager.update_available_resource(self.ctxt)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # At this point, service and compute come back to life"},{"line_number":68,"context_line":"        # with the same compute uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"be70b8e2_bbf80a54","line":65,"range":{"start_line":63,"start_character":8,"end_line":65,"end_character":60},"updated":"2025-10-09 11:35:51.000000000","message":"hum ok we actully od have a way to restart hte service in the functional jobs but i guess this work fine too.\n\nhttps://github.com/openstack/nova/blob/master/nova/test.py#L549-L597\n\ndoes that mask the bug if we use that helper?\n\nif so then lest keep with this approch\nif the bug is still present we may want to use this instead althoguh i guess you have deleted the comptue service so we ar enot really restart the service. we are starting a new comptue serivce with the same hostname.","commit_id":"05db317d702e552a39983d9923156a4f76a80612"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"511c087d969d467d4fee6fd087e27033fdf652ee","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            objects.HostMapping.get_by_host,"},{"line_number":61,"context_line":"            self.ctxt, host_name)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Now recreate the service and compute node by updating its resources"},{"line_number":64,"context_line":"        # like if the services restarts"},{"line_number":65,"context_line":"        service.manager.update_available_resource(self.ctxt)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # At this point, service and compute come back to life"},{"line_number":68,"context_line":"        # with the same compute uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"090d8023_3d1079f7","line":65,"range":{"start_line":63,"start_character":8,"end_line":65,"end_character":60},"in_reply_to":"be70b8e2_bbf80a54","updated":"2025-10-09 12:19:06.000000000","message":"exactly using the restart_service() function masks the bug","commit_id":"05db317d702e552a39983d9923156a4f76a80612"}]}