)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e5b766d44a1529dc447021ec13b3bbd05e36c6e3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     melanie witt \u003cmelwittt@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-09 18:44:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dump conf to debug log earlier in the WSGI app pipeline"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When CONF.log_options \u003d True, we dump the config to the DEBUG log and"},{"line_number":10,"context_line":"it can help with debugging issues to see whether a config has been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9988db28_2e5dc9ce","line":7,"updated":"2025-10-17 09:08:56.000000000","message":"This is confusing as the rest of th commit message and the code all agree that we move the dumping to *later* not earlier in the service startup sequence.","commit_id":"d6c6a8c50efefd0dc211579eacff01adbdbadd46"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ad40bdd0c0dd8255caf18f3c97c79b7d708119cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     melanie witt \u003cmelwittt@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-09 18:44:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dump conf to debug log earlier in the WSGI app pipeline"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When CONF.log_options \u003d True, we dump the config to the DEBUG log and"},{"line_number":10,"context_line":"it can help with debugging issues to see whether a config has been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"94acab29_362d81a7","line":7,"in_reply_to":"64b27412_69d6c294","updated":"2025-10-17 18:38:20.000000000","message":"Done","commit_id":"d6c6a8c50efefd0dc211579eacff01adbdbadd46"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4632281d467626ca07a7e365bc27d9d92f53f633","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     melanie witt \u003cmelwittt@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-09 18:44:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dump conf to debug log earlier in the WSGI app pipeline"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When CONF.log_options \u003d True, we dump the config to the DEBUG log and"},{"line_number":10,"context_line":"it can help with debugging issues to see whether a config has been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f534f1a8_6539ac0a","line":7,"in_reply_to":"9988db28_2e5dc9ce","updated":"2025-10-17 15:56:54.000000000","message":"right, good catch, it is stated correctly in message body but good to fix the title too.","commit_id":"d6c6a8c50efefd0dc211579eacff01adbdbadd46"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dcbf6896edb0019281253897a9643444e7dafe77","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     melanie witt \u003cmelwittt@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-09 18:44:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dump conf to debug log earlier in the WSGI app pipeline"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When CONF.log_options \u003d True, we dump the config to the DEBUG log and"},{"line_number":10,"context_line":"it can help with debugging issues to see whether a config has been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"64b27412_69d6c294","line":7,"in_reply_to":"f534f1a8_6539ac0a","updated":"2025-10-17 18:31:27.000000000","message":"I don\u0027t know how my brain thought the opposite word when I typed this 😩 thanks, I fix it.","commit_id":"d6c6a8c50efefd0dc211579eacff01adbdbadd46"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e5b766d44a1529dc447021ec13b3bbd05e36c6e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9be3112_485df74d","updated":"2025-10-17 09:08:56.000000000","message":"Change looks good but the commit message feels strange","commit_id":"d6c6a8c50efefd0dc211579eacff01adbdbadd46"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"90d29bc17486813b475b53fab9ddea86ba912728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c66fe42c_25369921","updated":"2025-10-15 17:56:26.000000000","message":"lgtm. it is working fine now.","commit_id":"d6c6a8c50efefd0dc211579eacff01adbdbadd46"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"638ed1433dcf6a5348380dbc3591dc9e163ccefe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"393f2068_5b6a31d3","updated":"2025-10-20 07:30:22.000000000","message":"Thanks. Looks good noe","commit_id":"45cdc1903b23646dcd8b1d4b23cfbb3ba62c8c4a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"49dc74cdac358473080d8ba7a523440ea2b74258","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a4708213_200536b7","updated":"2025-10-20 17:53:21.000000000","message":"recheck ssh timeout and Error: initializing source docker://quay.io/ceph/ceph:v19: Requesting bearer token: invalid status code from registry 504 (Gateway Timeout)","commit_id":"45cdc1903b23646dcd8b1d4b23cfbb3ba62c8c4a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bae9df3334b5461b47522d78e604b98345d9f955","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"388e9f1c_b7510ef6","updated":"2025-10-17 18:49:05.000000000","message":"thanks for update.","commit_id":"45cdc1903b23646dcd8b1d4b23cfbb3ba62c8c4a"}],"nova/api/openstack/wsgi_app.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"90d29bc17486813b475b53fab9ddea86ba912728","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    conf \u003d conf_files[0]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    app \u003d deploy.loadapp(\u0027config:%s\u0027 % conf, name\u003dname)"},{"line_number":145,"context_line":"    # We dump the conf after the WSGI app is loaded because some config options"},{"line_number":146,"context_line":"    # (such as the keystonemiddleware.auth_token options) are registered later"},{"line_number":147,"context_line":"    # in the pipeline."},{"line_number":148,"context_line":"    if CONF.log_options:"},{"line_number":149,"context_line":"        # dump conf at debug (log_options option comes from oslo.service)"},{"line_number":150,"context_line":"        CONF.log_opt_values("}],"source_content_type":"text/x-python","patch_set":1,"id":"c0d31347_d5be974c","line":147,"range":{"start_line":145,"start_character":0,"end_line":147,"end_character":22},"updated":"2025-10-15 17:56:26.000000000","message":"++, this is working fine. keystonemiddleware opts are initialzed here and we used to log config before that -  https://github.com/openstack/keystonemiddleware/blob/c893b626a252a6c3e18b51fa291bd54ffdb8c501/keystonemiddleware/auth_token/__init__.py#L922\n\nFrom the log, it is clear that config logging is happening correctly now:\n\nBefore this fix:\noslo.config started the logging first \n\n- https://zuul.opendev.org/t/openstack/build/825e801bae3a4275b21db2f7dd2f2849/log/controller/logs/screen-n-api.txt#113\n\nkeystonemiddleware opts are initialized after that, so those config opts are not logged\n- https://zuul.opendev.org/t/openstack/build/825e801bae3a4275b21db2f7dd2f2849/log/controller/logs/screen-n-api.txt#1830\n\nAfter this fix:\n\nkeystonemiddleware opts are initialized first\n\n- https://zuul.opendev.org/t/openstack/build/49978551ea374226bd05dd70fe42ed90/log/controller/logs/screen-n-api.txt#77\n\noslo.config started the logging after that\n- https://zuul.opendev.org/t/openstack/build/49978551ea374226bd05dd70fe42ed90/log/controller/logs/screen-n-api.txt#86\n\nkeystonemiddleware opts are logged in api service\n- https://zuul.opendev.org/t/openstack/build/49978551ea374226bd05dd70fe42ed90/log/controller/logs/screen-n-api.txt#1919","commit_id":"d6c6a8c50efefd0dc211579eacff01adbdbadd46"}]}
