)]}'
{"nova/api/openstack/contrib/volumes.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"970a2007656a1665efdd87db40503f3cb3cbed7b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":203,"context_line":"    if vol.get(\u0027instance_id\u0027):"},{"line_number":204,"context_line":"        d[\u0027serverId\u0027] \u003d vol[\u0027instance_id\u0027]"},{"line_number":205,"context_line":"    if vol.get(\u0027mountpoint\u0027):"},{"line_number":206,"context_line":"        d[\u0027device\u0027] \u003d vol[\u0027mountpoint\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7so%3D","side":"PARENT","line":203,"updated":"2011-10-19 21:35:45.000000000","message":"wonder if it would be better to change this to \u0027instance\u0027 vs \u0027instance_id\u0027 so this doesn\u0027t break if we decide to change volume table to have instance_uuid instead of instance_id.","commit_id":"b08d7f916679946b711572568a6d615ab4b47bb2"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"906bbb7f9c660c0e1dc9b2cbbd5c93b24caf6a41","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":203,"context_line":"    if vol.get(\u0027instance_id\u0027):"},{"line_number":204,"context_line":"        d[\u0027serverId\u0027] \u003d vol[\u0027instance_id\u0027]"},{"line_number":205,"context_line":"    if vol.get(\u0027mountpoint\u0027):"},{"line_number":206,"context_line":"        d[\u0027device\u0027] \u003d vol[\u0027mountpoint\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7iQ%3D","side":"PARENT","line":203,"in_reply_to":"AAAACX%2F%2F7mQ%3D","updated":"2011-10-20 17:40:38.000000000","message":"Sure.  You could change that line to:\n\u0027if vol.get(\u0027instance\u0027):\u0027\nso that if the \u0027instance\u0027 is None... it means there is no associated instance... It\u0027s the same thing as checking for \u0027instance_id\u0027 !\u003d 0, really.  But it makes slightly more sense to change it, since you access vol[\u0027instance\u0027] now on the next line.\n\nThe other thing I was thinking is that if we decide to change the foreign key from \u0027instance_id\u0027 to something else.. maybe \u0027instance_uuid\u0027... then this section of code wouldn\u0027t need to change at that time, either.   But this argument is probably pretty weak. :)","commit_id":"b08d7f916679946b711572568a6d615ab4b47bb2"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"c356e3df4f77bb2bba7565a8a661ab258e7fa748","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":203,"context_line":"    if vol.get(\u0027instance_id\u0027):"},{"line_number":204,"context_line":"        d[\u0027serverId\u0027] \u003d vol[\u0027instance_id\u0027]"},{"line_number":205,"context_line":"    if vol.get(\u0027mountpoint\u0027):"},{"line_number":206,"context_line":"        d[\u0027device\u0027] \u003d vol[\u0027mountpoint\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7mQ%3D","side":"PARENT","line":203,"in_reply_to":"AAAACX%2F%2F7so%3D","updated":"2011-10-20 14:12:32.000000000","message":"I\u0027m not sure I understand what you\u0027re asking for. Can you elaborate a bit? Thanks!","commit_id":"b08d7f916679946b711572568a6d615ab4b47bb2"}],"nova/api/openstack/servers.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"970a2007656a1665efdd87db40503f3cb3cbed7b","unresolved":false,"context_lines":[{"line_number":616,"context_line":"            except exception.NotFound:"},{"line_number":617,"context_line":"                raise exc.HTTPNotFound()"},{"line_number":618,"context_line":"            server_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        server_ref \u003d os.path.join(req.application_url, \u0027servers\u0027, server_uuid)"},{"line_number":621,"context_line":"        props \u003d {\u0027instance_ref\u0027: server_ref}"},{"line_number":622,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7sc%3D","line":619,"updated":"2011-10-19 21:35:45.000000000","message":"Can we just get rid of the integer ID stuff?  I\u0027d be cool with it.  :)  It really doesn\u0027t make sense with zones... so you could just use compute_api.get() vs the routing_get() if you want to keep the support for now.","commit_id":"26f94887c00c3c5d5bf0fb180bd68f5eb986f06b"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"970a2007656a1665efdd87db40503f3cb3cbed7b","unresolved":false,"context_lines":[{"line_number":906,"context_line":"                instance \u003d self.compute_api.routing_get(context, instance_id)"},{"line_number":907,"context_line":"            except exception.NotFound:"},{"line_number":908,"context_line":"                raise exc.HTTPNotFound()"},{"line_number":909,"context_line":"            server_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"        server_ref \u003d os.path.join(req.application_url, \u0027servers\u0027, server_uuid)"},{"line_number":912,"context_line":"        props \u003d {\u0027instance_ref\u0027: server_ref}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7sU%3D","line":909,"updated":"2011-10-19 21:35:45.000000000","message":"same as above.","commit_id":"26f94887c00c3c5d5bf0fb180bd68f5eb986f06b"}],"nova/tests/api/openstack/test_versions.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"970a2007656a1665efdd87db40503f3cb3cbed7b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from nova.api.openstack import wsgi"},{"line_number":29,"context_line":"from nova.api.openstack import xmlutil"},{"line_number":30,"context_line":"from nova.tests.api.openstack import common"},{"line_number":31,"context_line":"from nova.tests.api.openstack import fakes"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NS \u003d {"},{"line_number":34,"context_line":"    \u0027atom\u0027: \u0027http://www.w3.org/2005/Atom\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7rw%3D","side":"PARENT","line":31,"updated":"2011-10-19 21:35:45.000000000","message":"Mind fixing these imports to match HACKING since you had to add one here, anyway?","commit_id":"b08d7f916679946b711572568a6d615ab4b47bb2"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"c356e3df4f77bb2bba7565a8a661ab258e7fa748","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from nova.api.openstack import wsgi"},{"line_number":29,"context_line":"from nova.api.openstack import xmlutil"},{"line_number":30,"context_line":"from nova.tests.api.openstack import common"},{"line_number":31,"context_line":"from nova.tests.api.openstack import fakes"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NS \u003d {"},{"line_number":34,"context_line":"    \u0027atom\u0027: \u0027http://www.w3.org/2005/Atom\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7mU%3D","side":"PARENT","line":31,"in_reply_to":"AAAACX%2F%2F7rw%3D","updated":"2011-10-20 14:12:32.000000000","message":"Done","commit_id":"b08d7f916679946b711572568a6d615ab4b47bb2"}]}