)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"38fb4bd9bfd39f745878a0a995c7b690da01d23f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fba5da98_094bd808","updated":"2025-11-04 15:09:03.000000000","message":"Committed a comment from yesterday that I forgot to hit the button on. Either way I\u0027m sure I\u0027m not winning the autopep8 battle, so LGTM.","commit_id":"19a89b3765b6ff39092e404dce780835528cf42e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b8865eae4fb30643ab911e70834b4e8137ed3f93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1fc0e91_982eadde","updated":"2025-11-06 18:55:34.000000000","message":"i do not have a better solution really so if dan and other are fine with it im ok to move forward with this","commit_id":"0afb72e8831b8c46a3e3aa53addcc05617241a60"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af7b61e3876323a3c9df8decfd500aa5938102db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa3c1f72_652d6af2","updated":"2025-11-06 09:25:34.000000000","message":"recheck ceph \n```\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [None req-71380354-0022-47b2-b581-d024e66a5cce tempest-MigrationsAdminTest-1369875353 tempest-MigrationsAdminTest-1369875353-project-member] [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7] Setting instance vm_state to ERROR: nova.exception.SnapshotNotFound: Snapshot nova-resize could not be found.\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7] Traceback (most recent call last):\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]   File \"/opt/stack/nova/nova/compute/manager.py\", line 11550, in _error_out_instance_on_exception\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]     yield\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]   File \"/opt/stack/nova/nova/compute/manager.py\", line 6050, in _finish_revert_resize\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]     self.driver.finish_revert_migration(\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]   File \"/opt/stack/nova/nova/virt/libvirt/driver.py\", line 12765, in finish_revert_migration\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]     root_disk.rollback_to_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME)\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]   File \"/opt/stack/nova/nova/virt/libvirt/imagebackend.py\", line 1177, in rollback_to_snap\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]     return self.driver.rollback_to_snap(self.rbd_name, name)\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]   File \"/opt/stack/nova/nova/storage/rbd_utils.py\", line 509, in rollback_to_snap\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7]     raise exception.SnapshotNotFound(snapshot_id\u003dname)\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7] nova.exception.SnapshotNotFound: Snapshot nova-resize could not be found.\nNov 05 17:04:40.462256 npd23f9aed9a8f4 nova-compute[108351]: ERROR nova.compute.manager [instance: 1ab7f08a-f5a9-42e2-aa5f-cd1deabb07a7] ```","commit_id":"0afb72e8831b8c46a3e3aa53addcc05617241a60"}],"nova/cmd/baseproxy.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dab2d95f17ab8503732da7b84a5b73745445f1e8","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Base proxy module used to create compatible consoles"},{"line_number":18,"context_line":"for OpenStack Nova.\"\"\""},{"line_number":19,"context_line":"# autopep8: off"},{"line_number":20,"context_line":"from nova import monkey_patch; monkey_patch.patch()  # noqa"},{"line_number":21,"context_line":"# autopep8: on"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1227d6cc_8f1069ba","line":19,"updated":"2025-11-04 15:06:46.000000000","message":"This is unfortunate :/ Is this because it refuses to leave the single-line alone and doesn\u0027t honor the `# noqa`?\n\nWhat if we just made importing monkey_patch do the monkey patching at the end so we don\u0027t need this arrangement here?","commit_id":"19a89b3765b6ff39092e404dce780835528cf42e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"77d891edca9234d19bbfe5337df136b722063991","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Base proxy module used to create compatible consoles"},{"line_number":18,"context_line":"for OpenStack Nova.\"\"\""},{"line_number":19,"context_line":"# autopep8: off"},{"line_number":20,"context_line":"from nova import monkey_patch; monkey_patch.patch()  # noqa"},{"line_number":21,"context_line":"# autopep8: on"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"58575ff2_277581eb","line":19,"in_reply_to":"1227d6cc_8f1069ba","updated":"2025-11-04 15:40:06.000000000","message":"if the import does the monkey patching then I have no way to pass a flag with to change our default behavior. \n\nAnd yes we need both autopep8 and noqa tags to ensure autopep8 does not try to rearrange imports.","commit_id":"19a89b3765b6ff39092e404dce780835528cf42e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f2793d7985f506ef2462b95c00b4b090c73e58e0","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Base proxy module used to create compatible consoles"},{"line_number":18,"context_line":"for OpenStack Nova.\"\"\""},{"line_number":19,"context_line":"# autopep8: off"},{"line_number":20,"context_line":"from nova import monkey_patch; monkey_patch.patch()  # noqa"},{"line_number":21,"context_line":"# autopep8: on"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9e02ada4_238e3c66","line":19,"in_reply_to":"139d83ab_85111d27","updated":"2025-11-06 09:28:22.000000000","message":"even if a service is not monkey patched for eventlet we need to do couple of things at monkey patch time:\n* explicitly select the native treading oslo backend as the default is eventlet there\n* want to poision eventlet monkey patching to prevent accidental patching","commit_id":"19a89b3765b6ff39092e404dce780835528cf42e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"944868afe31872eced5ee26faad7e5e101255856","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Base proxy module used to create compatible consoles"},{"line_number":18,"context_line":"for OpenStack Nova.\"\"\""},{"line_number":19,"context_line":"# autopep8: off"},{"line_number":20,"context_line":"from nova import monkey_patch; monkey_patch.patch()  # noqa"},{"line_number":21,"context_line":"# autopep8: on"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"139d83ab_85111d27","line":19,"in_reply_to":"48f684d5_c3fe5854","updated":"2025-11-05 17:28:20.000000000","message":"looking at the follow up patch im kind of neutral on this\ni was hoping we could do it cleaner but im not sure if there is a better way.","commit_id":"19a89b3765b6ff39092e404dce780835528cf42e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0054e07ae84df84617b2a1270e13bfbf4def5c77","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Base proxy module used to create compatible consoles"},{"line_number":18,"context_line":"for OpenStack Nova.\"\"\""},{"line_number":19,"context_line":"# autopep8: off"},{"line_number":20,"context_line":"from nova import monkey_patch; monkey_patch.patch()  # noqa"},{"line_number":21,"context_line":"# autopep8: on"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"48f684d5_c3fe5854","line":19,"in_reply_to":"558e3b5b_9fde7b45","updated":"2025-11-05 17:06:21.000000000","message":"the other way to do this is what we did in watcher\n\nwe created an eventlet sub directory of cmd and moved the service that are eventlet monkeypatched into that\n\nhttps://github.com/openstack/watcher/commit/4f8c14646d4df20f1b296630307c905e7c2e12f4\n\nthen you can avoid having to do the monkey patch in all files but kep it clear which one are and are not patchable.\n\ni.e. the ones not in the eventlet dir are nerver patche and the ones in it can be based on teh env var.","commit_id":"19a89b3765b6ff39092e404dce780835528cf42e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"78aa0ed0841fe4ece078f53555bb3d32d4405983","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Base proxy module used to create compatible consoles"},{"line_number":18,"context_line":"for OpenStack Nova.\"\"\""},{"line_number":19,"context_line":"# autopep8: off"},{"line_number":20,"context_line":"from nova import monkey_patch; monkey_patch.patch()  # noqa"},{"line_number":21,"context_line":"# autopep8: on"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9e233b77_9afb4b03","line":19,"in_reply_to":"58575ff2_277581eb","updated":"2025-11-04 15:45:59.000000000","message":"You\u0027re not passing it a flag right now, so I\u0027m not sure what additional thing would be needed, but... okay.","commit_id":"19a89b3765b6ff39092e404dce780835528cf42e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd8650ebbc069d1a8fbdb3e9781ae698d5eccd9e","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Base proxy module used to create compatible consoles"},{"line_number":18,"context_line":"for OpenStack Nova.\"\"\""},{"line_number":19,"context_line":"# autopep8: off"},{"line_number":20,"context_line":"from nova import monkey_patch; monkey_patch.patch()  # noqa"},{"line_number":21,"context_line":"# autopep8: on"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"482fff98_93953fc7","line":19,"in_reply_to":"9e02ada4_238e3c66","updated":"2025-11-06 12:06:11.000000000","message":"ah good point on explcitly selecting the backend and setting up the mokey patch poison\n\ni forgot about that","commit_id":"19a89b3765b6ff39092e404dce780835528cf42e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ebec04493cb208d6aaa4f7c0dd68019484679fd0","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Base proxy module used to create compatible consoles"},{"line_number":18,"context_line":"for OpenStack Nova.\"\"\""},{"line_number":19,"context_line":"# autopep8: off"},{"line_number":20,"context_line":"from nova import monkey_patch; monkey_patch.patch()  # noqa"},{"line_number":21,"context_line":"# autopep8: on"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"558e3b5b_9fde7b45","line":19,"in_reply_to":"9e233b77_9afb4b03","updated":"2025-11-05 15:48:14.000000000","message":"the next patch starts passing a flag","commit_id":"19a89b3765b6ff39092e404dce780835528cf42e"}]}