)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3579d3f4bc5198f23dfb6cc5166f79745b5dcc37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1efeeaae_921f993c","updated":"2025-11-03 14:47:04.000000000","message":"this is very close to being correct","commit_id":"bc1cc356b69dce39b36d0852e8e8d47337487af2"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"bdfbc8635b2e2c132f41d840509ee3003261ccb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bf327e36_93921672","updated":"2025-11-04 08:46:23.000000000","message":"recheck - unrelated CI failure: detected leaked greenlets in nova.tests.functional.libvirt.test_pci_sriov_servers.PCIServersWithPortNUMAPoliciesTest.test_socket_policy_pass","commit_id":"cacb4cfbf55cb4358b1715a5318173f86943e233"}],"nova/tests/functional/regressions/test_bug_2088066.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3579d3f4bc5198f23dfb6cc5166f79745b5dcc37","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        final_attachments \u003d list("},{"line_number":92,"context_line":"            self.cinder.volume_ids_for_instance(server_id)"},{"line_number":93,"context_line":"        )"},{"line_number":94,"context_line":"        self.assertEqual("},{"line_number":95,"context_line":"            [], final_attachments, \"Volume attachments should be cleaned up\""},{"line_number":96,"context_line":"        )"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # allow build_and_run_instance to continue for clean up (also if this"},{"line_number":99,"context_line":"        # fails)"},{"line_number":100,"context_line":"        contd.set()"}],"source_content_type":"text/x-python","patch_set":1,"id":"757afb79_8a6fe4d5","line":97,"range":{"start_line":94,"start_character":7,"end_line":97,"end_character":1},"updated":"2025-11-03 14:47:04.000000000","message":"so this is th primarly assertion the represent the bug\n\nsicne this is the repoducer test before the fix you shoudl add a fix me comment before this line and update this to self.assertNotEqual(\n\nthen in the next patch you will remove the fixme and revert this back to assertEqual showign the bug is fixed.","commit_id":"bc1cc356b69dce39b36d0852e8e8d47337487af2"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"0abe731dd83fb356033d139769e4489ed73a7cbb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        final_attachments \u003d list("},{"line_number":92,"context_line":"            self.cinder.volume_ids_for_instance(server_id)"},{"line_number":93,"context_line":"        )"},{"line_number":94,"context_line":"        self.assertEqual("},{"line_number":95,"context_line":"            [], final_attachments, \"Volume attachments should be cleaned up\""},{"line_number":96,"context_line":"        )"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # allow build_and_run_instance to continue for clean up (also if this"},{"line_number":99,"context_line":"        # fails)"},{"line_number":100,"context_line":"        contd.set()"}],"source_content_type":"text/x-python","patch_set":1,"id":"277ef58f_65ac0a58","line":97,"range":{"start_line":94,"start_character":7,"end_line":97,"end_character":1},"in_reply_to":"757afb79_8a6fe4d5","updated":"2025-12-09 09:24:57.000000000","message":"marked as resolved as comment is in place","commit_id":"bc1cc356b69dce39b36d0852e8e8d47337487af2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1d5e642dedfa530a0d7157f459dc9af5e400dda5","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        final_attachments \u003d list("},{"line_number":92,"context_line":"            self.cinder.volume_ids_for_instance(server_id)"},{"line_number":93,"context_line":"        )"},{"line_number":94,"context_line":"        # FIXME: This is a regression check before the fix for bug 2088066"},{"line_number":95,"context_line":"        self.assertNotEqual("},{"line_number":96,"context_line":"            [], final_attachments, \"Volume attachments should be cleaned up\""},{"line_number":97,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ae545f5_dafe8d7d","line":94,"range":{"start_line":94,"start_character":9,"end_line":94,"end_character":15},"updated":"2025-11-03 15:26:36.000000000","message":"nit: i think we enfoce FIXME(name): at least in production code we may not in test code so if the pep8 tests fail on this just update it if not this is remvoed in teh next patch anyways so its not a big deal provide ci passes on this patch.","commit_id":"cacb4cfbf55cb4358b1715a5318173f86943e233"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"0abe731dd83fb356033d139769e4489ed73a7cbb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        final_attachments \u003d list("},{"line_number":92,"context_line":"            self.cinder.volume_ids_for_instance(server_id)"},{"line_number":93,"context_line":"        )"},{"line_number":94,"context_line":"        # FIXME: This is a regression check before the fix for bug 2088066"},{"line_number":95,"context_line":"        self.assertNotEqual("},{"line_number":96,"context_line":"            [], final_attachments, \"Volume attachments should be cleaned up\""},{"line_number":97,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"ce98271b_d5cc3fc1","line":94,"range":{"start_line":94,"start_character":9,"end_line":94,"end_character":15},"in_reply_to":"7ae545f5_dafe8d7d","updated":"2025-12-09 09:24:57.000000000","message":"Acknowledged","commit_id":"cacb4cfbf55cb4358b1715a5318173f86943e233"}]}