)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7525ee0f8a1f246c49dc7628af6620a36ac913a9","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Set vnic model and queue for VDPA"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set model to viritio and allow to set queues parameter"},{"line_number":10,"context_line":"when using VDPA vnic type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2131150"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"78715382_0fa79e1e","line":10,"updated":"2025-11-12 14:40:58.000000000","message":"its alrady virtio by default\n\nand we cant set queue reliblay due to libvir tissues\ntoday.","commit_id":"cdc3dba923c29b7eaf1221612cb8a085c6f4fe80"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c4e93ec624c833cefc4df5a9fb1cab9d0864cb87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb842aa6_48bfd0e4","updated":"2025-11-12 15:38:42.000000000","message":"this is supported from 8.2.0 libvirt version so higly likely we need to bump minimal version https://github.com/libvirt/libvirt/commit/a5e659f071ae5f5fc9aadb46ad7c31736425f8cf","commit_id":"e8f902f41f56c3034f9b3b101a2c5ffce2bb7e27"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7525ee0f8a1f246c49dc7628af6620a36ac913a9","unresolved":true,"context_lines":[{"line_number":1959,"context_line":"            if self.driver_iommu:"},{"line_number":1960,"context_line":"                drv_elem.set(\"iommu\", \"on\")"},{"line_number":1961,"context_line":"            if self.driver_packed:"},{"line_number":1962,"context_line":"                drv_elem.set(\"packed\", \"on\")"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"        if drv_elem is not None:"},{"line_number":1965,"context_line":"            if self.vhost_queues is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f542d076_432a771b","line":1962,"updated":"2025-11-12 14:40:58.000000000","message":"the iommu and packed format are not mentioned in the commit but also are not required and or nessiarly supproted with vdpa.\n\nadding supprot for them is technially a feature not a bug.","commit_id":"cdc3dba923c29b7eaf1221612cb8a085c6f4fe80"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7525ee0f8a1f246c49dc7628af6620a36ac913a9","unresolved":true,"context_lines":[{"line_number":201,"context_line":"        if ("},{"line_number":202,"context_line":"            vnic_type in network_model.VNIC_TYPES_DIRECT_PASSTHROUGH and"},{"line_number":203,"context_line":"            vnic_type !\u003d network_model.VNIC_TYPE_VDPA"},{"line_number":204,"context_line":"        ):"},{"line_number":205,"context_line":"            designer.set_vif_guest_frontend_config("},{"line_number":206,"context_line":"                conf, mac, model, driver, vhost_queues, rx_queue_size, packed)"},{"line_number":207,"context_line":"            return conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"12d727fb_52498850","line":204,"updated":"2025-11-12 14:40:58.000000000","message":"vdpa was intentilly not included before because there was no documented way to do this.\n\nim not entirly agaisnt this idea as it was on our down stream backlog\n\nhttps://issues.redhat.com/browse/OSPRH-256\n\nbut when i orginally develop the vdpa supprot for nova i did test this and it did not work so somewhere along the way and we need ot know when so we can document the version as requirement and add checks if required in the code\n\n\nnow i know that it has been claimed that multi queue can work if you config it via vdpa tool but we explicit don\u0027t use that and we know that there is a existrg gap in qemu supprot when qemu and the vdpa tool are both used on the same device.\n\nrelated to \nhttps://patchwork.ozlabs.org/project/qemu-devel/list/?series\u003d453198\nhttps://issues.redhat.com/browse/RHEL-7298\n\nif we are going to impement this featue we need to be very claer on teh rquirement.,","commit_id":"cdc3dba923c29b7eaf1221612cb8a085c6f4fe80"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2d54c9fc8b8c66370bf29dbea75e001f5b9b58d8","unresolved":true,"context_lines":[{"line_number":201,"context_line":"        if ("},{"line_number":202,"context_line":"            vnic_type in network_model.VNIC_TYPES_DIRECT_PASSTHROUGH and"},{"line_number":203,"context_line":"            vnic_type !\u003d network_model.VNIC_TYPE_VDPA"},{"line_number":204,"context_line":"        ):"},{"line_number":205,"context_line":"            designer.set_vif_guest_frontend_config("},{"line_number":206,"context_line":"                conf, mac, model, driver, vhost_queues, rx_queue_size, packed)"},{"line_number":207,"context_line":"            return conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"b74b6921_b97d2bc9","line":204,"in_reply_to":"12d727fb_52498850","updated":"2025-11-13 07:33:18.000000000","message":"I\u0027ve tested different scenarios\n\n* When vdpa device has less number of queues configured rather than libvirt. In this case VM can see only number of queues configured on VDPA. no issues with booting found.\n\n* When vdpa has more queues than domain xml, in this case performance is low (on 10Gb nic mode connect 6DX with 1 queue I can only get 5.6Gbps for iperf3 -P15, while with 2 and more queues it shows 9.6Gbs). \n\n* with packed queues multiqueue works fine\n```\n    \u003cinterface type\u003d\u0027vdpa\u0027\u003e                                                                                                                                                                \n      \u003cmac address\u003d\u002752:54:00:cb:46:02\u0027/\u003e                                                                                                                                                   \n      \u003csource dev\u003d\u0027/dev/vhost-vdpa-1\u0027/\u003e                                                                                                                                                    \n      \u003cmodel type\u003d\u0027virtio\u0027/\u003e                                                                                                                                                               \n      \u003cdriver name\u003d\u0027vhost\u0027 queues\u003d\u00278\u0027 packed\u003d\u0027on\u0027/\u003e                                                                                                                                        \n      \u003calias name\u003d\u0027net0\u0027/\u003e                                                                                                                                                                 \n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x03\u0027 function\u003d\u00270x0\u0027/\u003e                                                                                                          \n    \u003c/interface\u003e\n```\n\nIn libvirt multiqueue support was added in 8.2.0 release https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/D5QUZT2ZCUKF2526EOLGCB5JWCHHTIRV/?sort\u003dthread probably the easies option is to bump minor minimal libvirt version.\nMinimal version of qemu already supports multiqueues https://github.com/qemu/qemu/commit/402378407dbdce79ce745a13f5c84815f929cfdd","commit_id":"cdc3dba923c29b7eaf1221612cb8a085c6f4fe80"}]}
