)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3d82363cea0a79546b92819d40f5f5c28eeadf21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87661ccc_2f4175c2","updated":"2025-11-20 16:53:55.000000000","message":"just two notes. Thanks for the PoC","commit_id":"9c5a280ee6280172dfa3bbd60bf6b7595c13a3a1"}],"nova/compute/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff08d4dbb7a6e10031fbe6fad9b7905be42a6419","unresolved":true,"context_lines":[{"line_number":1795,"context_line":"        # status tracking. For example, we can track all"},{"line_number":1796,"context_line":"        # in-progress operations on compute and once all are"},{"line_number":1797,"context_line":"        # finished then we signal here to stop this rpcserver."},{"line_number":1798,"context_line":"        # time.sleep(180)"},{"line_number":1799,"context_line":"        pass"},{"line_number":1800,"context_line":""},{"line_number":1801,"context_line":"    def cleanup_host(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"59591bb2_35237ee3","line":1798,"range":{"start_line":1798,"start_character":0,"end_line":1798,"end_character":25},"updated":"2025-11-17 19:04:45.000000000","message":"I am commenting this time out because I am stoping service in my devstack env by systemd and that has its own timeout and stop service before this timeout. need to check how we can increase systemd/oslo service timeout so that we can have expected wait in finish_tasks()","commit_id":"aefffebe8efe73c4fe5de668edb719f2c6dfad2e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"882020063c1d5f8ed9cf9ecd30afcfca99f802f5","unresolved":false,"context_lines":[{"line_number":1795,"context_line":"        # status tracking. For example, we can track all"},{"line_number":1796,"context_line":"        # in-progress operations on compute and once all are"},{"line_number":1797,"context_line":"        # finished then we signal here to stop this rpcserver."},{"line_number":1798,"context_line":"        # time.sleep(180)"},{"line_number":1799,"context_line":"        pass"},{"line_number":1800,"context_line":""},{"line_number":1801,"context_line":"    def cleanup_host(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"6cb58daa_4a290fa9","line":1798,"range":{"start_line":1798,"start_character":0,"end_line":1798,"end_character":25},"in_reply_to":"59591bb2_35237ee3","updated":"2025-11-18 03:31:49.000000000","message":"Done. we can modify the graceful_shutdown_timeout config in nova cpu conf file to soemthing higher time than wait time here.","commit_id":"aefffebe8efe73c4fe5de668edb719f2c6dfad2e"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3d82363cea0a79546b92819d40f5f5c28eeadf21","unresolved":true,"context_lines":[{"line_number":668,"context_line":"        # Once shutdown is initiated,, source compute stop listening"},{"line_number":669,"context_line":"        # to this call (\u0027compute\u0027 topic queue) and RPC call will raise"},{"line_number":670,"context_line":"        # timeout exception to destination compute which will tell"},{"line_number":671,"context_line":"        # conductor task to fail the live migration."},{"line_number":672,"context_line":"        cctxt \u003d client.prepare(server\u003dsource, version\u003dversion)"},{"line_number":673,"context_line":"        return cctxt.call(ctxt, \u0027check_can_live_migrate_source\u0027,"},{"line_number":674,"context_line":"                          instance\u003dinstance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"a0637baa_62cf3397","line":671,"updated":"2025-11-20 16:53:55.000000000","message":"If dest compute is not in shutdown and sent this RPC call to the source host and the source host is in shutdown. Then The dest compute can wait for the RPC timeout normally and then abort the live migration. We should verify that such abort will put the migration properly to error.","commit_id":"9c5a280ee6280172dfa3bbd60bf6b7595c13a3a1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8b69618b4d749f1a725bcd20d51e9ca96a205ad","unresolved":true,"context_lines":[{"line_number":668,"context_line":"        # Once shutdown is initiated,, source compute stop listening"},{"line_number":669,"context_line":"        # to this call (\u0027compute\u0027 topic queue) and RPC call will raise"},{"line_number":670,"context_line":"        # timeout exception to destination compute which will tell"},{"line_number":671,"context_line":"        # conductor task to fail the live migration."},{"line_number":672,"context_line":"        cctxt \u003d client.prepare(server\u003dsource, version\u003dversion)"},{"line_number":673,"context_line":"        return cctxt.call(ctxt, \u0027check_can_live_migrate_source\u0027,"},{"line_number":674,"context_line":"                          instance\u003dinstance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bed86c5e_8d40f126","line":671,"in_reply_to":"a0637baa_62cf3397","updated":"2026-01-27 19:40:53.000000000","message":"ack, I will check if I can write some test for that to check migrations proper state.","commit_id":"9c5a280ee6280172dfa3bbd60bf6b7595c13a3a1"}],"nova/service.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3d82363cea0a79546b92819d40f5f5c28eeadf21","unresolved":true,"context_lines":[{"line_number":321,"context_line":"            LOG.debug(\u0027%s service stopping RPC server on topic: %s\u0027,"},{"line_number":322,"context_line":"                      self.binary, self.topic)"},{"line_number":323,"context_line":"            self.rpcserver.stop()"},{"line_number":324,"context_line":"            self.rpcserver.wait()"},{"line_number":325,"context_line":"            LOG.debug(\u0027%s service stopped RPC server on topic: %s\u0027,"},{"line_number":326,"context_line":"                      self.binary, self.topic)"},{"line_number":327,"context_line":"            if self.rpcserver_2 is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"218842b4_1008fcef","line":324,"updated":"2025-11-20 16:53:55.000000000","message":"so this will wait for any direct RPC1 handler threads to finish. So if such an RCP handler initiated further operations and waiting for the result then that will be waited here. This will already happen within the graceful shutdown time period. So it needs to be calculated in the total timeout.\n\nAfter all those RPC handlers are finished we can still have threads in our thread pools waiting for things. All those things expected to arrive via the RPC2 which is still operation at this point.","commit_id":"9c5a280ee6280172dfa3bbd60bf6b7595c13a3a1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8b69618b4d749f1a725bcd20d51e9ca96a205ad","unresolved":true,"context_lines":[{"line_number":321,"context_line":"            LOG.debug(\u0027%s service stopping RPC server on topic: %s\u0027,"},{"line_number":322,"context_line":"                      self.binary, self.topic)"},{"line_number":323,"context_line":"            self.rpcserver.stop()"},{"line_number":324,"context_line":"            self.rpcserver.wait()"},{"line_number":325,"context_line":"            LOG.debug(\u0027%s service stopped RPC server on topic: %s\u0027,"},{"line_number":326,"context_line":"                      self.binary, self.topic)"},{"line_number":327,"context_line":"            if self.rpcserver_2 is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"a88aad13_5a8838e0","line":324,"in_reply_to":"218842b4_1008fcef","updated":"2026-01-27 19:40:53.000000000","message":"good point. ack.","commit_id":"9c5a280ee6280172dfa3bbd60bf6b7595c13a3a1"}]}