)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffca954d6e1b3d9f7d2e714af09539159074329d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"values (maximum and used) should be returned in MiB (mebibytes)."},{"line_number":11,"context_line":"However, the libvirt driver was incorrectly dividing the memory"},{"line_number":12,"context_line":"values from libvirt by units.Mi instead of units.Ki, resulting in"},{"line_number":13,"context_line":"values being returned in GB instead of MiB."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This inconsistency caused confusion between what the API documentation"},{"line_number":16,"context_line":"stated and what was actually returned, especially when web GUIs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ee7b453_929969b3","line":13,"updated":"2025-11-19 11:13:24.000000000","message":"https://docs.openstack.org/api-ref/compute/#id144\n\nso yes prior to 2.48 the respocne was driver defiend \nin 2.48+ its sandarized.\n\nhowever that raises a question o fshould we do the normalisation of this value in teh api or not based on the microverison\n\ni think its oke to do it alwasy but if we are beign strict about it we shoudl technially only do it form 2.48+\n\n\nin the 2.1 responce we can see the memory was returned in what looks like kb\n\n{\n    \"cpu0_time\": 17300000000,\n    \"memory\": 524288,\n    \"vda_errors\": -1,\n    \"vda_read\": 262144,\n    \"vda_read_req\": 112,\n    \"vda_write\": 5778432,\n    \"vda_write_req\": 488,\n    \"vnet1_rx\": 2070139,\n    \"vnet1_rx_drop\": 0,\n    \"vnet1_rx_errors\": 0,\n    \"vnet1_rx_packets\": 26701,\n    \"vnet1_tx\": 140208,\n    \"vnet1_tx_drop\": 0,\n    \"vnet1_tx_errors\": 0,\n    \"vnet1_tx_packets\": 662\n}\n\nyou are correct that the domain info api is deocumented as using KBytes which are KiBs\nhttps://libvirt.org/html/libvirt-libvirt-domain.html#virDomainInfo\n\nbut the definiton we have had for this function in the libvirt driver from day 1 has deviced by MiB\n\nhttps://opendev.org/openstack/nova/commit/f9b5dba7b0612222b20a1d63f494b85c63c0e47e\n\ni think at some poiint libvirt changed form reutrning bytes to returnign KiBs instead or this has just alwasy been wrong.\n\nin that case it may be more correct to update the api ref to match the actual behavior\n\nim no agians actully fixing this but im concerned that this would technally be a breakign api change and that the fix shoudl have an api microveron\n\non the other hand just making the api respocen match the docuemted behavior shoudl nto need a micoverion in genral so i would liek to see what others think\n\n\noverall i think the change looks good. its just not clear that the correct way to fix this is in the driver vs the api.","commit_id":"f949a02081d54dfc2ee258d523ff7b07ce488e81"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"89bd2bf9bc54a860af33c6156d667f2bd506c90c","unresolved":true,"context_lines":[{"line_number":10,"context_line":"values (maximum and used) should be returned in MiB (mebibytes)."},{"line_number":11,"context_line":"However, the libvirt driver was incorrectly dividing the memory"},{"line_number":12,"context_line":"values from libvirt by units.Mi instead of units.Ki, resulting in"},{"line_number":13,"context_line":"values being returned in GB instead of MiB."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This inconsistency caused confusion between what the API documentation"},{"line_number":16,"context_line":"stated and what was actually returned, especially when web GUIs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2695213b_e300808c","line":13,"in_reply_to":"7ee7b453_929969b3","updated":"2025-11-20 09:53:48.000000000","message":"Thanks for explanation, I have updated the change and commit message as suggested.","commit_id":"f949a02081d54dfc2ee258d523ff7b07ce488e81"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffca954d6e1b3d9f7d2e714af09539159074329d","unresolved":true,"context_lines":[{"line_number":27,"context_line":"- API documentation specifies memory_details should be in MiB"},{"line_number":28,"context_line":"- Conversion: KiB / 1024 \u003d MiB"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Commit-message-assisted-by: claude-4.5-sonnet"},{"line_number":31,"context_line":"Closes-Bug: #2131563"},{"line_number":32,"context_line":"Signed-off-by: Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":33,"context_line":"Change-Id: I53be87f881c7c1409385c079f02df206d876af00"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"676990a0_78aa4c94","line":30,"updated":"2025-11-19 11:13:24.000000000","message":"you should add \n\n`Assisted-By:` not `Commit-message-assisted-by:`","commit_id":"f949a02081d54dfc2ee258d523ff7b07ce488e81"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"89bd2bf9bc54a860af33c6156d667f2bd506c90c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- API documentation specifies memory_details should be in MiB"},{"line_number":28,"context_line":"- Conversion: KiB / 1024 \u003d MiB"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Commit-message-assisted-by: claude-4.5-sonnet"},{"line_number":31,"context_line":"Closes-Bug: #2131563"},{"line_number":32,"context_line":"Signed-off-by: Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":33,"context_line":"Change-Id: I53be87f881c7c1409385c079f02df206d876af00"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a70e3738_e41da8ea","line":30,"in_reply_to":"676990a0_78aa4c94","updated":"2025-11-20 09:53:48.000000000","message":"Done","commit_id":"f949a02081d54dfc2ee258d523ff7b07ce488e81"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffca954d6e1b3d9f7d2e714af09539159074329d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a4ebe189_86fd1ae6","updated":"2025-11-19 11:13:24.000000000","message":"-1 is mainly because the ai atibutation is incorrect\n\nhttps://openinfra.org/legal/ai-policy\n\nbut also to hilight the other open quetion i have in the commit message\nnamely can we change the unit of the report value without a microveron because we are just changing it to aling with the docuemtned values.\n\neven though this has been wrong since day 1.","commit_id":"f949a02081d54dfc2ee258d523ff7b07ce488e81"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"90cae72f94b1acbe2a43fd15fe898aba06dd6235","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"71bc5849_22faf3b8","updated":"2025-12-12 05:34:50.000000000","message":"recheck nova-ceph-multistore","commit_id":"45b685e4c900c80e6b4c7ce0505b90c8ef74d354"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"66d4aa4aa3964123d9bbdf2b9e4f4d2acc33f829","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d890cecd_5b757453","updated":"2025-12-11 14:16:20.000000000","message":"recheck nova-ceph-multistore \u0027tempest.lib.exceptions.SSHTimeout\u0027","commit_id":"45b685e4c900c80e6b4c7ce0505b90c8ef74d354"}],"nova/virt/fake.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffca954d6e1b3d9f7d2e714af09539159074329d","unresolved":true,"context_lines":[{"line_number":442,"context_line":"                       write_bytes\u003d5778432,"},{"line_number":443,"context_line":"                       write_requests\u003d488,"},{"line_number":444,"context_line":"                       errors_count\u003d1)"},{"line_number":445,"context_line":"        # memory values are in KiB, convert to MiB as documented in the API"},{"line_number":446,"context_line":"        # reference (consistent with libvirt driver)"},{"line_number":447,"context_line":"        diags.memory_details \u003d diagnostics_obj.MemoryDiagnostics("},{"line_number":448,"context_line":"            maximum\u003d524288 / units.Ki, used\u003d0)"},{"line_number":449,"context_line":"        return diags"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    def get_all_volume_usage(self, context, compute_host_bdms):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aadaed0_07355ad3","line":448,"range":{"start_line":445,"start_character":8,"end_line":448,"end_character":46},"updated":"2025-11-19 11:13:24.000000000","message":"nit: we do not need to do this device over and over again for a hard coded value\nyou shoudl just put 512 here\n\nif you want to keep a comment tha tits in units of MiBs then thats fine.","commit_id":"f949a02081d54dfc2ee258d523ff7b07ce488e81"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"89bd2bf9bc54a860af33c6156d667f2bd506c90c","unresolved":false,"context_lines":[{"line_number":442,"context_line":"                       write_bytes\u003d5778432,"},{"line_number":443,"context_line":"                       write_requests\u003d488,"},{"line_number":444,"context_line":"                       errors_count\u003d1)"},{"line_number":445,"context_line":"        # memory values are in KiB, convert to MiB as documented in the API"},{"line_number":446,"context_line":"        # reference (consistent with libvirt driver)"},{"line_number":447,"context_line":"        diags.memory_details \u003d diagnostics_obj.MemoryDiagnostics("},{"line_number":448,"context_line":"            maximum\u003d524288 / units.Ki, used\u003d0)"},{"line_number":449,"context_line":"        return diags"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    def get_all_volume_usage(self, context, compute_host_bdms):"}],"source_content_type":"text/x-python","patch_set":2,"id":"abf8e478_596f93a0","line":448,"range":{"start_line":445,"start_character":8,"end_line":448,"end_character":46},"in_reply_to":"9aadaed0_07355ad3","updated":"2025-11-20 09:53:48.000000000","message":"Done","commit_id":"f949a02081d54dfc2ee258d523ff7b07ce488e81"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffca954d6e1b3d9f7d2e714af09539159074329d","unresolved":true,"context_lines":[{"line_number":12929,"context_line":"        # as documented in the API reference"},{"line_number":12930,"context_line":"        diags.memory_details \u003d diagnostics_obj.MemoryDiagnostics("},{"line_number":12931,"context_line":"            maximum\u003dmax_mem / units.Ki,"},{"line_number":12932,"context_line":"            used\u003dmem / units.Ki)"},{"line_number":12933,"context_line":""},{"line_number":12934,"context_line":"        # get cpu time, might launch an exception if the method"},{"line_number":12935,"context_line":"        # is not supported by the underlying hypervisor being"}],"source_content_type":"text/x-python","patch_set":2,"id":"adaae07f_2b2f5c6a","line":12932,"updated":"2025-11-19 11:13:24.000000000","message":"ack so this is the real fix","commit_id":"f949a02081d54dfc2ee258d523ff7b07ce488e81"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"89bd2bf9bc54a860af33c6156d667f2bd506c90c","unresolved":false,"context_lines":[{"line_number":12929,"context_line":"        # as documented in the API reference"},{"line_number":12930,"context_line":"        diags.memory_details \u003d diagnostics_obj.MemoryDiagnostics("},{"line_number":12931,"context_line":"            maximum\u003dmax_mem / units.Ki,"},{"line_number":12932,"context_line":"            used\u003dmem / units.Ki)"},{"line_number":12933,"context_line":""},{"line_number":12934,"context_line":"        # get cpu time, might launch an exception if the method"},{"line_number":12935,"context_line":"        # is not supported by the underlying hypervisor being"}],"source_content_type":"text/x-python","patch_set":2,"id":"b3ae2b2d_2f0d643c","line":12932,"in_reply_to":"adaae07f_2b2f5c6a","updated":"2025-11-20 09:53:48.000000000","message":"Acknowledged","commit_id":"f949a02081d54dfc2ee258d523ff7b07ce488e81"}]}