)]}'
{"id":"openstack%2Fnova~967570","triplet_id":"openstack%2Fnova~unmaintained%2F2024.1~I4a7b4ecf69cfe04c5291e5ca2a76db8829d6e592","project":"openstack/nova","branch":"unmaintained/2024.1","topic":"libvirt-tap-managed-no","attention_set":{},"removed_from_attention_set":{"17685":{"account":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"last_update":"2025-11-25 16:25:22.000000000","reason":"\u003cGERRIT_ACCOUNT_17685\u003e replied on the change","reason_account":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},"13734":{"account":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"last_update":"2025-11-25 18:31:01.000000000","reason":"Change was submitted"},"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2025-11-25 18:31:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4a7b4ecf69cfe04c5291e5ca2a76db8829d6e592","subject":"Add managed\u003d\u0027no\u0027 flag to libvirt XML definition for VIF type TAP","status":"MERGED","created":"2025-11-18 15:10:25.000000000","updated":"2025-11-25 18:32:40.000000000","submitted":"2025-11-25 18:31:01.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"967570-libvirt-tap-managed-no","cherry_pick_of_change":967569,"cherry_pick_of_patch_set":2,"meta_rev_id":"58bf30de926d7f13f1618fdca4d3ae0e4009bc3c","_number":967570,"virtual_id_number":967570,"owner":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-11-25 18:31:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2025-11-25 16:25:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":1,"date":"2025-11-18 16:26:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2025-11-25 16:25:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-18 16:26:16.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2025-11-18 16:26:16.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2025-11-18 17:33:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-11-19 10:48:03.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"b001188d00a951b35dad5a3c3d78badf629eac07","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"date":"2025-11-18 15:10:25.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"0a44c91ad143333eae6f1b71fd84a845219e761c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"date":"2025-11-18 15:20:34.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"75994efd7d6babc88d91cb3f2d850dcd29bb2e9a","tag":"autogenerated:gerrit:restore","author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"date":"2025-11-18 15:26:19.000000000","message":"Restored","accounts_in_message":[],"_revision_number":1},{"id":"a7a70ebe078403e712b9861edc037db8a1d5b2f8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"date":"2025-11-18 15:29:33.000000000","message":"Patch Set 2: Cherry Picked from branch stable/2024.2.","accounts_in_message":[],"_revision_number":2},{"id":"60672665ba14d7ddbd228703d58f956f4300ec2b","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"date":"2025-11-18 15:29:40.000000000","message":"Topic libvirt-tap-managed-no-unmaintained/2024.1 removed","accounts_in_message":[],"_revision_number":2},{"id":"00f8667c5a063f5c27e97742913038419600bb04","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"date":"2025-11-18 15:29:51.000000000","message":"Topic set to libvirt-tap-managed-no","accounts_in_message":[],"_revision_number":2},{"id":"ca4d2a18a8a16f2ba064f5d921961fc9905847a7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"date":"2025-11-18 15:45:18.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"6b56647cbf41f65e70d9cad02e0bf801db8ce09d","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2025-11-18 16:26:16.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"c83de824c3f3155326e99c07aa25c5c9da2f61f3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-18 17:33:57.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3ad6ae1020974132b6b98dae0e38df12\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/ea94f6d4f8554685a582ddcbdfebd5f8 : SUCCESS in 58m 40s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/ed0d73cab11e4ad998276c20a4c76bc4 : SUCCESS in 1h 30m 56s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3bd5b2b5aa21426f802ef63fa61189ed : SUCCESS in 29m 44s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a77c7286da0d41baa35792a5ccab4e01 : SUCCESS in 21m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/946180b09d354b7ea0db257240305a1c : SUCCESS in 7m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c6fbfb8ad6d84d429a0d93d0483b748d : SUCCESS in 11m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/fe56171e7c414404bee7399ba08bd3d1 : SUCCESS in 17m 12s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/36b1d3ad5bdc403a972d5d8e157b9e62 : SUCCESS in 53m 18s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/4b90d886b300482389413ad7a6f42eaf : SUCCESS in 1h 16m 59s\n- neutron-linuxbridge-tempest https://zuul.opendev.org/t/openstack/build/3d2ce0fcb4b5464ca50388ac27e80144 : SUCCESS in 1h 04m 11s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/3f10d034d4194e2caa81614b25dca03e : SUCCESS in 1h 04m 21s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/1d30b5a4b6c4468599e8cf1c758bcf0b : FAILURE in 6m 13s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/c53fd5b9139741e78b7a1d0f05b94b4f : SUCCESS in 25m 43s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/64ad221096e14c98ad28dd078965194c : SUCCESS in 25m 45s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/c368567205124a79b9f801e53dc200f9 : SUCCESS in 25m 53s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/8df4b181ee8c4ffead8e52fed8372598 : SUCCESS in 1h 17m 09s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/7cc1c5b40bbb4e2c91c0c53fe76546a1 : SUCCESS in 1h 43m 19s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/fef364d5921f4a5d840ccf1a74566117 : SUCCESS in 1h 22m 08s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c7b72bf52be44cef9fc8e6cf1fdb3462 : SUCCESS in 1h 04m 45s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/e746898823924505a7d11912a23e74ca : SUCCESS in 28m 12s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/3fd0f96d162e4023969030fcf39ce746 : SUCCESS in 31m 39s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"20a7e6968ea06b66b6f065b2204da74a6b7ab723","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-11-19 10:48:03.000000000","message":"Patch Set 3:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-967570-fxp46/index.html\u003e","accounts_in_message":[],"_revision_number":3},{"id":"113c3d1721fe77f636c88a817be4c286de88d16b","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-11-19 21:39:29.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-967570-cs4cq/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"7c57cb2eb65654a525e6c7877840d07968b0e891","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-11-25 16:25:22.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3570d8f7acdafef502024749d1b6c14eefd6ffc6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-25 16:25:53.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"68ad14fce832005a67dfefe1710d5a40d3645604","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-25 18:31:01.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/16fc58de82434066894ec6f7d207919b\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/e0d5c767f72f46c7ac59c3116efa9734 : SUCCESS in 57m 41s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/497ad17ea4ba4cb4b00cfce5516cb5b3 : SUCCESS in 1h 55m 33s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c143feb74ed248a880449704c68999a2 : SUCCESS in 26m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a5c12255ec2a4965a27c66d3c83c4388 : SUCCESS in 4m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1013423237004b639ad2332cb5759537 : SUCCESS in 5m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6fa6997e05fd4cb0b73ed1cbcccf8d56 : SUCCESS in 33m 20s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/870d3f89804a40d4b36a4de23d665757 : SUCCESS in 24m 55s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/ded5f6561d0a45e8a8c52e95929094dc : SUCCESS in 26m 47s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/72e022d5bd344b20b5e3eecaad26d37e : SUCCESS in 22m 39s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/1605337fc30d4dcdadd59bfe909be06c : SUCCESS in 5m 08s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/356e8127b55a45ccb6a35c7e149808f9 : SUCCESS in 1h 48m 06s\n- neutron-linuxbridge-tempest https://zuul.opendev.org/t/openstack/build/6043e7c992554ba182c44db49872d0e5 : SUCCESS in 33m 41s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/556c8c3fe1b5441cbf62e6e69923f9ba : SUCCESS in 1h 36m 51s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/8347462d209d484db46486d4a546f852 : SUCCESS in 47m 00s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/063c4ba96db04128be68fcf4728a1d72 : SUCCESS in 1h 26m 54s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/77238014b2394533a2d938eca81d2183 : SUCCESS in 57m 16s","accounts_in_message":[],"_revision_number":3},{"id":"28c2f239c3d6bb7473991eb6b734690c85f2d518","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-25 18:31:01.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3},{"id":"58bf30de926d7f13f1618fdca4d3ae0e4009bc3c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-25 18:32:40.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cefe1e6f0a7e404c9b8b93af632d693c\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6bcdace4f89b40d887303507e7d6a590 : SUCCESS in 45s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/05c302525a2c49f891ab971c83d5d504 : SUCCESS in 45s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"cd29a84f4c8a8e9e00fc79e1305cec94bc2b99fa","revisions":{"5f3ea9b2325ac6d31f223aa2dee34a54b369609b":{"kind":"REWORK","_number":1,"created":"2025-11-18 15:10:25.000000000","uploader":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"ref":"refs/changes/70/967570/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/70/967570/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/967570/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/967570/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/967570/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/70/967570/1"}}},"commit":{"parents":[{"commit":"9371df7a2b5dcc4cc895deb19da3bfaca209e564","subject":"Update .gitreview for unmaintained/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9371df7a2b5dcc4cc895deb19da3bfaca209e564"}]}],"author":{"name":"Nell Jerram","email":"nell@tigera.io","date":"2025-09-08 10:22:53.000000000","tz":60},"committer":{"name":"Nell Jerram","email":"nell@tigera.io","date":"2025-11-18 15:10:25.000000000","tz":0},"subject":"Add managed\u003d\u0027no\u0027 flag to libvirt XML definition for VIF type TAP","message":"Add managed\u003d\u0027no\u0027 flag to libvirt XML definition for VIF type TAP\n\nlibvirt 9.5.0 and later by default doesn\u0027t allow using a pre-created\nTAP device; instead it expects to create and manage the TAP device\nitself, which is incompatible with how Nova works.  To restore\ncompatibility with Nova we need to add the managed\u003d\"no\" flag to the\ntarget device section in the XML domain file.\n\nThe libvirt change is here[1].  In particular it breaks Calico for\nOpenStack, because the Calico plugin (out of tree[2]) uses VIF type TAP.\n\n1. https://github.com/libvirt/libvirt/commit/a2ae3d299cf\n2. https://github.com/projectcalico/calico/blob/master/networking-calico/networking_calico/plugins/ml2/drivers/calico/mech_calico.py#L217\n\nMany thanks to Masahito Muroi \u003cmasahito.muroi@linecorp.com\u003e for\nproposing an earlier version of this fix.\n\nCloses-Bug: #2033681\nChange-Id: I4a7b4ecf69cfe04c5291e5ca2a76db8829d6e592\nSigned-off-by: Nell Jerram \u003cnell@tigera.io\u003e\n(cherry picked from commit 6aba55a23faf47e6650e4cc0ae3007d77a19e3ac)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5f3ea9b2325ac6d31f223aa2dee34a54b369609b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5f3ea9b2325ac6d31f223aa2dee34a54b369609b"}]},"branch":"refs/heads/unmaintained/2024.1"},"fde8b6ff34e898a0a896fe7bbf656b89ca4f30a9":{"kind":"NO_CHANGE","_number":2,"created":"2025-11-18 15:29:33.000000000","uploader":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"ref":"refs/changes/70/967570/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/70/967570/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/967570/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/967570/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/967570/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/70/967570/2"}}},"commit":{"parents":[{"commit":"9371df7a2b5dcc4cc895deb19da3bfaca209e564","subject":"Update .gitreview for unmaintained/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9371df7a2b5dcc4cc895deb19da3bfaca209e564"}]}],"author":{"name":"Nell Jerram","email":"nell@tigera.io","date":"2025-09-08 10:22:53.000000000","tz":60},"committer":{"name":"Nell Jerram","email":"nell@tigera.io","date":"2025-11-18 15:29:33.000000000","tz":0},"subject":"Add managed\u003d\u0027no\u0027 flag to libvirt XML definition for VIF type TAP","message":"Add managed\u003d\u0027no\u0027 flag to libvirt XML definition for VIF type TAP\n\nlibvirt 9.5.0 and later by default doesn\u0027t allow using a pre-created\nTAP device; instead it expects to create and manage the TAP device\nitself, which is incompatible with how Nova works.  To restore\ncompatibility with Nova we need to add the managed\u003d\"no\" flag to the\ntarget device section in the XML domain file.\n\nThe libvirt change is here[1].  In particular it breaks Calico for\nOpenStack, because the Calico plugin (out of tree[2]) uses VIF type TAP.\n\n1. https://github.com/libvirt/libvirt/commit/a2ae3d299cf\n2. https://github.com/projectcalico/calico/blob/master/networking-calico/networking_calico/plugins/ml2/drivers/calico/mech_calico.py#L217\n\nMany thanks to Masahito Muroi \u003cmasahito.muroi@linecorp.com\u003e for\nproposing an earlier version of this fix.\n\nCloses-Bug: #2033681\nChange-Id: I4a7b4ecf69cfe04c5291e5ca2a76db8829d6e592\nSigned-off-by: Nell Jerram \u003cnell@tigera.io\u003e\n(cherry picked from commit 6aba55a23faf47e6650e4cc0ae3007d77a19e3ac)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fde8b6ff34e898a0a896fe7bbf656b89ca4f30a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fde8b6ff34e898a0a896fe7bbf656b89ca4f30a9"}]},"branch":"refs/heads/unmaintained/2024.1"},"cd29a84f4c8a8e9e00fc79e1305cec94bc2b99fa":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-11-18 15:45:18.000000000","uploader":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"ref":"refs/changes/70/967570/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/70/967570/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/967570/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/967570/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/70/967570/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/70/967570/3"}}},"commit":{"parents":[{"commit":"9371df7a2b5dcc4cc895deb19da3bfaca209e564","subject":"Update .gitreview for unmaintained/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9371df7a2b5dcc4cc895deb19da3bfaca209e564"}]}],"author":{"name":"Nell Jerram","email":"nell@tigera.io","date":"2025-09-08 10:22:53.000000000","tz":60},"committer":{"name":"Nell Jerram","email":"nell@tigera.io","date":"2025-11-18 15:45:18.000000000","tz":0},"subject":"Add managed\u003d\u0027no\u0027 flag to libvirt XML definition for VIF type TAP","message":"Add managed\u003d\u0027no\u0027 flag to libvirt XML definition for VIF type TAP\n\nlibvirt 9.5.0 and later by default doesn\u0027t allow using a pre-created\nTAP device; instead it expects to create and manage the TAP device\nitself, which is incompatible with how Nova works.  To restore\ncompatibility with Nova we need to add the managed\u003d\"no\" flag to the\ntarget device section in the XML domain file.\n\nThe libvirt change is here[1].  In particular it breaks Calico for\nOpenStack, because the Calico plugin (out of tree[2]) uses VIF type TAP.\n\n1. https://github.com/libvirt/libvirt/commit/a2ae3d299cf\n2. https://github.com/projectcalico/calico/blob/master/networking-calico/networking_calico/plugins/ml2/drivers/calico/mech_calico.py#L217\n\nMany thanks to Masahito Muroi \u003cmasahito.muroi@linecorp.com\u003e for\nproposing an earlier version of this fix.\n\nCloses-Bug: #2033681\nChange-Id: I4a7b4ecf69cfe04c5291e5ca2a76db8829d6e592\nSigned-off-by: Nell Jerram \u003cnell@tigera.io\u003e\n(cherry picked from commit 6aba55a23faf47e6650e4cc0ae3007d77a19e3ac)\n(cherry picked from commit d44afc965685deb1bb3581692375da59446dbe49)\n(cherry picked from commit b7d13d4dd46bb75fee609763f64d53bf7ac057b5)\n(cherry picked from commit 6a995e49fea2f4ed1bc24c0a6049588e1eb48463)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cd29a84f4c8a8e9e00fc79e1305cec94bc2b99fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cd29a84f4c8a8e9e00fc79e1305cec94bc2b99fa"}]},"branch":"refs/heads/unmaintained/2024.1","description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}