)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1b12efd8b6dc73be550bdc8d18ebc949d691f9b1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Taketani Ryo \u003ctaketani.ryo@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-21 09:56:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"mem-enc: nova.virt.libvirt.host: introduce Host.supports_mem_encryption"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduce Host.supports_mem_encryption and use it instead of"},{"line_number":10,"context_line":"supports_amd_sev for checking whether host supports VM memory encryption."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2e1364ca_b0aa3609","line":7,"updated":"2025-11-27 14:31:03.000000000","message":"This explains how the code updated, but does not explain its reason.\n\nHow about\n```\nmem-enc: Create generic checkfor mem encryption support by host\n\nIntroduce the new Host.supports_mem_encryption which tells whether\nthe host supports memory encryption. This allows us to centralize\nand generalize the check logic for additional mechanisms such as\nArm CCA, planned to be added in the future.\n```","commit_id":"c722e452f047e14e99bc34609ddd25627548c9f6"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"55409d72f1e7a2c061b0e805de5b281ed4216892","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Taketani Ryo \u003ctaketani.ryo@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-21 09:56:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"mem-enc: nova.virt.libvirt.host: introduce Host.supports_mem_encryption"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduce Host.supports_mem_encryption and use it instead of"},{"line_number":10,"context_line":"supports_amd_sev for checking whether host supports VM memory encryption."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4c6e9002_ffb1eeed","line":7,"in_reply_to":"2e1364ca_b0aa3609","updated":"2025-12-08 07:42:39.000000000","message":"Done","commit_id":"c722e452f047e14e99bc34609ddd25627548c9f6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"01306307b750cabcc4a79dc80b3c34e009493ce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1cfa660f_dd68db53","updated":"2025-12-14 12:07:33.000000000","message":"Thanks !","commit_id":"2fc4df5ed48a7a85bcad373d0e189a47222ede62"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"60ae2431468c64bb43f0b349f30436d6b32d3664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"11c61733_528841a5","updated":"2026-01-17 18:09:09.000000000","message":"Clean and simple. Thanks","commit_id":"2035afbb5ecd020fca728941fa7ce61153ba2aa5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f283107ad17ecd9035881cae915759b9b95fd74b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"66c76fa8_f6eddcde","updated":"2026-01-13 09:55:35.000000000","message":"cool with the patch, nothing really important for now but I guess we\u0027ll have more later.","commit_id":"2035afbb5ecd020fca728941fa7ce61153ba2aa5"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"cf017e4244d94c2ffefae932644cf0400fb84eb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ffdb9fc_f1b09aef","updated":"2026-01-19 06:54:54.000000000","message":"recheck bug #2131931","commit_id":"2035afbb5ecd020fca728941fa7ce61153ba2aa5"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1b12efd8b6dc73be550bdc8d18ebc949d691f9b1","unresolved":true,"context_lines":[{"line_number":7683,"context_line":"    def _get_mem_encryption_config(self, flavor, image_meta):"},{"line_number":7684,"context_line":"        \"\"\"To enable memory encryption (e.g., AMD SEV, Arm CCA),"},{"line_number":7685,"context_line":"         the following should be true:"},{"line_number":7686,"context_line":"        a) the host supports a memory encryption architecture (checked via"},{"line_number":7687,"context_line":"           `self._host.supports_mem_encryption`),"},{"line_number":7688,"context_line":"        b) the instance extra specs and/or image properties request"},{"line_number":7689,"context_line":"           memory encryption to be enabled, and"},{"line_number":7690,"context_line":"        c) there are no conflicts between extra specs, image properties"}],"source_content_type":"text/x-python","patch_set":1,"id":"8bae17bf_373244fb","line":7687,"range":{"start_line":7686,"start_character":62,"end_line":7687,"end_character":49},"updated":"2025-11-27 14:31:03.000000000","message":"I\u0027m inclined to remove this because it does not provide really additional info.","commit_id":"c722e452f047e14e99bc34609ddd25627548c9f6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4a13fce488e932628a3cc53b20ff75691a17996a","unresolved":false,"context_lines":[{"line_number":7683,"context_line":"    def _get_mem_encryption_config(self, flavor, image_meta):"},{"line_number":7684,"context_line":"        \"\"\"To enable memory encryption (e.g., AMD SEV, Arm CCA),"},{"line_number":7685,"context_line":"         the following should be true:"},{"line_number":7686,"context_line":"        a) the host supports a memory encryption architecture (checked via"},{"line_number":7687,"context_line":"           `self._host.supports_mem_encryption`),"},{"line_number":7688,"context_line":"        b) the instance extra specs and/or image properties request"},{"line_number":7689,"context_line":"           memory encryption to be enabled, and"},{"line_number":7690,"context_line":"        c) there are no conflicts between extra specs, image properties"}],"source_content_type":"text/x-python","patch_set":1,"id":"a887a099_0986742d","line":7687,"range":{"start_line":7686,"start_character":62,"end_line":7687,"end_character":49},"in_reply_to":"8bae17bf_373244fb","updated":"2025-12-08 15:41:45.000000000","message":"Done","commit_id":"c722e452f047e14e99bc34609ddd25627548c9f6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4a13fce488e932628a3cc53b20ff75691a17996a","unresolved":true,"context_lines":[{"line_number":7680,"context_line":"            guest.max_memory_slots +\u003d 1"},{"line_number":7681,"context_line":"            guest.add_device(vpmem_config)"},{"line_number":7682,"context_line":""},{"line_number":7683,"context_line":"    def _get_mem_encryption_config(self, flavor, image_meta):"},{"line_number":7684,"context_line":"        \"\"\"To enable memory encryption (e.g., AMD SEV, Arm CCA),"},{"line_number":7685,"context_line":"         the following should be true:"},{"line_number":7686,"context_line":"        a) the host supports a memory encryption architecture,"},{"line_number":7687,"context_line":"        b) the instance extra specs and/or image properties request"},{"line_number":7688,"context_line":"           memory encryption to be enabled, and"},{"line_number":7689,"context_line":"        c) there are no conflicts between extra specs, image properties"}],"source_content_type":"text/x-python","patch_set":2,"id":"ee7fa644_07e68b00","line":7686,"range":{"start_line":7683,"start_character":61,"end_line":7686,"end_character":62},"updated":"2025-12-08 15:41:45.000000000","message":"```suggestion\n    def _get_mem_encryption_config(self, flavor, image_meta):\n        \"\"\"To enable memory encryption the following should be true:\n\n        a) the host supports a memory encryption architecture,\n```\n\nCan we drop these examples so that we can put the title in one line ?\n\nAlso please add a blank line after it.\n\n(I don\u0027t know why pep8 does not detect this, but this is a best practice for function documentation)","commit_id":"566c6d4102bf92d7c2d33a980bf3bbe49c074087"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"01306307b750cabcc4a79dc80b3c34e009493ce5","unresolved":false,"context_lines":[{"line_number":7680,"context_line":"            guest.max_memory_slots +\u003d 1"},{"line_number":7681,"context_line":"            guest.add_device(vpmem_config)"},{"line_number":7682,"context_line":""},{"line_number":7683,"context_line":"    def _get_mem_encryption_config(self, flavor, image_meta):"},{"line_number":7684,"context_line":"        \"\"\"To enable memory encryption (e.g., AMD SEV, Arm CCA),"},{"line_number":7685,"context_line":"         the following should be true:"},{"line_number":7686,"context_line":"        a) the host supports a memory encryption architecture,"},{"line_number":7687,"context_line":"        b) the instance extra specs and/or image properties request"},{"line_number":7688,"context_line":"           memory encryption to be enabled, and"},{"line_number":7689,"context_line":"        c) there are no conflicts between extra specs, image properties"}],"source_content_type":"text/x-python","patch_set":2,"id":"be6342e6_8f2c42b7","line":7686,"range":{"start_line":7683,"start_character":61,"end_line":7686,"end_character":62},"in_reply_to":"941f0ebe_789a251b","updated":"2025-12-14 12:07:33.000000000","message":"Done","commit_id":"566c6d4102bf92d7c2d33a980bf3bbe49c074087"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"516afe6c4fea838e06eaba2753d60c565eb8da65","unresolved":true,"context_lines":[{"line_number":7680,"context_line":"            guest.max_memory_slots +\u003d 1"},{"line_number":7681,"context_line":"            guest.add_device(vpmem_config)"},{"line_number":7682,"context_line":""},{"line_number":7683,"context_line":"    def _get_mem_encryption_config(self, flavor, image_meta):"},{"line_number":7684,"context_line":"        \"\"\"To enable memory encryption (e.g., AMD SEV, Arm CCA),"},{"line_number":7685,"context_line":"         the following should be true:"},{"line_number":7686,"context_line":"        a) the host supports a memory encryption architecture,"},{"line_number":7687,"context_line":"        b) the instance extra specs and/or image properties request"},{"line_number":7688,"context_line":"           memory encryption to be enabled, and"},{"line_number":7689,"context_line":"        c) there are no conflicts between extra specs, image properties"}],"source_content_type":"text/x-python","patch_set":2,"id":"941f0ebe_789a251b","line":7686,"range":{"start_line":7683,"start_character":61,"end_line":7686,"end_character":62},"in_reply_to":"ee7fa644_07e68b00","updated":"2025-12-12 09:16:07.000000000","message":"Updated the message based on your suggestion.","commit_id":"566c6d4102bf92d7c2d33a980bf3bbe49c074087"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1b12efd8b6dc73be550bdc8d18ebc949d691f9b1","unresolved":true,"context_lines":[{"line_number":2006,"context_line":"        return self._supports_amd_sev"},{"line_number":2007,"context_line":""},{"line_number":2008,"context_line":"    @property"},{"line_number":2009,"context_line":"    def supports_mem_encryption(self) -\u003e bool:"},{"line_number":2010,"context_line":"        \"\"\"Determine if the host supports any memory"},{"line_number":2011,"context_line":"        encryption architecture for guests."},{"line_number":2012,"context_line":"        This checks whether any form of memory encryption"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a30fa04_4026a4f6","line":2009,"range":{"start_line":2009,"start_character":8,"end_line":2009,"end_character":31},"updated":"2025-11-27 14:31:03.000000000","message":"Can you add this after max_sev_es_guests, to avoid splitting sev logic block ?","commit_id":"c722e452f047e14e99bc34609ddd25627548c9f6"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"55409d72f1e7a2c061b0e805de5b281ed4216892","unresolved":false,"context_lines":[{"line_number":2006,"context_line":"        return self._supports_amd_sev"},{"line_number":2007,"context_line":""},{"line_number":2008,"context_line":"    @property"},{"line_number":2009,"context_line":"    def supports_mem_encryption(self) -\u003e bool:"},{"line_number":2010,"context_line":"        \"\"\"Determine if the host supports any memory"},{"line_number":2011,"context_line":"        encryption architecture for guests."},{"line_number":2012,"context_line":"        This checks whether any form of memory encryption"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a107d32_4347a168","line":2009,"range":{"start_line":2009,"start_character":8,"end_line":2009,"end_character":31},"in_reply_to":"0a30fa04_4026a4f6","updated":"2025-12-08 07:42:39.000000000","message":"Thank you for reviewing. I moved this.","commit_id":"c722e452f047e14e99bc34609ddd25627548c9f6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1b12efd8b6dc73be550bdc8d18ebc949d691f9b1","unresolved":true,"context_lines":[{"line_number":2007,"context_line":""},{"line_number":2008,"context_line":"    @property"},{"line_number":2009,"context_line":"    def supports_mem_encryption(self) -\u003e bool:"},{"line_number":2010,"context_line":"        \"\"\"Determine if the host supports any memory"},{"line_number":2011,"context_line":"        encryption architecture for guests."},{"line_number":2012,"context_line":"        This checks whether any form of memory encryption"},{"line_number":2013,"context_line":"        (e.g., AMD SEV, Arm CCA) is supported by the host."},{"line_number":2014,"context_line":"        This is conditional on support in the hardware,"},{"line_number":2015,"context_line":"        kernel, qemu, and libvirt for the specific encryption technology."}],"source_content_type":"text/x-python","patch_set":1,"id":"bd53cfd1_db47feed","line":2012,"range":{"start_line":2010,"start_character":8,"end_line":2012,"end_character":57},"updated":"2025-11-27 14:31:03.000000000","message":"Please create a dedicated title line, like\n\n```suggestion\n        \"\"\"Determine if the host supports memory encryption for guests.\n\n        This checks whether ....\n        \"\"\"\n```\n\nAlso \"form of memory encryption\" sounds a bit wired. Maybe \"memory encryption mechanism\" or even \"memory encryption technology\"(which you use later) could be better","commit_id":"c722e452f047e14e99bc34609ddd25627548c9f6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"01306307b750cabcc4a79dc80b3c34e009493ce5","unresolved":false,"context_lines":[{"line_number":2007,"context_line":""},{"line_number":2008,"context_line":"    @property"},{"line_number":2009,"context_line":"    def supports_mem_encryption(self) -\u003e bool:"},{"line_number":2010,"context_line":"        \"\"\"Determine if the host supports any memory"},{"line_number":2011,"context_line":"        encryption architecture for guests."},{"line_number":2012,"context_line":"        This checks whether any form of memory encryption"},{"line_number":2013,"context_line":"        (e.g., AMD SEV, Arm CCA) is supported by the host."},{"line_number":2014,"context_line":"        This is conditional on support in the hardware,"},{"line_number":2015,"context_line":"        kernel, qemu, and libvirt for the specific encryption technology."}],"source_content_type":"text/x-python","patch_set":1,"id":"d3c3d34b_41b034dd","line":2012,"range":{"start_line":2010,"start_character":8,"end_line":2012,"end_character":57},"in_reply_to":"aa3b20f9_3a81623e","updated":"2025-12-14 12:07:33.000000000","message":"Done","commit_id":"c722e452f047e14e99bc34609ddd25627548c9f6"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"55409d72f1e7a2c061b0e805de5b281ed4216892","unresolved":true,"context_lines":[{"line_number":2007,"context_line":""},{"line_number":2008,"context_line":"    @property"},{"line_number":2009,"context_line":"    def supports_mem_encryption(self) -\u003e bool:"},{"line_number":2010,"context_line":"        \"\"\"Determine if the host supports any memory"},{"line_number":2011,"context_line":"        encryption architecture for guests."},{"line_number":2012,"context_line":"        This checks whether any form of memory encryption"},{"line_number":2013,"context_line":"        (e.g., AMD SEV, Arm CCA) is supported by the host."},{"line_number":2014,"context_line":"        This is conditional on support in the hardware,"},{"line_number":2015,"context_line":"        kernel, qemu, and libvirt for the specific encryption technology."}],"source_content_type":"text/x-python","patch_set":1,"id":"aa3b20f9_3a81623e","line":2012,"range":{"start_line":2010,"start_character":8,"end_line":2012,"end_character":57},"in_reply_to":"bd53cfd1_db47feed","updated":"2025-12-08 07:42:39.000000000","message":"I added a title line and corrected \"form of memory encryption\"","commit_id":"c722e452f047e14e99bc34609ddd25627548c9f6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f283107ad17ecd9035881cae915759b9b95fd74b","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"        is supported."},{"line_number":2061,"context_line":"        \"\"\""},{"line_number":2062,"context_line":""},{"line_number":2063,"context_line":"        return self.supports_amd_sev"},{"line_number":2064,"context_line":""},{"line_number":2065,"context_line":"    @property"},{"line_number":2066,"context_line":"    def supports_remote_managed_ports(self) -\u003e bool:"}],"source_content_type":"text/x-python","patch_set":4,"id":"0a4f320f_3b3a71c1","line":2063,"updated":"2026-01-13 09:55:35.000000000","message":"I assume this conditional will become larger soon 😊","commit_id":"2035afbb5ecd020fca728941fa7ce61153ba2aa5"}]}