)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"844184862ec5f23de589d7d7258cd3e48516faf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b895b51_fc14c246","updated":"2025-11-27 06:11:49.000000000","message":"recheck","commit_id":"30f282bf89ed2cbff8e01a1bae133f6e5783d8f4"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"314c68b939a0cd5d2f5f2543782d51d1d9775fcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"19550d8d_fdf21ea2","updated":"2025-12-09 00:29:29.000000000","message":"recheck","commit_id":"691e4c35d4651f5a3c3217f3a16a8d78bc0958de"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"f8f578bd7cb3047fe0ade1cf2ca5c51c0c57ea1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"390030f1_f3f63eca","updated":"2026-01-14 08:27:18.000000000","message":"recheck Not sure what failed, rechecking to get another data point","commit_id":"a5cc12ff467edc7a6d7941ec0f0315e756e0b8cb"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"1f58ee47cfaed2463588a55ba13263273b14be7f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"71e4cf9f_a212a028","updated":"2026-02-04 14:15:44.000000000","message":"A soft -1 to highlight that the error message could be better for end user.\nOtherwise this path looks good to me.","commit_id":"813f1abddd12d0d0e8205d1c41cbde1ac7948a79"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"a2944c695d648e3bff8f127a3757229829fc25c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f1bb7644_eccb5f32","in_reply_to":"71e4cf9f_a212a028","updated":"2026-02-19 15:58:12.000000000","message":"Done","commit_id":"813f1abddd12d0d0e8205d1c41cbde1ac7948a79"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"a2944c695d648e3bff8f127a3757229829fc25c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"73a456d8_7ee55b3e","updated":"2026-02-19 15:58:12.000000000","message":"LGTM","commit_id":"916b5c76b1cb9d9bf3f622a24d52257287362d4a"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"e3b9aec8995526dc92637b3245ee8e5c489c8ff2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"085d70b4_ce02b554","updated":"2026-02-25 06:38:32.000000000","message":"recheck ceph deploy failed\n\n```\nRuntimeError: Failed command: /usr/bin/podman run --rm --ipc\u003dhost --stop-signal\u003dSIGTERM --net\u003dhost --entrypoint /usr/bin/ceph --init -e CONTAINER_IMAGE\u003dquay.io/ceph/ceph:v20 -e NODE_NAME\u003dnp39fe70792dc44 -v /var/log/ceph/0a4900c7-0861-4b77-b7a4-8f723e684ef4:/var/log/ceph:z -v /tmp/ceph-tmpnd26tzw5:/etc/ceph/ceph.client.admin.keyring:z -v /tmp/ceph-tmp9b7z3i_s:/etc/ceph/ceph.conf:z quay.io/ceph/ceph:v20 orch set backend cephadm: Error ENOTSUP: Warning: due to ceph-mgr restart, some PG states may not be up to date\nModule \u0027orchestrator\u0027 is not enabled/loaded (required by command \u0027orch set backend\u0027): use `ceph mgr module enable orchestrator` to enable it\n```","commit_id":"916b5c76b1cb9d9bf3f622a24d52257287362d4a"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"4f925948473fbb7db03a60433de9498fdd0729f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"959abeeb_d8dcffbc","updated":"2026-02-20 05:31:23.000000000","message":"recheck grenade-skip-level-always failed due to missing pkg resource","commit_id":"916b5c76b1cb9d9bf3f622a24d52257287362d4a"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"944e5aac8567402dd06960cfd8a6966349a7f2d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a930f7b7_34635e85","updated":"2026-02-26 01:27:22.000000000","message":"recheck nova-next failed due to the tempest test listed below:\n\nhttps://review.opendev.org/c/openstack/tempest/+/977922","commit_id":"916b5c76b1cb9d9bf3f622a24d52257287362d4a"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"0e698c04fdbc7ce2e712665a27f315052c134739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8cbf0de8_a52a023b","updated":"2026-03-19 17:58:42.000000000","message":"LGTM","commit_id":"bbf7951784910c556a80e2ed24973eaa243f2cbb"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"9d51ad72958cf491181e094caecbe08ede16a0ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5512e5ac_50107dd2","updated":"2026-03-09 04:17:05.000000000","message":"recheck Zuul failed due to missing config format","commit_id":"bbf7951784910c556a80e2ed24973eaa243f2cbb"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"35cc79b8f26f249090cd16e93137bd040b672ca6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8e10abc0_3e3b5bc6","updated":"2026-04-10 14:49:58.000000000","message":"nothing to say, good work !","commit_id":"d5699f1328db924cb9babd59b6be6eeece026922"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e6938e8798a6dc4f8ee6a96eda309e44b2b55063","unresolved":true,"context_lines":[{"line_number":7722,"context_line":"               and mem_enc_config.needs_locked_memory"},{"line_number":7723,"context_line":""},{"line_number":7724,"context_line":"    def _guest_configure_mem_encryption(self, guest, arch, mach_type, model):"},{"line_number":7725,"context_line":"        if model \u003d\u003d fields.MemEncryptionModel.AMD_SEV or \\"},{"line_number":7726,"context_line":"           model \u003d\u003d fields.MemEncryptionModel.AMD_SEV_ES:"},{"line_number":7727,"context_line":"            self._guest_configure_sev_mem_encryption("},{"line_number":7728,"context_line":"                guest, arch, mach_type, model)"},{"line_number":7729,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2077b9f8_a6bd974d","line":7726,"range":{"start_line":7725,"start_character":0,"end_line":7726,"end_character":57},"updated":"2025-11-27 14:51:07.000000000","message":"Please consider adding else if you put these two in if, to avoid leaking unknown values. Or we can probably avoid adding this if block with TODO note added.","commit_id":"30f282bf89ed2cbff8e01a1bae133f6e5783d8f4"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"32e5b29c0b68123e163a1bd8445707c13ada1224","unresolved":false,"context_lines":[{"line_number":7722,"context_line":"               and mem_enc_config.needs_locked_memory"},{"line_number":7723,"context_line":""},{"line_number":7724,"context_line":"    def _guest_configure_mem_encryption(self, guest, arch, mach_type, model):"},{"line_number":7725,"context_line":"        if model \u003d\u003d fields.MemEncryptionModel.AMD_SEV or \\"},{"line_number":7726,"context_line":"           model \u003d\u003d fields.MemEncryptionModel.AMD_SEV_ES:"},{"line_number":7727,"context_line":"            self._guest_configure_sev_mem_encryption("},{"line_number":7728,"context_line":"                guest, arch, mach_type, model)"},{"line_number":7729,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0ccb0f66_144ec32f","line":7726,"range":{"start_line":7725,"start_character":0,"end_line":7726,"end_character":57},"in_reply_to":"1bc34f0a_1cb9b5ce","updated":"2026-02-25 06:37:03.000000000","message":"Done","commit_id":"30f282bf89ed2cbff8e01a1bae133f6e5783d8f4"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"02718ad70e31994a3014dcbfd58559b9f848f6ae","unresolved":true,"context_lines":[{"line_number":7722,"context_line":"               and mem_enc_config.needs_locked_memory"},{"line_number":7723,"context_line":""},{"line_number":7724,"context_line":"    def _guest_configure_mem_encryption(self, guest, arch, mach_type, model):"},{"line_number":7725,"context_line":"        if model \u003d\u003d fields.MemEncryptionModel.AMD_SEV or \\"},{"line_number":7726,"context_line":"           model \u003d\u003d fields.MemEncryptionModel.AMD_SEV_ES:"},{"line_number":7727,"context_line":"            self._guest_configure_sev_mem_encryption("},{"line_number":7728,"context_line":"                guest, arch, mach_type, model)"},{"line_number":7729,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1bc34f0a_1cb9b5ce","line":7726,"range":{"start_line":7725,"start_character":0,"end_line":7726,"end_character":57},"in_reply_to":"2077b9f8_a6bd974d","updated":"2025-12-08 08:04:01.000000000","message":"I\u0027ve added exception within the else block.","commit_id":"30f282bf89ed2cbff8e01a1bae133f6e5783d8f4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"129383292ec647c30130d2a66d32e06bc76f6d70","unresolved":true,"context_lines":[{"line_number":7686,"context_line":""},{"line_number":7687,"context_line":"    def _guest_configure_mem_encryption(self, guest, arch, mach_type, model):"},{"line_number":7688,"context_line":"        if model \u003d\u003d fields.MemEncryptionModel.AMD_SEV or \\"},{"line_number":7689,"context_line":"           model \u003d\u003d fields.MemEncryptionModel.AMD_SEV_ES:"},{"line_number":7690,"context_line":"            self._guest_configure_sev_mem_encryption("},{"line_number":7691,"context_line":"                guest, arch, mach_type, model)"},{"line_number":7692,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6bc09b9c_5e235dca","line":7689,"updated":"2026-01-17 18:48:55.000000000","message":"nit: Instead of backslash I would say:\n```\nif model in (fields.MemEncryptionModel.AMD_SEV, fields.MemEncryptionModel.AMD_SEV_ES):\n```","commit_id":"a5cc12ff467edc7a6d7941ec0f0315e756e0b8cb"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"494cd69baf538c420637eaf365f0f7302e0ad804","unresolved":true,"context_lines":[{"line_number":7686,"context_line":""},{"line_number":7687,"context_line":"    def _guest_configure_mem_encryption(self, guest, arch, mach_type, model):"},{"line_number":7688,"context_line":"        if model \u003d\u003d fields.MemEncryptionModel.AMD_SEV or \\"},{"line_number":7689,"context_line":"           model \u003d\u003d fields.MemEncryptionModel.AMD_SEV_ES:"},{"line_number":7690,"context_line":"            self._guest_configure_sev_mem_encryption("},{"line_number":7691,"context_line":"                guest, arch, mach_type, model)"},{"line_number":7692,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"91d90f3d_a9ade2f5","line":7689,"in_reply_to":"6bc09b9c_5e235dca","updated":"2026-01-20 09:42:44.000000000","message":"Thank you for your review and +2. \nI\u0027ve addressed this feedback, so please review them again.","commit_id":"a5cc12ff467edc7a6d7941ec0f0315e756e0b8cb"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"d02b511a6f9cb1bc182c3bd939637797b2e3c0d1","unresolved":false,"context_lines":[{"line_number":7686,"context_line":""},{"line_number":7687,"context_line":"    def _guest_configure_mem_encryption(self, guest, arch, mach_type, model):"},{"line_number":7688,"context_line":"        if model \u003d\u003d fields.MemEncryptionModel.AMD_SEV or \\"},{"line_number":7689,"context_line":"           model \u003d\u003d fields.MemEncryptionModel.AMD_SEV_ES:"},{"line_number":7690,"context_line":"            self._guest_configure_sev_mem_encryption("},{"line_number":7691,"context_line":"                guest, arch, mach_type, model)"},{"line_number":7692,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bc8101df_eef41d5e","line":7689,"in_reply_to":"91d90f3d_a9ade2f5","updated":"2026-02-20 05:56:40.000000000","message":"Done","commit_id":"a5cc12ff467edc7a6d7941ec0f0315e756e0b8cb"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"1f58ee47cfaed2463588a55ba13263273b14be7f","unresolved":true,"context_lines":[{"line_number":7717,"context_line":"                guest, arch, mach_type, model)"},{"line_number":7718,"context_line":"        else:"},{"line_number":7719,"context_line":"            raise exception.Invalid("},{"line_number":7720,"context_line":"                \"Unknown MemEncryptionModel: %(model)s\" % {\u0027model\u0027: model})"},{"line_number":7721,"context_line":""},{"line_number":7722,"context_line":"    def _guest_configure_sev_mem_encryption("},{"line_number":7723,"context_line":"        self, guest, arch, mach_type, model):"}],"source_content_type":"text/x-python","patch_set":9,"id":"91540378_02039b1b","line":7720,"range":{"start_line":7720,"start_character":17,"end_line":7720,"end_character":74},"updated":"2026-02-04 14:15:44.000000000","message":"I will slightly change the mesage to include which models are valid:\n\n```python\n raise exception.Invalid(\n      \"Unknown MemEncryptionModel: %(model)s. Supported models: %(supported)s\" % {\n          \u0027model\u0027: model,\n          \u0027supported\u0027: \u0027, \u0027.join(supported_models)\n      })\n```","commit_id":"813f1abddd12d0d0e8205d1c41cbde1ac7948a79"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"a2944c695d648e3bff8f127a3757229829fc25c5","unresolved":false,"context_lines":[{"line_number":7717,"context_line":"                guest, arch, mach_type, model)"},{"line_number":7718,"context_line":"        else:"},{"line_number":7719,"context_line":"            raise exception.Invalid("},{"line_number":7720,"context_line":"                \"Unknown MemEncryptionModel: %(model)s\" % {\u0027model\u0027: model})"},{"line_number":7721,"context_line":""},{"line_number":7722,"context_line":"    def _guest_configure_sev_mem_encryption("},{"line_number":7723,"context_line":"        self, guest, arch, mach_type, model):"}],"source_content_type":"text/x-python","patch_set":9,"id":"15290edd_c403b1a6","line":7720,"range":{"start_line":7720,"start_character":17,"end_line":7720,"end_character":74},"in_reply_to":"52f1b82f_7969fe69","updated":"2026-02-19 15:58:12.000000000","message":"Done","commit_id":"813f1abddd12d0d0e8205d1c41cbde1ac7948a79"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"73adad43dfa78e72cdd9c7c0c8a51cb5584c228a","unresolved":true,"context_lines":[{"line_number":7717,"context_line":"                guest, arch, mach_type, model)"},{"line_number":7718,"context_line":"        else:"},{"line_number":7719,"context_line":"            raise exception.Invalid("},{"line_number":7720,"context_line":"                \"Unknown MemEncryptionModel: %(model)s\" % {\u0027model\u0027: model})"},{"line_number":7721,"context_line":""},{"line_number":7722,"context_line":"    def _guest_configure_sev_mem_encryption("},{"line_number":7723,"context_line":"        self, guest, arch, mach_type, model):"}],"source_content_type":"text/x-python","patch_set":9,"id":"52f1b82f_7969fe69","line":7720,"range":{"start_line":7720,"start_character":17,"end_line":7720,"end_character":74},"in_reply_to":"91540378_02039b1b","updated":"2026-02-09 10:01:23.000000000","message":"Updated as suggestion.","commit_id":"813f1abddd12d0d0e8205d1c41cbde1ac7948a79"}]}
