)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"abfc9c475ba57f1d449ba1fbf72db244f46c3e9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0477e50_711c7a4c","updated":"2026-01-16 15:48:05.000000000","message":"Looks good I just have a question inline","commit_id":"7e6a51e447daf8826039a641f7e411b4f6fbb71f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f721dc3c15f8c7b77a4563ef72153d061d54b1df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c0be446_138c9866","updated":"2026-01-13 13:50:22.000000000","message":"perfect, nothing to add","commit_id":"7e6a51e447daf8826039a641f7e411b4f6fbb71f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3fb0ecf07d8f1af109c77a4c0fa3c8fa789ccacd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"777a2e15_8c29c0ea","updated":"2026-01-13 11:03:20.000000000","message":"recheck","commit_id":"7e6a51e447daf8826039a641f7e411b4f6fbb71f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e94143804f1584f4d322a5d906f5e621c3e00b5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"deebb50a_4958f6d5","updated":"2026-01-19 11:12:12.000000000","message":"Thanks, looks good","commit_id":"5ff843316e900d318711bddc549fdbd6ab970e9e"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"1f1f8e39a491d5ed52f7bf1cbba4a90e6d86d9c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6868621a_c6ecf3f5","updated":"2026-02-02 15:01:49.000000000","message":"This patch is ok for me:\n- the intents are clear\n- it improves the coverage.\n- scenario raised by Gibi were addressed.\n- I don\u0027t see pitfalls or something else to rise.","commit_id":"517c935ff6046cead3b2cab05d9723302fa585e1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a07e2b2a82a24c99a4ba8555df4ba99a7e93f292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"643adbfb_55b0023d","updated":"2026-02-24 17:27:54.000000000","message":"I\u0027m +2 all the way up. So I start landing this series.","commit_id":"0c939329c50ded6d2b9e1e7fdeb58a788f2c1bf8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d563f29715d645de7f63c9a146cdeb233fcc60b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d0224fdc_94e13c28","updated":"2026-02-23 17:14:06.000000000","message":"restating my +2 since the only modification was an additional functional test (which also helps ++)","commit_id":"0c939329c50ded6d2b9e1e7fdeb58a788f2c1bf8"}],"nova/tests/functional/libvirt/test_uefi.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f721dc3c15f8c7b77a4563ef72153d061d54b1df","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                instance.system_metadata[\u0027image_hw_firmware_stateless\u0027])"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            self.assertNotIn(\u0027image_hw_firmware_stateless\u0027,"},{"line_number":60,"context_line":"                             instance.system_metadata)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_create_server(self):"},{"line_number":63,"context_line":"        orig_create \u003d nova.virt.libvirt.guest.Guest.create"}],"source_content_type":"text/x-python","patch_set":4,"id":"328dabd4_c457603a","line":60,"updated":"2026-01-13 13:50:22.000000000","message":"simple conditional asserts","commit_id":"7e6a51e447daf8826039a641f7e411b4f6fbb71f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"abfc9c475ba57f1d449ba1fbf72db244f46c3e9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7090d921_f369268f","line":248,"updated":"2026-01-16 15:48:05.000000000","message":"Is it a valid scenario that a domains is both secure and stateless at the same time? What happens if we try to boot with an image:\n```            \n\u0027properties\u0027: {\n                \u0027hw_machine_type\u0027: \u0027q35\u0027,\n                \u0027hw_firmware_type\u0027: \u0027uefi\u0027,\n                \u0027hw_firmware_stateless\u0027: True,\n                \u0027os_secure_boot\u0027: \u0027required\u0027,\n            }\n```","commit_id":"7e6a51e447daf8826039a641f7e411b4f6fbb71f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2142bf85f253c98497768293a26dd11694f85321","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b92178b3_fe283f54","line":248,"in_reply_to":"4ebb8e00_72cdb8a5","updated":"2026-01-17 17:30:30.000000000","message":"OK, so there is an uncommon but possible scenario when this combination actually works. Then I guess we should keep the combination of options available and then probably worth to add a test case that sets both.  (The another option would be reject the combination and assert that in such a test case)\n\nLet me know if you rather add that test case as a followup and then I\u0027can +2 +A this patch as otherwise this looks good to me.","commit_id":"7e6a51e447daf8826039a641f7e411b4f6fbb71f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c3873fa4d5cd7cd377f37ed0d754fc5390d6918","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4ebb8e00_72cdb8a5","line":248,"in_reply_to":"7090d921_f369268f","updated":"2026-01-17 14:55:40.000000000","message":"From PoV of libvirt and OVMF, it\u0027s a valid scenario.\n\nHowever it requires a unified OVMF file with secure-boot enabled, but that\u0027s not included by ovmf packages in major distros such as Ubuntu or CentOS Stream. The only firmware with stateless support provided are ones without secure boot support. Current nova may attempt to use secure boot firmware without var file (which results in incomplete firmware for secure boot, but once the auto-selection feature is implemented then the instance may fail to launch (unless that specific architecture of firmware is installed).","commit_id":"7e6a51e447daf8826039a641f7e411b4f6fbb71f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f00d49ebc3c4e8b3785db42951eae357be4f9d26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"14474ee9_4486120c","line":248,"in_reply_to":"b92178b3_fe283f54","updated":"2026-01-18 10:51:13.000000000","message":"I\u0027ve added one test case to verify that combination.","commit_id":"7e6a51e447daf8826039a641f7e411b4f6fbb71f"}]}
